)]}'
{"id":"openstack%2Fpython-cinderclient~647871","triplet_id":"openstack%2Fpython-cinderclient~master~I50e7231191dafab59c54a4312e3a4cb9049d1b7e","project":"openstack/python-cinderclient","branch":"master","topic":"major-bump","hashtags":[],"change_id":"I50e7231191dafab59c54a4312e3a4cb9049d1b7e","subject":"Bump default shell API version","status":"ABANDONED","created":"2019-03-26 18:53:00.000000000","updated":"2019-08-12 16:12:14.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"35578535546392ce5016d7a10840447644c820a1","_number":647871,"virtual_id_number":647871,"owner":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2019-04-03 17:36:15.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"all":[{"value":0,"date":"2019-04-16 19:52:49.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":-2,"date":"2019-05-29 14:46:05.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-04-03 17:36:15.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2019-04-16 19:52:49.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"a1d3a609635c9e16e43d3db9df6bb90d61e2387f","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-03-26 18:53:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"92499852e8af429dfc9db99bd5b07b1ec16c3c0f","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-03-26 18:53:44.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"072947f7e39cc1b3b4f5ea79c2a71bce905acd73","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-03-26 18:55:42.000000000","message":"Patch Set 1:\n\nI don\u0027t this is right. The \"default major version\" should still be 3.","accounts_in_message":[],"_revision_number":1},{"id":"ff6db9ec8d2ae404292893afa52c8beea20aefe2","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-03-26 20:28:00.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full http://logs.openstack.org/71/647871/1/check/tempest-full/a8a7d9d/ : SUCCESS in 1h 31m 56s\n- tempest-full-py3 http://logs.openstack.org/71/647871/1/check/tempest-full-py3/3b43f01/ : FAILURE in 1h 08m 45s\n- openstack-tox-cover http://logs.openstack.org/71/647871/1/check/openstack-tox-cover/ccf8dba/cover/ : SUCCESS in 4m 42s\n- openstack-tox-lower-constraints http://logs.openstack.org/71/647871/1/check/openstack-tox-lower-constraints/e86de55/ : SUCCESS in 4m 20s\n- openstack-tox-pep8 http://logs.openstack.org/71/647871/1/check/openstack-tox-pep8/b7a1de3/ : SUCCESS in 3m 42s\n- openstack-tox-py27 http://logs.openstack.org/71/647871/1/check/openstack-tox-py27/2b0e0a0/ : SUCCESS in 4m 31s\n- openstack-tox-py36 http://logs.openstack.org/71/647871/1/check/openstack-tox-py36/cff9095/ : SUCCESS in 4m 00s\n- openstack-tox-py37 http://logs.openstack.org/71/647871/1/check/openstack-tox-py37/9ff155a/ : SUCCESS in 4m 59s\n- openstack-tox-docs http://logs.openstack.org/71/647871/1/check/openstack-tox-docs/38cfc07/html/ : SUCCESS in 4m 17s\n- cinderclient-dsvm-functional http://logs.openstack.org/71/647871/1/check/cinderclient-dsvm-functional/be63671/ : SUCCESS in 27m 39s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/71/647871/1/check/openstack-tox-pylint/7681c3b/ : SUCCESS in 7m 02s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"111e5d862e2ad9bb56c5211f2ae2676382420417","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-04-03 15:39:33.000000000","message":"Patch Set 1:\n\nIt turns out we don\u0027t actually use the \"default major version\" for anything other than \"default version\" now.","accounts_in_message":[],"_revision_number":1},{"id":"427003baa5a9e5547378e6319b13310e2d7bde3e","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-04-03 15:41:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"2342942b7b157794f789259f238de1611977f926","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-04-03 17:36:15.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full http://logs.openstack.org/71/647871/2/check/tempest-full/11c6163/ : SUCCESS in 1h 49m 46s\n- tempest-full-py3 http://logs.openstack.org/71/647871/2/check/tempest-full-py3/cfa949d/ : SUCCESS in 1h 27m 16s\n- openstack-tox-cover http://logs.openstack.org/71/647871/2/check/openstack-tox-cover/34eb6c9/cover/ : SUCCESS in 4m 17s\n- openstack-tox-lower-constraints http://logs.openstack.org/71/647871/2/check/openstack-tox-lower-constraints/89a681b/ : SUCCESS in 5m 18s\n- openstack-tox-pep8 http://logs.openstack.org/71/647871/2/check/openstack-tox-pep8/2ae048e/ : SUCCESS in 3m 54s\n- openstack-tox-py27 http://logs.openstack.org/71/647871/2/check/openstack-tox-py27/94532ed/ : SUCCESS in 4m 38s\n- openstack-tox-py36 http://logs.openstack.org/71/647871/2/check/openstack-tox-py36/7531147/ : SUCCESS in 3m 41s\n- openstack-tox-py37 http://logs.openstack.org/71/647871/2/check/openstack-tox-py37/7218488/ : SUCCESS in 4m 53s\n- openstack-tox-docs http://logs.openstack.org/71/647871/2/check/openstack-tox-docs/777d631/html/ : SUCCESS in 4m 37s\n- cinderclient-dsvm-functional http://logs.openstack.org/71/647871/2/check/cinderclient-dsvm-functional/208f96a/ : SUCCESS in 30m 06s (non-voting)\n- openstack-tox-pylint http://logs.openstack.org/71/647871/2/check/openstack-tox-pylint/f1cab01/ : SUCCESS in 6m 21s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"69adbd5bbe6c1098c9f2e6a0d5eb1ac93d363b4d","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-04-16 19:52:49.000000000","message":"Patch Set 2: Code-Review-1\n\nWe can\u0027t set the base version to the max microversion. This causes problems when running a newer client against an older cinder service. If the service does not support 3.55 yet, it results in the client getting the error:\n\nERROR: Version 3.55 is not supported by the API. Minimum is 3.0 and maximum is 3.50. (HTTP 406)\n\nWe can assume we will only talk to services that support 3.0, but I don\u0027t think we should make it so they have to use the matching client for any service releases they need to interact with.","accounts_in_message":[],"_revision_number":2},{"id":"141624d34fc2e33f6fdb3c8e03c19fc534984800","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-04-24 22:02:07.000000000","message":"Patch Set 2:\n\n\u003e but I don\u0027t think we should make it so they have to use the matching client for any service releases they need to interact with.\n\nThat is not what this patch does, as was described in the commit message.\n\nWe could also go further back and pick a queens version if that\u0027s preferable.","accounts_in_message":[],"_revision_number":2},{"id":"c0f21a75bfad3d0139536f0609e8fe79ec972b20","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-04-24 22:07:59.000000000","message":"Patch Set 2:\n\n\u003e \u003e but I don\u0027t think we should make it so they have to use the\n \u003e matching client for any service releases they need to interact\n \u003e with.\n \u003e \n \u003e That is not what this patch does, as was described in the commit\n \u003e message.\n \u003e \n \u003e We could also go further back and pick a queens version if that\u0027s\n \u003e preferable.\n\nHelp now shows all help for any microversion the client knows about. I think that addresses the concern about \"revealing features\".","accounts_in_message":[],"_revision_number":2},{"id":"d07e68939ee03da230918ebe36a8daef6d6a9eeb","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-04-25 14:59:01.000000000","message":"Patch Set 2:\n\nIt doesn\u0027t.\n\nWhat\u0027s the justification for users defaulting to the 3.0 API and having to take extra steps to use features added/changed in the last few years?\n\nI fail to see how this is the ideal experience for someone using the cinderclient shell.","accounts_in_message":[],"_revision_number":2},{"id":"ad4a8e9ecf4f563ca08bf71629854ea1e590f530","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-04-25 15:10:19.000000000","message":"Patch Set 2:\n\n\u003e It doesn\u0027t.\n \u003e \n \u003e What\u0027s the justification for users defaulting to the 3.0 API and\n \u003e having to take extra steps to use features added/changed in the\n \u003e last few years?\n \u003e \n \u003e I fail to see how this is the ideal experience for someone using\n \u003e the cinderclient shell.\n\nThere\u0027s the risk that they upgrade their client (or worse, their system package manager does and they have no idea) and suddenly they start getting different behavior. We had decided early on that we wanted to avoid that and require that the user provide a microversion if they wanted a different behavior.","accounts_in_message":[],"_revision_number":2},{"id":"52f3435d9a789a54fde9254a35a3ad6cd02b429d","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-05-22 19:36:18.000000000","message":"Removed Code-Review-1 by Sean McGinnis \u003csean.mcginnis@gmail.com\u003e\n","accounts_in_message":[],"_revision_number":2},{"id":"d8383de676ac78ae86196831a661ddaa592cbb83","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-05-29 14:46:05.000000000","message":"Patch Set 2: Code-Review-2\n\nPer discussion at the PTG, we\u0027ll explore doing this the way that manilaclient does rather than just bumping the version like this.","accounts_in_message":[],"_revision_number":2},{"id":"07bf4045c5c002039d6332771f5e7bfea1d94deb","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-06-10 19:50:19.000000000","message":"Patch Set 2:\n\nThe follow up for this is here:\n    https://review.opendev.org/#/c/664430/","accounts_in_message":[],"_revision_number":2},{"id":"7046503ded4b2613ff3c837ab9063d91b6f974d3","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2019-08-12 16:12:14.000000000","message":"Abandoned\n\nhttps://review.opendev.org/#/c/664430/","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"54da6eae47417ec3cc2553d6704bce45b4d3b548","revisions":{"20e02796720e5ab4b397277e6e2ab913fd70a139":{"kind":"REWORK","_number":1,"created":"2019-03-26 18:53:00.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/71/647871/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/71/647871/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/71/647871/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/71/647871/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/71/647871/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/71/647871/1"}}},"commit":{"parents":[{"commit":"8804b7c978ebf056fa66e09b702355e44da71040","subject":"Merge \"Replace openstack.org git:// URLs with https://\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8804b7c978ebf056fa66e09b702355e44da71040"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2019-03-26 18:11:58.000000000","tz":-240},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2019-03-26 18:51:08.000000000","tz":-240},"subject":"Bump default shell API version","message":"Bump default shell API version\n\nAs part of a new major release of cinderclient,\ndefault to a newer API version for the shell when\nno version is specified.\n\nThis has the benefit of revealing features to\nusers which were not yet available in the v3.0 API.\n\nVersion 3.55 was somewhat arbitrarily selected, as\nthe last microversion for the Rocky release, with the\nintent of not having the client error on Rocky or\nStein clouds.\n\nChange-Id: I50e7231191dafab59c54a4312e3a4cb9049d1b7e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/20e02796720e5ab4b397277e6e2ab913fd70a139"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/20e02796720e5ab4b397277e6e2ab913fd70a139"}]},"branch":"refs/heads/master"},"54da6eae47417ec3cc2553d6704bce45b4d3b548":{"kind":"REWORK","_number":2,"created":"2019-04-03 15:41:44.000000000","uploader":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"ref":"refs/changes/71/647871/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/71/647871/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/71/647871/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/71/647871/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/71/647871/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/71/647871/2"}}},"commit":{"parents":[{"commit":"8804b7c978ebf056fa66e09b702355e44da71040","subject":"Merge \"Replace openstack.org git:// URLs with https://\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8804b7c978ebf056fa66e09b702355e44da71040"}]}],"author":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2019-03-26 18:11:58.000000000","tz":-240},"committer":{"name":"Eric Harney","email":"eharney@redhat.com","date":"2019-04-03 15:40:10.000000000","tz":-240},"subject":"Bump default shell API version","message":"Bump default shell API version\n\nAs part of a new major release of cinderclient,\ndefault to a newer API version for the shell when\nno version is specified.\n\nThis has the benefit of revealing features to\nusers which were not yet available in the v3.0 API.\n\nVersion 3.55 was somewhat arbitrarily selected, as\nthe last microversion for the Rocky release, with the\nintent of not having the client error on Rocky or\nStein clouds.\n\nChange-Id: I50e7231191dafab59c54a4312e3a4cb9049d1b7e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/54da6eae47417ec3cc2553d6704bce45b4d3b548"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/54da6eae47417ec3cc2553d6704bce45b4d3b548"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}