)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7730,"name":"Sahid Orentino Ferdjaoui","email":"sahid.ferdjaoui@industrialdiscipline.com","username":"sahid"},"change_message_id":"0f3802d15077631e19b4901667ab917de405d8dd","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The bash completion code is the sole user of the slugify() function"},{"line_number":10,"context_line":"in utils, which is substantially similar to to_slug() provided in"},{"line_number":11,"context_line":"strutils from oslo."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I52d8c1ae8846adb4a7da584fcee183230102c958"},{"line_number":14,"context_line":"Closes-bug: #1266127"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2F%2Bmk%3D","line":12,"updated":"2014-01-05 16:52:18.000000000","message":"Could you add in a commit message you have removed a method? thanks","commit_id":"5c22451e04804d3205e657b7e2e9e8429fc40bda"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"29dcbcca43f60abf5ecb6a4bb3231ac7c3efc95f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"The bash completion code is the sole user of the slugify() function"},{"line_number":10,"context_line":"in utils, which is substantially similar to to_slug() provided in"},{"line_number":11,"context_line":"strutils from oslo."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I52d8c1ae8846adb4a7da584fcee183230102c958"},{"line_number":14,"context_line":"Closes-bug: #1266127"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2FhIw%3D","line":12,"in_reply_to":"AAAAUH%2F%2F%2Bmk%3D","updated":"2014-01-13 00:56:25.000000000","message":"Done","commit_id":"5c22451e04804d3205e657b7e2e9e8429fc40bda"}],"cinderclient/base.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"84a8fd6d75eb6af687d5ab1b362c54768063d86b","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":"        if \u0027name\u0027 in self.__dict__ and self.HUMAN_ID:"},{"line_number":253,"context_line":"            if self.name is not None:"},{"line_number":254,"context_line":"                return strutils.to_slug(self.name)"},{"line_number":255,"context_line":"        return None"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _add_details(self, info):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FOlY%3D","line":254,"updated":"2014-01-16 06:12:23.000000000","message":"Pylint:\nE:254,23: Undefined variable \u0027strutils\u0027 (undefined-variable)\n\nImport strutils.","commit_id":"efa357bad7ddf57123a07240c531f15964b474ba"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"98367e6be39612b65f0e4070ca3ec3654371297d","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":"        if \u0027name\u0027 in self.__dict__ and self.HUMAN_ID:"},{"line_number":253,"context_line":"            if self.name is not None:"},{"line_number":254,"context_line":"                return strutils.to_slug(self.name)"},{"line_number":255,"context_line":"        return None"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def _add_details(self, info):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAUH%2F%2FOd0%3D","line":254,"in_reply_to":"AAAAUH%2F%2FOlY%3D","updated":"2014-01-16 06:51:41.000000000","message":"Done","commit_id":"efa357bad7ddf57123a07240c531f15964b474ba"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"d097df7b6f9a6cd318d5cc2a3321e962fb59d7ea","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from cinderclient import exceptions"},{"line_number":29,"context_line":"from cinderclient import utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from cinderclient.openstack.common import strutils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Python 2.4 compat"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FopY%3D","line":30,"updated":"2014-04-18 16:34:56.000000000","message":"Remove this new line. Imports should be grouped together per http://docs.openstack.org/developer/hacking/#imports","commit_id":"288479e337433d8bf6d574ac27e2a6f760537172"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"2d6a8601533ade5b56f205815bd9a5384c72f6b1","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from cinderclient import exceptions"},{"line_number":29,"context_line":"from cinderclient import utils"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from cinderclient.openstack.common import strutils"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Python 2.4 compat"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAXH%2F%2FJow%3D","line":30,"in_reply_to":"AAAAXH%2F%2FopY%3D","updated":"2014-04-23 17:09:26.000000000","message":"Done","commit_id":"288479e337433d8bf6d574ac27e2a6f760537172"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"0542ccfeaf50f7c9c3458c6bdb95c6de2f275b0f","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        for bash completion."},{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":"        if \u0027name\u0027 in self.__dict__ and self.HUMAN_ID:"},{"line_number":253,"context_line":"            if self.name is not None:"},{"line_number":254,"context_line":"                return strutils.to_slug(self.name)"},{"line_number":255,"context_line":"        return None"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FS2w%3D","line":253,"updated":"2014-04-22 17:30:45.000000000","message":"In the old code if self.name\u003d\u003dNone human_id return u\u0027none\u0027 but now it just return None, is this correct?","commit_id":"4635f8305759f09485f384c7cde4be42475b3168"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"0d2f682f2d2a3602b63c9abd82ccd6a3a4b76630","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        for bash completion."},{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":"        if \u0027name\u0027 in self.__dict__ and self.HUMAN_ID:"},{"line_number":253,"context_line":"            if self.name is not None:"},{"line_number":254,"context_line":"                return strutils.to_slug(self.name)"},{"line_number":255,"context_line":"        return None"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAXH%2F%2FSdI%3D","line":253,"in_reply_to":"AAAAXH%2F%2FS2w%3D","updated":"2014-04-23 17:09:37.000000000","message":"Yes, that is correct.","commit_id":"4635f8305759f09485f384c7cde4be42475b3168"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"4544b14cedd3a61084a25e35c1a640aea5387eb0","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        for bash completion."},{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":"        if \u0027name\u0027 in self.__dict__ and self.HUMAN_ID:"},{"line_number":253,"context_line":"            if self.name is not None:"},{"line_number":254,"context_line":"                return strutils.to_slug(self.name)"},{"line_number":255,"context_line":"        return None"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_36dedfda","line":253,"updated":"2014-07-21 06:38:01.000000000","message":"This should be merged with the if statement on the line above.","commit_id":"c6ea499d50bee9279a17f58b84a23f610034e51a"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"97dc0c5582318f6e903563eb255553823515bab8","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        for bash completion."},{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":"        if \u0027name\u0027 in self.__dict__ and self.HUMAN_ID:"},{"line_number":253,"context_line":"            if self.name is not None:"},{"line_number":254,"context_line":"                return strutils.to_slug(self.name)"},{"line_number":255,"context_line":"        return None"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_18a00841","line":253,"in_reply_to":"baada198_36dedfda","updated":"2014-07-22 13:42:45.000000000","message":"Done","commit_id":"c6ea499d50bee9279a17f58b84a23f610034e51a"},{"author":{"_account_id":167,"name":"Christian Berendt","email":"berendt@osism.tech","username":"berendt"},"change_message_id":"4bf1cd973b6792f33b8c1626d8fbe53264c749d4","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        for bash completion."},{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":"        if \u0027name\u0027 in self.__dict__ and self.HUMAN_ID and self.name is not None:"},{"line_number":253,"context_line":"                return strutils.to_slug(self.name)"},{"line_number":254,"context_line":"        return None"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _add_details(self, info):"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_34091433","line":253,"updated":"2014-07-22 16:24:50.000000000","message":"Wrong indent.","commit_id":"e88e3a66d751a09f71fc912ab0c8f804c6b25f87"},{"author":{"_account_id":9126,"name":"Chris Buccella","email":"chris@buccella.org","username":"hdd"},"change_message_id":"d43d2536add5e274f684b3570f2c069b3f252f74","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        for bash completion."},{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":"        if \u0027name\u0027 in self.__dict__ and self.HUMAN_ID and self.name is not None:"},{"line_number":253,"context_line":"                return strutils.to_slug(self.name)"},{"line_number":254,"context_line":"        return None"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def _add_details(self, info):"}],"source_content_type":"text/x-python","patch_set":9,"id":"baada198_dbeab19f","line":253,"in_reply_to":"baada198_34091433","updated":"2014-08-06 13:45:05.000000000","message":"Done","commit_id":"e88e3a66d751a09f71fc912ab0c8f804c6b25f87"},{"author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"change_message_id":"0907b6ff38de01dd71c9208e945a2deea431c593","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        \"\"\"Subclasses may override this provide a pretty ID which can be used"},{"line_number":250,"context_line":"        for bash completion."},{"line_number":251,"context_line":"        \"\"\""},{"line_number":252,"context_line":"        if \u0027name\u0027 in self.__dict__ and self.HUMAN_ID and self.name is not None:"},{"line_number":253,"context_line":"            return strutils.to_slug(self.name)"},{"line_number":254,"context_line":"        return None"},{"line_number":255,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"baada198_c390e351","line":252,"updated":"2014-08-07 12:39:07.000000000","message":"I\u0027d prefer if the statement can be changed to check \u0027not None\u0027 first, before checking existence in a dict, like so\n\n  if self.name is not None and self.HUMAN_ID and \u0027name\u0027 in self.__dict__","commit_id":"d09f547f6afe8143a0d1c11e4107d9e4672dd745"}]}