)]}'
{"cinderclient/v3/shell.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9a83fc16e96b2a9ef6e3c2e98d431f002b31bd3c","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                  limit\u003dargs.limit,"},{"line_number":180,"context_line":"                                  sort\u003dargs.sort)"},{"line_number":181,"context_line":"    shell_utils.translate_volume_snapshot_keys(backups)"},{"line_number":182,"context_line":"    columns \u003d [\u0027ID\u0027, \u0027Volume ID\u0027, \u0027Status\u0027, \u0027Name\u0027, \u0027Size\u0027, \u0027Object Count\u0027,"},{"line_number":183,"context_line":"               \u0027Container\u0027]"},{"line_number":184,"context_line":"    if cs.api_version \u003e\u003d api_versions.APIVersion(\u00273.56\u0027):"},{"line_number":185,"context_line":"        columns.append(\u0027User ID\u0027)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    if args.sort:"},{"line_number":188,"context_line":"        sortby_index \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_b55fa970","line":185,"range":{"start_line":182,"start_character":0,"end_line":185,"end_character":33},"updated":"2019-04-17 16:09:24.000000000","message":"I\u0027m not familiar with the thought behind this implementation but it feels strange to show only selective columns when the API is returning these[1].\nwouldn\u0027t it be better to let API handle the MV stuff so we don\u0027t end up adding too much code here for every column added to backup response?\n[1] https://github.com/openstack/cinder/blob/master/cinder/api/views/backups.py#L61-L77","commit_id":"44061cfab2dc74dca054546af955d12e13d6e6d2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3753697ebdd3ad64a64c682e9a5c70526a755822","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                  limit\u003dargs.limit,"},{"line_number":180,"context_line":"                                  sort\u003dargs.sort)"},{"line_number":181,"context_line":"    shell_utils.translate_volume_snapshot_keys(backups)"},{"line_number":182,"context_line":"    columns \u003d [\u0027ID\u0027, \u0027Volume ID\u0027, \u0027Status\u0027, \u0027Name\u0027, \u0027Size\u0027, \u0027Object Count\u0027,"},{"line_number":183,"context_line":"               \u0027Container\u0027]"},{"line_number":184,"context_line":"    if cs.api_version \u003e\u003d api_versions.APIVersion(\u00273.56\u0027):"},{"line_number":185,"context_line":"        columns.append(\u0027User ID\u0027)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    if args.sort:"},{"line_number":188,"context_line":"        sortby_index \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_6b6f2492","line":185,"range":{"start_line":182,"start_character":0,"end_line":185,"end_character":33},"in_reply_to":"3fce034c_b00c973b","updated":"2019-04-17 17:04:33.000000000","message":"got it. from client\u0027s perspective only few columns makes sense so we wouldn\u0027t end up adding every response added in API.","commit_id":"44061cfab2dc74dca054546af955d12e13d6e6d2"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"ba7f8fd10ea7dc9bedc275221444c1ed7ce61c61","unresolved":false,"context_lines":[{"line_number":179,"context_line":"                                  limit\u003dargs.limit,"},{"line_number":180,"context_line":"                                  sort\u003dargs.sort)"},{"line_number":181,"context_line":"    shell_utils.translate_volume_snapshot_keys(backups)"},{"line_number":182,"context_line":"    columns \u003d [\u0027ID\u0027, \u0027Volume ID\u0027, \u0027Status\u0027, \u0027Name\u0027, \u0027Size\u0027, \u0027Object Count\u0027,"},{"line_number":183,"context_line":"               \u0027Container\u0027]"},{"line_number":184,"context_line":"    if cs.api_version \u003e\u003d api_versions.APIVersion(\u00273.56\u0027):"},{"line_number":185,"context_line":"        columns.append(\u0027User ID\u0027)"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    if args.sort:"},{"line_number":188,"context_line":"        sortby_index \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_b00c973b","line":185,"range":{"start_line":182,"start_character":0,"end_line":185,"end_character":33},"in_reply_to":"3fce034c_b55fa970","updated":"2019-04-17 16:12:34.000000000","message":"Most client table output, including in newer OpenStackClient code, limit the columns shown for returned objects to keep them just the interesting attributes and to keep the output readable.","commit_id":"44061cfab2dc74dca054546af955d12e13d6e6d2"}]}