)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f9c92ffdaea0a67aded6546fecd217efdd7fd48a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If OS_VOLUME_API_VERSION is not set, use the highest"},{"line_number":10,"context_line":"supported by the server."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"If OS_VOLUME_API_VERSION exceeds that supported by the server,"},{"line_number":13,"context_line":"use the highest supported by the server."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(This matches behavior of the manila CLI, and is mostly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_b0792ac6","line":12,"updated":"2019-08-12 16:17:14.000000000","message":"I\u0027m a little concerned about this approach. It seems like it would be better to error out if the client has stated they want to use a version that is higher than what the server supports to prevent getting unexpected behavior. This was part of the reason for going with a v3 API rather than just adding microversions to the v2 API.\n\nConsistency is good though. Do you know how Nova handles this case?","commit_id":"eba0ca4408e6432d49912513a5ad9fcaa51bd058"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bfad6c9dc0ac217846166e47246a77667bee1a0e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If OS_VOLUME_API_VERSION is not set, use the highest"},{"line_number":10,"context_line":"supported by the server."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"If OS_VOLUME_API_VERSION exceeds that supported by the server,"},{"line_number":13,"context_line":"use the highest supported by the server."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(This matches behavior of the manila CLI, and is mostly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_119da009","line":12,"in_reply_to":"7faddb67_31ebfc78","updated":"2019-08-12 17:46:32.000000000","message":"(manilaclient also does this)","commit_id":"eba0ca4408e6432d49912513a5ad9fcaa51bd058"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"aedfdd8ab755ba2ba04a9173b1fe93ed446b7370","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If OS_VOLUME_API_VERSION is not set, use the highest"},{"line_number":10,"context_line":"supported by the server."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"If OS_VOLUME_API_VERSION exceeds that supported by the server,"},{"line_number":13,"context_line":"use the highest supported by the server."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(This matches behavior of the manila CLI, and is mostly"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_31ebfc78","line":12,"in_reply_to":"7faddb67_b0792ac6","updated":"2019-08-12 17:44:56.000000000","message":"If you specify a version newer than the version supported by the server, novaclient just runs with an older version than what you asked for.\n\nSee:\n    http://paste.openstack.org/raw/756354/","commit_id":"eba0ca4408e6432d49912513a5ad9fcaa51bd058"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c08b001d6ee478370289fcd8d27a96b002fcc1bb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Autonegotiate API version for shell"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If OS_VOLUME_API_VERSION is not set, use the highest"},{"line_number":10,"context_line":"supported by the server."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"If OS_VOLUME_API_VERSION exceeds that supported by the server,"},{"line_number":13,"context_line":"use the highest supported by the server."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_ef19add0","line":10,"range":{"start_line":10,"start_character":17,"end_line":10,"end_character":23},"updated":"2019-08-16 14:31:00.000000000","message":"client and the server\n(This call: https://review.opendev.org/#/c/664430/4/cinderclient/shell.py@774 takes the max version supported by the client into account)","commit_id":"d776848dc84041b0e9116fc73a17b985495ce184"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c08b001d6ee478370289fcd8d27a96b002fcc1bb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"supported by the server."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"If OS_VOLUME_API_VERSION exceeds that supported by the server,"},{"line_number":13,"context_line":"use the highest supported by the server."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"(This matches behavior of the manila CLI, and is mostly"},{"line_number":16,"context_line":"code from manilaclient tweaked to work in cinderclient.)"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7faddb67_4f7ec1e3","line":13,"range":{"start_line":13,"start_character":33,"end_line":13,"end_character":39},"updated":"2019-08-16 14:31:00.000000000","message":"client and the server","commit_id":"d776848dc84041b0e9116fc73a17b985495ce184"}],"cinderclient/shell.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"320941cc7ac9fe059586bc09e383160f9d637e13","unresolved":false,"context_lines":[{"line_number":766,"context_line":"                         os_auth_url,"},{"line_number":767,"context_line":"                         client_args):"},{"line_number":768,"context_line":""},{"line_number":769,"context_line":"        if os_api_version in api_versions.DEPRECATED_VERSIONS:"},{"line_number":770,"context_line":"            discovered_version \u003d cinderclient.API_DEPRECATED_VERSION"},{"line_number":771,"context_line":"            os_service_type \u003d \u0027volume\u0027"},{"line_number":772,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_83d14332","line":769,"range":{"start_line":769,"start_character":11,"end_line":769,"end_character":28},"updated":"2019-08-12 18:14:42.000000000","message":"This only works on py2.7.","commit_id":"eba0ca4408e6432d49912513a5ad9fcaa51bd058"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"eb8c6c1aac14b4cfb093d49679df1439bb228cc3","unresolved":false,"context_lines":[{"line_number":777,"context_line":""},{"line_number":778,"context_line":"        if (os_api_version.get_major_version() in"},{"line_number":779,"context_line":"                api_versions.DEPRECATED_VERSIONS):"},{"line_number":780,"context_line":"            discovered_version \u003d cinderclient.API_DEPRECATED_VERSION"},{"line_number":781,"context_line":"            os_service_type \u003d \u0027volume\u0027"},{"line_number":782,"context_line":"        else:"},{"line_number":783,"context_line":"            discovered_version \u003d api_versions.discover_version("}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_20bc8804","line":780,"updated":"2019-08-20 13:18:52.000000000","message":"pylint doesn\u0027t like this -- should it be api_versions.DEPRECATED_VERSION ?","commit_id":"e0c7ee0c786a0e76c8f9eba5c4ac02c6c592e759"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c424eb0fabd478e0d804e7c1e74424c7b662fdec","unresolved":false,"context_lines":[{"line_number":777,"context_line":""},{"line_number":778,"context_line":"        if (os_api_version.get_major_version() in"},{"line_number":779,"context_line":"                api_versions.DEPRECATED_VERSIONS):"},{"line_number":780,"context_line":"            discovered_version \u003d cinderclient.API_DEPRECATED_VERSION"},{"line_number":781,"context_line":"            os_service_type \u003d \u0027volume\u0027"},{"line_number":782,"context_line":"        else:"},{"line_number":783,"context_line":"            discovered_version \u003d api_versions.discover_version("}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_218faacd","line":780,"in_reply_to":"7faddb67_20bc8804","updated":"2019-08-20 15:43:37.000000000","message":"Yes","commit_id":"e0c7ee0c786a0e76c8f9eba5c4ac02c6c592e759"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"e2f2b3c3eb01b51535d024bfe1651c0b9ce242dd","unresolved":false,"context_lines":[{"line_number":527,"context_line":""},{"line_number":528,"context_line":"    @staticmethod"},{"line_number":529,"context_line":"    def downgrade_warning(requested, discovered):"},{"line_number":530,"context_line":"        logger.warning(\"API version %s requested, \" % requested.get_string())"},{"line_number":531,"context_line":"        logger.warning(\"downgrading to %s based on server support.\" %"},{"line_number":532,"context_line":"                       discovered.get_string())"},{"line_number":533,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_861c7413","line":530,"updated":"2019-09-04 21:49:52.000000000","message":"This will emit a warning now any time you use a newer client against an older service. I wonder if we should add to that warning message instructions on how to set the environment variable to default to the lesser MV. Or only emit these warnings if they\u0027ve explicitly requested a version higher than the service supports.\n\nMaybe something for a follow up.","commit_id":"d1b044b82a9d632e5769b377abe4f7f653cb94d4"}]}