)]}'
{"id":"openstack%2Fpython-cinderclient~678523","triplet_id":"openstack%2Fpython-cinderclient~master~I2f8662555f830b0821147324849d04e7a29d0580","project":"openstack/python-cinderclient","branch":"master","topic":"678523","hashtags":[],"change_id":"I2f8662555f830b0821147324849d04e7a29d0580","subject":"Optional filters parameters should be passed only once","status":"MERGED","created":"2019-08-26 11:29:11.000000000","updated":"2019-09-11 14:17:35.000000000","submitted":"2019-09-11 14:16:08.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":8,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"678523-1568211369168-649ce1e1","meta_rev_id":"05035cf5b5e3f0501feef0f1fcdb4d1697c6fc92","_number":678523,"virtual_id_number":678523,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-09-11 14:16:08.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"date":"2019-09-11 12:59:55.000000000","_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":2,"date":"2019-09-11 12:31:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2019-09-10 20:31:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2019-09-11 12:31:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"value":0,"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"value":0,"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-08-27 22:41:26.000000000","updated_by":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"reviewer":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"state":"REVIEWER"},{"updated":"2019-08-29 06:45:58.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2019-09-04 16:17:01.000000000","updated_by":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"reviewer":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"state":"REVIEWER"},{"updated":"2019-09-10 20:31:21.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2019-09-11 12:31:32.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2019-09-11 14:16:08.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5420c1b79d07d21c76719806ba2e8f534bf24b33","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-08-26 11:29:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4d722110eda43a2962f7b8f1dd8e341e4252a66b","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-26 13:18:08.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/48e97c9529314f10b399fe6861c42c01 : SUCCESS in 1h 47m 08s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/531606da70e24bcc94f4d5baca9ed259 : SUCCESS in 1h 28m 19s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/50f6cc0d60364a83a1a80f725063c160 : FAILURE in 5m 38s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a453368cb08b4ffea798c514e683224d : FAILURE in 4m 58s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/5b16d16f765542f7ac11a4051a774d15 : FAILURE in 3m 44s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2a6c52cf49f6471388233327e0a58384 : FAILURE in 5m 25s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/87c289345e0d4d61ad4b7aa244c94137 : FAILURE in 5m 41s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f4ea800f2999475292d4ada867f16179 : FAILURE in 4m 12s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/60ade34aa28b42058d0588a164efa7df : SUCCESS in 4m 43s\n- cinderclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/6684f5472d584cb88666105c177eeb90 : FAILURE in 32m 37s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/1ac35d750b0a48ee963647b9c37fc648 : SUCCESS in 5m 42s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5fc50b08108a5d86269ec1c613cd62bc1939578d","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-08-27 05:23:37.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"cf665fc6f83600f95d8950a0f6dec580725b4a31","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-27 07:18:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/92f5b378ae7e4997ba2e48cd1154bed3 : SUCCESS in 1h 42m 48s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/0c7e810de6dc482c8c382d2d3f1da1cf : SUCCESS in 1h 34m 08s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/1a0ce1dde98940c6a57d7aea4785de8c : SUCCESS in 6m 02s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/1ff6f2e080334adcb771f1d8e3537c8a : SUCCESS in 5m 05s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/48f760d8be6d4aa8a62970085c7c7a16 : SUCCESS in 5m 00s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/c410c624c07d4366846d4774a893b424 : SUCCESS in 6m 18s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/5d8fe5d7d5b34e4fa33bcdbd23113b8b : SUCCESS in 4m 13s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5c186e50189942179caf52a4a8371786 : SUCCESS in 5m 06s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0fd7a3f241fc497e98edb17a0e60610b : SUCCESS in 4m 11s\n- cinderclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/b671f1a7fc224f2c882db69d651bdf80 : FAILURE in 37m 24s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/5493c598e9f0400aa779c9fb1a56fadd : SUCCESS in 5m 22s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"8654d8b099d59f4245f84bed2223e0432972a83b","author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"date":"2019-08-27 22:41:26.000000000","message":"Patch Set 2: Code-Review-1\n\nCan we get some UnitTest with this please?","accounts_in_message":[],"_revision_number":2},{"id":"0a640d257bbefa69044af7bf98606129976d0725","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-08-29 06:30:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"6b02fc599e39f7c66513650be649a09c3ba0080a","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-08-29 06:33:07.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"0571ef607dbae1a4dc222ca9c43935fde0f89192","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-08-29 06:33:45.000000000","message":"Patch Set 4:\n\n\u003e Can we get some UnitTest with this please?\n\nThanks Jay\nDone","accounts_in_message":[],"_revision_number":4},{"id":"1e95114b36757fd2d34bae68ef0b7fc524b76f76","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-08-29 08:24:44.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/ae25dc2b73244d919979330cc1804335 : SUCCESS in 1h 48m 40s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/6edfe5872e784366a0c3c9be1c31a62e : SUCCESS in 1h 29m 35s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/33ff262ff0994774b4aa93132d5cd20e : SUCCESS in 4m 37s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c69017e59f8f4c0dae44088512e11c62 : SUCCESS in 7m 10s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/41abb2c131a849cdb12c00749a8cdda6 : SUCCESS in 5m 27s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/11cd8443d4c047a9828964abf9e9f615 : SUCCESS in 4m 48s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ec099c4f4d554175a069f397bab2ad5f : SUCCESS in 4m 38s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/0a9ef0446e3f4ad8985dd53b1f0a0b57 : SUCCESS in 5m 28s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bdbbe3384c904fa89d386573f8258afe : SUCCESS in 5m 18s\n- cinderclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/9b95e34161cb4b4aaf8ff59b9fa170d2 : SUCCESS in 37m 57s (non-voting)\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/456622813676461cb9d1c465f0230771 : SUCCESS in 6m 38s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"9f4217b3786ff7d02f1f5d5c27537accb5be0f6d","author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"date":"2019-09-04 16:17:01.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"9f4f2e90149f982677e2ebdf1e355625ebb61074","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-09-05 12:57:59.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"af66e4049b17437836cad476a14dc077fe5c0884","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-09-05 13:14:24.000000000","message":"Patch Set 5:\n\n(1 comment)\n\nThanks for the review Walter.","accounts_in_message":[],"_revision_number":5},{"id":"911571fcf7ba14527d3bbf48ed9559654b70b5ce","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-05 18:05:29.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/d7eccc80dd7449dcb0fffc0a2984019f : SUCCESS in 1h 48m 08s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/ba7627c8112b4818b06fe910e4494ef0 : SUCCESS in 1h 21m 34s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/d933d5b9c03f4fae912d41ed9e0901cb : SUCCESS in 3m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/00bc8cbd2c004d228f899eae40f67f53 : SUCCESS in 3m 52s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6b66b0877e1a47238368ea8f28aa268c : SUCCESS in 3m 38s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/f34a5d1d34c543188f0b326a9e292239 : SUCCESS in 5m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/58665286222f461c9d6101f3fa3e148a : SUCCESS in 4m 06s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/eb23ce7528174ccd8e7f1da5530ee185 : SUCCESS in 4m 43s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/94f8874445134602b222fcc77e78f13c : SUCCESS in 6m 08s\n- python-cinderclient-functional https://zuul.opendev.org/t/openstack/build/1274620d1455421083bbddd7a3e4bc6c : FAILURE in 34m 38s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/4bad79e806644913b8c8df92caf7c853 : SUCCESS in 6m 36s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"5a1c03d3cb9c5d38fce528f42731ce3b3b77ce98","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-09-06 07:07:38.000000000","message":"Patch Set 5:\n\nrecheck","accounts_in_message":[],"_revision_number":5},{"id":"a8c446a9ab66e377d88d7968629a9ce9faa0e01e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-06 08:54:17.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/98215446048c4804b2b0a45479012bb2 : SUCCESS in 1h 40m 06s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/384c45125e274612a5583cd8375e296e : SUCCESS in 1h 35m 22s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/44da5bda34d043d9b30f191058242af9 : SUCCESS in 3m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/39b807125a564101a097cd9ca0b29529 : SUCCESS in 4m 24s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/a34ba2fdce1149d880085a151b12ef48 : SUCCESS in 2m 48s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/2e883accdd30469f8bfe0fb6e9978d33 : SUCCESS in 4m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4d565824d3d24418b6c0f8fccffe7cc1 : SUCCESS in 3m 55s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fdb3c6f785744200abeec2ab4467ff0f : SUCCESS in 3m 37s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/4a8b95f2919a40d796480eeddac335ce : SUCCESS in 5m 01s\n- python-cinderclient-functional https://zuul.opendev.org/t/openstack/build/ae42841e747a460c8fb6818b2bae1499 : SUCCESS in 36m 42s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/61e013bdec5b4ef899f8f108b70d149e : SUCCESS in 5m 06s (non-voting)","accounts_in_message":[],"_revision_number":5},{"id":"cf96b8159d698203ba817904a5fa023b29d826b5","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2019-09-10 20:31:21.000000000","message":"Patch Set 5: Code-Review+2\n\nGlobal var replaced with a class attribute.  Functionality looks correct and has unit tests.  LGTM.","accounts_in_message":[],"_revision_number":5},{"id":"97c11c25ab88b4dd5b06e0ae75568949ddc7f404","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2019-09-11 12:31:32.000000000","message":"Patch Set 5: Code-Review+2 Workflow+1\n\n(3 comments)\n\nI think there\u0027s some room for improvement, but given the looming deadline and that this functionally works, we can clean things up later if we want.","accounts_in_message":[],"_revision_number":5},{"id":"c723d5b6217f741c7e3cdb784bf3b05eb0d24089","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-11 12:31:45.000000000","message":"Patch Set 5: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":5},{"id":"a79e2b91542f114c967354472952d71d38dfd26f","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2019-09-11 12:59:55.000000000","message":"Patch Set 5:\n\n(3 comments)\n\nThanks for the review Sean.","accounts_in_message":[],"_revision_number":5},{"id":"5b2c24e4ca3d54c4f2c8925fb21147864eb30a3f","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-11 14:16:08.000000000","message":"Patch Set 5: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full https://zuul.opendev.org/t/openstack/build/e0f2aa89cf744e41b83cbc97b8848327 : SUCCESS in 1h 31m 12s\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/73b3226ad0ea4927b8b69bf8cd6efe3b : SUCCESS in 1h 38m 29s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/c9063b515ee74ab0b57424147502530a : SUCCESS in 6m 35s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6a8332523bd84cdcac8f3a7516d070e3 : SUCCESS in 2m 59s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/0479c3d7958749d0b900388ed1aa60cc : SUCCESS in 4m 12s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b5f3cecb66874cdf964f133e39360668 : SUCCESS in 3m 21s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/f35640d2948f4a85bcaa63bde227b2d7 : SUCCESS in 4m 27s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e1b2fe05357a45aa9dc2a7fd8f269208 : SUCCESS in 5m 06s","accounts_in_message":[],"_revision_number":5},{"id":"3498aece9cfd9be9c745c2d3840f2d94128be302","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-11 14:16:09.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":5},{"id":"ce4d5486c51b2c7422880c3d22fe5fe4f5296606","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-11 14:17:35.000000000","message":"Patch Set 5:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f2f6a0b4d13646ecaac26d10bbde1d99 : SUCCESS in 1m 05s","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"624b444226a6a5f14d1f381c1ba9301b192510d1","revisions":{"c7a8bfdb080521816b8bba3184a08e855106060d":{"kind":"REWORK","_number":1,"created":"2019-08-26 11:29:11.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/23/678523/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/23/678523/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/1"}}},"commit":{"parents":[{"commit":"fd106c77bffecaf81985fa0006ffe147ce7b8ef2","subject":"Merge \"Add \u0027is_public\u0027 support in \u0027--filters\u0027 option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/fd106c77bffecaf81985fa0006ffe147ce7b8ef2"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-08-26 11:25:03.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-08-26 11:29:06.000000000","tz":330},"subject":"WIP: Optional filters should be passed only once","message":"WIP: Optional filters should be passed only once\n\nChange-Id: I2f8662555f830b0821147324849d04e7a29d0580\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/c7a8bfdb080521816b8bba3184a08e855106060d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/c7a8bfdb080521816b8bba3184a08e855106060d"}]},"branch":"refs/heads/master"},"83d367ff152e82deaa9b67b503b228387cbf0bde":{"kind":"REWORK","_number":2,"created":"2019-08-27 05:23:37.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/23/678523/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/23/678523/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/2"}}},"commit":{"parents":[{"commit":"fd106c77bffecaf81985fa0006ffe147ce7b8ef2","subject":"Merge \"Add \u0027is_public\u0027 support in \u0027--filters\u0027 option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/fd106c77bffecaf81985fa0006ffe147ce7b8ef2"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-08-26 11:25:03.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-08-27 05:09:54.000000000","tz":330},"subject":"Optional filters parameters should be passed only once","message":"Optional filters parameters should be passed only once\n\nThis patch does the following :\n\n1) Errors out if similar type of filters args are passed\nEg :\ncinder list --name abc --name xyz\ncinder list --name abc --filters name\u003dxyz\n\n2) Allows multiple filter parameters of different type\ncinder list --filters name\u003dabc --filters size\u003d1\n\nChange-Id: I2f8662555f830b0821147324849d04e7a29d0580\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/83d367ff152e82deaa9b67b503b228387cbf0bde"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/83d367ff152e82deaa9b67b503b228387cbf0bde"}]},"branch":"refs/heads/master"},"e1beb88bf69172b8b2f45d49467148d337aaa6bb":{"kind":"REWORK","_number":3,"created":"2019-08-29 06:30:46.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/23/678523/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/23/678523/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/3"}}},"commit":{"parents":[{"commit":"fd106c77bffecaf81985fa0006ffe147ce7b8ef2","subject":"Merge \"Add \u0027is_public\u0027 support in \u0027--filters\u0027 option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/fd106c77bffecaf81985fa0006ffe147ce7b8ef2"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-08-26 11:25:03.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-08-29 06:30:22.000000000","tz":330},"subject":"Optional filters parameters should be passed only once","message":"Optional filters parameters should be passed only once\n\nThis patch does the following :\n\n1) Errors out if similar type of filters args are passed\nEg :\ncinder list --name abc --name xyz\ncinder list --name abc --filters name\u003dxyz\n\n2) Allows multiple filter parameters of different type\ncinder list --filters name\u003dabc --filters size\u003d1\n\nChange-Id: I2f8662555f830b0821147324849d04e7a29d0580\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e1beb88bf69172b8b2f45d49467148d337aaa6bb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e1beb88bf69172b8b2f45d49467148d337aaa6bb"}]},"branch":"refs/heads/master"},"a6c1793471351fa6cca9c3b738cd5e1cc3bc24ad":{"kind":"REWORK","_number":4,"created":"2019-08-29 06:33:07.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/23/678523/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/23/678523/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/4"}}},"commit":{"parents":[{"commit":"fd106c77bffecaf81985fa0006ffe147ce7b8ef2","subject":"Merge \"Add \u0027is_public\u0027 support in \u0027--filters\u0027 option\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/fd106c77bffecaf81985fa0006ffe147ce7b8ef2"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-08-26 11:25:03.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-08-29 06:32:50.000000000","tz":330},"subject":"Optional filters parameters should be passed only once","message":"Optional filters parameters should be passed only once\n\nThis patch does the following :\n\n1) Errors out if similar type of filters args are passed\nEg :\ncinder list --name abc --name xyz\ncinder list --name abc --filters name\u003dxyz\n\n2) Allows multiple filter parameters of different type\ncinder list --filters name\u003dabc --filters size\u003d1\n\nChange-Id: I2f8662555f830b0821147324849d04e7a29d0580\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a6c1793471351fa6cca9c3b738cd5e1cc3bc24ad"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a6c1793471351fa6cca9c3b738cd5e1cc3bc24ad"}]},"branch":"refs/heads/master"},"624b444226a6a5f14d1f381c1ba9301b192510d1":{"kind":"REWORK","_number":5,"created":"2019-09-05 12:57:59.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/23/678523/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/23/678523/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/23/678523/5"}}},"commit":{"parents":[{"commit":"4bd9000eddfa559ab831df92b7108d15a4b15c87","subject":"Merge \"Autonegotiate API version for shell\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4bd9000eddfa559ab831df92b7108d15a4b15c87"}]}],"author":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-08-26 11:25:03.000000000","tz":330},"committer":{"name":"whoami-rajat","email":"rajatdhasmana@gmail.com","date":"2019-09-05 12:57:52.000000000","tz":330},"subject":"Optional filters parameters should be passed only once","message":"Optional filters parameters should be passed only once\n\nThis patch does the following :\n\n1) Errors out if similar type of filters args are passed\nEg :\ncinder list --name abc --name xyz\ncinder list --name abc --filters name\u003dxyz\n\n2) Allows multiple filter parameters of different type\ncinder list --filters name\u003dabc --filters size\u003d1\n\nChange-Id: I2f8662555f830b0821147324849d04e7a29d0580\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/624b444226a6a5f14d1f381c1ba9301b192510d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/624b444226a6a5f14d1f381c1ba9301b192510d1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}