)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"f7cac15a6ace50f5cba7f7a44cb79db74ff402e5","unresolved":false,"context_lines":[{"line_number":14,"context_line":"tests to confirm it\u0027s functionality is correct and avoid regression."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://github.com/openstack/cinder/commit/311c5153bc7a9c13a670e102dee54a91b1adbb43"},{"line_number":17,"context_line":"[2] https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L5417"},{"line_number":18,"context_line":"[3] https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L5445-L5447"},{"line_number":19,"context_line":"[4] https://github.com/openstack/cinder/blob/stable/queens/cinder/db/sqlalchemy/api.py#L5423"},{"line_number":20,"context_line":"[5] https://review.opendev.org/#/c/703658"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_aff2f299","line":17,"updated":"2020-01-21 17:45:54.000000000","message":"And press \"y\" to get the link to the current commit so the link continues to point to the right lines of code over time as things change.","commit_id":"2631c5e1e5812fe8e68d679d86624c72e87f933e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b1854ca14abc5f55d00fb6f301ee7f66fc64b111","unresolved":false,"context_lines":[{"line_number":14,"context_line":"tests to confirm it\u0027s functionality is correct and avoid regression."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://github.com/openstack/cinder/commit/311c5153bc7a9c13a670e102dee54a91b1adbb43"},{"line_number":17,"context_line":"[2] https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L5417"},{"line_number":18,"context_line":"[3] https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L5445-L5447"},{"line_number":19,"context_line":"[4] https://github.com/openstack/cinder/blob/stable/queens/cinder/db/sqlalchemy/api.py#L5423"},{"line_number":20,"context_line":"[5] https://review.opendev.org/#/c/703658"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_f3f4338a","line":17,"in_reply_to":"3fa7e38b_0f48e687","updated":"2020-01-23 11:57:07.000000000","message":"oh, thanks for the info.","commit_id":"2631c5e1e5812fe8e68d679d86624c72e87f933e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"cbf0a9d23a25e3deb0f82472a23bc42f4a09f27c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"tests to confirm it\u0027s functionality is correct and avoid regression."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://github.com/openstack/cinder/commit/311c5153bc7a9c13a670e102dee54a91b1adbb43"},{"line_number":17,"context_line":"[2] https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L5417"},{"line_number":18,"context_line":"[3] https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L5445-L5447"},{"line_number":19,"context_line":"[4] https://github.com/openstack/cinder/blob/stable/queens/cinder/db/sqlalchemy/api.py#L5423"},{"line_number":20,"context_line":"[5] https://review.opendev.org/#/c/703658"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_0f48e687","line":17,"in_reply_to":"3fa7e38b_4f19fecf","updated":"2020-01-21 17:59:13.000000000","message":"Over time, code changes will be committed and the line numbers you are pointing to here will no longer point to the code you intend it to. So if you go to that link in your browser and press the \"y\" key, that will give you a URL that links to a specific commit in the repo so that the line number you are referencing will always point to the code you meant to reference.","commit_id":"2631c5e1e5812fe8e68d679d86624c72e87f933e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c8140f678aeefedae5880476abd49e3807e4178c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"tests to confirm it\u0027s functionality is correct and avoid regression."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://github.com/openstack/cinder/commit/311c5153bc7a9c13a670e102dee54a91b1adbb43"},{"line_number":17,"context_line":"[2] https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L5417"},{"line_number":18,"context_line":"[3] https://github.com/openstack/cinder/blob/master/cinder/db/sqlalchemy/api.py#L5445-L5447"},{"line_number":19,"context_line":"[4] https://github.com/openstack/cinder/blob/stable/queens/cinder/db/sqlalchemy/api.py#L5423"},{"line_number":20,"context_line":"[5] https://review.opendev.org/#/c/703658"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_4f19fecf","line":17,"in_reply_to":"3fa7e38b_aff2f299","updated":"2020-01-21 17:51:49.000000000","message":"Not sure if i understand the hidden message here :/","commit_id":"2631c5e1e5812fe8e68d679d86624c72e87f933e"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"b9a2d33c0d8262034a75ed1e8809b9be6f6e7578","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Related-Bug: #1860100"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: I6a4d12d5dd55080e9aa73027ed82d3bf13855e28"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I2fd3a6a7b9add65a9a21388df44efb6747065a74"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_0f022673","line":24,"updated":"2020-01-21 17:45:05.000000000","message":"Just a reminder that reference by change-id was announced as deprecated a long time ago. I\u0027m not sure if they will ever actually remove that capability, but probably best to use the recommended Gerrit review link instead.","commit_id":"2631c5e1e5812fe8e68d679d86624c72e87f933e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c8140f678aeefedae5880476abd49e3807e4178c","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Related-Bug: #1860100"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Depends-On: I6a4d12d5dd55080e9aa73027ed82d3bf13855e28"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Change-Id: I2fd3a6a7b9add65a9a21388df44efb6747065a74"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa7e38b_af37524b","line":24,"in_reply_to":"3fa7e38b_0f022673","updated":"2020-01-21 17:51:49.000000000","message":"Done","commit_id":"2631c5e1e5812fe8e68d679d86624c72e87f933e"}],"cinderclient/tests/unit/v3/test_shell.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"12cb5f326cbca045eb1faf8b05f1fb5be5a0a80e","unresolved":false,"context_lines":[{"line_number":1457,"context_line":"        {\u0027command\u0027:"},{"line_number":1458,"context_line":"             \u0027transfer-list --filters name\u003dabc\u0027,"},{"line_number":1459,"context_line":"         \u0027expected\u0027:"},{"line_number":1460,"context_line":"             \u0027/os-volume-transfer/detail?name\u003dabc\u0027},"},{"line_number":1461,"context_line":"    )"},{"line_number":1462,"context_line":"    @ddt.unpack"},{"line_number":1463,"context_line":"    def test_transfer_list_with_filters(self, command, expected):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_e5d45420","line":1460,"updated":"2020-02-12 11:56:20.000000000","message":"nit: it\u0027s always good to see a case to show the code can handle multiple filters in the same call.","commit_id":"ba351da275b6340f314aca32c9d93f60b1066f9f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a9a84d9e609b4f919060d900bbc8d95b0a656862","unresolved":false,"context_lines":[{"line_number":1457,"context_line":"        {\u0027command\u0027:"},{"line_number":1458,"context_line":"             \u0027transfer-list --filters name\u003dabc\u0027,"},{"line_number":1459,"context_line":"         \u0027expected\u0027:"},{"line_number":1460,"context_line":"             \u0027/os-volume-transfer/detail?name\u003dabc\u0027},"},{"line_number":1461,"context_line":"    )"},{"line_number":1462,"context_line":"    @ddt.unpack"},{"line_number":1463,"context_line":"    def test_transfer_list_with_filters(self, command, expected):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_f9eab80a","line":1460,"in_reply_to":"3fa7e38b_e5d45420","updated":"2020-02-12 17:56:21.000000000","message":"Done\nYes, it caused a lot of issues previously[1]\n\n[1] https://review.opendev.org/#/c/678523/5","commit_id":"ba351da275b6340f314aca32c9d93f60b1066f9f"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"12cb5f326cbca045eb1faf8b05f1fb5be5a0a80e","unresolved":false,"context_lines":[{"line_number":2574,"context_line":"           start_version\u003d\u00273.52\u0027,"},{"line_number":2575,"context_line":"           metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":2576,"context_line":"           default\u003dNone,"},{"line_number":2577,"context_line":"           help\u003d\"Filter key and value pairs. Admin only.\")"},{"line_number":2578,"context_line":"def do_transfer_list(cs, args):"},{"line_number":2579,"context_line":"    \"\"\"Lists all transfers.\"\"\""},{"line_number":2580,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_a56f3c91","line":2577,"range":{"start_line":2577,"start_character":44,"end_line":2577,"end_character":56},"updated":"2020-02-12 11:56:20.000000000","message":"Is this correct?","commit_id":"ba351da275b6340f314aca32c9d93f60b1066f9f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a9a84d9e609b4f919060d900bbc8d95b0a656862","unresolved":false,"context_lines":[{"line_number":2574,"context_line":"           start_version\u003d\u00273.52\u0027,"},{"line_number":2575,"context_line":"           metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":2576,"context_line":"           default\u003dNone,"},{"line_number":2577,"context_line":"           help\u003d\"Filter key and value pairs. Admin only.\")"},{"line_number":2578,"context_line":"def do_transfer_list(cs, args):"},{"line_number":2579,"context_line":"    \"\"\"Lists all transfers.\"\"\""},{"line_number":2580,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_b9d8c07f","line":2577,"range":{"start_line":2577,"start_character":44,"end_line":2577,"end_character":56},"in_reply_to":"3fa7e38b_a56f3c91","updated":"2020-02-12 17:56:21.000000000","message":"Nope, i did this test for releasenote but forgot to update here. Corrected now.","commit_id":"ba351da275b6340f314aca32c9d93f60b1066f9f"}],"cinderclient/v3/volume_transfers.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5025d116e8a0fb00fb1091a7f7607f2516d17082","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if search_opts and search_opts.get(\u0027name\u0027):"},{"line_number":78,"context_line":"            search_opts[\u0027display_name\u0027] \u003d search_opts[\u0027name\u0027]"},{"line_number":79,"context_line":"            del search_opts[\u0027name\u0027]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        url \u003d self._build_list_url(resource_type, detailed\u003ddetailed,"},{"line_number":82,"context_line":"                                   search_opts\u003dsearch_opts,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_02bc4d69","line":79,"updated":"2020-01-20 20:43:26.000000000","message":"If this is the right way to fix this, this can be done by setting NAME_ATTR in the VolumeTransfer object.\n\nBut, I\u0027m not yet sure if this is something that should be fixed in the client or if the filtering in the server is just wrong.","commit_id":"bf26e98adee3ed9ffee7cd207d4ee6a314635deb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b1854ca14abc5f55d00fb6f301ee7f66fc64b111","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if search_opts and search_opts.get(\u0027name\u0027):"},{"line_number":78,"context_line":"            search_opts[\u0027display_name\u0027] \u003d search_opts[\u0027name\u0027]"},{"line_number":79,"context_line":"            del search_opts[\u0027name\u0027]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        url \u003d self._build_list_url(resource_type, detailed\u003ddetailed,"},{"line_number":82,"context_line":"                                   search_opts\u003dsearch_opts,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_7301236d","line":79,"in_reply_to":"3fa7e38b_02bc4d69","updated":"2020-01-23 11:57:07.000000000","message":"fixed it on the API side\nhttps://review.opendev.org/#/c/703658/","commit_id":"bf26e98adee3ed9ffee7cd207d4ee6a314635deb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bafe96f8e6999746cb72427f894833147cc2757d","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if search_opts and search_opts.get(\u0027name\u0027):"},{"line_number":78,"context_line":"            search_opts[\u0027display_name\u0027] \u003d search_opts[\u0027name\u0027]"},{"line_number":79,"context_line":"            del search_opts[\u0027name\u0027]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        url \u003d self._build_list_url(resource_type, detailed\u003ddetailed,"},{"line_number":82,"context_line":"                                   search_opts\u003dsearch_opts,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_02a726bd","line":79,"in_reply_to":"3fa7e38b_24c3638e","updated":"2020-01-24 18:53:34.000000000","message":"I think Sean has a good point here.  Since we know about the bug, it would be nice if the client could handle both fixed and unfixed Cinders.\n\nSince this is a bug and not a microversion change, I\u0027m not sure what could we do other than to send both \u0027name\u0027 and \u0027display_name\u0027 all the time?  That\u0027s assuming an incorrect filter is ignored silently on the server side, which I\u0027m not sure is the case.  Otherwise, we could check for a change in Ussuri that\u0027s going to require a microversion change and piggy-back on that microversion to detect a fixed vs. unfixed Block Storage API.","commit_id":"bf26e98adee3ed9ffee7cd207d4ee6a314635deb"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"5cd9db7969033154d9e2ec5c89e8508e82dfd7ad","unresolved":false,"context_lines":[{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        if search_opts and search_opts.get(\u0027name\u0027):"},{"line_number":78,"context_line":"            search_opts[\u0027display_name\u0027] \u003d search_opts[\u0027name\u0027]"},{"line_number":79,"context_line":"            del search_opts[\u0027name\u0027]"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        url \u003d self._build_list_url(resource_type, detailed\u003ddetailed,"},{"line_number":82,"context_line":"                                   search_opts\u003dsearch_opts,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fa7e38b_24c3638e","line":79,"in_reply_to":"3fa7e38b_7301236d","updated":"2020-01-23 14:51:39.000000000","message":"What about for when a newer client is used to talk to an older service that does not have that change?","commit_id":"bf26e98adee3ed9ffee7cd207d4ee6a314635deb"}],"releasenotes/notes/support-filters-transfer-a1e7b728c7895a45.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"12cb5f326cbca045eb1faf8b05f1fb5be5a0a80e","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - New command option ``--filters`` is added to ``transfer-list``"},{"line_number":4,"context_line":"    command to support filtering."},{"line_number":5,"context_line":"    It requires API with minimum MV of 3.52."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_e5a214ac","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":44},"updated":"2020-02-12 11:56:20.000000000","message":"Should probably be more precise here.  The MV is tied to the transfer list API, not to filtering with the API.  Maybe:\n\nThe ``transfer-list`` command can be used when communicating with the Block Storage API version 3.52 and higher.","commit_id":"ba351da275b6340f314aca32c9d93f60b1066f9f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a9a84d9e609b4f919060d900bbc8d95b0a656862","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - New command option ``--filters`` is added to ``transfer-list``"},{"line_number":4,"context_line":"    command to support filtering."},{"line_number":5,"context_line":"    It requires API with minimum MV of 3.52."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_d9d33c62","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":44},"in_reply_to":"3fa7e38b_e5a214ac","updated":"2020-02-12 17:56:21.000000000","message":"Done","commit_id":"ba351da275b6340f314aca32c9d93f60b1066f9f"}]}