)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Closes-Bug: #1275881"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1dfde51636e8dc4b42e4c4810c27c1c4ac513d82"},{"line_number":16,"context_line":"author: diane fleming"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"AAAAWH%2F9%2B%2B0%3D","line":16,"updated":"2014-03-31 18:58:55.000000000","message":"Not needed?","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Closes-Bug: #1275881"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1dfde51636e8dc4b42e4c4810c27c1c4ac513d82"},{"line_number":16,"context_line":"author: diane fleming"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"AAAAWH%2F9%2BU0%3D","line":16,"in_reply_to":"AAAAWH%2F9%2B%2B0%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"}],"cinderclient/openstack/common/apiclient/base.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c171ec340bf8d5bbe11258d888fbb2d37a9ab2e0","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        return resp.status_code \u003d\u003d 204"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def _post(self, url, json, response_key, return_raw\u003dFalse):"},{"line_number":148,"context_line":"        \"\"\"Creates an object."},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        :param url: a partial URL, e.g., \u0027/servers\u0027"},{"line_number":151,"context_line":"        :param json: data that will be encoded as JSON and passed in POST"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAU3%2F%2FhMs%3D","line":148,"updated":"2014-02-26 06:45:09.000000000","message":"This needs to be fixed in oslo and imported/updated here.","commit_id":"0ee5fa404d4dd1e1ba6516985c3715e02af36146"}],"cinderclient/shell.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c171ec340bf8d5bbe11258d888fbb2d37a9ab2e0","unresolved":false,"context_lines":[{"line_number":489,"context_line":"            endpoint_api_version \u003d options.os_volume_api_version"},{"line_number":490,"context_line":"            if api_version_input:"},{"line_number":491,"context_line":"                logger.warning(\"Cannot determine the API version through \""},{"line_number":492,"context_line":"                               \"the endpoint URL. Using the user-specified \""},{"line_number":493,"context_line":"                               \"version: %s\" %"},{"line_number":494,"context_line":"                               endpoint_api_version)"},{"line_number":495,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAU3%2F%2FhLU%3D","line":492,"updated":"2014-02-26 06:45:09.000000000","message":"Personally I kinda feel that having the \"falling back\" is a bit more explanatory.  Maybe this could be reworded a little to make sure it\u0027s clear.\n\nEven just say \"Will instead use the user-specified....\"","commit_id":"0ee5fa404d4dd1e1ba6516985c3715e02af36146"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":489,"context_line":"            endpoint_api_version \u003d options.os_volume_api_version"},{"line_number":490,"context_line":"            if api_version_input:"},{"line_number":491,"context_line":"                logger.warning(\"Cannot determine the API version from \""},{"line_number":492,"context_line":"                               \"the endpoint URL. Falls back to the \""},{"line_number":493,"context_line":"                               \"user-specified version: %s\" %"},{"line_number":494,"context_line":"                               endpoint_api_version)"},{"line_number":495,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FHU%3D","line":492,"updated":"2014-03-31 18:58:55.000000000","message":"Seems like \"Falling\" was correct?","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":489,"context_line":"            endpoint_api_version \u003d options.os_volume_api_version"},{"line_number":490,"context_line":"            if api_version_input:"},{"line_number":491,"context_line":"                logger.warning(\"Cannot determine the API version from \""},{"line_number":492,"context_line":"                               \"the endpoint URL. Falls back to the \""},{"line_number":493,"context_line":"                               \"user-specified version: %s\" %"},{"line_number":494,"context_line":"                               endpoint_api_version)"},{"line_number":495,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BUE%3D","line":492,"in_reply_to":"AAAAWH%2F9%2FHU%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                               endpoint_api_version)"},{"line_number":495,"context_line":"            else:"},{"line_number":496,"context_line":"                logger.warning(\"Cannot determine the API version from the \""},{"line_number":497,"context_line":"                               \"endpoint URL or user input. Falls back \""},{"line_number":498,"context_line":"                               \"to the default API version: %s\" %"},{"line_number":499,"context_line":"                               endpoint_api_version)"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FHQ%3D","line":497,"updated":"2014-03-31 18:58:55.000000000","message":"Ditto.","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":494,"context_line":"                               endpoint_api_version)"},{"line_number":495,"context_line":"            else:"},{"line_number":496,"context_line":"                logger.warning(\"Cannot determine the API version from the \""},{"line_number":497,"context_line":"                               \"endpoint URL or user input. Falls back \""},{"line_number":498,"context_line":"                               \"to the default API version: %s\" %"},{"line_number":499,"context_line":"                               endpoint_api_version)"},{"line_number":500,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BUA%3D","line":497,"in_reply_to":"AAAAWH%2F9%2FHQ%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"}],"cinderclient/v1/shell.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c171ec340bf8d5bbe11258d888fbb2d37a9ab2e0","unresolved":false,"context_lines":[{"line_number":198,"context_line":"    \u0027--snapshot-id\u0027,"},{"line_number":199,"context_line":"    metavar\u003d\u0027\u003csnapshot-id\u003e\u0027,"},{"line_number":200,"context_line":"    default\u003dNone,"},{"line_number":201,"context_line":"    help\u003d\u0027Optional. Creates volume from snapshot ID. \u0027"},{"line_number":202,"context_line":"    \u0027Default is None.\u0027)"},{"line_number":203,"context_line":"@utils.arg("},{"line_number":204,"context_line":"    \u0027--snapshot_id\u0027,"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAU3%2F%2FhI4%3D","line":201,"updated":"2014-02-26 06:45:09.000000000","message":"In the case of the optional params I think it\u0027s more clear to leave them as they were before, but maybe use a colon.\n\nie \"Creates a volume from the snapshot with the provided id (OPTIONAL: Default\u003dNone)\"\n\nThat may not be the best either but it\u0027s important IMO to be as clear as possible here.","commit_id":"0ee5fa404d4dd1e1ba6516985c3715e02af36146"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c171ec340bf8d5bbe11258d888fbb2d37a9ab2e0","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    metavar\u003d\u0027\u003csnapshot-id\u003e\u0027,"},{"line_number":200,"context_line":"    default\u003dNone,"},{"line_number":201,"context_line":"    help\u003d\u0027Optional. Creates volume from snapshot ID. \u0027"},{"line_number":202,"context_line":"    \u0027Default is None.\u0027)"},{"line_number":203,"context_line":"@utils.arg("},{"line_number":204,"context_line":"    \u0027--snapshot_id\u0027,"},{"line_number":205,"context_line":"    help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAU3%2F%2FhHo%3D","line":202,"updated":"2014-02-26 06:45:09.000000000","message":"I think \"Default\u003dNone\" is still better... but this is fine as long as we do something to signify the default value more clearly.  Maybe just quotes?\n\n\u0027Default is \"None\".\u0027","commit_id":"0ee5fa404d4dd1e1ba6516985c3715e02af36146"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c171ec340bf8d5bbe11258d888fbb2d37a9ab2e0","unresolved":false,"context_lines":[{"line_number":842,"context_line":"           default\u003dNone)"},{"line_number":843,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":844,"context_line":"def do_backup_create(cs, args):"},{"line_number":845,"context_line":"    \"\"\"Creates a volume backup.\"\"\""},{"line_number":846,"context_line":"    volume \u003d utils.find_volume(cs, args.volume)"},{"line_number":847,"context_line":"    backup \u003d cs.backups.create(volume.id,"},{"line_number":848,"context_line":"                               args.container,"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAU3%2F%2FhHQ%3D","line":845,"updated":"2014-02-26 06:45:09.000000000","message":"Creates a backup of the specified Volume object","commit_id":"0ee5fa404d4dd1e1ba6516985c3715e02af36146"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c171ec340bf8d5bbe11258d888fbb2d37a9ab2e0","unresolved":false,"context_lines":[{"line_number":861,"context_line":"@utils.arg(\u0027backup\u0027, metavar\u003d\u0027\u003cbackup\u003e\u0027, help\u003d\u0027Name or ID of backup.\u0027)"},{"line_number":862,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":863,"context_line":"def do_backup_show(cs, args):"},{"line_number":864,"context_line":"    \"\"\"Show backup details.\"\"\""},{"line_number":865,"context_line":"    backup \u003d _find_backup(cs, args.backup)"},{"line_number":866,"context_line":"    info \u003d dict()"},{"line_number":867,"context_line":"    info.update(backup._info)"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAAU3%2F%2FhHY%3D","line":864,"updated":"2014-02-26 06:45:09.000000000","message":"\"Show details for the requested backup object\"","commit_id":"0ee5fa404d4dd1e1ba6516985c3715e02af36146"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":379,"context_line":"@utils.arg(\u0027action\u0027,"},{"line_number":380,"context_line":"           metavar\u003d\u0027\u003caction\u003e\u0027,"},{"line_number":381,"context_line":"           choices\u003d[\u0027set\u0027, \u0027unset\u0027],"},{"line_number":382,"context_line":"           help\u003d\"The action. Valid values are set or unset.\")"},{"line_number":383,"context_line":"@utils.arg(\u0027metadata\u0027,"},{"line_number":384,"context_line":"           metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":385,"context_line":"           nargs\u003d\u0027+\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FGU%3D","line":382,"updated":"2014-03-31 18:58:55.000000000","message":"Why no quotes around \u0027set\u0027 or \u0027unset\u0027?","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":379,"context_line":"@utils.arg(\u0027action\u0027,"},{"line_number":380,"context_line":"           metavar\u003d\u0027\u003caction\u003e\u0027,"},{"line_number":381,"context_line":"           choices\u003d[\u0027set\u0027, \u0027unset\u0027],"},{"line_number":382,"context_line":"           help\u003d\"The action. Valid values are set or unset.\")"},{"line_number":383,"context_line":"@utils.arg(\u0027metadata\u0027,"},{"line_number":384,"context_line":"           metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":385,"context_line":"           nargs\u003d\u0027+\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BOM%3D","line":382,"in_reply_to":"AAAAWH%2F9%2FGU%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":462,"context_line":"           help\u003d\u0027Name or ID of volume to snapshot.\u0027)"},{"line_number":463,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":464,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":465,"context_line":"           help\u003d\u0027Enables or disables snapshot of \u0027"},{"line_number":466,"context_line":"           \u0027a volume when the volume is attached to an instance. \u0027"},{"line_number":467,"context_line":"           \u0027OPTIONAL: Default\u003dFalse.\u0027,"},{"line_number":468,"context_line":"           default\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FFU%3D","line":465,"updated":"2014-03-31 18:58:55.000000000","message":"a) This is only part of the story -- what it does is ignore the current status of the volume when attempting to snapshot it (rather than forcing it to be \u0027available\u0027).\n\nb) If we did want to document it this way (which is the common case), it would probably make more sense as \"Allow\"/\"disallow\" rather than Enables/disables, since this is only relevant for this particular call and not really \"enabling\" anything permanently?","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":462,"context_line":"           help\u003d\u0027Name or ID of volume to snapshot.\u0027)"},{"line_number":463,"context_line":"@utils.arg(\u0027--force\u0027,"},{"line_number":464,"context_line":"           metavar\u003d\u0027\u003cTrue|False\u003e\u0027,"},{"line_number":465,"context_line":"           help\u003d\u0027Enables or disables snapshot of \u0027"},{"line_number":466,"context_line":"           \u0027a volume when the volume is attached to an instance. \u0027"},{"line_number":467,"context_line":"           \u0027OPTIONAL: Default\u003dFalse.\u0027,"},{"line_number":468,"context_line":"           default\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BMM%3D","line":465,"in_reply_to":"AAAAWH%2F9%2FFU%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":574,"context_line":""},{"line_number":575,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":576,"context_line":"def do_extra_specs_list(cs, args):"},{"line_number":577,"context_line":"    \"\"\"Lists current \u0027volume types and extra specs.\u0027 Default: admin only.\"\"\""},{"line_number":578,"context_line":"    vtypes \u003d cs.volume_types.list()"},{"line_number":579,"context_line":"    _print_type_and_extra_specs_list(vtypes)"},{"line_number":580,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FEc%3D","line":577,"updated":"2014-03-31 18:58:55.000000000","message":"Admin only is a policy/requirement, not a default?","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":574,"context_line":""},{"line_number":575,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":576,"context_line":"def do_extra_specs_list(cs, args):"},{"line_number":577,"context_line":"    \"\"\"Lists current \u0027volume types and extra specs.\u0027 Default: admin only.\"\"\""},{"line_number":578,"context_line":"    vtypes \u003d cs.volume_types.list()"},{"line_number":579,"context_line":"    _print_type_and_extra_specs_list(vtypes)"},{"line_number":580,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BL0%3D","line":577,"in_reply_to":"AAAAWH%2F9%2FEc%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":595,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":596,"context_line":"def do_type_delete(cs, args):"},{"line_number":597,"context_line":"    \"\"\"Deletes a specified volume type.\"\"\""},{"line_number":598,"context_line":"    cs.volume_types.delete(args.id)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"@utils.arg(\u0027vtype\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FEQ%3D","line":598,"updated":"2014-03-31 18:58:55.000000000","message":"!! This actually changed code -- looks like accidental revert/bad rebase around https://review.openstack.org/#/c/77264/ .","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":595,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":596,"context_line":"def do_type_delete(cs, args):"},{"line_number":597,"context_line":"    \"\"\"Deletes a specified volume type.\"\"\""},{"line_number":598,"context_line":"    cs.volume_types.delete(args.id)"},{"line_number":599,"context_line":""},{"line_number":600,"context_line":""},{"line_number":601,"context_line":"@utils.arg(\u0027vtype\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BK8%3D","line":598,"in_reply_to":"AAAAWH%2F9%2FEQ%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":604,"context_line":"@utils.arg(\u0027action\u0027,"},{"line_number":605,"context_line":"           metavar\u003d\u0027\u003caction\u003e\u0027,"},{"line_number":606,"context_line":"           choices\u003d[\u0027set\u0027, \u0027unset\u0027],"},{"line_number":607,"context_line":"           help\u003d\"The action. Valid values are set or unset.\")"},{"line_number":608,"context_line":"@utils.arg(\u0027metadata\u0027,"},{"line_number":609,"context_line":"           metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":610,"context_line":"           nargs\u003d\u0027*\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FDk%3D","line":607,"updated":"2014-03-31 18:58:55.000000000","message":"Same q about quotes for \u0027set\u0027 and \u0027unset\u0027.","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":604,"context_line":"@utils.arg(\u0027action\u0027,"},{"line_number":605,"context_line":"           metavar\u003d\u0027\u003caction\u003e\u0027,"},{"line_number":606,"context_line":"           choices\u003d[\u0027set\u0027, \u0027unset\u0027],"},{"line_number":607,"context_line":"           help\u003d\"The action. Valid values are set or unset.\")"},{"line_number":608,"context_line":"@utils.arg(\u0027metadata\u0027,"},{"line_number":609,"context_line":"           metavar\u003d\u0027\u003ckey\u003dvalue\u003e\u0027,"},{"line_number":610,"context_line":"           nargs\u003d\u0027*\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BKs%3D","line":607,"in_reply_to":"AAAAWH%2F9%2FDk%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":686,"context_line":""},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"@utils.arg(\u0027tenant\u0027, metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":689,"context_line":"           help\u003d\u0027UUID of acount for which to list quotas.\u0027)"},{"line_number":690,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":691,"context_line":"def do_quota_show(cs, args):"},{"line_number":692,"context_line":"    \"\"\"Lists quotas for a tenant.\"\"\""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FDg%3D","line":689,"updated":"2014-03-31 18:58:55.000000000","message":"\"acount\" typo.  Also I thought we were trying to reference tenants etc. as identified by \"ids\" rather than \"uuids\"?","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":686,"context_line":""},{"line_number":687,"context_line":""},{"line_number":688,"context_line":"@utils.arg(\u0027tenant\u0027, metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":689,"context_line":"           help\u003d\u0027UUID of acount for which to list quotas.\u0027)"},{"line_number":690,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":691,"context_line":"def do_quota_show(cs, args):"},{"line_number":692,"context_line":"    \"\"\"Lists quotas for a tenant.\"\"\""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BKk%3D","line":689,"in_reply_to":"AAAAWH%2F9%2FDg%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":695,"context_line":""},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"@utils.arg(\u0027tenant\u0027, metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":698,"context_line":"           help\u003d\u0027UUID of account for which to list quota usage.\u0027)"},{"line_number":699,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":700,"context_line":"def do_quota_usage(cs, args):"},{"line_number":701,"context_line":"    \"\"\"Lists quota usage for a tenant.\"\"\""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FDM%3D","line":698,"updated":"2014-03-31 18:58:55.000000000","message":"Ditto ^","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":695,"context_line":""},{"line_number":696,"context_line":""},{"line_number":697,"context_line":"@utils.arg(\u0027tenant\u0027, metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":698,"context_line":"           help\u003d\u0027UUID of account for which to list quota usage.\u0027)"},{"line_number":699,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":700,"context_line":"def do_quota_usage(cs, args):"},{"line_number":701,"context_line":"    \"\"\"Lists quota usage for a tenant.\"\"\""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BKY%3D","line":698,"in_reply_to":"AAAAWH%2F9%2FDM%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"@utils.arg(\u0027tenant\u0027, metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":707,"context_line":"           help\u003d\u0027UUID of account for which to list default quotas.\u0027)"},{"line_number":708,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":709,"context_line":"def do_quota_defaults(cs, args):"},{"line_number":710,"context_line":"    \"\"\"Lists default quotas for a tenant.\"\"\""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FDE%3D","line":707,"updated":"2014-03-31 18:58:55.000000000","message":"Ditto ^","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":704,"context_line":""},{"line_number":705,"context_line":""},{"line_number":706,"context_line":"@utils.arg(\u0027tenant\u0027, metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":707,"context_line":"           help\u003d\u0027UUID of account for which to list default quotas.\u0027)"},{"line_number":708,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":709,"context_line":"def do_quota_defaults(cs, args):"},{"line_number":710,"context_line":"    \"\"\"Lists default quotas for a tenant.\"\"\""}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BKU%3D","line":707,"in_reply_to":"AAAAWH%2F9%2FDE%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"@utils.arg(\u0027tenant\u0027, metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":716,"context_line":"           help\u003d\u0027UUID of account for which to set quotas.\u0027)"},{"line_number":717,"context_line":"@utils.arg(\u0027--volumes\u0027,"},{"line_number":718,"context_line":"           metavar\u003d\u0027\u003cvolumes\u003e\u0027,"},{"line_number":719,"context_line":"           type\u003dint, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FDA%3D","line":716,"updated":"2014-03-31 18:58:55.000000000","message":"Ditto ^","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":713,"context_line":""},{"line_number":714,"context_line":""},{"line_number":715,"context_line":"@utils.arg(\u0027tenant\u0027, metavar\u003d\u0027\u003ctenant_id\u003e\u0027,"},{"line_number":716,"context_line":"           help\u003d\u0027UUID of account for which to set quotas.\u0027)"},{"line_number":717,"context_line":"@utils.arg(\u0027--volumes\u0027,"},{"line_number":718,"context_line":"           metavar\u003d\u0027\u003cvolumes\u003e\u0027,"},{"line_number":719,"context_line":"           type\u003dint, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BKQ%3D","line":716,"in_reply_to":"AAAAWH%2F9%2FDA%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":717,"context_line":"@utils.arg(\u0027--volumes\u0027,"},{"line_number":718,"context_line":"           metavar\u003d\u0027\u003cvolumes\u003e\u0027,"},{"line_number":719,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":720,"context_line":"           help\u003d\u0027The new volumes quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":721,"context_line":"@utils.arg(\u0027--snapshots\u0027,"},{"line_number":722,"context_line":"           metavar\u003d\u0027\u003csnapshots\u003e\u0027,"},{"line_number":723,"context_line":"           type\u003dint, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FCU%3D","line":720,"updated":"2014-03-31 18:58:55.000000000","message":"Quotes for \u0027volumes\u0027?","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":717,"context_line":"@utils.arg(\u0027--volumes\u0027,"},{"line_number":718,"context_line":"           metavar\u003d\u0027\u003cvolumes\u003e\u0027,"},{"line_number":719,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":720,"context_line":"           help\u003d\u0027The new volumes quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":721,"context_line":"@utils.arg(\u0027--snapshots\u0027,"},{"line_number":722,"context_line":"           metavar\u003d\u0027\u003csnapshots\u003e\u0027,"},{"line_number":723,"context_line":"           type\u003dint, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BJ0%3D","line":720,"in_reply_to":"AAAAWH%2F9%2FCU%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":721,"context_line":"@utils.arg(\u0027--snapshots\u0027,"},{"line_number":722,"context_line":"           metavar\u003d\u0027\u003csnapshots\u003e\u0027,"},{"line_number":723,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":724,"context_line":"           help\u003d\u0027The new snapshots quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":725,"context_line":"@utils.arg(\u0027--gigabytes\u0027,"},{"line_number":726,"context_line":"           metavar\u003d\u0027\u003cgigabytes\u003e\u0027,"},{"line_number":727,"context_line":"           type\u003dint, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FCQ%3D","line":724,"updated":"2014-03-31 18:58:55.000000000","message":"Quotes? ^","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":721,"context_line":"@utils.arg(\u0027--snapshots\u0027,"},{"line_number":722,"context_line":"           metavar\u003d\u0027\u003csnapshots\u003e\u0027,"},{"line_number":723,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":724,"context_line":"           help\u003d\u0027The new snapshots quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":725,"context_line":"@utils.arg(\u0027--gigabytes\u0027,"},{"line_number":726,"context_line":"           metavar\u003d\u0027\u003cgigabytes\u003e\u0027,"},{"line_number":727,"context_line":"           type\u003dint, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BJw%3D","line":724,"in_reply_to":"AAAAWH%2F9%2FCQ%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":725,"context_line":"@utils.arg(\u0027--gigabytes\u0027,"},{"line_number":726,"context_line":"           metavar\u003d\u0027\u003cgigabytes\u003e\u0027,"},{"line_number":727,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":728,"context_line":"           help\u003d\u0027The new gigabytes quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":729,"context_line":"@utils.arg(\u0027--volume-type\u0027,"},{"line_number":730,"context_line":"           metavar\u003d\u0027\u003cvolume_type_name\u003e\u0027,"},{"line_number":731,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FCM%3D","line":728,"updated":"2014-03-31 18:58:55.000000000","message":"Quotes? ^","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":725,"context_line":"@utils.arg(\u0027--gigabytes\u0027,"},{"line_number":726,"context_line":"           metavar\u003d\u0027\u003cgigabytes\u003e\u0027,"},{"line_number":727,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":728,"context_line":"           help\u003d\u0027The new gigabytes quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":729,"context_line":"@utils.arg(\u0027--volume-type\u0027,"},{"line_number":730,"context_line":"           metavar\u003d\u0027\u003cvolume_type_name\u003e\u0027,"},{"line_number":731,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BJs%3D","line":728,"in_reply_to":"AAAAWH%2F9%2FCM%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":751,"context_line":"@utils.arg(\u0027--volumes\u0027,"},{"line_number":752,"context_line":"           metavar\u003d\u0027\u003cvolumes\u003e\u0027,"},{"line_number":753,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":754,"context_line":"           help\u003d\u0027The new volumes quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":755,"context_line":"@utils.arg(\u0027--snapshots\u0027,"},{"line_number":756,"context_line":"           metavar\u003d\u0027\u003csnapshots\u003e\u0027,"},{"line_number":757,"context_line":"           type\u003dint, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FCI%3D","line":754,"updated":"2014-03-31 18:58:55.000000000","message":"Quotes? ^","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":751,"context_line":"@utils.arg(\u0027--volumes\u0027,"},{"line_number":752,"context_line":"           metavar\u003d\u0027\u003cvolumes\u003e\u0027,"},{"line_number":753,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":754,"context_line":"           help\u003d\u0027The new volumes quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":755,"context_line":"@utils.arg(\u0027--snapshots\u0027,"},{"line_number":756,"context_line":"           metavar\u003d\u0027\u003csnapshots\u003e\u0027,"},{"line_number":757,"context_line":"           type\u003dint, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BJk%3D","line":754,"in_reply_to":"AAAAWH%2F9%2FCI%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":755,"context_line":"@utils.arg(\u0027--snapshots\u0027,"},{"line_number":756,"context_line":"           metavar\u003d\u0027\u003csnapshots\u003e\u0027,"},{"line_number":757,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":758,"context_line":"           help\u003d\u0027The new snapshots quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":759,"context_line":"@utils.arg(\u0027--gigabytes\u0027,"},{"line_number":760,"context_line":"           metavar\u003d\u0027\u003cgigabytes\u003e\u0027,"},{"line_number":761,"context_line":"           type\u003dint, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FCE%3D","line":758,"updated":"2014-03-31 18:58:55.000000000","message":"Quotes? ^","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":755,"context_line":"@utils.arg(\u0027--snapshots\u0027,"},{"line_number":756,"context_line":"           metavar\u003d\u0027\u003csnapshots\u003e\u0027,"},{"line_number":757,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":758,"context_line":"           help\u003d\u0027The new snapshots quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":759,"context_line":"@utils.arg(\u0027--gigabytes\u0027,"},{"line_number":760,"context_line":"           metavar\u003d\u0027\u003cgigabytes\u003e\u0027,"},{"line_number":761,"context_line":"           type\u003dint, default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BJQ%3D","line":758,"in_reply_to":"AAAAWH%2F9%2FCE%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":759,"context_line":"@utils.arg(\u0027--gigabytes\u0027,"},{"line_number":760,"context_line":"           metavar\u003d\u0027\u003cgigabytes\u003e\u0027,"},{"line_number":761,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":762,"context_line":"           help\u003d\u0027The new gigabytes quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":763,"context_line":"@utils.arg(\u0027--volume-type\u0027,"},{"line_number":764,"context_line":"           metavar\u003d\u0027\u003cvolume_type_name\u003e\u0027,"},{"line_number":765,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FCA%3D","line":762,"updated":"2014-03-31 18:58:55.000000000","message":"Quotes? ^","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":759,"context_line":"@utils.arg(\u0027--gigabytes\u0027,"},{"line_number":760,"context_line":"           metavar\u003d\u0027\u003cgigabytes\u003e\u0027,"},{"line_number":761,"context_line":"           type\u003dint, default\u003dNone,"},{"line_number":762,"context_line":"           help\u003d\u0027The new gigabytes quota value. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":763,"context_line":"@utils.arg(\u0027--volume-type\u0027,"},{"line_number":764,"context_line":"           metavar\u003d\u0027\u003cvolume_type_name\u003e\u0027,"},{"line_number":765,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BJM%3D","line":762,"in_reply_to":"AAAAWH%2F9%2FCA%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":1097,"context_line":"def do_encryption_type_list(cs, args):"},{"line_number":1098,"context_line":"    \"\"\"Shows encryption type details for volume types. Default: admin only.\"\"\""},{"line_number":1099,"context_line":"    result \u003d cs.volume_encryption_types.list()"},{"line_number":1100,"context_line":"    utils.print_list(result, [\u0027Volume Type ID\u0027, \u0027Provider\u0027, \u0027Cipher\u0027,"},{"line_number":1101,"context_line":"                              \u0027Key Size\u0027, \u0027Control Location\u0027])"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FBc%3D","line":1098,"updated":"2014-03-31 18:58:55.000000000","message":"Admin only is a policy/requirement and not a default?","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":1095,"context_line":""},{"line_number":1096,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":1097,"context_line":"def do_encryption_type_list(cs, args):"},{"line_number":1098,"context_line":"    \"\"\"Shows encryption type details for volume types. Default: admin only.\"\"\""},{"line_number":1099,"context_line":"    result \u003d cs.volume_encryption_types.list()"},{"line_number":1100,"context_line":"    utils.print_list(result, [\u0027Volume Type ID\u0027, \u0027Provider\u0027, \u0027Cipher\u0027,"},{"line_number":1101,"context_line":"                              \u0027Key Size\u0027, \u0027Control Location\u0027])"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BJI%3D","line":1098,"in_reply_to":"AAAAWH%2F9%2FBc%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"           help\u003d\"Name or ID of volume type.\")"},{"line_number":1108,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":1109,"context_line":"def do_encryption_type_show(cs, args):"},{"line_number":1110,"context_line":"    \"\"\"Shows encryption type details for volume type. Default: admin only.\"\"\""},{"line_number":1111,"context_line":"    volume_type \u003d _find_volume_type(cs, args.volume_type)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    result \u003d cs.volume_encryption_types.get(volume_type)"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FBY%3D","line":1110,"updated":"2014-03-31 18:58:55.000000000","message":"Ditto ^","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":1107,"context_line":"           help\u003d\"Name or ID of volume type.\")"},{"line_number":1108,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":1109,"context_line":"def do_encryption_type_show(cs, args):"},{"line_number":1110,"context_line":"    \"\"\"Shows encryption type details for volume type. Default: admin only.\"\"\""},{"line_number":1111,"context_line":"    volume_type \u003d _find_volume_type(cs, args.volume_type)"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    result \u003d cs.volume_encryption_types.get(volume_type)"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BH4%3D","line":1110,"in_reply_to":"AAAAWH%2F9%2FBY%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"           metavar\u003d\u0027\u003cprovider\u003e\u0027,"},{"line_number":1128,"context_line":"           type\u003dstr,"},{"line_number":1129,"context_line":"           help\u003d\u0027The class that provides encryption support. \u0027"},{"line_number":1130,"context_line":"           \u0027For example, LuksEncryptor.\u0027)"},{"line_number":1131,"context_line":"@utils.arg(\u0027--cipher\u0027,"},{"line_number":1132,"context_line":"           metavar\u003d\u0027\u003ccipher\u003e\u0027,"},{"line_number":1133,"context_line":"           type\u003dstr,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FBI%3D","line":1130,"updated":"2014-03-31 18:58:55.000000000","message":"Is \u0027LuksEncryptor\u0027 actually a valid example or does this look more like a volume driver class path?","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":1127,"context_line":"           metavar\u003d\u0027\u003cprovider\u003e\u0027,"},{"line_number":1128,"context_line":"           type\u003dstr,"},{"line_number":1129,"context_line":"           help\u003d\u0027The class that provides encryption support. \u0027"},{"line_number":1130,"context_line":"           \u0027For example, LuksEncryptor.\u0027)"},{"line_number":1131,"context_line":"@utils.arg(\u0027--cipher\u0027,"},{"line_number":1132,"context_line":"           metavar\u003d\u0027\u003ccipher\u003e\u0027,"},{"line_number":1133,"context_line":"           type\u003dstr,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BHw%3D","line":1130,"in_reply_to":"AAAAWH%2F9%2FBI%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"           type\u003dstr,"},{"line_number":1134,"context_line":"           required\u003dFalse,"},{"line_number":1135,"context_line":"           default\u003dNone,"},{"line_number":1136,"context_line":"           help\u003d\u0027The encryption algorithm or mode. \u0027"},{"line_number":1137,"context_line":"           \u0027For example, aes-xts-plain64. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":1138,"context_line":"@utils.arg(\u0027--key_size\u0027,"},{"line_number":1139,"context_line":"           metavar\u003d\u0027\u003ckey_size\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FAs%3D","line":1136,"updated":"2014-03-31 18:58:55.000000000","message":"I think this is \"and mode\".  (i.e. algorithm\u003daes mode\u003dxts for \u0027aes-xts-plain64\u0027)","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":1133,"context_line":"           type\u003dstr,"},{"line_number":1134,"context_line":"           required\u003dFalse,"},{"line_number":1135,"context_line":"           default\u003dNone,"},{"line_number":1136,"context_line":"           help\u003d\u0027The encryption algorithm or mode. \u0027"},{"line_number":1137,"context_line":"           \u0027For example, aes-xts-plain64. OPTIONAL: Default\u003dNone.\u0027)"},{"line_number":1138,"context_line":"@utils.arg(\u0027--key_size\u0027,"},{"line_number":1139,"context_line":"           metavar\u003d\u0027\u003ckey_size\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BHg%3D","line":1136,"in_reply_to":"AAAAWH%2F9%2FAs%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":1148,"context_line":"           type\u003dstr,"},{"line_number":1149,"context_line":"           required\u003dFalse,"},{"line_number":1150,"context_line":"           default\u003d\u0027front-end\u0027,"},{"line_number":1151,"context_line":"           help\u003d\u0027Notional service where encryption is performed. \u0027"},{"line_number":1152,"context_line":"           \u0027Valid values are front-end or back-end. \u0027"},{"line_number":1153,"context_line":"           \u0027For example, front-end\u003dNova. \u0027"},{"line_number":1154,"context_line":"           \u0027OPTIONAL: Default is front-end.\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2B%2Fg%3D","line":1151,"updated":"2014-03-31 18:58:55.000000000","message":"It worries me that if you google for \u0027Notional service\u0027, cinderclient is the primary result.","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":1148,"context_line":"           type\u003dstr,"},{"line_number":1149,"context_line":"           required\u003dFalse,"},{"line_number":1150,"context_line":"           default\u003d\u0027front-end\u0027,"},{"line_number":1151,"context_line":"           help\u003d\u0027Notional service where encryption is performed. \u0027"},{"line_number":1152,"context_line":"           \u0027Valid values are front-end or back-end. \u0027"},{"line_number":1153,"context_line":"           \u0027For example, front-end\u003dNova. \u0027"},{"line_number":1154,"context_line":"           \u0027OPTIONAL: Default is front-end.\u0027)"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BHQ%3D","line":1151,"in_reply_to":"AAAAWH%2F9%2B%2Fg%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"8f87585b7455d15bafef04a6eec937ebc633dea1","unresolved":false,"context_lines":[{"line_number":1154,"context_line":"           \u0027OPTIONAL: Default is front-end.\u0027)"},{"line_number":1155,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":1156,"context_line":"def do_encryption_type_create(cs, args):"},{"line_number":1157,"context_line":"    \"\"\"Creates encryption type for a volume type. Default: admin only.\"\"\""},{"line_number":1158,"context_line":"    volume_type \u003d _find_volume_type(cs, args.volume_type)"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"    body \u003d {}"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2FAU%3D","line":1157,"updated":"2014-03-31 18:58:55.000000000","message":"Same default/admin comment.","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"},{"author":{"_account_id":2448,"name":"Diane Fleming","email":"dfleming@austin.rr.com","username":"diane-fleming"},"change_message_id":"cf7e1ba264e3b3a5fdd91ce1cf25b0cd989d01a3","unresolved":false,"context_lines":[{"line_number":1154,"context_line":"           \u0027OPTIONAL: Default is front-end.\u0027)"},{"line_number":1155,"context_line":"@utils.service_type(\u0027volume\u0027)"},{"line_number":1156,"context_line":"def do_encryption_type_create(cs, args):"},{"line_number":1157,"context_line":"    \"\"\"Creates encryption type for a volume type. Default: admin only.\"\"\""},{"line_number":1158,"context_line":"    volume_type \u003d _find_volume_type(cs, args.volume_type)"},{"line_number":1159,"context_line":""},{"line_number":1160,"context_line":"    body \u003d {}"}],"source_content_type":"text/x-python","patch_set":29,"id":"AAAAWH%2F9%2BFI%3D","line":1157,"in_reply_to":"AAAAWH%2F9%2FAU%3D","updated":"2014-03-31 20:49:08.000000000","message":"Done","commit_id":"24fb7acbc087872e9ea575f99803ee19a4923015"}]}