)]}'
{"id":"openstack%2Fpython-cinderclient~714570","triplet_id":"openstack%2Fpython-cinderclient~master~I6b9a1f088c84676ddf9894cf9524d3239f3cf3a9","project":"openstack/python-cinderclient","branch":"master","topic":"endpoint-override","hashtags":[],"change_id":"I6b9a1f088c84676ddf9894cf9524d3239f3cf3a9","subject":"Pass os_endpoint to keystone session","status":"MERGED","created":"2020-03-24 05:12:23.000000000","updated":"2020-04-03 14:04:00.000000000","submitted":"2020-04-03 14:01:47.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"714570-1585922507354-9820b1aa","meta_rev_id":"1c8e7c883dd9e5e78763e7c5b8e9a26936dc7f3a","_number":714570,"virtual_id_number":714570,"owner":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-04-03 14:01:47.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-03-24 12:05:09.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2020-03-24 11:59:07.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":2,"date":"2020-04-03 12:25:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":1,"date":"2020-04-03 12:25:55.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-24 11:59:07.000000000","updated_by":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"reviewer":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"state":"REVIEWER"},{"updated":"2020-03-24 12:05:09.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-04-03 12:25:55.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2020-04-03 14:01:47.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"c29f7239d1de73906730295eac41e9ca819e5917","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-03-24 05:12:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"95cb218a53ea33c9defc50194d984b98b444030e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 06:44:34.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/11fcb425068d4bc3b7a60c1bd77a17a4 : SUCCESS in 1h 30m 57s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/17698364b55a49cfb88271a594c4a93d : FAILURE in 3m 46s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/5b1290c421ee4d4c8c592c93f03e110f : FAILURE in 3m 49s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/99d51ffa74324fc980028a42174c1b41 : SUCCESS in 3m 31s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8c50a5346312434397c7bfa353ac81d1 : FAILURE in 3m 29s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/236f6ac984c94df9a093bcce65ff9ec4 : FAILURE in 5m 11s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9b609b77b4c84141b043ace518b33b33 : FAILURE in 5m 12s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/23c6eeb47e204a619a9ecb2703d8154c : SUCCESS in 6m 09s\n- python-cinderclient-functional-py36 https://zuul.opendev.org/t/openstack/build/86e72d37b60942a589ad0eeb91e910c4 : SUCCESS in 32m 22s\n- python-cinderclient-functional-py37 https://zuul.opendev.org/t/openstack/build/de08049b7cea475a92efdd3e569113ce : SUCCESS in 33m 50s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/de81704aaafb4474976329d735295dcf : SUCCESS in 5m 19s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"1fa9d394b0f77e755485beb7457d99f22e8ebf64","author":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"date":"2020-03-24 07:41:54.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ea5bf1a94a24be147537e03f28ec64788e383446","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-24 09:08:30.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/63fd113e43404d2b9f4ce0b9faec1ddb : SUCCESS in 1h 25m 48s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4f14edacd81a41bbbbdddb0877443ee5 : SUCCESS in 4m 49s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b0de5856507a44f28204762a4426cfa6 : SUCCESS in 4m 08s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1ab61756cd65425e83d892f217e2b47e : SUCCESS in 4m 10s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2f89d735725043faa80191c5e370dd74 : SUCCESS in 4m 06s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/9e5b832973be40afbec48c630d73396b : SUCCESS in 5m 40s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/4b71fd0175a148acba096aeff0d6529c : SUCCESS in 5m 02s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/ee8528574c8a4dc497377b940f6149db : SUCCESS in 5m 36s\n- python-cinderclient-functional-py36 https://zuul.opendev.org/t/openstack/build/4cac959e517b42a294f4a5a9ec3fdcfa : SUCCESS in 32m 26s\n- python-cinderclient-functional-py37 https://zuul.opendev.org/t/openstack/build/aa19919f60c74e3f841ee2e6497be61c : SUCCESS in 33m 18s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/3447e439e879469297b0b0c461f0f5d5 : SUCCESS in 5m 17s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"6413e481f22d6974b9708319879daee875734c18","author":{"_account_id":2,"name":"Monty Taylor","email":"mordred@inaugust.com","username":"mordred"},"date":"2020-03-24 11:59:07.000000000","message":"Patch Set 2: Code-Review+1\n\nUnit test fix is right. If it\u0027s honoring the endpoint override now, admin should not be present. If this was a *real* cloud, the endpoint override should likely have /admin on the end of it to be right. (like your rackspace example) But in the requests_mock case it\u0027s actually good to see that it is making a call to the endpoint the user passed.","accounts_in_message":[],"_revision_number":2},{"id":"71dc1436daec09be4ad493cf29afd8a492c4535b","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-03-24 12:05:09.000000000","message":"Patch Set 2: Code-Review+2\n\nLooks like we might also need the changes in https://review.opendev.org/#/c/714572/, but this looks good and that one can get updated after this merges.","accounts_in_message":[],"_revision_number":2},{"id":"f202d23f4498a2294f4fafc517a380a7b13503bb","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-04-03 12:25:55.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\nThanks, Ian.","accounts_in_message":[],"_revision_number":2},{"id":"234f4c43c24d945c30f68b55b0b6c776a01529d7","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-03 12:26:06.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"2f2050956fcd6e6a37f9c60d7d72921b8922d005","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-03 14:01:47.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/303ab60ace044587bcf11b27e9ddda26 : SUCCESS in 1h 29m 53s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/78ecdb7424664510a566b964692fdf3f : SUCCESS in 4m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6d132f620aae4750b7b278580affe2ed : SUCCESS in 5m 21s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/9264b1ee7a6c46e0a8004992c83e6d1f : SUCCESS in 5m 13s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/83b90d8af0ba45579e99947f08981321 : SUCCESS in 5m 33s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/e198d9e1e8714004abc53816666b3557 : SUCCESS in 6m 48s","accounts_in_message":[],"_revision_number":2},{"id":"6ed4b9ed7a7c5e1e11b5c08b5fc3589e8d5c29c7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-03 14:01:47.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"ea4d9e5776be537b38b8a37fb771c933d04750f9","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-04-03 14:04:00.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/99bf5ccfc8fb403e818abc319753627c : SUCCESS in 1m 46s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"38a44e7ebeead6c086374d80f25d135618380faa","revisions":{"75690f5ec6a1fc71a5c2c88fe6cf0f268e16221f":{"kind":"REWORK","_number":1,"created":"2020-03-24 05:12:23.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/70/714570/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/70/714570/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/70/714570/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/70/714570/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/70/714570/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/70/714570/1"}}},"commit":{"parents":[{"commit":"7e8d5ca15a655f9d706c36e4bb3a7ede53f4b03e","subject":"Merge \"Fix doc bug filing link\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/7e8d5ca15a655f9d706c36e4bb3a7ede53f4b03e"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2020-03-24 04:24:59.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2020-03-24 05:11:58.000000000","tz":660},"subject":"Pass os_endpoint to keystone session","message":"Pass os_endpoint to keystone session\n\nThe os_endpoint should be passed to the keystone session as the\nendpoint_override argument.\n\nThis is particularly imprtant for talking to Rackspace, who seem to\nhave an odd situation where the endpoint is V2 compatible [1], but the\nAPI is still at /v1/ [2] (i think?).\n\nTo use the RAX API you need to find your account number, then\nsomething like:\n\n OS_USERNAME\u003dxyz\n OS_PASSWORD\u003dabc\n OS_AUTH_URL\u003dhttps://identity.api.rackspacecloud.com/v2.0/\n OS_VOLUME_API_VERSION\u003d2\n CINDER_ENDPOINT\u003dhttps://dfw.blockstorage.api.rackspacecloud.com/v1/\u003caccount#\u003e\n cinder volume list\n\nShould work\n\nStory: #2007459\nTask: #39138\n\n[1] https://developer.rackspace.com/docs/cloud-block-storage/v1/general-api-info/cbsv1-methods-vs-cinderv2-methods/\n[2] https://developer.rackspace.com/docs/cloud-block-storage/v1/general-api-info/service-access/\n\nChange-Id: I6b9a1f088c84676ddf9894cf9524d3239f3cf3a9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/75690f5ec6a1fc71a5c2c88fe6cf0f268e16221f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/75690f5ec6a1fc71a5c2c88fe6cf0f268e16221f"}]},"branch":"refs/heads/master"},"38a44e7ebeead6c086374d80f25d135618380faa":{"kind":"REWORK","_number":2,"created":"2020-03-24 07:41:54.000000000","uploader":{"_account_id":7118,"name":"Ian Wienand","email":"iwienand@redhat.com","username":"iwienand"},"ref":"refs/changes/70/714570/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/70/714570/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/70/714570/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/70/714570/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/70/714570/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/70/714570/2"}}},"commit":{"parents":[{"commit":"7e8d5ca15a655f9d706c36e4bb3a7ede53f4b03e","subject":"Merge \"Fix doc bug filing link\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/7e8d5ca15a655f9d706c36e4bb3a7ede53f4b03e"}]}],"author":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2020-03-24 04:24:59.000000000","tz":660},"committer":{"name":"Ian Wienand","email":"iwienand@redhat.com","date":"2020-03-24 07:39:11.000000000","tz":660},"subject":"Pass os_endpoint to keystone session","message":"Pass os_endpoint to keystone session\n\nThe os_endpoint should be passed to the keystone session as the\nendpoint_override argument.\n\nThis is particularly imprtant for talking to Rackspace, who seem to\nhave an odd situation where the endpoint is V2 compatible [1], but the\nAPI is still at /v1/ [2] (i think?).\n\nTo use the RAX API you need to find your account number, then\nsomething like:\n\n OS_USERNAME\u003dxyz\n OS_PASSWORD\u003dabc\n OS_AUTH_URL\u003dhttps://identity.api.rackspacecloud.com/v2.0/\n OS_VOLUME_API_VERSION\u003d2\n CINDER_ENDPOINT\u003dhttps://dfw.blockstorage.api.rackspacecloud.com/v1/\u003caccount#\u003e\n cinder volume list\n\nShould work\n\nHonestly I\u0027m not 100% what\u0027s up with the unit test.  I think endpoint\noverride was not being processed previously, and now it is so it drops\nthe \"admin\"?\n\nStory: #2007459\nTask: #39138\n\n[1] https://developer.rackspace.com/docs/cloud-block-storage/v1/general-api-info/cbsv1-methods-vs-cinderv2-methods/\n[2] https://developer.rackspace.com/docs/cloud-block-storage/v1/general-api-info/service-access/\n\nChange-Id: I6b9a1f088c84676ddf9894cf9524d3239f3cf3a9\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/38a44e7ebeead6c086374d80f25d135618380faa"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/38a44e7ebeead6c086374d80f25d135618380faa"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}