)]}'
{"id":"openstack%2Fpython-cinderclient~731537","triplet_id":"openstack%2Fpython-cinderclient~master~Id2772ce0b4f9f9d689ee1775002cd998fc400b98","project":"openstack/python-cinderclient","branch":"master","hashtags":[],"change_id":"Id2772ce0b4f9f9d689ee1775002cd998fc400b98","subject":"Use unittest.mock instead of third party mock","status":"ABANDONED","created":"2020-05-28 13:59:57.000000000","updated":"2020-05-29 01:19:09.000000000","total_comment_count":12,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fed5cc5fe82695fc97b96c2cc571765f00ffdb1c","_number":731537,"virtual_id_number":731537,"owner":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2020-05-28 16:12:48.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"date":"2020-05-29 01:19:04.000000000","_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},{"value":0,"date":"2020-05-28 16:38:50.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-05-28 16:12:48.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2020-05-28 16:38:50.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"3bb3b22615517c2e82ac491a15d053349226608a","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2020-05-28 13:59:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"62cf55ca27ed2c13c518c38bc7a3f348a8b5d331","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-05-28 14:04:59.000000000","message":"Patch Set 1: Code-Review-1\n\n(2 comments)\n\nImport ordering needs to be cleaned up throughout.","accounts_in_message":[],"_revision_number":1},{"id":"2bcc4db0d84eb09c2991dedcb815004951c22ce6","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2020-05-28 14:13:10.000000000","message":"Patch Set 1:\n\n\u003e (2 comments)\n \u003e \n \u003e Import ordering needs to be cleaned up throughout.\n\ndone,  and combine local lib","accounts_in_message":[],"_revision_number":1},{"id":"c6754548f0824c11a62539497b26cf19ec402f43","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2020-05-28 14:13:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e7ad8204f6fd45002805e5fb6ba381aa4cab050b","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2020-05-28 14:24:45.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"d4418ca74a0e01c7bd070117ffa331477063f857","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-05-28 14:37:56.000000000","message":"Patch Set 3: Code-Review-1\n\n(9 comments)\n\nThanks. Still have this in the third party import grouping in a lot of places.","accounts_in_message":[],"_revision_number":3},{"id":"ac013df809bce7e3cde129df96bc5815339619d9","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2020-05-28 15:10:27.000000000","message":"Patch Set 3:\n\n\u003e (9 comments)\n \u003e \n \u003e Thanks. Still have this in the third party import grouping in a lot\n \u003e of places.\n\ndone, thanks","accounts_in_message":[],"_revision_number":3},{"id":"d41ab58bfde224dbabe452c6f7aef8fce0d770ed","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2020-05-28 15:11:21.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"b22c881f75bc152b0a9428344d5168dc2e7e0030","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-05-28 15:37:24.000000000","message":"Patch Set 4: Code-Review+2\n\n(1 comment)\n\nLooks good. One missed, but I don\u0027t think we have to block on that. If you update, great. If not, we can clean that up in a future patch if we decide to more strictly enforce import ordering.\n\nThanks for making the updates.","accounts_in_message":[],"_revision_number":4},{"id":"44986ec6f41c6a36f32a3527ef5d319b2f4434b0","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-05-28 16:12:48.000000000","message":"Patch Set 4: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/fa381d0193b64961bbfd21afb099e9bc : SUCCESS in 55m 18s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/6e147ccf2dcf4a50b099d8724847a686 : SUCCESS in 7m 03s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/fbb1c878de824dda8ad6605ee13a668c : SUCCESS in 6m 32s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/278056000812405aa3a5e1a26228eccf : SUCCESS in 7m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/76d002a3cfc647288b8b6c86c24e08de : SUCCESS in 8m 01s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/2a07e1f50b8d4c0ebe66dede1a61a630 : SUCCESS in 8m 41s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/920a4e6a24e44625b3cf1bc1e22eab47 : SUCCESS in 9m 47s\n- python-cinderclient-functional-py36 https://zuul.opendev.org/t/openstack/build/40f08ccd09b74e3bb9c2c74128e6ced9 : SUCCESS in 30m 11s\n- python-cinderclient-functional-py37 https://zuul.opendev.org/t/openstack/build/c98d90b3c97149ab891d0f5f2c8b9a05 : SUCCESS in 31m 18s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/250b686165b94903a768e189baea1c67 : SUCCESS in 8m 11s (non-voting)","accounts_in_message":[],"_revision_number":4},{"id":"2de524de6d804764f7ccfbd9d9e448f4ef1db2b7","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-05-28 16:38:50.000000000","message":"Patch Set 4: -Code-Review\n\nActually, https://review.opendev.org/#/c/720978/2 was first, so we should probably get that one in.","accounts_in_message":[],"_revision_number":4},{"id":"cb3188253d2d7ce973af5824fe52248c80f15068","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2020-05-29 01:19:04.000000000","message":"Patch Set 4:\n\n\u003e Actually, https://review.opendev.org/#/c/720978/2 was first, so we\n \u003e should probably get that one in.\n\nok","accounts_in_message":[],"_revision_number":4},{"id":"fed5cc5fe82695fc97b96c2cc571765f00ffdb1c","author":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"date":"2020-05-29 01:19:09.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":4}],"current_revision_number":4,"current_revision":"2dbbdd7c68cbe8565bcc828c1ed80c392eeec58a","revisions":{"e64c60698f7263c48f82853a2332cd2a2d1f484a":{"kind":"REWORK","_number":1,"created":"2020-05-28 13:59:57.000000000","uploader":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"ref":"refs/changes/37/731537/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/37/731537/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/1"}}},"commit":{"parents":[{"commit":"185aa9471f5a0880779dd26def5ce71072caac8f","subject":"Merge \"Add py38 package metadata\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/185aa9471f5a0880779dd26def5ce71072caac8f"}]}],"author":{"name":"wu.chunyang","email":"wchy1001@gmail.com","date":"2020-05-28 13:53:01.000000000","tz":480},"committer":{"name":"wu.chunyang","email":"wchy1001@gmail.com","date":"2020-05-28 13:59:51.000000000","tz":480},"subject":"Use unittest.mock instead of third party mock","message":"Use unittest.mock instead of third party mock\n\nwe currently don\u0027t support py2 and py3 has removed mock to\nunittest module.\n\nChange-Id: Id2772ce0b4f9f9d689ee1775002cd998fc400b98\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e64c60698f7263c48f82853a2332cd2a2d1f484a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/e64c60698f7263c48f82853a2332cd2a2d1f484a"}]},"branch":"refs/heads/master"},"5ce95977a2b239dabc24356480b2c84e85796f06":{"kind":"REWORK","_number":2,"created":"2020-05-28 14:13:25.000000000","uploader":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"ref":"refs/changes/37/731537/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/37/731537/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/2"}}},"commit":{"parents":[{"commit":"185aa9471f5a0880779dd26def5ce71072caac8f","subject":"Merge \"Add py38 package metadata\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/185aa9471f5a0880779dd26def5ce71072caac8f"}]}],"author":{"name":"wu.chunyang","email":"wchy1001@gmail.com","date":"2020-05-28 13:53:01.000000000","tz":480},"committer":{"name":"wu.chunyang","email":"wchy1001@gmail.com","date":"2020-05-28 14:12:17.000000000","tz":480},"subject":"Use unittest.mock instead of third party mock","message":"Use unittest.mock instead of third party mock\n\nwe currently don\u0027t support py2 and py3 has removed mock to\nunittest module.\n\nChange-Id: Id2772ce0b4f9f9d689ee1775002cd998fc400b98\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/5ce95977a2b239dabc24356480b2c84e85796f06"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/5ce95977a2b239dabc24356480b2c84e85796f06"}]},"branch":"refs/heads/master"},"016199a369075884f7a1a02bcbf7813524ae669e":{"kind":"REWORK","_number":3,"created":"2020-05-28 14:24:45.000000000","uploader":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"ref":"refs/changes/37/731537/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/37/731537/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/3"}}},"commit":{"parents":[{"commit":"185aa9471f5a0880779dd26def5ce71072caac8f","subject":"Merge \"Add py38 package metadata\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/185aa9471f5a0880779dd26def5ce71072caac8f"}]}],"author":{"name":"wu.chunyang","email":"wchy1001@gmail.com","date":"2020-05-28 13:53:01.000000000","tz":480},"committer":{"name":"wu.chunyang","email":"wchy1001@gmail.com","date":"2020-05-28 14:23:33.000000000","tz":480},"subject":"Use unittest.mock instead of third party mock","message":"Use unittest.mock instead of third party mock\n\nwe currently don\u0027t support py2 and py3 has removed mock to\nunittest module.\n\nChange-Id: Id2772ce0b4f9f9d689ee1775002cd998fc400b98\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/016199a369075884f7a1a02bcbf7813524ae669e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/016199a369075884f7a1a02bcbf7813524ae669e"}]},"branch":"refs/heads/master"},"2dbbdd7c68cbe8565bcc828c1ed80c392eeec58a":{"kind":"REWORK","_number":4,"created":"2020-05-28 15:11:21.000000000","uploader":{"_account_id":26285,"name":"wu.chunyang","email":"wchy1001@gmail.com","username":"wu.chunyang"},"ref":"refs/changes/37/731537/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/37/731537/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/37/731537/4"}}},"commit":{"parents":[{"commit":"185aa9471f5a0880779dd26def5ce71072caac8f","subject":"Merge \"Add py38 package metadata\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/185aa9471f5a0880779dd26def5ce71072caac8f"}]}],"author":{"name":"wu.chunyang","email":"wchy1001@gmail.com","date":"2020-05-28 13:53:01.000000000","tz":480},"committer":{"name":"wu.chunyang","email":"wchy1001@gmail.com","date":"2020-05-28 15:10:06.000000000","tz":480},"subject":"Use unittest.mock instead of third party mock","message":"Use unittest.mock instead of third party mock\n\nwe currently don\u0027t support py2 and py3 has removed mock to\nunittest module.\n\nChange-Id: Id2772ce0b4f9f9d689ee1775002cd998fc400b98\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2dbbdd7c68cbe8565bcc828c1ed80c392eeec58a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2dbbdd7c68cbe8565bcc828c1ed80c392eeec58a"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}