)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3a6739f2a1706b8e66577a139d22eebbdd76f8b7","unresolved":false,"context_lines":[{"line_number":22,"context_line":"cinder --os-volume-api-version 3.61 default-type-list"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"3) Unset"},{"line_number":25,"context_line":"Unset defualt volume type for a project"},{"line_number":26,"context_line":"cinder --os-volume-api-version 3.61 default-type-unset \u003cproject-id\u003e"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Id2fb00c218edbb98df3193577dba6a897c6e73f6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_d327c7b5","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":13},"updated":"2020-09-06 23:17:29.000000000","message":"nit: typo\n(only fix if you need to push a new patch)","commit_id":"56bdf70ef44cac9ad5cfe61ab18f35e72dd10c3e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7b1f6db1efb51d03513d4e706b0046438686214d","unresolved":false,"context_lines":[{"line_number":22,"context_line":"cinder --os-volume-api-version 3.61 default-type-list"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"3) Unset"},{"line_number":25,"context_line":"Unset defualt volume type for a project"},{"line_number":26,"context_line":"cinder --os-volume-api-version 3.61 default-type-unset \u003cproject-id\u003e"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"Change-Id: Id2fb00c218edbb98df3193577dba6a897c6e73f6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9f560f44_267a4323","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":13},"in_reply_to":"9f560f44_d327c7b5","updated":"2020-09-07 06:21:01.000000000","message":"Done","commit_id":"56bdf70ef44cac9ad5cfe61ab18f35e72dd10c3e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e80836f48a4abfe0ecffa6aa19afaed76bfa328d","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1) Set"},{"line_number":15,"context_line":"Set a default volume type for a project"},{"line_number":16,"context_line":"cinder --os-volume-api-version 3.61 default-type-set \u003cvol-type-id\u003e \u003cproject-id\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2) Get"},{"line_number":19,"context_line":"Get the default volume type for a project"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_552437c6","line":16,"range":{"start_line":16,"start_character":31,"end_line":16,"end_character":35},"updated":"2020-09-07 17:55:02.000000000","message":"-1: 3.62","commit_id":"03a14b6791432c35c21af74035301129cbc0fbad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"832398b9863e871f4d1c90ffa480df53b9a28b32","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"1) Set"},{"line_number":15,"context_line":"Set a default volume type for a project"},{"line_number":16,"context_line":"cinder --os-volume-api-version 3.61 default-type-set \u003cvol-type-id\u003e \u003cproject-id\u003e"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"2) Get"},{"line_number":19,"context_line":"Get the default volume type for a project"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9f560f44_f188f171","line":16,"range":{"start_line":16,"start_character":31,"end_line":16,"end_character":35},"in_reply_to":"9f560f44_552437c6","updated":"2020-09-08 12:29:01.000000000","message":"Done","commit_id":"03a14b6791432c35c21af74035301129cbc0fbad"}],"cinderclient/base.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e80836f48a4abfe0ecffa6aa19afaed76bfa328d","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            if isinstance(body[response_key], list):"},{"line_number":338,"context_line":"                return [self.resource_class(self, res, loaded\u003dTrue)"},{"line_number":339,"context_line":"                        for res in body[response_key] if res]"},{"line_number":340,"context_line":"            else:"},{"line_number":341,"context_line":"                return self.resource_class(self, body[response_key],"},{"line_number":342,"context_line":"                                           loaded\u003dTrue)"},{"line_number":343,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_a21ab6c2","line":340,"range":{"start_line":340,"start_character":12,"end_line":340,"end_character":16},"updated":"2020-09-07 17:55:02.000000000","message":"nit: No need for the else, as L338 will never continue here","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"832398b9863e871f4d1c90ffa480df53b9a28b32","unresolved":false,"context_lines":[{"line_number":337,"context_line":"            if isinstance(body[response_key], list):"},{"line_number":338,"context_line":"                return [self.resource_class(self, res, loaded\u003dTrue)"},{"line_number":339,"context_line":"                        for res in body[response_key] if res]"},{"line_number":340,"context_line":"            else:"},{"line_number":341,"context_line":"                return self.resource_class(self, body[response_key],"},{"line_number":342,"context_line":"                                           loaded\u003dTrue)"},{"line_number":343,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_b1df9964","line":340,"range":{"start_line":340,"start_character":12,"end_line":340,"end_character":16},"in_reply_to":"9f560f44_a21ab6c2","updated":"2020-09-08 12:29:01.000000000","message":"Done","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e80836f48a4abfe0ecffa6aa19afaed76bfa328d","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            else:"},{"line_number":341,"context_line":"                return self.resource_class(self, body[response_key],"},{"line_number":342,"context_line":"                                           loaded\u003dTrue)"},{"line_number":343,"context_line":"        else:"},{"line_number":344,"context_line":"            return self.resource_class(self, body, loaded\u003dTrue)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def _create_update_with_base_url(self, url, body, response_key\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_0279e2fa","line":343,"range":{"start_line":343,"start_character":8,"end_line":343,"end_character":12},"updated":"2020-09-07 17:55:02.000000000","message":"nit: No need for an else here, L344 is actually the default behavior if response_key is not evaluated to True.","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"832398b9863e871f4d1c90ffa480df53b9a28b32","unresolved":false,"context_lines":[{"line_number":340,"context_line":"            else:"},{"line_number":341,"context_line":"                return self.resource_class(self, body[response_key],"},{"line_number":342,"context_line":"                                           loaded\u003dTrue)"},{"line_number":343,"context_line":"        else:"},{"line_number":344,"context_line":"            return self.resource_class(self, body, loaded\u003dTrue)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def _create_update_with_base_url(self, url, body, response_key\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_11d2c55c","line":343,"range":{"start_line":343,"start_character":8,"end_line":343,"end_character":12},"in_reply_to":"9f560f44_0279e2fa","updated":"2020-09-08 12:29:01.000000000","message":"Done","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e80836f48a4abfe0ecffa6aa19afaed76bfa328d","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            url, body\u003dbody)"},{"line_number":349,"context_line":"        if response_key:"},{"line_number":350,"context_line":"            return self.resource_class(self, body[response_key], loaded\u003dTrue)"},{"line_number":351,"context_line":"        else:"},{"line_number":352,"context_line":"            return self.resource_class(self, body, loaded\u003dTrue)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _delete_with_base_url(self, url, response_key\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_e27dcee7","line":351,"range":{"start_line":351,"start_character":8,"end_line":351,"end_character":12},"updated":"2020-09-07 17:55:02.000000000","message":"ditto","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"832398b9863e871f4d1c90ffa480df53b9a28b32","unresolved":false,"context_lines":[{"line_number":348,"context_line":"            url, body\u003dbody)"},{"line_number":349,"context_line":"        if response_key:"},{"line_number":350,"context_line":"            return self.resource_class(self, body[response_key], loaded\u003dTrue)"},{"line_number":351,"context_line":"        else:"},{"line_number":352,"context_line":"            return self.resource_class(self, body, loaded\u003dTrue)"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _delete_with_base_url(self, url, response_key\u003dNone):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_f1d6314f","line":351,"range":{"start_line":351,"start_character":8,"end_line":351,"end_character":12},"in_reply_to":"9f560f44_e27dcee7","updated":"2020-09-08 12:29:01.000000000","message":"Done","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"}],"cinderclient/client.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e80836f48a4abfe0ecffa6aa19afaed76bfa328d","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    def get_with_base_url(self, url, **kwargs):"},{"line_number":270,"context_line":"        return self._cs_request_base_url(url, \u0027GET\u0027, **kwargs)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def get_all_with_base_url(self, url, **kwargs):"},{"line_number":273,"context_line":"        return self._cs_request_base_url(url, \u0027GET\u0027, **kwargs)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def create_update_with_base_url(self, url, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_c2724a12","line":272,"updated":"2020-09-07 17:55:02.000000000","message":"-1: This is exactly the same as method \"get_with_base_url\", I think we should use the already existing one.","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"832398b9863e871f4d1c90ffa480df53b9a28b32","unresolved":false,"context_lines":[{"line_number":269,"context_line":"    def get_with_base_url(self, url, **kwargs):"},{"line_number":270,"context_line":"        return self._cs_request_base_url(url, \u0027GET\u0027, **kwargs)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"    def get_all_with_base_url(self, url, **kwargs):"},{"line_number":273,"context_line":"        return self._cs_request_base_url(url, \u0027GET\u0027, **kwargs)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def create_update_with_base_url(self, url, **kwargs):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_d1696d8c","line":272,"in_reply_to":"9f560f44_c2724a12","updated":"2020-09-08 12:29:01.000000000","message":"Yeah, i did it to pass the test of test_shell as [1] contains this method already and returns something different. will update the test and remove this.\n\n[1] https://review.opendev.org/#/c/739223/8/cinderclient/tests/unit/v2/fakes.py","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"}],"cinderclient/tests/unit/v2/fakes.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1b894f4ab53c5743073b25707f5678b3053adabe","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            \u0027project_id\u0027: \u0027a0c01994-1245-416e-8fc9-1aca86329bfd\u0027,"},{"line_number":328,"context_line":"            \u0027volume_type_id\u0027: \u0027ff094b46-f82a-4a74-9d9e-d3d08116ad93\u0027"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    }]}"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"class FakeClient(fakes.FakeClient, client.Client):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_3d342e4a","line":330,"updated":"2020-09-03 19:06:46.000000000","message":"nit: the formatting looks a bit nonstandard, but if pep8 isn\u0027t complaining, I won\u0027t either.","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71e2f78b5db649a7a57faba81e3aeea7f00bf257","unresolved":false,"context_lines":[{"line_number":327,"context_line":"            \u0027project_id\u0027: \u0027a0c01994-1245-416e-8fc9-1aca86329bfd\u0027,"},{"line_number":328,"context_line":"            \u0027volume_type_id\u0027: \u0027ff094b46-f82a-4a74-9d9e-d3d08116ad93\u0027"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    }]}"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":""},{"line_number":333,"context_line":"class FakeClient(fakes.FakeClient, client.Client):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_8f7532fd","line":330,"in_reply_to":"9f560f44_3d342e4a","updated":"2020-09-04 15:54:13.000000000","message":"Done","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"}],"cinderclient/tests/unit/v3/test_default_types.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1b894f4ab53c5743073b25707f5678b3053adabe","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from cinderclient.tests.unit import utils"},{"line_number":17,"context_line":"from cinderclient.tests.unit.v3 import fakes"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"defaults \u003d fakes.FakeClient(api_versions.APIVersion(\u00273.61\u0027))"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class VolumeTypeDefaultTest(utils.TestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_1d2a0a2b","line":19,"range":{"start_line":19,"start_character":53,"end_line":19,"end_character":57},"updated":"2020-09-03 19:06:46.000000000","message":"Should this be 3.62 ?","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71e2f78b5db649a7a57faba81e3aeea7f00bf257","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from cinderclient.tests.unit import utils"},{"line_number":17,"context_line":"from cinderclient.tests.unit.v3 import fakes"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"defaults \u003d fakes.FakeClient(api_versions.APIVersion(\u00273.61\u0027))"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class VolumeTypeDefaultTest(utils.TestCase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_6f49beb5","line":19,"range":{"start_line":19,"start_character":53,"end_line":19,"end_character":57},"in_reply_to":"9f560f44_1d2a0a2b","updated":"2020-09-04 15:54:13.000000000","message":"Done","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"}],"cinderclient/tests/unit/v3/test_shell.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1b894f4ab53c5743073b25707f5678b3053adabe","unresolved":false,"context_lines":[{"line_number":1617,"context_line":"                         \u00274c298f16-e339-4c80-b934-6cbfcb7525a0 \u0027"},{"line_number":1618,"context_line":"                         \u0027629632e7-99d2-4c40-9ae3-106fa3b1c9b7\u0027)"},{"line_number":1619,"context_line":"        self.assert_called("},{"line_number":1620,"context_line":"            \u0027PUT\u0027, \u0027v3/default-types/629632e7-99d2-4c40-9ae3-106fa3b1c9b7\u0027)"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"    def test_default_type_list_project(self):"},{"line_number":1623,"context_line":"        self.run_command(\u0027--os-volume-api-version 3.62 default-type-list \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_bde31ea4","line":1620,"updated":"2020-09-03 19:06:46.000000000","message":"should probably also check the body to make sure it\u0027s getting the correct uuid.","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71e2f78b5db649a7a57faba81e3aeea7f00bf257","unresolved":false,"context_lines":[{"line_number":1617,"context_line":"                         \u00274c298f16-e339-4c80-b934-6cbfcb7525a0 \u0027"},{"line_number":1618,"context_line":"                         \u0027629632e7-99d2-4c40-9ae3-106fa3b1c9b7\u0027)"},{"line_number":1619,"context_line":"        self.assert_called("},{"line_number":1620,"context_line":"            \u0027PUT\u0027, \u0027v3/default-types/629632e7-99d2-4c40-9ae3-106fa3b1c9b7\u0027)"},{"line_number":1621,"context_line":""},{"line_number":1622,"context_line":"    def test_default_type_list_project(self):"},{"line_number":1623,"context_line":"        self.run_command(\u0027--os-volume-api-version 3.62 default-type-list \u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_cf4a8a81","line":1620,"in_reply_to":"9f560f44_bde31ea4","updated":"2020-09-04 15:54:13.000000000","message":"Done","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"}],"cinderclient/v3/default_types.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1b894f4ab53c5743073b25707f5678b3053adabe","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class DefaultVolumeTypeManager(base.ManagerWithFind):"},{"line_number":27,"context_line":"    \"\"\"Manage :class:`VolumeType` resources.\"\"\""},{"line_number":28,"context_line":"    resource_class \u003d DefaultVolumeType"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def create(self, volume_type, project_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d8ef00e7","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":44},"updated":"2020-09-03 19:06:46.000000000","message":"Not sure this is accurate, what you\u0027re managing here is a relation between projects and volume types.","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71e2f78b5db649a7a57faba81e3aeea7f00bf257","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class DefaultVolumeTypeManager(base.ManagerWithFind):"},{"line_number":27,"context_line":"    \"\"\"Manage :class:`VolumeType` resources.\"\"\""},{"line_number":28,"context_line":"    resource_class \u003d DefaultVolumeType"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def create(self, volume_type, project_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_6f537e3a","line":27,"range":{"start_line":27,"start_character":7,"end_line":27,"end_character":44},"in_reply_to":"9f560f44_d8ef00e7","updated":"2020-09-04 15:54:13.000000000","message":"Done","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1b894f4ab53c5743073b25707f5678b3053adabe","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    resource_class \u003d DefaultVolumeType"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def create(self, volume_type, project_id):"},{"line_number":31,"context_line":"        \"\"\"Creates a volume type."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param volume_type: Descriptive name/id of the volume type"},{"line_number":34,"context_line":"        :param project_id: Project to set default type for"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_98ce2881","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":33},"updated":"2020-09-03 19:06:46.000000000","message":"Creates a default volume type for a project.","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71e2f78b5db649a7a57faba81e3aeea7f00bf257","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    resource_class \u003d DefaultVolumeType"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def create(self, volume_type, project_id):"},{"line_number":31,"context_line":"        \"\"\"Creates a volume type."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param volume_type: Descriptive name/id of the volume type"},{"line_number":34,"context_line":"        :param project_id: Project to set default type for"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_2f1ea673","line":31,"range":{"start_line":31,"start_character":11,"end_line":31,"end_character":33},"in_reply_to":"9f560f44_98ce2881","updated":"2020-09-04 15:54:13.000000000","message":"Done","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1b894f4ab53c5743073b25707f5678b3053adabe","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def create(self, volume_type, project_id):"},{"line_number":31,"context_line":"        \"\"\"Creates a volume type."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param volume_type: Descriptive name/id of the volume type"},{"line_number":34,"context_line":"        :param project_id: Project to set default type for"},{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_987c6821","line":33,"range":{"start_line":33,"start_character":28,"end_line":33,"end_character":47},"updated":"2020-09-03 19:06:46.000000000","message":"I suggest saying simply \"Name or ID of the volume type\" to make it clear that you\u0027ll accept either one.","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71e2f78b5db649a7a57faba81e3aeea7f00bf257","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def create(self, volume_type, project_id):"},{"line_number":31,"context_line":"        \"\"\"Creates a volume type."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        :param volume_type: Descriptive name/id of the volume type"},{"line_number":34,"context_line":"        :param project_id: Project to set default type for"},{"line_number":35,"context_line":"        \"\"\""},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_ef15ce4a","line":33,"range":{"start_line":33,"start_character":28,"end_line":33,"end_character":47},"in_reply_to":"9f560f44_987c6821","updated":"2020-09-04 15:54:13.000000000","message":"Done","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1b894f4ab53c5743073b25707f5678b3053adabe","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return self._get_all_with_base_url(url, \"default_types\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def delete(self, project_id):"},{"line_number":59,"context_line":"        \"\"\"Deletes a specific volume_type."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param project_id: The ID of the project to unset default for."},{"line_number":62,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_d8c8a075","line":59,"range":{"start_line":59,"start_character":11,"end_line":59,"end_character":41},"updated":"2020-09-03 19:06:46.000000000","message":"Removes the default volume type for a project.","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71e2f78b5db649a7a57faba81e3aeea7f00bf257","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            return self._get_all_with_base_url(url, \"default_types\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def delete(self, project_id):"},{"line_number":59,"context_line":"        \"\"\"Deletes a specific volume_type."},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        :param project_id: The ID of the project to unset default for."},{"line_number":62,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_2f07c61f","line":59,"range":{"start_line":59,"start_character":11,"end_line":59,"end_character":41},"in_reply_to":"9f560f44_d8c8a075","updated":"2020-09-04 15:54:13.000000000","message":"Done","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e80836f48a4abfe0ecffa6aa19afaed76bfa328d","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        url \u003d \u0027v3/default-types\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if project_id:"},{"line_number":53,"context_line":"            url \u003d url + \u0027/\u0027 + project_id"},{"line_number":54,"context_line":"            return self._get_all_with_base_url(url, \"default_type\")"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            return self._get_all_with_base_url(url, \"default_types\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_22d226d2","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":40},"updated":"2020-09-07 17:55:02.000000000","message":"nit:\n\n  url +\u003d \u0027/\u0027 + project_id","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"832398b9863e871f4d1c90ffa480df53b9a28b32","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        url \u003d \u0027v3/default-types\u0027"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if project_id:"},{"line_number":53,"context_line":"            url \u003d url + \u0027/\u0027 + project_id"},{"line_number":54,"context_line":"            return self._get_all_with_base_url(url, \"default_type\")"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            return self._get_all_with_base_url(url, \"default_types\")"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_d1c5ed5d","line":53,"range":{"start_line":53,"start_character":12,"end_line":53,"end_character":40},"in_reply_to":"9f560f44_22d226d2","updated":"2020-09-08 12:29:01.000000000","message":"Done","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e80836f48a4abfe0ecffa6aa19afaed76bfa328d","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if project_id:"},{"line_number":53,"context_line":"            url \u003d url + \u0027/\u0027 + project_id"},{"line_number":54,"context_line":"            return self._get_all_with_base_url(url, \"default_type\")"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            return self._get_all_with_base_url(url, \"default_types\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def delete(self, project_id):"},{"line_number":59,"context_line":"        \"\"\"Removes the default volume type for a project"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_42cd9a2e","line":56,"range":{"start_line":54,"start_character":0,"end_line":56,"end_character":68},"updated":"2020-09-07 17:55:02.000000000","message":"-1: It\u0027s the same call for both after you change the url in L53","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"587fd02e934e59a23496fb687fa8f94870de4b29","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if project_id:"},{"line_number":53,"context_line":"            url \u003d url + \u0027/\u0027 + project_id"},{"line_number":54,"context_line":"            return self._get_all_with_base_url(url, \"default_type\")"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            return self._get_all_with_base_url(url, \"default_types\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def delete(self, project_id):"},{"line_number":59,"context_line":"        \"\"\"Removes the default volume type for a project"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_ccec34f6","line":56,"range":{"start_line":54,"start_character":0,"end_line":56,"end_character":68},"in_reply_to":"9f560f44_11a125aa","updated":"2020-09-08 12:50:46.000000000","message":"I just realized I missed the difference in the string. type vs types :-(","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"832398b9863e871f4d1c90ffa480df53b9a28b32","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if project_id:"},{"line_number":53,"context_line":"            url \u003d url + \u0027/\u0027 + project_id"},{"line_number":54,"context_line":"            return self._get_all_with_base_url(url, \"default_type\")"},{"line_number":55,"context_line":"        else:"},{"line_number":56,"context_line":"            return self._get_all_with_base_url(url, \"default_types\")"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def delete(self, project_id):"},{"line_number":59,"context_line":"        \"\"\"Removes the default volume type for a project"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_11a125aa","line":56,"range":{"start_line":54,"start_character":0,"end_line":56,"end_character":68},"in_reply_to":"9f560f44_42cd9a2e","updated":"2020-09-08 12:29:01.000000000","message":"Done","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1b894f4ab53c5743073b25707f5678b3053adabe","unresolved":false,"context_lines":[{"line_number":2622,"context_line":"@utils.arg(\u0027--project-id\u0027,"},{"line_number":2623,"context_line":"           metavar\u003d\u0027\u003cproject_id\u003e\u0027,"},{"line_number":2624,"context_line":"           default\u003dNone,"},{"line_number":2625,"context_line":"           help\u003d\u0027ID of project for which to set default type.\u0027)"},{"line_number":2626,"context_line":"def do_default_type_list(cs, args):"},{"line_number":2627,"context_line":"    \"\"\"Lists all default volume types.\"\"\""},{"line_number":2628,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_38439c15","line":2625,"range":{"start_line":2625,"start_character":44,"end_line":2625,"end_character":60},"updated":"2020-09-03 19:06:46.000000000","message":"\"show the default type\"","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71e2f78b5db649a7a57faba81e3aeea7f00bf257","unresolved":false,"context_lines":[{"line_number":2622,"context_line":"@utils.arg(\u0027--project-id\u0027,"},{"line_number":2623,"context_line":"           metavar\u003d\u0027\u003cproject_id\u003e\u0027,"},{"line_number":2624,"context_line":"           default\u003dNone,"},{"line_number":2625,"context_line":"           help\u003d\u0027ID of project for which to set default type.\u0027)"},{"line_number":2626,"context_line":"def do_default_type_list(cs, args):"},{"line_number":2627,"context_line":"    \"\"\"Lists all default volume types.\"\"\""},{"line_number":2628,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"9f560f44_aa00e401","line":2625,"range":{"start_line":2625,"start_character":44,"end_line":2625,"end_character":60},"in_reply_to":"9f560f44_38439c15","updated":"2020-09-04 15:54:13.000000000","message":"Done","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e80836f48a4abfe0ecffa6aa19afaed76bfa328d","unresolved":false,"context_lines":[{"line_number":2645,"context_line":"        try:"},{"line_number":2646,"context_line":"            cs.default_types.delete(project_id)"},{"line_number":2647,"context_line":"            print(\"Request to unset default volume type for project %s has \""},{"line_number":2648,"context_line":"                  \"been accepted.\" % (project_id))"},{"line_number":2649,"context_line":"        except Exception as e:"},{"line_number":2650,"context_line":"            print(\"Unset for default volume type for project %s failed: %s\""},{"line_number":2651,"context_line":"                  % (project_id, e))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_82033242","line":2648,"updated":"2020-09-07 17:55:02.000000000","message":"-1: This is a sync call, when we finish the delete call the default has been eliminated, and this message seems to indicate that we may have to wait (as we do in deleting a volume).\n\nWe should rephrase it to make clear that the default has been unset.","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"832398b9863e871f4d1c90ffa480df53b9a28b32","unresolved":false,"context_lines":[{"line_number":2645,"context_line":"        try:"},{"line_number":2646,"context_line":"            cs.default_types.delete(project_id)"},{"line_number":2647,"context_line":"            print(\"Request to unset default volume type for project %s has \""},{"line_number":2648,"context_line":"                  \"been accepted.\" % (project_id))"},{"line_number":2649,"context_line":"        except Exception as e:"},{"line_number":2650,"context_line":"            print(\"Unset for default volume type for project %s failed: %s\""},{"line_number":2651,"context_line":"                  % (project_id, e))"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f560f44_51a71dbd","line":2648,"in_reply_to":"9f560f44_82033242","updated":"2020-09-08 12:29:01.000000000","message":"Done","commit_id":"a93fc8604c7795ebc0d2e96084ebf50432d64268"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"587fd02e934e59a23496fb687fa8f94870de4b29","unresolved":false,"context_lines":[{"line_number":2645,"context_line":"        try:"},{"line_number":2646,"context_line":"            cs.default_types.delete(project_id)"},{"line_number":2647,"context_line":"            print(\"Default volume type for project %s has been unset \""},{"line_number":2648,"context_line":"                  \"successfully.\" % (project_id))"},{"line_number":2649,"context_line":"        except Exception as e:"},{"line_number":2650,"context_line":"            print(\"Unset for default volume type for project %s failed: %s\""},{"line_number":2651,"context_line":"                  % (project_id, e))"}],"source_content_type":"text/x-python","patch_set":9,"id":"9f560f44_ec93f84d","line":2648,"range":{"start_line":2648,"start_character":19,"end_line":2648,"end_character":31},"updated":"2020-09-08 12:50:46.000000000","message":"nit: has been successfully unset.","commit_id":"8dc82b5d2b27c172e4c2d4394b1d83adcd25036a"}],"releasenotes/notes/project-default-types-727156d1db10a24d.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1b894f4ab53c5743073b25707f5678b3053adabe","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for set, get, delete default types for projects"},{"line_number":5,"context_line":"    with Block Storage API version 3.61 and higher."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_385c3cec","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":65},"updated":"2020-09-03 19:06:46.000000000","message":"\"to set, get, and unset the default volume type for projects\"","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71e2f78b5db649a7a57faba81e3aeea7f00bf257","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for set, get, delete default types for projects"},{"line_number":5,"context_line":"    with Block Storage API version 3.61 and higher."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_ea42dc0e","line":4,"range":{"start_line":4,"start_character":18,"end_line":4,"end_character":65},"in_reply_to":"9f560f44_385c3cec","updated":"2020-09-04 15:54:13.000000000","message":"Done","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1b894f4ab53c5743073b25707f5678b3053adabe","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for set, get, delete default types for projects"},{"line_number":5,"context_line":"    with Block Storage API version 3.61 and higher."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_9872a87b","line":5,"range":{"start_line":5,"start_character":35,"end_line":5,"end_character":39},"updated":"2020-09-03 19:06:46.000000000","message":"3.62","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"71e2f78b5db649a7a57faba81e3aeea7f00bf257","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support for set, get, delete default types for projects"},{"line_number":5,"context_line":"    with Block Storage API version 3.61 and higher."},{"line_number":6,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9f560f44_2a44d418","line":5,"range":{"start_line":5,"start_character":35,"end_line":5,"end_character":39},"in_reply_to":"9f560f44_9872a87b","updated":"2020-09-04 15:54:13.000000000","message":"Done","commit_id":"19c4ddf3d75975724ae1bc44aea2832da63b66f4"}]}