)]}'
{"cinderclient/client.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":33,"context_line":"from oslo_utils import importutils"},{"line_number":34,"context_line":"from oslo_utils import strutils"},{"line_number":35,"context_line":"import requests"},{"line_number":36,"context_line":"import urllib"},{"line_number":37,"context_line":"from urllib import parse as urlparse"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from cinderclient._i18n import _"},{"line_number":40,"context_line":"from cinderclient import api_versions"}],"source_content_type":"text/x-python","patch_set":6,"id":"b4e09663_be85fc29","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":36},"updated":"2021-03-04 03:10:23.000000000","message":"these should be up with the standard library imports","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from oslo_utils import importutils"},{"line_number":34,"context_line":"from oslo_utils import strutils"},{"line_number":35,"context_line":"import requests"},{"line_number":36,"context_line":"import urllib"},{"line_number":37,"context_line":"from urllib import parse as urlparse"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"from cinderclient._i18n import _"},{"line_number":40,"context_line":"from cinderclient import api_versions"}],"source_content_type":"text/x-python","patch_set":6,"id":"80289d42_0ebab479","line":37,"range":{"start_line":36,"start_character":0,"end_line":37,"end_character":36},"in_reply_to":"b4e09663_be85fc29","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"}],"cinderclient/tests/functional/test_snapshot_create_cli.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":47,"context_line":"            \u0027snapshot\u0027,"},{"line_number":48,"context_line":"            params\u003d\u0027--metadata test_metadata\u003dtest_date {0}\u0027.format("},{"line_number":49,"context_line":"                self.volume[\u0027id\u0027]))"},{"line_number":50,"context_line":"        self.assertEqual(str({u\u0027test_metadata\u0027: u\u0027test_date\u0027}),"},{"line_number":51,"context_line":"                         snapshot[\u0027metadata\u0027])"},{"line_number":52,"context_line":"        self.object_delete(\u0027snapshot\u0027, snapshot[\u0027id\u0027])"},{"line_number":53,"context_line":"        self.check_object_deleted(\u0027snapshot\u0027, snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"9182e619_bdd20c22","line":50,"range":{"start_line":50,"start_character":30,"end_line":50,"end_character":61},"updated":"2021-03-04 03:10:23.000000000","message":"don\u0027t need the u prefixes","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            \u0027snapshot\u0027,"},{"line_number":48,"context_line":"            params\u003d\u0027--metadata test_metadata\u003dtest_date {0}\u0027.format("},{"line_number":49,"context_line":"                self.volume[\u0027id\u0027]))"},{"line_number":50,"context_line":"        self.assertEqual(str({u\u0027test_metadata\u0027: u\u0027test_date\u0027}),"},{"line_number":51,"context_line":"                         snapshot[\u0027metadata\u0027])"},{"line_number":52,"context_line":"        self.object_delete(\u0027snapshot\u0027, snapshot[\u0027id\u0027])"},{"line_number":53,"context_line":"        self.check_object_deleted(\u0027snapshot\u0027, snapshot[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"49b92a87_6c53c866","line":50,"range":{"start_line":50,"start_character":30,"end_line":50,"end_character":61},"in_reply_to":"9182e619_bdd20c22","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"}],"cinderclient/tests/functional/test_volume_create_cli.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import ddt"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib import exceptions"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinderclient.tests.functional import base"}],"source_content_type":"text/x-python","patch_set":6,"id":"dd51d32d_bad6725a","line":14,"updated":"2021-03-04 03:10:23.000000000","message":"ddt is a 3rd party library, so please remove the blank line (14).","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import ddt"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib import exceptions"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinderclient.tests.functional import base"}],"source_content_type":"text/x-python","patch_set":6,"id":"d4e45c8f_7baddbfe","line":14,"in_reply_to":"dd51d32d_bad6725a","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":96,"context_line":"        \"\"\""},{"line_number":97,"context_line":"        volume \u003d self.object_create("},{"line_number":98,"context_line":"            \u0027volume\u0027, params\u003d\u0027--metadata test_metadata\u003dtest_date 1\u0027)"},{"line_number":99,"context_line":"        self.assertEqual(str({u\u0027test_metadata\u0027: u\u0027test_date\u0027}),"},{"line_number":100,"context_line":"                         volume[\u0027metadata\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"bf0c8de3_1383f75b","line":99,"range":{"start_line":99,"start_character":30,"end_line":99,"end_character":60},"updated":"2021-03-04 03:10:23.000000000","message":"don\u0027t need the u prefixes","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        \"\"\""},{"line_number":97,"context_line":"        volume \u003d self.object_create("},{"line_number":98,"context_line":"            \u0027volume\u0027, params\u003d\u0027--metadata test_metadata\u003dtest_date 1\u0027)"},{"line_number":99,"context_line":"        self.assertEqual(str({u\u0027test_metadata\u0027: u\u0027test_date\u0027}),"},{"line_number":100,"context_line":"                         volume[\u0027metadata\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"4b4c3b6d_eec72619","line":99,"range":{"start_line":99,"start_character":30,"end_line":99,"end_character":60},"in_reply_to":"bf0c8de3_1383f75b","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"}],"cinderclient/tests/functional/test_volume_extend_cli.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import ddt"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib import exceptions"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinderclient.tests.functional import base"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ada60d6_7f5cfb88","line":14,"updated":"2021-03-04 03:10:23.000000000","message":"please remove blank line (14)","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import ddt"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from tempest.lib import exceptions"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from cinderclient.tests.functional import base"}],"source_content_type":"text/x-python","patch_set":6,"id":"0f60d418_a44ddd5f","line":14,"in_reply_to":"7ada60d6_7f5cfb88","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"}],"cinderclient/tests/unit/v2/test_availability_zone.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        self.assertEqual(2, len(zones))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        l0 \u003d [str(\u0027zone-1\u0027), str(\u0027available\u0027)]"},{"line_number":46,"context_line":"        l1 \u003d [str(\u0027zone-2\u0027), str(\u0027not available\u0027)]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        z0 \u003d shell.treeizeAvailabilityZone(zones[0])"},{"line_number":49,"context_line":"        z1 \u003d shell.treeizeAvailabilityZone(zones[1])"}],"source_content_type":"text/x-python","patch_set":6,"id":"e2525f24_44080354","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":50},"updated":"2021-03-04 03:10:23.000000000","message":"these str() are all redundant, their arguments are already str.","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        self.assertEqual(2, len(zones))"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        l0 \u003d [str(\u0027zone-1\u0027), str(\u0027available\u0027)]"},{"line_number":46,"context_line":"        l1 \u003d [str(\u0027zone-2\u0027), str(\u0027not available\u0027)]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        z0 \u003d shell.treeizeAvailabilityZone(zones[0])"},{"line_number":49,"context_line":"        z1 \u003d shell.treeizeAvailabilityZone(zones[1])"}],"source_content_type":"text/x-python","patch_set":6,"id":"daafcdac_80bfbcf6","line":46,"range":{"start_line":45,"start_character":0,"end_line":46,"end_character":50},"in_reply_to":"e2525f24_44080354","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.assertEqual(3, len(zones))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        l0 \u003d [str(\u0027zone-1\u0027), str(\u0027available\u0027)]"},{"line_number":68,"context_line":"        l1 \u003d [str(\u0027|- fake_host-1\u0027), str(\u0027\u0027)]"},{"line_number":69,"context_line":"        l2 \u003d [str(\u0027| |- cinder-volume\u0027),"},{"line_number":70,"context_line":"              str(\u0027enabled :-) 2012-12-26 14:45:25\u0027)]"},{"line_number":71,"context_line":"        l3 \u003d [str(\u0027internal\u0027), str(\u0027available\u0027)]"},{"line_number":72,"context_line":"        l4 \u003d [str(\u0027|- fake_host-1\u0027), str(\u0027\u0027)]"},{"line_number":73,"context_line":"        l5 \u003d [str(\u0027| |- cinder-sched\u0027),"},{"line_number":74,"context_line":"              str(\u0027enabled :-) 2012-12-26 14:45:24\u0027)]"},{"line_number":75,"context_line":"        l6 \u003d [str(\u0027zone-2\u0027), str(\u0027not available\u0027)]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        z0 \u003d shell.treeizeAvailabilityZone(zones[0])"},{"line_number":78,"context_line":"        z1 \u003d shell.treeizeAvailabilityZone(zones[1])"}],"source_content_type":"text/x-python","patch_set":6,"id":"c6c7d17e_aca70b16","line":75,"range":{"start_line":67,"start_character":0,"end_line":75,"end_character":50},"updated":"2021-03-04 03:10:23.000000000","message":"these str() are all redundant, their arguments are already str.","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.assertEqual(3, len(zones))"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        l0 \u003d [str(\u0027zone-1\u0027), str(\u0027available\u0027)]"},{"line_number":68,"context_line":"        l1 \u003d [str(\u0027|- fake_host-1\u0027), str(\u0027\u0027)]"},{"line_number":69,"context_line":"        l2 \u003d [str(\u0027| |- cinder-volume\u0027),"},{"line_number":70,"context_line":"              str(\u0027enabled :-) 2012-12-26 14:45:25\u0027)]"},{"line_number":71,"context_line":"        l3 \u003d [str(\u0027internal\u0027), str(\u0027available\u0027)]"},{"line_number":72,"context_line":"        l4 \u003d [str(\u0027|- fake_host-1\u0027), str(\u0027\u0027)]"},{"line_number":73,"context_line":"        l5 \u003d [str(\u0027| |- cinder-sched\u0027),"},{"line_number":74,"context_line":"              str(\u0027enabled :-) 2012-12-26 14:45:24\u0027)]"},{"line_number":75,"context_line":"        l6 \u003d [str(\u0027zone-2\u0027), str(\u0027not available\u0027)]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        z0 \u003d shell.treeizeAvailabilityZone(zones[0])"},{"line_number":78,"context_line":"        z1 \u003d shell.treeizeAvailabilityZone(zones[1])"}],"source_content_type":"text/x-python","patch_set":6,"id":"a2be6f15_47bcb295","line":75,"range":{"start_line":67,"start_character":0,"end_line":75,"end_character":50},"in_reply_to":"c6c7d17e_aca70b16","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"}],"cinderclient/tests/unit/v3/test_messages.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import ddt"},{"line_number":14,"context_line":"from urllib import parse"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from cinderclient import api_versions"},{"line_number":17,"context_line":"from cinderclient.tests.unit import utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"b205966f_9928a05e","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":24},"updated":"2021-03-04 03:10:23.000000000","message":"urllib is part of the standard library, so it should be at line 12 followed by a blank line","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"import ddt"},{"line_number":14,"context_line":"from urllib import parse"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from cinderclient import api_versions"},{"line_number":17,"context_line":"from cinderclient.tests.unit import utils"}],"source_content_type":"text/x-python","patch_set":6,"id":"32195791_0feb5963","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":24},"in_reply_to":"b205966f_9928a05e","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"}],"cinderclient/tests/unit/v3/test_shell.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":44,"context_line":"import fixtures"},{"line_number":45,"context_line":"from requests_mock.contrib import fixture as requests_mock_fixture"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"from urllib import parse"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"import cinderclient"},{"line_number":50,"context_line":"from cinderclient import api_versions"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a5d66bb_92886282","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":24},"updated":"2021-03-04 03:10:23.000000000","message":"should be up top with unittest","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":44,"context_line":"import fixtures"},{"line_number":45,"context_line":"from requests_mock.contrib import fixture as requests_mock_fixture"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"from urllib import parse"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"import cinderclient"},{"line_number":50,"context_line":"from cinderclient import api_versions"}],"source_content_type":"text/x-python","patch_set":6,"id":"12be2723_b4e7627d","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":24},"in_reply_to":"1a5d66bb_92886282","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":322,"context_line":"        self.assert_call_contained("},{"line_number":323,"context_line":"            parse.urlencode("},{"line_number":324,"context_line":"                {\u0027extra_specs\u0027:"},{"line_number":325,"context_line":"                    {str(\u0027key\u0027): str(\u0027value\u0027)}}))"},{"line_number":326,"context_line":"        self.assert_call_contained(parse.urlencode({\u0027is_public\u0027: None}))"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def test_type_list_public(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"bdb2a24c_0513d186","line":325,"range":{"start_line":325,"start_character":21,"end_line":325,"end_character":45},"updated":"2021-03-04 03:10:23.000000000","message":"these calls to str() are redundant, the literals are already str.","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":322,"context_line":"        self.assert_call_contained("},{"line_number":323,"context_line":"            parse.urlencode("},{"line_number":324,"context_line":"                {\u0027extra_specs\u0027:"},{"line_number":325,"context_line":"                    {str(\u0027key\u0027): str(\u0027value\u0027)}}))"},{"line_number":326,"context_line":"        self.assert_call_contained(parse.urlencode({\u0027is_public\u0027: None}))"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"    def test_type_list_public(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"e7a2618e_f2261174","line":325,"range":{"start_line":325,"start_character":21,"end_line":325,"end_character":45},"in_reply_to":"bdb2a24c_0513d186","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"}],"cinderclient/tests/unit/v3/test_volumes.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":23,"context_line":"from cinderclient.tests.unit.v3 import fakes"},{"line_number":24,"context_line":"from cinderclient.v3 import volume_snapshots"},{"line_number":25,"context_line":"from cinderclient.v3 import volumes"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from urllib import parse"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":6,"id":"a3e3f5b3_5bb776bc","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":24},"updated":"2021-03-04 03:10:23.000000000","message":"should be up at line 17 followed by a blank line","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from cinderclient.tests.unit.v3 import fakes"},{"line_number":24,"context_line":"from cinderclient.v3 import volume_snapshots"},{"line_number":25,"context_line":"from cinderclient.v3 import volumes"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from urllib import parse"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":6,"id":"a4507c58_07251a55","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":24},"in_reply_to":"a3e3f5b3_5bb776bc","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"}],"cinderclient/utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import collections"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":"import uuid"}],"source_content_type":"text/x-python","patch_set":6,"id":"2e8381d3_7050ea3d","line":16,"updated":"2021-03-04 03:10:23.000000000","message":"might as well remove the blank line (16) while you\u0027re here","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"import collections"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import os"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":"import uuid"}],"source_content_type":"text/x-python","patch_set":6,"id":"6e153e7a_eb817b32","line":16,"in_reply_to":"2e8381d3_7050ea3d","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import prettytable"},{"line_number":22,"context_line":"import stevedore"},{"line_number":23,"context_line":"from urllib import parse"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinderclient import exceptions"},{"line_number":26,"context_line":"from oslo_utils import encodeutils"}],"source_content_type":"text/x-python","patch_set":6,"id":"c7a128b2_6b8c2460","line":23,"updated":"2021-03-04 03:10:23.000000000","message":"should be in between lines 18 and 19","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import prettytable"},{"line_number":22,"context_line":"import stevedore"},{"line_number":23,"context_line":"from urllib import parse"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from cinderclient import exceptions"},{"line_number":26,"context_line":"from oslo_utils import encodeutils"}],"source_content_type":"text/x-python","patch_set":6,"id":"b8a63706_b57cb1f1","line":23,"in_reply_to":"c7a128b2_6b8c2460","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":182,"context_line":"    _print(pt, order_by)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"def _encode(src):"},{"line_number":186,"context_line":"    return src"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"0abd1e37_621d62bf","line":185,"updated":"2021-03-04 03:10:23.000000000","message":"it looks like this function doesn\u0027t do anything anymore, and hence, unicode_key_value_to_string doesn\u0027t either","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":true,"context_lines":[{"line_number":182,"context_line":"    _print(pt, order_by)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"def _encode(src):"},{"line_number":186,"context_line":"    return src"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"dbd582bd_3160dde6","line":185,"in_reply_to":"0abd1e37_621d62bf","updated":"2021-03-04 08:05:33.000000000","message":"i agree with remove it in this patch, i will try to remove it.","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"}],"cinderclient/v2/shell.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":1113,"context_line":"        print(\"Request to migrate volume %s has been accepted.\" % (volume.id))"},{"line_number":1114,"context_line":"    except Exception as e:"},{"line_number":1115,"context_line":"        print(\"Migration for volume %s failed: %s.\" % (volume.id,"},{"line_number":1116,"context_line":"                                                       str(e)))"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"@utils.arg(\u0027volume\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"b682c557_8fdd2c82","line":1116,"range":{"start_line":1116,"start_character":55,"end_line":1116,"end_character":61},"updated":"2021-03-04 03:10:23.000000000","message":"don\u0027t need to use str() here, just pass it e","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":1113,"context_line":"        print(\"Request to migrate volume %s has been accepted.\" % (volume.id))"},{"line_number":1114,"context_line":"    except Exception as e:"},{"line_number":1115,"context_line":"        print(\"Migration for volume %s failed: %s.\" % (volume.id,"},{"line_number":1116,"context_line":"                                                       str(e)))"},{"line_number":1117,"context_line":""},{"line_number":1118,"context_line":""},{"line_number":1119,"context_line":"@utils.arg(\u0027volume\u0027, metavar\u003d\u0027\u003cvolume\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"e52a67ca_38a69897","line":1116,"range":{"start_line":1116,"start_character":55,"end_line":1116,"end_character":61},"in_reply_to":"b682c557_8fdd2c82","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"}],"tools/lintstack.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"2bb1a5493810a274c61869b7071f332bf492b058","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from pylint import lint"},{"line_number":24,"context_line":"from pylint.reporters import text"},{"line_number":25,"context_line":"from io import StringIO"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"ignore_codes \u003d ["},{"line_number":28,"context_line":"    # Note(maoy): E1103 is error code related to partial type inference"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f560f44_57ecadf3","line":25,"updated":"2020-09-30 04:24:23.000000000","message":"pep8: H306: imports not in alphabetical order (pylint.reporters.text, io.stringio)","commit_id":"6e4b72ba590150b41959cbfba6f18faedf998ce0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5efe07349724cc8c2d6044ecb850f12ab14403fa","unresolved":true,"context_lines":[{"line_number":20,"context_line":"import re"},{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from io import StringIO"},{"line_number":24,"context_line":"from pylint import lint"},{"line_number":25,"context_line":"from pylint.reporters import text"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"af374b8c_6e01e3e4","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":23},"updated":"2021-03-04 03:10:23.000000000","message":"this should be up with the standard library imports","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"},{"author":{"_account_id":30407,"name":"haixin","email":"haixin_haixin@qq.com","username":"haixin"},"change_message_id":"bdc2860995f290abc678e20099e242a64f277aec","unresolved":false,"context_lines":[{"line_number":20,"context_line":"import re"},{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from io import StringIO"},{"line_number":24,"context_line":"from pylint import lint"},{"line_number":25,"context_line":"from pylint.reporters import text"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"679bcd8b_a4bac255","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":23},"in_reply_to":"af374b8c_6e01e3e4","updated":"2021-03-04 08:05:33.000000000","message":"Done","commit_id":"da3a881a1bd2dfe499edc31163d8c4f236c6458a"}]}