)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c5fbb59719363e5417c1042a9ffdc33e617c08a2","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix undesirable raw Python error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added a default value to `func` and an empty value to"},{"line_number":10,"context_line":"`command` as placeholders in order to prevent further"},{"line_number":11,"context_line":"references from issuing Python errors."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f621f24_8eed9c27","line":9,"updated":"2020-10-29 12:54:01.000000000","message":"You\u0027re telling *how* you fixed it. You may also add a brief description about *what* you fixed (the actual error message and an example command line that causes it).\n\nOnce this patch is merged, people might see your commit message from several places (e.g. from the Git command line), and it might be difficult for them to open the LP bug link.\n\nYou can find other advices here:\nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"f3ad18a87484473a0a57d81c089dce26ad26d434"}],"cinderclient/shell.py":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"11b11860774f93ce374a5bd7308df1048e419757","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        parser.set_defaults(insecure\u003dutils.env(\u0027CINDERCLIENT_INSECURE\u0027,"},{"line_number":350,"context_line":"                                               default\u003dFalse))"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        parser.set_defaults(func\u003d\u0027\u0027)"},{"line_number":353,"context_line":"        parser.set_defaults(command\u003d\u0027\u0027)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def get_subcommand_parser(self, version, do_help\u003dFalse, input_args\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_502786b4","line":352,"range":{"start_line":352,"start_character":33,"end_line":352,"end_character":35},"updated":"2020-10-23 19:48:38.000000000","message":"Oh, now I understood what you meant to do.\n\nYou should set the default method (self.do_help) here instead of an empty string.","commit_id":"d70a217b904b2a72f48a8b490f2614bd4834afcd"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"2dd779124ff0e34468466011e6c61c012548663f","unresolved":false,"context_lines":[{"line_number":608,"context_line":"        self._run_extension_hooks(\u0027__post_parse_args__\u0027, args)"},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"        # Short-circuit and deal with help right away."},{"line_number":611,"context_line":"        if args.func \u003d\u003d self.do_bash_completion:"},{"line_number":612,"context_line":"            self.do_bash_completion(args)"},{"line_number":613,"context_line":"            return 0"},{"line_number":614,"context_line":"        else:"},{"line_number":615,"context_line":"            self.do_help(args)"},{"line_number":616,"context_line":"            return 0"},{"line_number":617,"context_line":""},{"line_number":618,"context_line":"        (os_username, os_password, os_project_name, os_auth_url,"},{"line_number":619,"context_line":"         os_region_name, os_project_id, endpoint_type,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f65232a_2d84375e","line":616,"range":{"start_line":611,"start_character":0,"end_line":616,"end_character":20},"updated":"2020-10-23 18:37:58.000000000","message":"You modified in a way that the script always exits, no matter the command/arguments.\n\nSo it now prints the help message even if I run `cinder list`, regardless the `--os-volume-api-version` parameter.","commit_id":"d70a217b904b2a72f48a8b490f2614bd4834afcd"},{"author":{"_account_id":32411,"name":"Eduardo Santos","email":"eduardo.experimental@gmail.com","username":"ecsantos"},"change_message_id":"0a8b27ffa2a9a9873a1d355463af09646e48eac2","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        parser.set_defaults(insecure\u003dutils.env(\u0027CINDERCLIENT_INSECURE\u0027,"},{"line_number":350,"context_line":"                                               default\u003dFalse))"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        parser.set_defaults(func\u003dself.do_help)"},{"line_number":353,"context_line":"        parser.set_defaults(command\u003d\u0027\u0027)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def get_subcommand_parser(self, version, do_help\u003dFalse, input_args\u003dNone):"},{"line_number":356,"context_line":"        parser \u003d self.get_base_parser()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_525011d5","line":353,"range":{"start_line":352,"start_character":8,"end_line":353,"end_character":39},"updated":"2020-10-27 14:49:18.000000000","message":"I ran most of cinder subcommands and optional arguments and they worked as expected in my environment.\n\nHowever, I\u0027m not sure if setting the default values for `func` and `command` inside the `_append_global_identity_args` method is a good idea, for readability and consistency reasons, since all the other attributes being added here are related to authentication, but I\u0027m not sure where else `func` and `command` could be initialized.","commit_id":"60e56b845b14aa91d076601a5f144508649a1f23"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"b9453ab8cc90cddcfde2660217b4f15f0df5e3b1","unresolved":false,"context_lines":[{"line_number":349,"context_line":"        parser.set_defaults(insecure\u003dutils.env(\u0027CINDERCLIENT_INSECURE\u0027,"},{"line_number":350,"context_line":"                                               default\u003dFalse))"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        parser.set_defaults(func\u003dself.do_help)"},{"line_number":353,"context_line":"        parser.set_defaults(command\u003d\u0027\u0027)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def get_subcommand_parser(self, version, do_help\u003dFalse, input_args\u003dNone):"},{"line_number":356,"context_line":"        parser \u003d self.get_base_parser()"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f65232a_a8065885","line":353,"range":{"start_line":352,"start_character":8,"end_line":353,"end_character":39},"in_reply_to":"3f65232a_525011d5","updated":"2020-10-27 16:53:19.000000000","message":"I agree that it would be inconsistent to set things unrelated to authentication here.\n\nYou might want to move these lines to inside `get_base_parser`. Alternatively, you may create a new method `_set_pareser_default_method` and call it from `get_base_parser`.","commit_id":"60e56b845b14aa91d076601a5f144508649a1f23"}],"releasenotes/notes/bug-1867061-fix-py-raw-error-msg-ff3c6da0b01d5d6c.yaml":[{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"43e5d723c2cae735a8962ddf1283ff421a5fdef6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed raw error message when using ``cinder`` with an optional argument"},{"line_number":5,"context_line":"    without a command. For more details, please refer to the"},{"line_number":6,"context_line":"    `Launchpad Bug #1867061 \u003chttps://bugs.launchpad.net/python-cinderclient/+bug/1867061\u003e`_ "}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3f65232a_09d172ce","line":4,"updated":"2020-10-23 16:09:16.000000000","message":"Please follow the bugfix reno format we recently adopted. You may find some examples here: https://review.opendev.org/#/c/746319/","commit_id":"a22850c78a5a8e2a6c3eceab3c597faaa104a898"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"b9453ab8cc90cddcfde2660217b4f15f0df5e3b1","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1867061 \u003chttps://bugs.launchpad.net/python-cinderclient/+bug/1867061\u003e`_:"},{"line_number":5,"context_line":"    Fixed raw error message when using"},{"line_number":6,"context_line":"    ``cinder`` with an optional argument"},{"line_number":7,"context_line":"    without a command."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f65232a_2856c85d","line":5,"updated":"2020-10-27 16:53:19.000000000","message":"nit: AFAIK we don\u0027t have a hard limit on # of characters per line for reno, so you may use 72 or 79 chars per line. It\u0027s not a problem though, as it\u0027s rendered properly [0].\n\n[0] https://0a5c623ff913673f34ed-80527d3715cd24d9d5daf12827bd66d5.ssl.cf2.rackcdn.com/759440/3/check/build-openstack-releasenotes/bb0e8a2/docs/unreleased.html","commit_id":"60e56b845b14aa91d076601a5f144508649a1f23"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"c5fbb59719363e5417c1042a9ffdc33e617c08a2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1867061 \u003chttps://bugs.launchpad.net/python-cinderclient/+bug/1867061\u003e`_:"},{"line_number":5,"context_line":"    Fixed raw error message when using"},{"line_number":6,"context_line":"    ``cinder`` with an optional argument"},{"line_number":7,"context_line":"    without a command."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f621f24_ae04d8c7","line":6,"range":{"start_line":6,"start_character":15,"end_line":6,"end_character":40},"updated":"2020-10-29 12:54:01.000000000","message":"You could give an example of an optional argument.","commit_id":"f3ad18a87484473a0a57d81c089dce26ad26d434"}]}