)]}'
{"cinderclient/shell.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bee276a208245f0937c1d64c6387d1bca78a4a02","unresolved":true,"context_lines":[{"line_number":539,"context_line":"    @staticmethod"},{"line_number":540,"context_line":"    def _validate_input_api_version(options):"},{"line_number":541,"context_line":"        if not options.os_volume_api_version:"},{"line_number":542,"context_line":"            api_version \u003d api_versions.APIVersion(api_versions.MAX_VERSION)"},{"line_number":543,"context_line":"        else:"},{"line_number":544,"context_line":"            api_version \u003d api_versions.get_api_version("},{"line_number":545,"context_line":"                options.os_volume_api_version)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d5a226ce_3809196a","line":542,"updated":"2021-03-19 15:44:08.000000000","message":"So here if the user hasn\u0027t specified a version, we figure that they want the max version the *client* supports (whereas, they may want the max version that the *server* supports).","commit_id":"046c034fafe177124febf7ab600899c47678b0a4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bee276a208245f0937c1d64c6387d1bca78a4a02","unresolved":true,"context_lines":[{"line_number":582,"context_line":"        do_help \u003d (\u0027help\u0027 in argv) or ("},{"line_number":583,"context_line":"            \u0027--help\u0027 in argv) or (\u0027-h\u0027 in argv) or not argv"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":"        api_version \u003d self._validate_input_api_version(options)"},{"line_number":586,"context_line":""},{"line_number":587,"context_line":"        # build available subcommands based on version"},{"line_number":588,"context_line":"        major_version_string \u003d \"%s\" % api_version.ver_major"}],"source_content_type":"text/x-python","patch_set":2,"id":"e86d49cc_9b9f151a","line":585,"updated":"2021-03-19 15:44:08.000000000","message":"See comment above ... if the user hasn\u0027t specifically asked for a version, this will be the highest version this client supports","commit_id":"046c034fafe177124febf7ab600899c47678b0a4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"bee276a208245f0937c1d64c6387d1bca78a4a02","unresolved":true,"context_lines":[{"line_number":782,"context_line":"                os_auth_url,"},{"line_number":783,"context_line":"                client_args)"},{"line_number":784,"context_line":""},{"line_number":785,"context_line":"            if discovered_version \u003c api_version:"},{"line_number":786,"context_line":"                self.downgrade_warning(api_version, discovered_version)"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"        profile \u003d osprofiler_profiler and options.profile"}],"source_content_type":"text/x-python","patch_set":2,"id":"18486a0a_afd1f680","line":785,"range":{"start_line":785,"start_character":36,"end_line":785,"end_character":47},"updated":"2021-03-19 15:44:08.000000000","message":"This was set at line 585.  If this is true because the user requested a particular version, we definitely want to tell them we\u0027re using a lower one.  But if it\u0027s true because the server is version n but we support version n+1, then I see how the warnings will be confusing to users.\n\nThere\u0027s an \u0027api_version_input\u0027 var that is set True at line 579, but its value isn\u0027t changed anywhere.  I wonder whether that was supposed to indicate whether api_version is being supplied by the user.  If so, we could use it to make the warning message more fine grained (or suppressed) to cause less user confusion.","commit_id":"046c034fafe177124febf7ab600899c47678b0a4"}]}