)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"857c237c174d94b360c3cce96bc9e6f7e8504c48","unresolved":true,"context_lines":[{"line_number":10,"context_line":"`OpenSSL.SSL.Error: [sslv3 alert handshake failure]` when the server"},{"line_number":11,"context_line":"expects client certificates as part of these requests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added the optional parameter `cert` to both get_highest_client_server_version and"},{"line_number":14,"context_line":"get_server_version methods so, that this bug can be fixed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: 1915996 Fetching server version fails to support passing client certificates."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"92fe27ce_ad0a1a93","line":13,"updated":"2021-02-18 13:08:59.000000000","message":"Please try to follow commit message guidelines:\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure","commit_id":"aa59f355c531125ecfd2c4adba437da82a4f8c34"},{"author":{"_account_id":27252,"name":"Sri Harsha mekala","email":"smekala@oath.com","username":"smekala"},"change_message_id":"a33c31d42d9911346c2ddd02390fe1d31b1e2e12","unresolved":false,"context_lines":[{"line_number":10,"context_line":"`OpenSSL.SSL.Error: [sslv3 alert handshake failure]` when the server"},{"line_number":11,"context_line":"expects client certificates as part of these requests."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Added the optional parameter `cert` to both get_highest_client_server_version and"},{"line_number":14,"context_line":"get_server_version methods so, that this bug can be fixed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: 1915996 Fetching server version fails to support passing client certificates."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9cbc5e8e_1bbf259f","line":13,"in_reply_to":"92fe27ce_ad0a1a93","updated":"2021-02-18 15:07:28.000000000","message":"Done","commit_id":"aa59f355c531125ecfd2c4adba437da82a4f8c34"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"857c237c174d94b360c3cce96bc9e6f7e8504c48","unresolved":true,"context_lines":[{"line_number":13,"context_line":"Added the optional parameter `cert` to both get_highest_client_server_version and"},{"line_number":14,"context_line":"get_server_version methods so, that this bug can be fixed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: 1915996 Fetching server version fails to support passing client certificates."},{"line_number":17,"context_line":"Change-Id: I57c665dd9d4b8c32e5f10994d891d1e0f5315548"},{"line_number":18,"context_line":"Signed-off-by: sri harsha mekala \u003csmekala@oath.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"8e30053a_e3321332","line":16,"updated":"2021-02-18 13:08:59.000000000","message":"Format should be:\n\nCloses: #1915996","commit_id":"aa59f355c531125ecfd2c4adba437da82a4f8c34"},{"author":{"_account_id":27252,"name":"Sri Harsha mekala","email":"smekala@oath.com","username":"smekala"},"change_message_id":"a33c31d42d9911346c2ddd02390fe1d31b1e2e12","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Added the optional parameter `cert` to both get_highest_client_server_version and"},{"line_number":14,"context_line":"get_server_version methods so, that this bug can be fixed."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: 1915996 Fetching server version fails to support passing client certificates."},{"line_number":17,"context_line":"Change-Id: I57c665dd9d4b8c32e5f10994d891d1e0f5315548"},{"line_number":18,"context_line":"Signed-off-by: sri harsha mekala \u003csmekala@oath.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ac9b414d_08b3186f","line":16,"in_reply_to":"8e30053a_e3321332","updated":"2021-02-18 15:07:28.000000000","message":"Done","commit_id":"aa59f355c531125ecfd2c4adba437da82a4f8c34"}],"cinderclient/client.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a459658edddb9492b7874ace9c86f894c398cf66","unresolved":true,"context_lines":[{"line_number":78,"context_line":"                     (https) requests"},{"line_number":79,"context_line":"    :param cacert: Specify a CA bundle file to use in verifying a TLS"},{"line_number":80,"context_line":"                            (https) server certificate"},{"line_number":81,"context_line":"    :param cert: A client certificate to pass to requests. These are of the"},{"line_number":82,"context_line":"                 same form as requests expects. Either a single filename"},{"line_number":83,"context_line":"                 containing both the certificate and key or a tuple containing"},{"line_number":84,"context_line":"                 the path to the certificate then a path to the key. (optional)"},{"line_number":85,"context_line":"    :returns: APIVersion object for min and max version supported by"},{"line_number":86,"context_line":"              the server"},{"line_number":87,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"60a8291d_dcd58697","line":84,"range":{"start_line":81,"start_character":59,"end_line":84,"end_character":67},"updated":"2021-04-14 13:04:05.000000000","message":"Maybe I have a bad sample, but in other openstack clients (e.g., change I19fb971de864), this is kept as 2 params, cert and key, and the tuple-ization is done in the code before handing off to requests.  The cinder-side change for mTLS in the connection to glance also has separate client cert and key parameters (change Ic9deaa001482).  I think we should be consistent with general openstack usage.","commit_id":"9c2e8df94839412b4ccf13cc538c61af7c16ca2f"},{"author":{"_account_id":27252,"name":"Sri Harsha mekala","email":"smekala@oath.com","username":"smekala"},"change_message_id":"40a88ec32f96bb5322e9a7584489b2c331cb8a55","unresolved":true,"context_lines":[{"line_number":78,"context_line":"                     (https) requests"},{"line_number":79,"context_line":"    :param cacert: Specify a CA bundle file to use in verifying a TLS"},{"line_number":80,"context_line":"                            (https) server certificate"},{"line_number":81,"context_line":"    :param cert: A client certificate to pass to requests. These are of the"},{"line_number":82,"context_line":"                 same form as requests expects. Either a single filename"},{"line_number":83,"context_line":"                 containing both the certificate and key or a tuple containing"},{"line_number":84,"context_line":"                 the path to the certificate then a path to the key. (optional)"},{"line_number":85,"context_line":"    :returns: APIVersion object for min and max version supported by"},{"line_number":86,"context_line":"              the server"},{"line_number":87,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"944d6e7b_b68c3a6f","line":84,"range":{"start_line":81,"start_character":59,"end_line":84,"end_character":67},"in_reply_to":"60a8291d_dcd58697","updated":"2021-04-14 19:47:56.000000000","message":"Regarding the format of cert option, I have followed the format supported and documented in keystoneauth code.\nhttps://github.com/openstack/keystoneauth/blob/master/keystoneauth1/session.py#L288-L291","commit_id":"9c2e8df94839412b4ccf13cc538c61af7c16ca2f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1df21376f8ab241b265de9d2b7df93d5ca115747","unresolved":true,"context_lines":[{"line_number":78,"context_line":"                     (https) requests"},{"line_number":79,"context_line":"    :param cacert: Specify a CA bundle file to use in verifying a TLS"},{"line_number":80,"context_line":"                            (https) server certificate"},{"line_number":81,"context_line":"    :param cert: A client certificate to pass to requests. These are of the"},{"line_number":82,"context_line":"                 same form as requests expects. Either a single filename"},{"line_number":83,"context_line":"                 containing both the certificate and key or a tuple containing"},{"line_number":84,"context_line":"                 the path to the certificate then a path to the key. (optional)"},{"line_number":85,"context_line":"    :returns: APIVersion object for min and max version supported by"},{"line_number":86,"context_line":"              the server"},{"line_number":87,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"635579b9_5e1262be","line":84,"range":{"start_line":81,"start_character":59,"end_line":84,"end_character":67},"in_reply_to":"944d6e7b_b68c3a6f","updated":"2021-04-20 19:51:22.000000000","message":"OK, thanks for the reference.  Consistency with keystone is good!","commit_id":"9c2e8df94839412b4ccf13cc538c61af7c16ca2f"}]}