)]}'
{"cinderclient/tests/unit/v1/test_shell.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"48eb0dbf43817de53059c0740a12ac7d47acec25","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        self.run_command(\u0027snapshot-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":259,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/snapshots/detail?\u0027"},{"line_number":260,"context_line":"                           \u0027status\u003davailable\u0026volume_id\u003d1234\u0027)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def test_backup_list(self):"},{"line_number":263,"context_line":"        self.run_command(\u0027backup-list\u0027)"},{"line_number":264,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1af86dd1_b410d74f","line":261,"updated":"2015-06-12 12:57:17.000000000","message":"Are changes to v1 still accepted?","commit_id":"fe2e4e707b0d68f2b1bddd92b2209adbce675932"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"d3e36176d841f4a1a4ec9adcd2ee90ea5a048b81","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        self.run_command(\u0027snapshot-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":259,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/snapshots/detail?\u0027"},{"line_number":260,"context_line":"                           \u0027status\u003davailable\u0026volume_id\u003d1234\u0027)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def test_backup_list(self):"},{"line_number":263,"context_line":"        self.run_command(\u0027backup-list\u0027)"},{"line_number":264,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa32b979_f52145b5","line":261,"in_reply_to":"1af86dd1_b410d74f","updated":"2015-06-16 20:19:24.000000000","message":"I think volume backup api version 1 is still supporting. Am I wrong?","commit_id":"fe2e4e707b0d68f2b1bddd92b2209adbce675932"}],"cinderclient/tests/v1/test_shell.py":[{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"9f9c2de5422c89bd76f49d89ec9393938f5af9a8","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":153,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"},{"line_number":154,"context_line":"                           \u0027status\u003davailable\u0026volume_id\u003d1234\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_rename(self):"},{"line_number":157,"context_line":"        # basic rename with positional arguments"},{"line_number":158,"context_line":"        self.run_command(\u0027rename 1234 new-name\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F5wE%3D","line":155,"updated":"2014-04-25 12:25:19.000000000","message":"Please add an extra test with no parameter to check that ? is not addad at the end of the line if there is no extra parameter","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"a098151997b20d14e35821036b19003ff1192e86","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":153,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"},{"line_number":154,"context_line":"                           \u0027status\u003davailable\u0026volume_id\u003d1234\u0027)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    def test_rename(self):"},{"line_number":157,"context_line":"        # basic rename with positional arguments"},{"line_number":158,"context_line":"        self.run_command(\u0027rename 1234 new-name\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F0vU%3D","line":155,"in_reply_to":"AAAAXX%2F%2F5wE%3D","updated":"2014-04-26 01:28:01.000000000","message":"Thank you for your review.\n\nI added basic backup list test code.","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"f1d3bbe3a6dd1c11966c0a61efedf65266bd092a","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def test_backup_list(self):"},{"line_number":182,"context_line":"        self.run_command(\u0027backup-list\u0027)"},{"line_number":183,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail\u0027)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_backup_list_filter_volume_id(self):"},{"line_number":186,"context_line":"        self.run_command(\u0027backup-list --volume-id\u003d1234\u0027)"},{"line_number":187,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?volume_id\u003d1234\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_0dc29ee8","line":184,"updated":"2014-07-14 14:05:35.000000000","message":"@httpretty.activate","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"74c886e7445645bf461dfecbef97354b7afb2ff0","unresolved":false,"context_lines":[{"line_number":181,"context_line":"    def test_backup_list(self):"},{"line_number":182,"context_line":"        self.run_command(\u0027backup-list\u0027)"},{"line_number":183,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail\u0027)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_backup_list_filter_volume_id(self):"},{"line_number":186,"context_line":"        self.run_command(\u0027backup-list --volume-id\u003d1234\u0027)"},{"line_number":187,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?volume_id\u003d1234\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_9048812e","line":184,"in_reply_to":"baada198_0dc29ee8","updated":"2014-07-14 14:15:48.000000000","message":"Done Thanks!","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"f1d3bbe3a6dd1c11966c0a61efedf65266bd092a","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def test_backup_list_filter_volume_id(self):"},{"line_number":186,"context_line":"        self.run_command(\u0027backup-list --volume-id\u003d1234\u0027)"},{"line_number":187,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?volume_id\u003d1234\u0027)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_backup_list_filter_status_and_volume_id(self):"},{"line_number":190,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":191,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_4db81675","line":188,"updated":"2014-07-14 14:05:35.000000000","message":"@httpretty.activate","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"74c886e7445645bf461dfecbef97354b7afb2ff0","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    def test_backup_list_filter_volume_id(self):"},{"line_number":186,"context_line":"        self.run_command(\u0027backup-list --volume-id\u003d1234\u0027)"},{"line_number":187,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?volume_id\u003d1234\u0027)"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def test_backup_list_filter_status_and_volume_id(self):"},{"line_number":190,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":191,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_b053c5e0","line":188,"in_reply_to":"baada198_4db81675","updated":"2014-07-14 14:15:48.000000000","message":"Done Thanks!","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"f1d3bbe3a6dd1c11966c0a61efedf65266bd092a","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":191,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"},{"line_number":192,"context_line":"                           \u0027status\u003davailable\u0026volume_id\u003d1234\u0027)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_rename(self):"},{"line_number":195,"context_line":"        self.register_keystone_auth_fixture()"},{"line_number":196,"context_line":"        # basic rename with positional arguments"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_ed656a1e","line":193,"updated":"2014-07-14 14:05:35.000000000","message":"@httpretty.activate","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"74c886e7445645bf461dfecbef97354b7afb2ff0","unresolved":false,"context_lines":[{"line_number":190,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":191,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"},{"line_number":192,"context_line":"                           \u0027status\u003davailable\u0026volume_id\u003d1234\u0027)"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    def test_rename(self):"},{"line_number":195,"context_line":"        self.register_keystone_auth_fixture()"},{"line_number":196,"context_line":"        # basic rename with positional arguments"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_d04e7937","line":193,"in_reply_to":"baada198_ed656a1e","updated":"2014-07-14 14:15:48.000000000","message":"Done Thanks!","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"}],"cinderclient/tests/v2/test_shell.py":[{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"9f9c2de5422c89bd76f49d89ec9393938f5af9a8","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":131,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"},{"line_number":132,"context_line":"                           \u0027status\u003davailable\u0026volume_id\u003d1234\u0027)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_rename(self):"},{"line_number":135,"context_line":"        # basic rename with positional arguments"},{"line_number":136,"context_line":"        self.run_command(\u0027rename 1234 new-name\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F5wc%3D","line":133,"updated":"2014-04-25 12:25:19.000000000","message":"Please add an extra test with no parameter to check that ? is not addad at the end of the line if there is no extra parameter","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"a098151997b20d14e35821036b19003ff1192e86","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":131,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"},{"line_number":132,"context_line":"                           \u0027status\u003davailable\u0026volume_id\u003d1234\u0027)"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def test_rename(self):"},{"line_number":135,"context_line":"        # basic rename with positional arguments"},{"line_number":136,"context_line":"        self.run_command(\u0027rename 1234 new-name\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F0vY%3D","line":133,"in_reply_to":"AAAAXX%2F%2F5wc%3D","updated":"2014-04-26 01:28:01.000000000","message":"Thank you for your review.\n\nI added basic backup list test code.","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"f1d3bbe3a6dd1c11966c0a61efedf65266bd092a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    def test_backup_list(self):"},{"line_number":173,"context_line":"        self.run_command(\u0027backup-list\u0027)"},{"line_number":174,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def test_backup_list_filter_volume_id(self):"},{"line_number":177,"context_line":"        self.run_command(\u0027backup-list --volume-id\u003d1234\u0027)"},{"line_number":178,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?volume_id\u003d1234\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_adfa9240","line":175,"updated":"2014-07-14 14:05:35.000000000","message":"@httpretty.activate","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"74c886e7445645bf461dfecbef97354b7afb2ff0","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    def test_backup_list(self):"},{"line_number":173,"context_line":"        self.run_command(\u0027backup-list\u0027)"},{"line_number":174,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail\u0027)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def test_backup_list_filter_volume_id(self):"},{"line_number":177,"context_line":"        self.run_command(\u0027backup-list --volume-id\u003d1234\u0027)"},{"line_number":178,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?volume_id\u003d1234\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_505a69f2","line":175,"in_reply_to":"baada198_adfa9240","updated":"2014-07-14 14:15:48.000000000","message":"Done Thanks!","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"f1d3bbe3a6dd1c11966c0a61efedf65266bd092a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    def test_backup_list_filter_volume_id(self):"},{"line_number":177,"context_line":"        self.run_command(\u0027backup-list --volume-id\u003d1234\u0027)"},{"line_number":178,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?volume_id\u003d1234\u0027)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def test_backup_list_filter_status_and_volume_id(self):"},{"line_number":181,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":182,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_cdf50652","line":179,"updated":"2014-07-14 14:05:35.000000000","message":"@httpretty.activate","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"74c886e7445645bf461dfecbef97354b7afb2ff0","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    def test_backup_list_filter_volume_id(self):"},{"line_number":177,"context_line":"        self.run_command(\u0027backup-list --volume-id\u003d1234\u0027)"},{"line_number":178,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?volume_id\u003d1234\u0027)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    def test_backup_list_filter_status_and_volume_id(self):"},{"line_number":181,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":182,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_b06ae57e","line":179,"in_reply_to":"baada198_cdf50652","updated":"2014-07-14 14:15:48.000000000","message":"Done Thanks!","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"f1d3bbe3a6dd1c11966c0a61efedf65266bd092a","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":182,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"},{"line_number":183,"context_line":"                           \u0027status\u003davailable\u0026volume_id\u003d1234\u0027)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_rename(self):"},{"line_number":186,"context_line":"        self.register_keystone_auth_fixture()"},{"line_number":187,"context_line":"        # basic rename with positional arguments"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_0d9b7e18","line":184,"updated":"2014-07-14 14:05:35.000000000","message":"@httpretty.activate","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"74c886e7445645bf461dfecbef97354b7afb2ff0","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        self.run_command(\u0027backup-list --status\u003davailable --volume-id\u003d1234\u0027)"},{"line_number":182,"context_line":"        self.assert_called(\u0027GET\u0027, \u0027/backups/detail?\u0027"},{"line_number":183,"context_line":"                           \u0027status\u003davailable\u0026volume_id\u003d1234\u0027)"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def test_rename(self):"},{"line_number":186,"context_line":"        self.register_keystone_auth_fixture()"},{"line_number":187,"context_line":"        # basic rename with positional arguments"}],"source_content_type":"text/x-python","patch_set":8,"id":"baada198_100b91d6","line":184,"in_reply_to":"baada198_0d9b7e18","updated":"2014-07-14 14:15:48.000000000","message":"Done Thanks!","commit_id":"590eadbd7c505f32426279bfc0965a29900fe440"}],"cinderclient/v1/shell.py":[{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"9f9c2de5422c89bd76f49d89ec9393938f5af9a8","unresolved":false,"context_lines":[{"line_number":880,"context_line":"    \u0027--display-name\u0027,"},{"line_number":881,"context_line":"    metavar\u003d\u0027\u003cdisplay-name\u003e\u0027,"},{"line_number":882,"context_line":"    default\u003dNone,"},{"line_number":883,"context_line":"    help\u003d\u0027Filter results by display-name\u0027)"},{"line_number":884,"context_line":"@utils.arg("},{"line_number":885,"context_line":"    \u0027--status\u0027,"},{"line_number":886,"context_line":"    metavar\u003d\u0027\u003cstatus\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F5yU%3D","line":883,"updated":"2014-04-25 12:25:19.000000000","message":"if you add --display_name in API v2 because most user usis in that way, you should be consistent with API v1, also for --volume-id","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"a098151997b20d14e35821036b19003ff1192e86","unresolved":false,"context_lines":[{"line_number":880,"context_line":"    \u0027--display-name\u0027,"},{"line_number":881,"context_line":"    metavar\u003d\u0027\u003cdisplay-name\u003e\u0027,"},{"line_number":882,"context_line":"    default\u003dNone,"},{"line_number":883,"context_line":"    help\u003d\u0027Filter results by display-name\u0027)"},{"line_number":884,"context_line":"@utils.arg("},{"line_number":885,"context_line":"    \u0027--status\u0027,"},{"line_number":886,"context_line":"    metavar\u003d\u0027\u003cstatus\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F0vc%3D","line":883,"in_reply_to":"AAAAXX%2F%2F5yU%3D","updated":"2014-04-26 01:28:01.000000000","message":"Thank you for your review\n\nI fixed.","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"9bc3b18e10ad67bc5714d9c78cc3611ac5844ba6","unresolved":false,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    search_opts \u003d {"},{"line_number":902,"context_line":"        \u0027all_tenants\u0027: all_tenants,"},{"line_number":903,"context_line":"        \u0027display_name\u0027: args.display_name,"},{"line_number":904,"context_line":"        \u0027status\u0027: args.status,"},{"line_number":905,"context_line":"        \u0027volume_id\u0027: args.volume_id,"},{"line_number":906,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_3dcd145e","line":903,"updated":"2014-05-05 13:46:42.000000000","message":"please change this one also to \u0027name\u0027","commit_id":"e05e48d3f36d3d707b9131d1291402118dcda9aa"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"647916998adee1684ff103bdf58ee1282188fea5","unresolved":false,"context_lines":[{"line_number":900,"context_line":""},{"line_number":901,"context_line":"    search_opts \u003d {"},{"line_number":902,"context_line":"        \u0027all_tenants\u0027: all_tenants,"},{"line_number":903,"context_line":"        \u0027display_name\u0027: args.display_name,"},{"line_number":904,"context_line":"        \u0027status\u0027: args.status,"},{"line_number":905,"context_line":"        \u0027volume_id\u0027: args.volume_id,"},{"line_number":906,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad9bd40_0aa39101","line":903,"in_reply_to":"9ad9bd40_3dcd145e","updated":"2014-05-06 05:54:01.000000000","message":"OK, I did","commit_id":"e05e48d3f36d3d707b9131d1291402118dcda9aa"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"8ba77f5df4972522ebe4fcc7429288be99461169","unresolved":false,"context_lines":[{"line_number":907,"context_line":"           const\u003d1,"},{"line_number":908,"context_line":"           default\u003d0,"},{"line_number":909,"context_line":"           help\u003d\u0027Display information from all tenants (Admin only).\u0027)"},{"line_number":910,"context_line":"@utils.arg(\u0027--all_tenants\u0027,"},{"line_number":911,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":912,"context_line":"           type\u003dint,"},{"line_number":913,"context_line":"           const\u003d1,"}],"source_content_type":"text/x-python","patch_set":17,"id":"3acd31a7_1ea2ad4b","line":910,"updated":"2015-05-04 23:32:59.000000000","message":"Can we remove the supressed options here? The only reason we have these to begin with is because they were previously offered in v1. Backups didn\u0027t exist in v1.","commit_id":"9c281490992267fb8aaebcff3c6a27a6e8bd7c7f"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"df62389874da2f51c979c796107ac58886012532","unresolved":false,"context_lines":[{"line_number":907,"context_line":"           const\u003d1,"},{"line_number":908,"context_line":"           default\u003d0,"},{"line_number":909,"context_line":"           help\u003d\u0027Display information from all tenants (Admin only).\u0027)"},{"line_number":910,"context_line":"@utils.arg(\u0027--all_tenants\u0027,"},{"line_number":911,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":912,"context_line":"           type\u003dint,"},{"line_number":913,"context_line":"           const\u003d1,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aca2d91_2e0d4437","line":910,"in_reply_to":"3acd31a7_1ea2ad4b","updated":"2015-05-08 16:19:51.000000000","message":"Done","commit_id":"9c281490992267fb8aaebcff3c6a27a6e8bd7c7f"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"48eb0dbf43817de53059c0740a12ac7d47acec25","unresolved":false,"context_lines":[{"line_number":910,"context_line":""},{"line_number":911,"context_line":"    utils.print_dict(info)"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"@utils.arg(\u0027--all-tenants\u0027,"},{"line_number":915,"context_line":"           dest\u003d\u0027all_tenants\u0027,"},{"line_number":916,"context_line":"           metavar\u003d\u0027\u003c0|1\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"1af86dd1_0149af8b","line":913,"updated":"2015-06-12 12:57:17.000000000","message":"Are changes to v1 still being accepted?","commit_id":"fe2e4e707b0d68f2b1bddd92b2209adbce675932"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"d3e36176d841f4a1a4ec9adcd2ee90ea5a048b81","unresolved":false,"context_lines":[{"line_number":910,"context_line":""},{"line_number":911,"context_line":"    utils.print_dict(info)"},{"line_number":912,"context_line":""},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"@utils.arg(\u0027--all-tenants\u0027,"},{"line_number":915,"context_line":"           dest\u003d\u0027all_tenants\u0027,"},{"line_number":916,"context_line":"           metavar\u003d\u0027\u003c0|1\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa32b979_50003f01","line":913,"in_reply_to":"1af86dd1_0149af8b","updated":"2015-06-16 20:19:24.000000000","message":"I think volume backup api version 1 is still supporting. Am I wrong?","commit_id":"fe2e4e707b0d68f2b1bddd92b2209adbce675932"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"48eb0dbf43817de53059c0740a12ac7d47acec25","unresolved":false,"context_lines":[{"line_number":918,"context_line":"           type\u003dint,"},{"line_number":919,"context_line":"           const\u003d1,"},{"line_number":920,"context_line":"           default\u003d0,"},{"line_number":921,"context_line":"           help\u003d\u0027Display information from all tenants (Admin only).\u0027)"},{"line_number":922,"context_line":"@utils.arg(\u0027--name\u0027,"},{"line_number":923,"context_line":"           metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":924,"context_line":"           dest\u003d\u0027display_name\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"1af86dd1_c1239704","line":921,"updated":"2015-06-12 12:57:17.000000000","message":"Is there any benefit to using 1 and 0 here instead of True and False (aside from char count)?","commit_id":"fe2e4e707b0d68f2b1bddd92b2209adbce675932"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"d3e36176d841f4a1a4ec9adcd2ee90ea5a048b81","unresolved":false,"context_lines":[{"line_number":918,"context_line":"           type\u003dint,"},{"line_number":919,"context_line":"           const\u003d1,"},{"line_number":920,"context_line":"           default\u003d0,"},{"line_number":921,"context_line":"           help\u003d\u0027Display information from all tenants (Admin only).\u0027)"},{"line_number":922,"context_line":"@utils.arg(\u0027--name\u0027,"},{"line_number":923,"context_line":"           metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":924,"context_line":"           dest\u003d\u0027display_name\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"fa32b979_b05e6b10","line":921,"in_reply_to":"1af86dd1_c1239704","updated":"2015-06-16 20:19:24.000000000","message":"I tried to follow the search options to volume in order that users are not confused between volume and backup search options.","commit_id":"fe2e4e707b0d68f2b1bddd92b2209adbce675932"}],"cinderclient/v1/volume_backups.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"48eb0dbf43817de53059c0740a12ac7d47acec25","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        \"\"\"Get a list of all volume backups."},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        :rtype: list of :class:`VolumeBackup`"},{"line_number":71,"context_line":"        \"\"\""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if search_opts is None:"},{"line_number":74,"context_line":"            search_opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":19,"id":"1af86dd1_216dcb04","line":71,"updated":"2015-06-12 12:57:17.000000000","message":"Are changes to v1 still being accepted?","commit_id":"fe2e4e707b0d68f2b1bddd92b2209adbce675932"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"48eb0dbf43817de53059c0740a12ac7d47acec25","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            search_opts \u003d {}"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        qparams \u003d {}"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        for opt, val in six.iteritems(search_opts):"},{"line_number":79,"context_line":"            if val:"},{"line_number":80,"context_line":"                qparams[opt] \u003d val"}],"source_content_type":"text/x-python","patch_set":19,"id":"1af86dd1_619503e3","line":77,"updated":"2015-06-12 12:57:17.000000000","message":"Maybe add a brief comment here stating what\u0027s happening, something like:\n\n# Filtering out unset search options","commit_id":"fe2e4e707b0d68f2b1bddd92b2209adbce675932"}],"cinderclient/v2/shell.py":[{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"428794672bc337931907a8141927fbbd7f99cf03","unresolved":false,"context_lines":[{"line_number":973,"context_line":"           const\u003d1,"},{"line_number":974,"context_line":"           default\u003d0,"},{"line_number":975,"context_line":"           help\u003d\u0027Display information from all tenants (Admin only).\u0027)"},{"line_number":976,"context_line":"@utils.arg(\u0027--all_tenants\u0027,"},{"line_number":977,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":978,"context_line":"           type\u003dint,"},{"line_number":979,"context_line":"           const\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FCiI%3D","line":976,"updated":"2014-04-24 13:21:37.000000000","message":"IMO, I\u0027m not sure if this is really needed, if params are new, no backward compatibility should be needed.\n\nSame for others","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"cd29724edd97dea2ef18422bae7997c5aea4efc0","unresolved":false,"context_lines":[{"line_number":973,"context_line":"           const\u003d1,"},{"line_number":974,"context_line":"           default\u003d0,"},{"line_number":975,"context_line":"           help\u003d\u0027Display information from all tenants (Admin only).\u0027)"},{"line_number":976,"context_line":"@utils.arg(\u0027--all_tenants\u0027,"},{"line_number":977,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":978,"context_line":"           type\u003dint,"},{"line_number":979,"context_line":"           const\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F8oQ%3D","line":976,"in_reply_to":"AAAAXH%2F%2FCiI%3D","updated":"2014-04-25 06:00:24.000000000","message":"Thank you for you review\n\nLot\u0027s of commands use thie arguement now, kind of nova list, cinder list, cinder snapshot-list.\n\nI think this argumet is useful for administrator for searching all resource of topics.","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"a098151997b20d14e35821036b19003ff1192e86","unresolved":false,"context_lines":[{"line_number":973,"context_line":"           const\u003d1,"},{"line_number":974,"context_line":"           default\u003d0,"},{"line_number":975,"context_line":"           help\u003d\u0027Display information from all tenants (Admin only).\u0027)"},{"line_number":976,"context_line":"@utils.arg(\u0027--all_tenants\u0027,"},{"line_number":977,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":978,"context_line":"           type\u003dint,"},{"line_number":979,"context_line":"           const\u003d1,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F0vk%3D","line":976,"in_reply_to":"AAAAXX%2F%2F8oQ%3D","updated":"2014-04-26 01:28:01.000000000","message":"Thank you for your review\n\nI fixed.","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"4d48615317a86cf6e8c1cbb2754d2cacee844b69","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"    if args.display_name is not None:"},{"line_number":1005,"context_line":"        args.name \u003d args.display_name"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"    search_opts \u003d {"},{"line_number":1008,"context_line":"        \u0027all_tenants\u0027: all_tenants,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2FAjI%3D","line":1005,"updated":"2014-04-24 17:39:55.000000000","message":"IMO instead of this logic you could use dest\u003dname in arg definition\nor using dest in --name","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"cd29724edd97dea2ef18422bae7997c5aea4efc0","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"    if args.display_name is not None:"},{"line_number":1005,"context_line":"        args.name \u003d args.display_name"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"    search_opts \u003d {"},{"line_number":1008,"context_line":"        \u0027all_tenants\u0027: all_tenants,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F8mM%3D","line":1005,"updated":"2014-04-25 06:00:24.000000000","message":"Thank you for you review\n\nPlease let me know in detail, actually I don\u0027t understand what you mean.","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"a098151997b20d14e35821036b19003ff1192e86","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"    if args.display_name is not None:"},{"line_number":1005,"context_line":"        args.name \u003d args.display_name"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"    search_opts \u003d {"},{"line_number":1008,"context_line":"        \u0027all_tenants\u0027: all_tenants,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F0vg%3D","line":1005,"in_reply_to":"AAAAXX%2F%2F5zI%3D","updated":"2014-04-26 01:28:01.000000000","message":"Thank you for your review\n\nI fixed.","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"9f9c2de5422c89bd76f49d89ec9393938f5af9a8","unresolved":false,"context_lines":[{"line_number":1002,"context_line":"    all_tenants \u003d int(os.environ.get(\"ALL_TENANTS\", args.all_tenants))"},{"line_number":1003,"context_line":""},{"line_number":1004,"context_line":"    if args.display_name is not None:"},{"line_number":1005,"context_line":"        args.name \u003d args.display_name"},{"line_number":1006,"context_line":""},{"line_number":1007,"context_line":"    search_opts \u003d {"},{"line_number":1008,"context_line":"        \u0027all_tenants\u0027: all_tenants,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXX%2F%2F5zI%3D","line":1005,"in_reply_to":"AAAAXX%2F%2F8mM%3D","updated":"2014-04-25 12:25:19.000000000","message":"Sure with \u0027dest\u0027 you could indicate the name of the variable to storage the data\n\n@utils.arg(\u0027--name\u0027,\n           metavar\u003d\u0027\u003cname\u003e\u0027,\n           dest\u003d\u0027display_name\u0027,\n           default\u003dNone,\n           help\u003d\u0027Filter results by name\u0027)\n@utils.arg(\u0027--display-name\u0027,\n           help\u003dargparse.SUPPRESS)\n@utils.arg(\u0027--display_name\u0027,\n           help\u003dargparse.SUPPRESS)\n\nIn this case if the user use --name test  you could retieve it from args.display_name","commit_id":"8b50780fb4c94b033451f147605022a89230e255"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"732c460f4b1941c4be8f313b68e57de93eb2024b","unresolved":false,"context_lines":[{"line_number":1004,"context_line":""},{"line_number":1005,"context_line":"    search_opts \u003d {"},{"line_number":1006,"context_line":"        \u0027all_tenants\u0027: all_tenants,"},{"line_number":1007,"context_line":"        \u0027display_name\u0027: args.display_name,"},{"line_number":1008,"context_line":"        \u0027status\u0027: args.status,"},{"line_number":1009,"context_line":"        \u0027volume_id\u0027: args.volume_id,"},{"line_number":1010,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad9bd40_732f1fa2","line":1007,"updated":"2014-05-01 13:20:38.000000000","message":"John, we should use \u0027name\u0027 instead of \u0027display_name\u0027 to be consistent with volume search options\nCould you change it?\n\nThis is the review of the server side\nhttps://review.openstack.org/#/c/90996/\n\nThanks","commit_id":"f0837aad9447504e46d506af2348114eb7f9a386"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"8ba77f5df4972522ebe4fcc7429288be99461169","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"           dest\u003d\u0027display_name\u0027,"},{"line_number":1197,"context_line":"           default\u003dNone,"},{"line_number":1198,"context_line":"           help\u003d\u0027Filter results by name\u0027)"},{"line_number":1199,"context_line":"@utils.arg(\u0027--display-name\u0027,"},{"line_number":1200,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":1201,"context_line":"@utils.arg(\u0027--display_name\u0027,"},{"line_number":1202,"context_line":"           help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":17,"id":"3acd31a7_7e9761ec","line":1199,"updated":"2015-05-04 23:32:59.000000000","message":"Can we remove the supressed options here? The only reason we have these to begin with is because they were previously offered in v1. Backups didn\u0027t exist in v1.","commit_id":"9c281490992267fb8aaebcff3c6a27a6e8bd7c7f"},{"author":{"_account_id":1523,"name":"SeungjinHan","email":"seungjin.han@kt.com","username":"yongiman"},"change_message_id":"df62389874da2f51c979c796107ac58886012532","unresolved":false,"context_lines":[{"line_number":1196,"context_line":"           dest\u003d\u0027display_name\u0027,"},{"line_number":1197,"context_line":"           default\u003dNone,"},{"line_number":1198,"context_line":"           help\u003d\u0027Filter results by name\u0027)"},{"line_number":1199,"context_line":"@utils.arg(\u0027--display-name\u0027,"},{"line_number":1200,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":1201,"context_line":"@utils.arg(\u0027--display_name\u0027,"},{"line_number":1202,"context_line":"           help\u003dargparse.SUPPRESS)"}],"source_content_type":"text/x-python","patch_set":17,"id":"1aca2d91_ce1ed062","line":1199,"in_reply_to":"3acd31a7_7e9761ec","updated":"2015-05-08 16:19:51.000000000","message":"Done","commit_id":"9c281490992267fb8aaebcff3c6a27a6e8bd7c7f"},{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"48eb0dbf43817de53059c0740a12ac7d47acec25","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"           type\u003dint,"},{"line_number":1206,"context_line":"           const\u003d1,"},{"line_number":1207,"context_line":"           default\u003d0,"},{"line_number":1208,"context_line":"           help\u003d\u0027Display information from all tenants (Admin only).\u0027)"},{"line_number":1209,"context_line":"@utils.arg(\u0027--name\u0027,"},{"line_number":1210,"context_line":"           metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1211,"context_line":"           dest\u003d\u0027display_name\u0027,"}],"source_content_type":"text/x-python","patch_set":19,"id":"1af86dd1_411d6772","line":1208,"updated":"2015-06-12 12:57:17.000000000","message":"See comment in v1/shell.py","commit_id":"fe2e4e707b0d68f2b1bddd92b2209adbce675932"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0e5fb0fcbc5809e76dbe65d886fe0801048a9898","unresolved":false,"context_lines":[{"line_number":1205,"context_line":"           type\u003dint,"},{"line_number":1206,"context_line":"           const\u003d1,"},{"line_number":1207,"context_line":"           default\u003d0,"},{"line_number":1208,"context_line":"           help\u003d\u0027Display information from all tenants (Admin only).\u0027)"},{"line_number":1209,"context_line":"@utils.arg(\u0027--name\u0027,"},{"line_number":1210,"context_line":"           metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1211,"context_line":"           dest\u003d\u0027display_name\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_c6fbcb79","line":1208,"updated":"2015-06-25 11:26:48.000000000","message":"Why don\u0027t we make it consistent with other --all-tenants descriptions? It would be:\n\n\u0027Shows details for all tenants. Admin only.\u0027","commit_id":"8a535f6cb44313221705521b45c8691d59f4e03d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0e5fb0fcbc5809e76dbe65d886fe0801048a9898","unresolved":false,"context_lines":[{"line_number":1208,"context_line":"           help\u003d\u0027Display information from all tenants (Admin only).\u0027)"},{"line_number":1209,"context_line":"@utils.arg(\u0027--name\u0027,"},{"line_number":1210,"context_line":"           metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1211,"context_line":"           dest\u003d\u0027display_name\u0027,"},{"line_number":1212,"context_line":"           default\u003dNone,"},{"line_number":1213,"context_line":"           help\u003d\u0027Filter results by name\u0027)"},{"line_number":1214,"context_line":"@utils.arg(\u0027--status\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_c69c2b10","line":1211,"updated":"2015-06-25 11:26:48.000000000","message":"Why exactly do we need this line? We may as well remove it and use\n\nargs.name\n\nin line 1229.","commit_id":"8a535f6cb44313221705521b45c8691d59f4e03d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0e5fb0fcbc5809e76dbe65d886fe0801048a9898","unresolved":false,"context_lines":[{"line_number":1210,"context_line":"           metavar\u003d\u0027\u003cname\u003e\u0027,"},{"line_number":1211,"context_line":"           dest\u003d\u0027display_name\u0027,"},{"line_number":1212,"context_line":"           default\u003dNone,"},{"line_number":1213,"context_line":"           help\u003d\u0027Filter results by name\u0027)"},{"line_number":1214,"context_line":"@utils.arg(\u0027--status\u0027,"},{"line_number":1215,"context_line":"           metavar\u003d\u0027\u003cstatus\u003e\u0027,"},{"line_number":1216,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_a651e763","line":1213,"updated":"2015-06-25 11:26:48.000000000","message":"Missing dot.","commit_id":"8a535f6cb44313221705521b45c8691d59f4e03d"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0e5fb0fcbc5809e76dbe65d886fe0801048a9898","unresolved":false,"context_lines":[{"line_number":1214,"context_line":"@utils.arg(\u0027--status\u0027,"},{"line_number":1215,"context_line":"           metavar\u003d\u0027\u003cstatus\u003e\u0027,"},{"line_number":1216,"context_line":"           default\u003dNone,"},{"line_number":1217,"context_line":"           help\u003d\u0027Filter results by status\u0027)"},{"line_number":1218,"context_line":"@utils.arg(\u0027--volume-id\u0027,"},{"line_number":1219,"context_line":"           metavar\u003d\u0027\u003cvolume-id\u003e\u0027,"},{"line_number":1220,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_464c9bc7","line":1217,"updated":"2015-06-25 11:26:48.000000000","message":"Missing dot.","commit_id":"8a535f6cb44313221705521b45c8691d59f4e03d"}],"cinderclient/v2/volume_backups.py":[{"author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"change_message_id":"48eb0dbf43817de53059c0740a12ac7d47acec25","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            search_opts \u003d {}"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        qparams \u003d {}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        for opt, val in six.iteritems(search_opts):"},{"line_number":82,"context_line":"            if val:"},{"line_number":83,"context_line":"                qparams[opt] \u003d val"}],"source_content_type":"text/x-python","patch_set":19,"id":"1af86dd1_c1095733","line":80,"updated":"2015-06-12 12:57:17.000000000","message":"See comment in v1/volume_backups.py","commit_id":"fe2e4e707b0d68f2b1bddd92b2209adbce675932"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"0e5fb0fcbc5809e76dbe65d886fe0801048a9898","unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import six"},{"line_number":21,"context_line":"try:"},{"line_number":22,"context_line":"    from urllib import urlencode"},{"line_number":23,"context_line":"except ImportError:"},{"line_number":24,"context_line":"    from urllib.parse import urlencode"}],"source_content_type":"text/x-python","patch_set":21,"id":"fa32b979_666f5f60","line":21,"updated":"2015-06-25 11:26:48.000000000","message":"How about\n\n    from six.moves.urllib import parse\n\n?","commit_id":"8a535f6cb44313221705521b45c8691d59f4e03d"}]}