)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"48f7c6eaf0bf4fa49dd3cb6152871393aff76ccc","unresolved":true,"context_lines":[{"line_number":12,"context_line":"This patch (along with the cinder patch) make the instance_uuid"},{"line_number":13,"context_line":"optional and allow glance to do attachments without passing"},{"line_number":14,"context_line":"instance_uuid."},{"line_number":15,"context_line":"This patch also makes server_id parameter optional in command line"},{"line_number":16,"context_line":"and if required then it needs to be passed manually like:"},{"line_number":17,"context_line":"``cinder attachment-create \u003cvolume-id\u003e --server-id \u003cserver-id\u003e``"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ifbaca4aa87d890bc5130069638d42665b914b378"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4a7bb9b7_de6fda50","line":17,"range":{"start_line":15,"start_character":0,"end_line":17,"end_character":64},"updated":"2021-07-14 12:39:34.000000000","message":"This is no longer accurate.  (I think you can simply remove it, the  previous paragraph is sufficient.)","commit_id":"5edd3eef3a7420f5db5dca70e99e311311f92083"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"f797490a003824a65ececde8c43a744c3025e5f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f62e3f95_c291a2a5","updated":"2022-06-28 13:27:44.000000000","message":"Related cinder change was backported in Victoria.\nhttps://opendev.org/openstack/cinder/commit/d7bb194d092a9f48c09b539ef6153294273147e5\nI suppose we need to backport the change in Victoria too.\n","commit_id":"d714249ca9e95297f5e53c9dcc0af9ba58d0ab6d"}],"cinderclient/tests/unit/v3/test_attachments.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"bc886779a22929ad7699e06d5d5d6888ab378c57","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        att \u003d cs.attachments.create("},{"line_number":37,"context_line":"            \u0027e84fda45-4de4-4ce4-8f39-fc9d3b0aa05e\u0027,"},{"line_number":38,"context_line":"            {},"},{"line_number":39,"context_line":"            \u0027null\u0027)"},{"line_number":40,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/attachments\u0027)"},{"line_number":41,"context_line":"        self.assertEqual(fakes.fake_attachment[\u0027attachment\u0027], att)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8c64f5b8_af309402","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":18},"updated":"2021-06-16 15:37:47.000000000","message":"-1: If I\u0027m reading this correctly this is wrong, this is saying that the instance uuid is \u0027null\u0027, which is not what we want to test.","commit_id":"8ab5d4a69ce65babe4fcb5708a4a3275cc33210c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6f23f6fa3a1b7fdde7a6a8026986596b16ca09a6","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        att \u003d cs.attachments.create("},{"line_number":37,"context_line":"            \u0027e84fda45-4de4-4ce4-8f39-fc9d3b0aa05e\u0027,"},{"line_number":38,"context_line":"            {},"},{"line_number":39,"context_line":"            \u0027null\u0027)"},{"line_number":40,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/attachments\u0027)"},{"line_number":41,"context_line":"        self.assertEqual(fakes.fake_attachment[\u0027attachment\u0027], att)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"def6e27b_b7bea182","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":18},"in_reply_to":"8c64f5b8_af309402","updated":"2021-06-17 15:16:34.000000000","message":"Thanks Gorka, the \u0027null\u0027 is for mode and i forgot to add the None param for instance before this but since you pointed it out I realised that the whole test was wrong.\nCorrected it in next PS.","commit_id":"8ab5d4a69ce65babe4fcb5708a4a3275cc33210c"}],"cinderclient/tests/unit/v3/test_shell.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d61f6a26e064998c9001bfb043021e43ba3a17c6","unresolved":true,"context_lines":[{"line_number":385,"context_line":"                                      \u0027initiator\u0027: \u0027aabbccdd\u0027,"},{"line_number":386,"context_line":"                                      \u0027platform\u0027: \u0027x86_xx\u0027},"},{"line_number":387,"context_line":"                        \u0027volume_uuid\u0027: \u00271234\u0027}},"},{"line_number":388,"context_line":"              {\u0027cmd\u0027: \u0027abc 1233\u0027,"},{"line_number":389,"context_line":"               \u0027body\u0027: {\u0027instance_uuid\u0027: \u00271233\u0027,"},{"line_number":390,"context_line":"                        \u0027connector\u0027: {},"},{"line_number":391,"context_line":"                        \u0027volume_uuid\u0027: \u00271234\u0027}},"}],"source_content_type":"text/x-python","patch_set":8,"id":"28635f4e_0d877cb4","line":388,"range":{"start_line":388,"start_character":23,"end_line":388,"end_character":26},"updated":"2021-07-20 15:44:39.000000000","message":"unrelated: This is not \"technically\" correct, it should be 1234, otherwise the expected body makes no sense, because it should be \u0027abc\u0027 on L391, yet it\u0027s 1234 because it\u0027s hardcoded on L415.\n\nNewly added test data is correct in this regard.","commit_id":"d714249ca9e95297f5e53c9dcc0af9ba58d0ab6d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d61f6a26e064998c9001bfb043021e43ba3a17c6","unresolved":true,"context_lines":[{"line_number":444,"context_line":"                                      \u0027platform\u0027: \u0027x86_xx\u0027},"},{"line_number":445,"context_line":"                        \u0027volume_uuid\u0027: \u00271234\u0027,"},{"line_number":446,"context_line":"                        \u0027mode\u0027: \u0027ro\u0027}},"},{"line_number":447,"context_line":"              {\u0027cmd\u0027: \u0027abc 1233\u0027,"},{"line_number":448,"context_line":"               \u0027body\u0027: {\u0027instance_uuid\u0027: \u00271233\u0027,"},{"line_number":449,"context_line":"                        \u0027connector\u0027: {},"},{"line_number":450,"context_line":"                        \u0027volume_uuid\u0027: \u00271234\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"c9e912f0_8a7ad535","line":447,"range":{"start_line":447,"start_character":23,"end_line":447,"end_character":26},"updated":"2021-07-20 15:44:39.000000000","message":"ditto","commit_id":"d714249ca9e95297f5e53c9dcc0af9ba58d0ab6d"}],"cinderclient/v3/attachments.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"952f7e45f30f2313983c73676431eea66e3bacfc","unresolved":true,"context_lines":[{"line_number":29,"context_line":"    @api_versions.wraps(\u00273.27\u0027)"},{"line_number":30,"context_line":"    def create(self, volume_id, connector, instance_id\u003dNone, mode\u003d\u0027null\u0027):"},{"line_number":31,"context_line":"        \"\"\"Create a attachment for specified volume.\"\"\""},{"line_number":32,"context_line":"        if instance_id:"},{"line_number":33,"context_line":"            body \u003d {\u0027attachment\u0027: {\u0027volume_uuid\u0027: volume_id,"},{"line_number":34,"context_line":"                                   \u0027instance_uuid\u0027: instance_id,"},{"line_number":35,"context_line":"                                   \u0027connector\u0027: connector}}"},{"line_number":36,"context_line":"        else:"},{"line_number":37,"context_line":"            body \u003d {\u0027attachment\u0027: {\u0027volume_uuid\u0027: volume_id,"},{"line_number":38,"context_line":"                                   \u0027connector\u0027: connector}}"},{"line_number":39,"context_line":"        if self.api_version \u003e\u003d api_versions.APIVersion(\"3.54\"):"},{"line_number":40,"context_line":"            if mode and mode !\u003d \u0027null\u0027:"},{"line_number":41,"context_line":"                body[\u0027attachment\u0027][\u0027mode\u0027] \u003d mode"}],"source_content_type":"text/x-python","patch_set":1,"id":"01a3ed07_9d42aac1","line":38,"range":{"start_line":32,"start_character":0,"end_line":38,"end_character":59},"updated":"2021-06-16 14:23:10.000000000","message":"-1: I think it\u0027s clearer like this:\n\n        body \u003d {\u0027attachment\u0027: {\u0027volume_uuid\u0027: volume_id,\n                               \u0027connector\u0027: connector}}\n        if instance_id:\n            body[\u0027attachment\u0027][\u0027instance_uuid\u0027] \u003d instance_id","commit_id":"f16774262926e216adf621e03c0e25ba9f37c949"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"241160b4a41d6ac039aa087df0d18d2c6612a272","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    @api_versions.wraps(\u00273.27\u0027)"},{"line_number":30,"context_line":"    def create(self, volume_id, connector, instance_id\u003dNone, mode\u003d\u0027null\u0027):"},{"line_number":31,"context_line":"        \"\"\"Create a attachment for specified volume.\"\"\""},{"line_number":32,"context_line":"        if instance_id:"},{"line_number":33,"context_line":"            body \u003d {\u0027attachment\u0027: {\u0027volume_uuid\u0027: volume_id,"},{"line_number":34,"context_line":"                                   \u0027instance_uuid\u0027: instance_id,"},{"line_number":35,"context_line":"                                   \u0027connector\u0027: connector}}"},{"line_number":36,"context_line":"        else:"},{"line_number":37,"context_line":"            body \u003d {\u0027attachment\u0027: {\u0027volume_uuid\u0027: volume_id,"},{"line_number":38,"context_line":"                                   \u0027connector\u0027: connector}}"},{"line_number":39,"context_line":"        if self.api_version \u003e\u003d api_versions.APIVersion(\"3.54\"):"},{"line_number":40,"context_line":"            if mode and mode !\u003d \u0027null\u0027:"},{"line_number":41,"context_line":"                body[\u0027attachment\u0027][\u0027mode\u0027] \u003d mode"}],"source_content_type":"text/x-python","patch_set":1,"id":"7071bf72_c2e416db","line":38,"range":{"start_line":32,"start_character":0,"end_line":38,"end_character":59},"in_reply_to":"01a3ed07_9d42aac1","updated":"2021-06-16 15:29:10.000000000","message":"Done","commit_id":"f16774262926e216adf621e03c0e25ba9f37c949"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7712f740052deda53758dfc7f781edc4d6c9cf4e","unresolved":true,"context_lines":[{"line_number":583,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"@utils.arg(\u0027size\u0027,"},{"line_number":587,"context_line":"           metavar\u003d\u0027\u003csize\u003e\u0027,"},{"line_number":588,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":589,"context_line":"           type\u003dint,"},{"line_number":590,"context_line":"           action\u003dCheckSizeArgForCreate,"},{"line_number":591,"context_line":"           help\u003d\u0027Size of volume, in GiBs. (Required unless \u0027"},{"line_number":592,"context_line":"                \u0027snapshot-id/source-volid/backup-id is specified).\u0027)"},{"line_number":593,"context_line":"@utils.arg(\u0027--consisgroup-id\u0027,"},{"line_number":594,"context_line":"           metavar\u003d\u0027\u003cconsistencygroup-id\u003e\u0027,"},{"line_number":595,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"f1582638_b508b143","line":592,"range":{"start_line":586,"start_character":0,"end_line":592,"end_character":68},"updated":"2021-07-13 20:58:49.000000000","message":"I think we should handle \u0027server_id\u0027 like the way \u0027size\u0027 (nargs\u003d\u0027?\u0027) is handled here.  If you do \n\n  cinder --os-volume-api-version 3.latest help create\n\nyou get something like this:\n\n  usage: cinder create [--consisgroup-id \u003cconsistencygroup-id\u003e]\n                       ... etc ...\n                       [\u003csize\u003e]\n\n  Creates a volume.\n\n  Positional Arguments:\n    \u003csize\u003e                Size of volume, in GiBs. (Required unless snapshot-\n                          id/source-volid/backup-id is specified).\n\n  Optional Arguments:\n    --consisgroup-id \u003cconsistencygroup-id\u003e\n                          ID of a consistency group where the new volume belongs\n                          to. Default\u003dNone.\n\nYou can tell that \u0027size\u0027 is optional because of the \u0027[\u003csize\u003e]\u0027 in the usage statement.  This way, we won\u0027t break shell scripts that are using attachment-create in the current way, i.e., as a positional arg.  Otherwise, people will have to update scripts to add the \u0027--server-id\u0027 option.","commit_id":"64f9fe02e717e42bfe43d073c3b78978a382fc4b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9650ed854eba44ea09edb7bd56a527727dca6d5c","unresolved":false,"context_lines":[{"line_number":583,"context_line":"        raise exceptions.CommandError(msg)"},{"line_number":584,"context_line":""},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"@utils.arg(\u0027size\u0027,"},{"line_number":587,"context_line":"           metavar\u003d\u0027\u003csize\u003e\u0027,"},{"line_number":588,"context_line":"           nargs\u003d\u0027?\u0027,"},{"line_number":589,"context_line":"           type\u003dint,"},{"line_number":590,"context_line":"           action\u003dCheckSizeArgForCreate,"},{"line_number":591,"context_line":"           help\u003d\u0027Size of volume, in GiBs. (Required unless \u0027"},{"line_number":592,"context_line":"                \u0027snapshot-id/source-volid/backup-id is specified).\u0027)"},{"line_number":593,"context_line":"@utils.arg(\u0027--consisgroup-id\u0027,"},{"line_number":594,"context_line":"           metavar\u003d\u0027\u003cconsistencygroup-id\u003e\u0027,"},{"line_number":595,"context_line":"           default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":5,"id":"d16b5331_dde5f519","line":592,"range":{"start_line":586,"start_character":0,"end_line":592,"end_character":68},"in_reply_to":"f1582638_b508b143","updated":"2021-07-14 08:34:06.000000000","message":"Ack","commit_id":"64f9fe02e717e42bfe43d073c3b78978a382fc4b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7712f740052deda53758dfc7f781edc4d6c9cf4e","unresolved":true,"context_lines":[{"line_number":2295,"context_line":"@utils.arg(\u0027volume\u0027,"},{"line_number":2296,"context_line":"           metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":2297,"context_line":"           help\u003d\u0027Name or ID of volume or volumes to attach.\u0027)"},{"line_number":2298,"context_line":"@utils.arg(\u0027--server-id\u0027,"},{"line_number":2299,"context_line":"           metavar\u003d\u0027\u003cserver_id\u003e\u0027,"},{"line_number":2300,"context_line":"           default\u003dNone,"},{"line_number":2301,"context_line":"           help\u003d\u0027ID of server attaching to.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"04c381b4_e4dde309","line":2298,"updated":"2021-07-13 20:58:49.000000000","message":"See my comment above at line 586 for a different way to handle this.","commit_id":"64f9fe02e717e42bfe43d073c3b78978a382fc4b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9650ed854eba44ea09edb7bd56a527727dca6d5c","unresolved":false,"context_lines":[{"line_number":2295,"context_line":"@utils.arg(\u0027volume\u0027,"},{"line_number":2296,"context_line":"           metavar\u003d\u0027\u003cvolume\u003e\u0027,"},{"line_number":2297,"context_line":"           help\u003d\u0027Name or ID of volume or volumes to attach.\u0027)"},{"line_number":2298,"context_line":"@utils.arg(\u0027--server-id\u0027,"},{"line_number":2299,"context_line":"           metavar\u003d\u0027\u003cserver_id\u003e\u0027,"},{"line_number":2300,"context_line":"           default\u003dNone,"},{"line_number":2301,"context_line":"           help\u003d\u0027ID of server attaching to.\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f364fb60_fc7f5c33","line":2298,"in_reply_to":"04c381b4_e4dde309","updated":"2021-07-14 08:34:06.000000000","message":"Done","commit_id":"64f9fe02e717e42bfe43d073c3b78978a382fc4b"}]}