)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c63e967858c2ed8fff1e55502a4c8b42e44601b2","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Additionally, the cinderclient.tests.v2.test_availablity_zone module"},{"line_number":13,"context_line":"depends on the v2.shell class, so move that module to v3, update the"},{"line_number":14,"context_line":"v3 AvailablityZone class, and make appropriate adjustments to the"},{"line_number":15,"context_line":"tests and test fixtures."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7a3cca15f5944141d510a75af6684221c297963b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"e0a7e5ae_fb2f2d6b","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":18},"updated":"2021-06-02 14:41:44.000000000","message":"AvailabilityZone","commit_id":"d41a42e678940e2857a26218e8bd9dacd013fdcd"}],"cinderclient/api_versions.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d9416985bb5d004ed61a0592aa41df83e3e9c305","unresolved":true,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    if not versions:"},{"line_number":246,"context_line":"        msg \u003d _(\"Server does not support microversions. You cannot use this \""},{"line_number":247,"context_line":"                \"version of the cinderclient with the requested server.\")"},{"line_number":248,"context_line":"        raise exceptions.UnsupportedVersion(msg)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    for version in versions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"e98a84e6_86314ea2","line":247,"updated":"2021-06-11 16:05:11.000000000","message":"Is this a case where the user would have to downgrade the client in order to talk to the older cinder api versions?   If so, then we should probably state that.","commit_id":"d41a42e678940e2857a26218e8bd9dacd013fdcd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7776b4c9d52564f23a6078640905ae611dc7e596","unresolved":true,"context_lines":[{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    if not versions:"},{"line_number":246,"context_line":"        msg \u003d _(\"Server does not support microversions. You cannot use this \""},{"line_number":247,"context_line":"                \"version of the cinderclient with the requested server.\")"},{"line_number":248,"context_line":"        raise exceptions.UnsupportedVersion(msg)"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"    for version in versions:"}],"source_content_type":"text/x-python","patch_set":2,"id":"de60c0da_2140eb57","line":247,"in_reply_to":"e98a84e6_86314ea2","updated":"2021-07-13 03:05:54.000000000","message":"Good point, will revise.","commit_id":"d41a42e678940e2857a26218e8bd9dacd013fdcd"}],"cinderclient/client.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8096e9b5ad9a975592997bfa1bc8af29b48d98ec","unresolved":true,"context_lines":[{"line_number":855,"context_line":""},{"line_number":856,"context_line":"    Here ``VERSION`` can be a string or"},{"line_number":857,"context_line":"    ``cinderclient.api_versions.APIVersion`` obj. If you prefer string value,"},{"line_number":858,"context_line":"    you can use ``3`` or ``3.X`` (where X is a microversion)."},{"line_number":859,"context_line":""},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"    Alternatively, you can create a client instance using the keystoneclient"}],"source_content_type":"text/x-python","patch_set":3,"id":"a7037c84_64106158","line":858,"range":{"start_line":858,"start_character":16,"end_line":858,"end_character":21},"updated":"2021-07-16 15:07:35.000000000","message":"i think 3.X covers 3.0 too but I don\u0027t mind this","commit_id":"3502a5591a654ae57741c6738994ffa9d8457696"}],"cinderclient/shell.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"d9416985bb5d004ed61a0592aa41df83e3e9c305","unresolved":true,"context_lines":[{"line_number":829,"context_line":"        API_MAX_VERSION \u003d api_versions.APIVersion(api_versions.MAX_VERSION)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        if (discovered_version !\u003d API_MAX_VERSION or"},{"line_number":832,"context_line":"                os_service_type !\u003d \u0027volume\u0027 or"},{"line_number":833,"context_line":"                os_endpoint_type !\u003d DEFAULT_CINDER_ENDPOINT_TYPE):"},{"line_number":834,"context_line":"            client_args[\u0027service_type\u0027] \u003d os_service_type"},{"line_number":835,"context_line":"            client_args[\u0027endpoint_type\u0027] \u003d os_endpoint_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"446ed093_49ea35f9","line":832,"updated":"2021-06-11 16:05:11.000000000","message":"shouldn\u0027t we also include volumev2 here and force the _discover_service_type to not allow volume and volumev2 ?","commit_id":"d41a42e678940e2857a26218e8bd9dacd013fdcd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7776b4c9d52564f23a6078640905ae611dc7e596","unresolved":true,"context_lines":[{"line_number":829,"context_line":"        API_MAX_VERSION \u003d api_versions.APIVersion(api_versions.MAX_VERSION)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"        if (discovered_version !\u003d API_MAX_VERSION or"},{"line_number":832,"context_line":"                os_service_type !\u003d \u0027volume\u0027 or"},{"line_number":833,"context_line":"                os_endpoint_type !\u003d DEFAULT_CINDER_ENDPOINT_TYPE):"},{"line_number":834,"context_line":"            client_args[\u0027service_type\u0027] \u003d os_service_type"},{"line_number":835,"context_line":"            client_args[\u0027endpoint_type\u0027] \u003d os_endpoint_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"fb716305_ee88a0b1","line":832,"in_reply_to":"446ed093_49ea35f9","updated":"2021-07-13 03:05:54.000000000","message":"if the user didn\u0027t specify an os_service_type, line 827 will set it to volumev3 because by the time we reach line 826, an UnsupportedVersion would have been raised if the user didn\u0027t specify 3.x or the catalog endpoint wasn\u0027t 3.x.  So in that case we\u0027ll wind up creating a new v3 client to return\n\nI think the check at line 832 was added when DEPRECATED_VERSIONS \u003d {\"1\": \"2\"}, and os_service_type would have been set to \u0027volume\u0027 at line 813 in the base change in the left column of this diff, and that code wasn\u0027t updated when v1 support was removed.  So it looks like for the past few cycles, os_service_type has been set to \u0027volume\u0027 for v2, which I think didn\u0027t matter because the current_client at this point would be a v2 client anyway.\n\nIn any case, this section of the shell definitely needs a refactor, because it seems way over complicated.  I\u0027m really hesitant to change this now because it has been working for v3.","commit_id":"d41a42e678940e2857a26218e8bd9dacd013fdcd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8096e9b5ad9a975592997bfa1bc8af29b48d98ec","unresolved":true,"context_lines":[{"line_number":758,"context_line":"                               \"the endpoint URL. Falling back to the \""},{"line_number":759,"context_line":"                               \"user-specified version: %s\","},{"line_number":760,"context_line":"                               endpoint_api_version)"},{"line_number":761,"context_line":"            elif endpoint_api_version:"},{"line_number":762,"context_line":"                logger.warning(\"Cannot determine the API version from the \""},{"line_number":763,"context_line":"                               \"endpoint URL or user input. Falling back \""},{"line_number":764,"context_line":"                               \"to the default API version: %s\","},{"line_number":765,"context_line":"                               endpoint_api_version)"},{"line_number":766,"context_line":"            else:"},{"line_number":767,"context_line":"                msg \u003d _(\"Cannot determine API version.  Please specify by \""},{"line_number":768,"context_line":"                        \"using --os-volume-api-version option.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"160437b3_1de6b8f9","line":765,"range":{"start_line":761,"start_character":0,"end_line":765,"end_character":52},"updated":"2021-07-16 15:07:35.000000000","message":"if api_version_input is always true, we will only reach this if endpoint_api_version is False and this part will never be executed so no need to keep this","commit_id":"3502a5591a654ae57741c6738994ffa9d8457696"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fa1dfdf9d7d389e973f9b1e6f225f57ac375e211","unresolved":true,"context_lines":[{"line_number":758,"context_line":"                               \"the endpoint URL. Falling back to the \""},{"line_number":759,"context_line":"                               \"user-specified version: %s\","},{"line_number":760,"context_line":"                               endpoint_api_version)"},{"line_number":761,"context_line":"            elif endpoint_api_version:"},{"line_number":762,"context_line":"                logger.warning(\"Cannot determine the API version from the \""},{"line_number":763,"context_line":"                               \"endpoint URL or user input. Falling back \""},{"line_number":764,"context_line":"                               \"to the default API version: %s\","},{"line_number":765,"context_line":"                               endpoint_api_version)"},{"line_number":766,"context_line":"            else:"},{"line_number":767,"context_line":"                msg \u003d _(\"Cannot determine API version.  Please specify by \""},{"line_number":768,"context_line":"                        \"using --os-volume-api-version option.\")"}],"source_content_type":"text/x-python","patch_set":3,"id":"94346467_38c62ba7","line":765,"range":{"start_line":761,"start_character":0,"end_line":765,"end_character":52},"in_reply_to":"160437b3_1de6b8f9","updated":"2021-07-16 16:27:41.000000000","message":"You\u0027re right, but I figure that api_version_input not being modified is a mistake, so I left this block so in a followup someone can figure out what the logic of this is supposed to be.","commit_id":"3502a5591a654ae57741c6738994ffa9d8457696"}],"cinderclient/tests/unit/fixture_data/client.py":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"e65edd653840d7f3b9ddaad803750aee72380c93","unresolved":true,"context_lines":[{"line_number":34,"context_line":"                                   headers\u003dself.json_headers)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class V2(Base):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":40,"context_line":"        super(V2, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5410c514_f15b88cf","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":8},"updated":"2021-05-25 15:22:20.000000000","message":"Still this V2 class is required?, we are updating to v3 right.","commit_id":"d41a42e678940e2857a26218e8bd9dacd013fdcd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6d4d01cd321b21dd85a996c01027d659f5897658","unresolved":true,"context_lines":[{"line_number":34,"context_line":"                                   headers\u003dself.json_headers)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class V2(Base):"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":40,"context_line":"        super(V2, self).__init__(*args, **kwargs)"}],"source_content_type":"text/x-python","patch_set":2,"id":"441230d4_5d0eba9f","line":37,"range":{"start_line":37,"start_character":6,"end_line":37,"end_character":8},"in_reply_to":"5410c514_f15b88cf","updated":"2021-05-25 20:29:41.000000000","message":"Yes, it\u0027s required in this patch. It\u0027s removed in the followup patch: https://review.opendev.org/c/openstack/python-cinderclient/+/792959","commit_id":"d41a42e678940e2857a26218e8bd9dacd013fdcd"}],"cinderclient/tests/unit/test_shell.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8096e9b5ad9a975592997bfa1bc8af29b48d98ec","unresolved":true,"context_lines":[{"line_number":258,"context_line":"    @requests_mock.Mocker()"},{"line_number":259,"context_line":"    def test_noauth_plugin(self, mock_disco, mocker):"},{"line_number":260,"context_line":"        # just to prove i\u0027m not crazy about the mock parameter ordering"},{"line_number":261,"context_line":"        self.assertTrue(requests_mock.mocker.Mocker, type(mocker))"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"        os_volume_url \u003d \"http://example.com/volumes/v3\""},{"line_number":264,"context_line":"        mocker.register_uri(\u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"cf1ee84f_a24c1111","line":261,"range":{"start_line":261,"start_character":0,"end_line":261,"end_character":66},"updated":"2021-07-16 15:07:35.000000000","message":"Same thing happens with ddt so it\u0027s not much needed but don\u0027t mind it","commit_id":"3502a5591a654ae57741c6738994ffa9d8457696"}]}