)]}'
{"id":"openstack%2Fpython-cinderclient~802782","triplet_id":"openstack%2Fpython-cinderclient~stable%2Fwallaby~Ifbaca4aa87d890bc5130069638d42665b914b378","project":"openstack/python-cinderclient","branch":"stable/wallaby","topic":"783628-stable/wallaby","hashtags":[],"change_id":"Ifbaca4aa87d890bc5130069638d42665b914b378","subject":"Make instance_uuid optional in attachment create","status":"MERGED","created":"2021-07-29 07:43:39.000000000","updated":"2021-08-30 16:09:02.000000000","submitted":"2021-08-30 16:02:54.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"802782-783628-stable/wallaby","cherry_pick_of_change":783628,"cherry_pick_of_patch_set":8,"meta_rev_id":"fc6865a4c2a4e7ce0322b4216a0528218c86d472","_number":802782,"virtual_id_number":802782,"owner":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2021-08-30 16:02:54.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2021-08-30 14:28:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2021-08-25 20:08:30.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2021-08-30 14:28:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2021-07-29 09:14:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2021-08-02 15:51:40.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2021-08-30 14:28:50.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"43ff0329f1445e41e76a4f3684190ac89e127b33","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-07-29 07:43:39.000000000","message":"Patch Set 1: Cherry Picked from branch master.","accounts_in_message":[],"_revision_number":1},{"id":"412eb0e28d1842382decdd0840d5718b33ca2b17","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-07-29 09:14:28.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/d92b8057110d43b583ddafcf88e7c00f : SUCCESS in 1h 29m 04s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b58265bcd4544674be4d6448fcb43397 : SUCCESS in 4m 47s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/c647daf9c0da436cb2031199cd007d71 : SUCCESS in 4m 20s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/b5a7cbd4068e48ada2a3b0f546546128 : SUCCESS in 4m 38s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/21a95fa2c6c04a6db3368e11c4643c12 : SUCCESS in 5m 31s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/e52e6ffcdd974cf68a7d330ebbef79d3 : SUCCESS in 6m 08s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/de53fe2669664102a5f3f711a139724d : SUCCESS in 6m 58s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/bfeafe9373174b10a0438e54768ad066 : SUCCESS in 4m 22s\n- python-cinderclient-functional-py36 https://zuul.opendev.org/t/openstack/build/211402b0ed3e4a129ffc3442eeeaaed2 : SUCCESS in 36m 23s\n- python-cinderclient-functional-py38 https://zuul.opendev.org/t/openstack/build/a93d7277a2ad46b7ba2ab7a842849462 : SUCCESS in 28m 35s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/eb6cdc8f290e46be8b37d3a67ee6e21a : SUCCESS in 5m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"e6a802275cfe176725aa228af2de941594371aec","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2021-08-02 15:51:40.000000000","message":"Patch Set 1: Code-Review+1\n\nI think this is probably OK?  My worry is what happens if someone uses an updated wallaby client against a wallaby cinder that doesn\u0027t contain the corresponding fix.  I guess anyone who was already using this in wallaby will already know about the fake instance uuid workaround, so maybe it\u0027s not an issue?","accounts_in_message":[],"_revision_number":1},{"id":"c99c7942b19721f658de6286cdb6a38b15bd757d","author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"date":"2021-08-16 08:12:26.000000000","message":"Patch Set 1:\n\n\u003e Patch Set 1: Code-Review+1\n\u003e \n\u003e I think this is probably OK?  My worry is what happens if someone uses an updated wallaby client against a wallaby cinder that doesn\u0027t contain the corresponding fix.  I guess anyone who was already using this in wallaby will already know about the fake instance uuid workaround, so maybe it\u0027s not an issue?\n\nIt will fail and In that case they need to use the old syntax of providing server which we do support for backward compatibility which we also have mentioned in the releasenote.\nI think this is the case for every feature that we add client commands for, which requires the API changes to work, so it\u0027s a very common scenario.","accounts_in_message":[],"_revision_number":1},{"id":"bc07b49a76cb7a7509dcc7fa9861f473cee0bd83","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2021-08-25 20:08:30.000000000","message":"Patch Set 1: Code-Review+2\n\nOK, works for me.","accounts_in_message":[],"_revision_number":1},{"id":"50ca66c3eadf630f078b48a772e915c2836483ab","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2021-08-30 14:28:50.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nMerged to master, makes sense to backport to address the issue pointed out (though would have been better to have an actual bug report to refer to).","accounts_in_message":[],"_revision_number":1},{"id":"374a5e199d6133967fae512acdecea2d74408e4f","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-30 14:29:28.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"6d13bd2978ee941191ea609e94981bf42bed330e","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-30 16:02:54.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/d31bad0040db49688760e860029a46d3 : SUCCESS in 1h 30m 54s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1d25f50ffc4d422f92cd05c3ea442dec : SUCCESS in 5m 29s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d878ea0059b8443ea975223f5b69b75a : SUCCESS in 4m 59s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/5dc6cf56a57b4680b988805af9a2b8da : SUCCESS in 5m 04s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bcc9990793ef4601b3cb197b5913e7ee : SUCCESS in 7m 21s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/d053595e0a1c493b8bd84030beca1685 : SUCCESS in 5m 11s","accounts_in_message":[],"_revision_number":1},{"id":"e17526c7faeb4774f66064e2c5895d4914c0e5e5","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-30 16:02:54.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"fc6865a4c2a4e7ce0322b4216a0528218c86d472","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2021-08-30 16:09:02.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/74e19780220d4b94812e07513c7c59e2 : SUCCESS in 1m 16s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/bf980b66c880409e8031a3fe7c7b4c2a : SUCCESS in 58s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"aba49e1b275f8a43cb808e394d6847de5928ef02","revisions":{"aba49e1b275f8a43cb808e394d6847de5928ef02":{"kind":"REWORK","_number":1,"created":"2021-07-29 07:43:39.000000000","uploader":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"ref":"refs/changes/82/802782/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/82/802782/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/82/802782/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/82/802782/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/82/802782/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/82/802782/1"}}},"commit":{"parents":[{"commit":"4c6c3b49b5334518be1b776d32fada394743142f","subject":"Remove skip_missing_interpreters","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/4c6c3b49b5334518be1b776d32fada394743142f"}]}],"author":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2021-03-29 10:31:31.000000000","tz":-240},"committer":{"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","date":"2021-07-29 07:43:39.000000000","tz":0},"subject":"Make instance_uuid optional in attachment create","message":"Make instance_uuid optional in attachment create\n\nCinder and cinderclient assumes an attachment create request will\nalways contain instance_uuid. This is not true when glance calls\ncinder for attachment in glance cinder configuration.\nThis patch (along with the cinder patch) make the instance_uuid\noptional and allow glance to do attachments without passing\ninstance_uuid.\n\nChange-Id: Ifbaca4aa87d890bc5130069638d42665b914b378\n(cherry picked from commit d714249ca9e95297f5e53c9dcc0af9ba58d0ab6d)\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/aba49e1b275f8a43cb808e394d6847de5928ef02"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/aba49e1b275f8a43cb808e394d6847de5928ef02"}]},"branch":"refs/heads/stable/wallaby"}},"requirements":[],"submit_records":[{"status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Verified\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Workflow","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Workflow\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Workflow\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}},{"name":"Code-Review","status":"SATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dCustom-Rule","fulfilled":true,"status":"PASS","passing_atoms":["label:Code-Review\u003dCustom-Rule"],"failing_atoms":[],"atom_explanations":{}}}]}