)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4e8ae1aaa025a995f3f5bfa130f674fff146bdeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6462008e_83eb7d7d","updated":"2021-11-02 16:58:29.000000000","message":"Looks like a good start.  Some suggestions inline.","commit_id":"e5ced801c05d4f8b1a9b27d6943a708f0e160987"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dc0bf90f0cfb8432dc64c788fb8fe17990c8ba69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f3bcda10_4759f125","updated":"2021-11-19 16:46:06.000000000","message":"Just realized that even though this touches .py files, it\u0027s really a documentation change, and hence only requires a single +2.","commit_id":"e268778d3efd449ed88de7744005b228751d2a0a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"020a11e91cd9272cd3210da912d9241401e06f71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"57c34eb1_733ae360","updated":"2021-11-17 16:14:04.000000000","message":"LGTM!  To save other reviewers some time, this is what the help output looks like now:\n\nhttps://paste.opendev.org/show/811139/","commit_id":"e268778d3efd449ed88de7744005b228751d2a0a"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"ff92222ff139b68898c0a2933cb0429f0f143d0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0014b436_1db097b4","updated":"2021-11-19 16:47:07.000000000","message":"Thanks for adding more detailed text on the help +2","commit_id":"e268778d3efd449ed88de7744005b228751d2a0a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b2a785a9ea1af068b32fb9e93309babebf598139","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e126ad03_a8d86c32","updated":"2021-11-08 14:55:15.000000000","message":"Thanks for the suggestions Brian. I\u0027ve updated the help text.","commit_id":"e268778d3efd449ed88de7744005b228751d2a0a"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4e8ae1aaa025a995f3f5bfa130f674fff146bdeb","unresolved":true,"context_lines":[{"line_number":649,"context_line":"@utils.arg(\u0027--volume-type\u0027,"},{"line_number":650,"context_line":"           metavar\u003d\u0027\u003cvolume-type\u003e\u0027,"},{"line_number":651,"context_line":"           default\u003dNone,"},{"line_number":652,"context_line":"           help\u003d\u0027Volume type. Default can be the type set as project default \u0027"},{"line_number":653,"context_line":"                \u0027or value of default_volume_type set in cinder.conf. The \u0027"},{"line_number":654,"context_line":"                \u0027default_volume_type parameter points to __DEFAULT__ type by \u0027"},{"line_number":655,"context_line":"                \u0027default.\u0027)"},{"line_number":656,"context_line":"@utils.arg(\u0027--volume_type\u0027,"},{"line_number":657,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":658,"context_line":"@utils.arg(\u0027--availability-zone\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ca429de6_d47f045e","line":655,"range":{"start_line":652,"start_character":0,"end_line":655,"end_character":27},"updated":"2021-11-02 16:58:29.000000000","message":"I think we don\u0027t want to make a big deal about __DEFAULT__ here ... the point is to make it clear that if you don\u0027t specify a volume type as part of this call, you\u0027re still going to get a volume type, and what type depends on how cinder is configured.  So maybe something like this:\n\n  help\u003d\u0027Volume type. Default\u003dNone, that is, use the default \u0027\n       \u0027volume type configured for the Block Storage API.  You \u0027\n       \"can see what type this is by using the \u0027cinder type-default\u0027 \"\n       \u0027command.\u0027)","commit_id":"e5ced801c05d4f8b1a9b27d6943a708f0e160987"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b2a785a9ea1af068b32fb9e93309babebf598139","unresolved":false,"context_lines":[{"line_number":649,"context_line":"@utils.arg(\u0027--volume-type\u0027,"},{"line_number":650,"context_line":"           metavar\u003d\u0027\u003cvolume-type\u003e\u0027,"},{"line_number":651,"context_line":"           default\u003dNone,"},{"line_number":652,"context_line":"           help\u003d\u0027Volume type. Default can be the type set as project default \u0027"},{"line_number":653,"context_line":"                \u0027or value of default_volume_type set in cinder.conf. The \u0027"},{"line_number":654,"context_line":"                \u0027default_volume_type parameter points to __DEFAULT__ type by \u0027"},{"line_number":655,"context_line":"                \u0027default.\u0027)"},{"line_number":656,"context_line":"@utils.arg(\u0027--volume_type\u0027,"},{"line_number":657,"context_line":"           help\u003dargparse.SUPPRESS)"},{"line_number":658,"context_line":"@utils.arg(\u0027--availability-zone\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7be227e_ccc73886","line":655,"range":{"start_line":652,"start_character":0,"end_line":655,"end_character":27},"in_reply_to":"ca429de6_d47f045e","updated":"2021-11-08 14:55:15.000000000","message":"Done","commit_id":"e5ced801c05d4f8b1a9b27d6943a708f0e160987"}],"cinderclient/v3/shell_base.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4e8ae1aaa025a995f3f5bfa130f674fff146bdeb","unresolved":true,"context_lines":[{"line_number":693,"context_line":""},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"def do_type_default(cs, args):"},{"line_number":696,"context_line":"    \"\"\"List the default volume type.\"\"\""},{"line_number":697,"context_line":"    vtype \u003d cs.volume_types.default()"},{"line_number":698,"context_line":"    shell_utils.print_volume_type_list([vtype])"},{"line_number":699,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"e6f9e746_c0da2a50","line":696,"range":{"start_line":696,"start_character":4,"end_line":696,"end_character":39},"updated":"2021-11-02 16:58:29.000000000","message":"Maybe enhance this help text so it\u0027s clear that the default type may be different for different users.  Something like:\n\n  \"\"\"List the default volume type.\n  \n     The Block Storage service allows configuration of a default\n     type for each project, as well as the system default, so use\n     this command to determine what your effective default volume\n     type is.\n     \"\"\"","commit_id":"e5ced801c05d4f8b1a9b27d6943a708f0e160987"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b2a785a9ea1af068b32fb9e93309babebf598139","unresolved":false,"context_lines":[{"line_number":693,"context_line":""},{"line_number":694,"context_line":""},{"line_number":695,"context_line":"def do_type_default(cs, args):"},{"line_number":696,"context_line":"    \"\"\"List the default volume type.\"\"\""},{"line_number":697,"context_line":"    vtype \u003d cs.volume_types.default()"},{"line_number":698,"context_line":"    shell_utils.print_volume_type_list([vtype])"},{"line_number":699,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a70473fe_524c3c79","line":696,"range":{"start_line":696,"start_character":4,"end_line":696,"end_character":39},"in_reply_to":"e6f9e746_c0da2a50","updated":"2021-11-08 14:55:15.000000000","message":"Done","commit_id":"e5ced801c05d4f8b1a9b27d6943a708f0e160987"}]}