)]}'
{"id":"openstack%2Fpython-cinderclient~851467","triplet_id":"openstack%2Fpython-cinderclient~master~I2d4cb81a394f3c10e5f01945d894746a904fb5df","project":"openstack/python-cinderclient","branch":"master","topic":"py311","attention_set":{},"removed_from_attention_set":{"8122":{"account":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"last_update":"2022-12-12 23:13:37.000000000","reason":"Change was submitted"}},"hashtags":[],"change_id":"I2d4cb81a394f3c10e5f01945d894746a904fb5df","subject":"Python3.11: Fix argparse-related test failures","status":"MERGED","created":"2022-07-28 19:46:54.000000000","updated":"2022-12-12 23:14:33.000000000","submitted":"2022-12-12 23:13:37.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":3,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"851467-py311","meta_rev_id":"192f1884baacf13137896f969fc2f507c88d12cc","_number":851467,"virtual_id_number":851467,"owner":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2022-12-12 23:13:37.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"recommended":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"all":[{"value":1,"date":"2022-12-12 08:29:40.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2022-11-09 15:39:24.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":1,"date":"2022-09-29 09:35:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},{"value":2,"date":"2022-12-12 21:39:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":1,"date":"2022-07-28 20:24:38.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},{"value":1,"date":"2022-12-12 21:39:23.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},{"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2022-07-28 20:24:38.000000000","updated_by":{"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"},"reviewer":{"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"},"state":"REVIEWER"},{"updated":"2022-07-28 21:33:54.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2022-09-29 09:35:39.000000000","updated_by":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"reviewer":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"state":"REVIEWER"},{"updated":"2022-11-09 15:39:24.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2022-12-12 08:29:40.000000000","updated_by":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"reviewer":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"state":"REVIEWER"},{"updated":"2022-12-12 21:39:23.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"}],"messages":[{"id":"c1962fe17e5214dcdca2c0c27494bf63bcab2816","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"date":"2022-07-28 19:46:54.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"596a9529a80dfaaf5242d9e73e90288649138368","author":{"_account_id":34275,"name":"Jorge Merlino","email":"jorge.merlino@canonical.com","username":"drencrom"},"date":"2022-07-28 20:24:38.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6a25bcb50e429d28cfbf2d57a6fdb6cd2793eb96","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-07-28 21:33:54.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/e2d7ee79496d4948b743615425e06411\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/c89dff9111f742ea9829e44c75e0efb9 : SUCCESS in 1h 44m 01s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/92090c8b7a87431bb5656cc2763afd3c : SUCCESS in 6m 50s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/e23c2be34ef5482899175167ff907abf : SUCCESS in 5m 53s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/f4b23ef26ee64886932808127a82edd3 : SUCCESS in 6m 53s\n- openstack-tox-py39 https://zuul.opendev.org/t/openstack/build/3e65507073954b65828defd8827c6249 : SUCCESS in 6m 41s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/1e44144672c34c0cb3f1e6b6eec68fce : RETRY_LIMIT in 2m 33s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/858eef543d0549f3a202d16977e9db38 : SUCCESS in 8m 18s\n- openstack-tox-pylint https://zuul.opendev.org/t/openstack/build/f93ed1565e644d3abcf2335bbc3e237b : SUCCESS in 7m 42s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"70e485737ac4cb5a86ec0807d125f661f12788d1","author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"date":"2022-09-29 09:35:39.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"04034392c058012399392b2c348b2a423ee02bd7","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2022-11-09 15:39:24.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"3901a6a14c16257e5ef7a8f84830ec5dd8e61e24","author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"date":"2022-12-12 08:29:40.000000000","message":"Patch Set 1: Code-Review+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"afcfa77422ff0e2e55c515b4a3b84de11c37a517","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2022-12-12 21:39:23.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"617f8d3b637ee5b40e5ff9888c118f14c73afad6","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-12 21:39:50.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"14362b21e3e7b46d478a2c57cabe439cfa5427be","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-12 23:13:37.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8f2cd79d1fb347deaf2b026b5baa1357\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/c21ecdd6b5c742e69d989ba4d815538f : SUCCESS in 1h 33m 13s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/0dee6d8a8d964b60b5bbbee08ba9015d : SUCCESS in 2m 56s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/d1440f95bd454f80b155c000b30194b5 : SUCCESS in 3m 08s\n- openstack-tox-py310 https://zuul.opendev.org/t/openstack/build/b381bb3e8de6440dae1cd78d538b8ca3 : SUCCESS in 2m 44s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/6ff960bef2354bea814d0ffd0e95ee43 : SUCCESS in 4m 15s","accounts_in_message":[],"_revision_number":1},{"id":"40349ab848636077a764169f6d8b434d0c473444","tag":"autogenerated:gerrit:merged","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-12 23:13:37.000000000","message":"Change has been successfully merged","accounts_in_message":[],"_revision_number":1},{"id":"192f1884baacf13137896f969fc2f507c88d12cc","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2022-12-12 23:14:33.000000000","message":"Patch Set 1:\n\nBuild succeeded (promote pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/8a91c6c488564759bdc3e3fb6d371c0c\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/0d8496e24e684a2981f6c552625aa7d1 : SUCCESS in 38s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"90eb9d2be62b5eef179edc7d5ab2cb424a6119e0","revisions":{"90eb9d2be62b5eef179edc7d5ab2cb424a6119e0":{"kind":"REWORK","_number":1,"created":"2022-07-28 19:46:54.000000000","uploader":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"ref":"refs/changes/67/851467/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/67/851467/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/67/851467/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/67/851467/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/67/851467/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/67/851467/1"}}},"commit":{"parents":[{"commit":"1f3b6634857e346e2be225a5552469213f329194","subject":"Fix extension loading from python path","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/1f3b6634857e346e2be225a5552469213f329194"}]}],"author":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2022-07-28 18:48:58.000000000","tz":120},"committer":{"name":"Cyril Roelandt","email":"cyril@redhat.com","date":"2022-07-28 19:46:35.000000000","tz":120},"subject":"Python3.11: Fix argparse-related test failures","message":"Python3.11: Fix argparse-related test failures\n\nIn Python3.11, the following code crashes:\n\n$ cat test.py\nimport argparse\n\nparser \u003d argparse.ArgumentParser(description\u003d\u0027Short sample app\u0027)\nsubparsers \u003d parser.add_subparsers()\nsubparsers.add_parser(\u0027foo\u0027)\nsubparsers.add_parser(\u0027foo\u0027)\n\n$ python3.11 test.py\nTraceback (most recent call last):\n  File \"/tmp/arg.py\", line 6, in \u003cmodule\u003e\n    subparsers.add_parser(\u0027foo\u0027)\n  File \"/usr/lib/python3.11/argparse.py\", line 1197, in add_parser\n    raise ArgumentError(self, _(\u0027conflicting subparser: %s\u0027) % name)\nargparse.ArgumentError: argument {foo}: conflicting subparser: foo\n\nIt is now forbidden to use add_parser() multiple times with the same\narguments, which is exactly what we do in the following tests:\n\n- cinderclient.tests.unit.test_shell.TestLoadVersionedActions.test_load_versioned_actions\n- cinderclient.tests.unit.test_shell.TestLoadVersionedActions.test_load_actions_with_versioned_args\n\nIn order to fix the tests failures, we make sure to reset the parser and\nsubparsers before calling add_parser().\n\nWhile not strictly necessary, we split those tests into two functions,\nfor readability purposes.\n\nCloses-Bug: #1983054\nChange-Id: I2d4cb81a394f3c10e5f01945d894746a904fb5df\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/90eb9d2be62b5eef179edc7d5ab2cb424a6119e0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/90eb9d2be62b5eef179edc7d5ab2cb424a6119e0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"CLOSED","labels":[{"label":"Verified","status":"OK","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"OK","applied_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}},{"label":"Workflow","status":"OK","applied_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[]}