)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"f3c5e2d814a234d35539e1b03780c37e994a6cc1","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix cinderclient group type update error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using cinder group-type-update to update group type name, descriptioin or is_public，"},{"line_number":10,"context_line":"if is_public is not given (None will be assigned), it will be set to False by error."},{"line_number":11,"context_line":"For example command like \u0027cinder group-type-update 1234\u0027 will update is_public to false but not raise an exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is caused by calling bool_from_string() without checking whether argument \u0027is_public\u0027 is None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"c748bd27_faa186ae","line":10,"range":{"start_line":10,"start_character":50,"end_line":10,"end_character":84},"updated":"2022-12-01 14:21:03.000000000","message":"Sorry if my question doesn\u0027t make sense but in order to update a group type you should have a system-admin role or credentials. I think it makes sense to set False by default.","commit_id":"8009f114ab44b55316d79f82bac3905e68cc391b"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"d30791799a4f361e4abd8eee704ff9bfc8be4b49","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix cinderclient group type update error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using cinder group-type-update to update group type name, descriptioin or is_public，"},{"line_number":10,"context_line":"if is_public is not given (None will be assigned), it will be set to False by error."},{"line_number":11,"context_line":"For example command like \u0027cinder group-type-update 1234\u0027 will update is_public to false but not raise an exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is caused by calling bool_from_string() without checking whether argument \u0027is_public\u0027 is None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"b9c5adf1_824f8e27","line":10,"range":{"start_line":10,"start_character":50,"end_line":10,"end_character":84},"in_reply_to":"49fa0732_e047c814","updated":"2022-12-05 18:29:10.000000000","message":"What about this scenario: I\u0027d like to update a group type name that originally is private but I don\u0027t pass the is_public as you mentioned in the commit message. This patch would update it to is_public\u003dNone?","commit_id":"8009f114ab44b55316d79f82bac3905e68cc391b"},{"author":{"_account_id":35495,"name":"wanghelin","email":"wanghelin_yewu@cmss.chinamobile.com","username":"wanghelin"},"change_message_id":"2ffe07f7d0e9c5f7c62c01ef3f3d2917234b2473","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix cinderclient group type update error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using cinder group-type-update to update group type name, descriptioin or is_public，"},{"line_number":10,"context_line":"if is_public is not given (None will be assigned), it will be set to False by error."},{"line_number":11,"context_line":"For example command like \u0027cinder group-type-update 1234\u0027 will update is_public to false but not raise an exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is caused by calling bool_from_string() without checking whether argument \u0027is_public\u0027 is None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d866350f_a9cc0982","line":10,"range":{"start_line":10,"start_character":50,"end_line":10,"end_character":84},"in_reply_to":"b9c5adf1_824f8e27","updated":"2022-12-12 02:35:19.000000000","message":"No, is_public will remain unchanged, since is_public is not passed.","commit_id":"8009f114ab44b55316d79f82bac3905e68cc391b"},{"author":{"_account_id":35495,"name":"wanghelin","email":"wanghelin_yewu@cmss.chinamobile.com","username":"wanghelin"},"change_message_id":"3dc1ab465c54c9c0133124a31beed878ece1f094","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix cinderclient group type update error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using cinder group-type-update to update group type name, descriptioin or is_public，"},{"line_number":10,"context_line":"if is_public is not given (None will be assigned), it will be set to False by error."},{"line_number":11,"context_line":"For example command like \u0027cinder group-type-update 1234\u0027 will update is_public to false but not raise an exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is caused by calling bool_from_string() without checking whether argument \u0027is_public\u0027 is None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"49fa0732_e047c814","line":10,"range":{"start_line":10,"start_character":50,"end_line":10,"end_character":84},"in_reply_to":"c748bd27_faa186ae","updated":"2022-12-02 01:34:28.000000000","message":"The current situation here is that although we don\u0027t want to change the is-public attribute, it will still get changed. I think there is a lack of checking when is_public is None.","commit_id":"8009f114ab44b55316d79f82bac3905e68cc391b"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"bf2920cc55aa2b9f8e2d45a62b57f821023037ce","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix cinderclient group type update error"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When using cinder group-type-update to update group type name, descriptioin or is_public，"},{"line_number":10,"context_line":"if is_public is not given (None will be assigned), it will be set to False by error."},{"line_number":11,"context_line":"For example command like \u0027cinder group-type-update 1234\u0027 will update is_public to false but not raise an exception."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is caused by calling bool_from_string() without checking whether argument \u0027is_public\u0027 is None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a7c52ee6_0e47e1b4","line":10,"range":{"start_line":10,"start_character":50,"end_line":10,"end_character":84},"in_reply_to":"d866350f_a9cc0982","updated":"2022-12-15 14:01:42.000000000","message":"Thanks!","commit_id":"8009f114ab44b55316d79f82bac3905e68cc391b"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"bf2920cc55aa2b9f8e2d45a62b57f821023037ce","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5c1a11e_6d221ce0","updated":"2022-12-15 14:01:42.000000000","message":"Looks good to me","commit_id":"8009f114ab44b55316d79f82bac3905e68cc391b"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"f3c5e2d814a234d35539e1b03780c37e994a6cc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28728aa0_7802a09b","updated":"2022-12-01 14:21:03.000000000","message":"Question in line","commit_id":"8009f114ab44b55316d79f82bac3905e68cc391b"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6e2ad14d4ba027bc76dab024f5d8dc41140c3948","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba39e547_1ef0f3bd","updated":"2023-02-13 17:26:19.000000000","message":"Think it would be good to have Rajat\u0027s question answered.","commit_id":"8009f114ab44b55316d79f82bac3905e68cc391b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"047f1fc4969a2b3016f30a68ccc36e490723cf7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8189d21d_223511a6","updated":"2023-02-13 16:41:30.000000000","message":"one suggestion inline","commit_id":"8009f114ab44b55316d79f82bac3905e68cc391b"}],"cinderclient/v3/shell.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"038a8b7ded4488bb67c6e00a71b88e5557700e90","unresolved":true,"context_lines":[{"line_number":873,"context_line":"    \"\"\"Updates group type name, description, and/or is_public.\"\"\""},{"line_number":874,"context_line":"    if args.is_public is not None:"},{"line_number":875,"context_line":"        is_public \u003d strutils.bool_from_string(args.is_public)"},{"line_number":876,"context_line":"    else:"},{"line_number":877,"context_line":"        is_public \u003d None"},{"line_number":878,"context_line":"    gtype \u003d cs.group_types.update(args.id, args.name, args.description,"},{"line_number":879,"context_line":"                                  is_public)"}],"source_content_type":"text/x-python","patch_set":2,"id":"564ecdee_882ace26","line":876,"range":{"start_line":876,"start_character":4,"end_line":876,"end_character":9},"updated":"2023-02-15 14:09:10.000000000","message":"The \"else\" case here is odd -- if we hit this case, it was already None, so why do we need this?","commit_id":"8009f114ab44b55316d79f82bac3905e68cc391b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"047f1fc4969a2b3016f30a68ccc36e490723cf7c","unresolved":true,"context_lines":[{"line_number":871,"context_line":"           help\u003d\u0027Make type accessible to the public or not.\u0027)"},{"line_number":872,"context_line":"def do_group_type_update(cs, args):"},{"line_number":873,"context_line":"    \"\"\"Updates group type name, description, and/or is_public.\"\"\""},{"line_number":874,"context_line":"    if args.is_public is not None:"},{"line_number":875,"context_line":"        is_public \u003d strutils.bool_from_string(args.is_public)"},{"line_number":876,"context_line":"    else:"},{"line_number":877,"context_line":"        is_public \u003d None"},{"line_number":878,"context_line":"    gtype \u003d cs.group_types.update(args.id, args.name, args.description,"},{"line_number":879,"context_line":"                                  is_public)"},{"line_number":880,"context_line":"    shell_utils.print_group_type_list([gtype])"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f3254c5_cbff9969","line":877,"range":{"start_line":874,"start_character":4,"end_line":877,"end_character":24},"updated":"2023-02-13 16:41:30.000000000","message":"I haven\u0027t tried it but does setting default\u003dNone in the --is-public option solve the issue?","commit_id":"8009f114ab44b55316d79f82bac3905e68cc391b"}]}