)]}'
{"cinderclient/shell.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"81a786a7e8fe7ab8d7861bd48a73b9ebcc9ea028","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                      \u0027subp\u0027: progparts[2]})"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _get_option_tuples(self, option_string):"},{"line_number":70,"context_line":"        result \u003d super(CinderClientArgumentParser, self)._get_option_tuples("},{"line_number":71,"context_line":"            option_string)"},{"line_number":72,"context_line":"        #If the len \u003e 1, remove all parameter that are hidden, whit this"},{"line_number":73,"context_line":"        #abbreviation only works for arguments in helps"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F5qg%3D","line":70,"updated":"2014-04-16 15:47:09.000000000","message":"Please add some docstring here to explain what this is doing and why - people browsing the code currently have no idea what this function is all about","commit_id":"82a3e2773b733ffd13173fef27d31c2fb667b52b"},{"author":{"_account_id":9450,"name":"Juan Manuel Ollé","email":"juan.m.olle@intel.com","username":"jmolle"},"change_message_id":"6a61fa2cf7631aa040ef29b59ce3baee64d4c1cc","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                      \u0027subp\u0027: progparts[2]})"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _get_option_tuples(self, option_string):"},{"line_number":70,"context_line":"        result \u003d super(CinderClientArgumentParser, self)._get_option_tuples("},{"line_number":71,"context_line":"            option_string)"},{"line_number":72,"context_line":"        #If the len \u003e 1, remove all parameter that are hidden, whit this"},{"line_number":73,"context_line":"        #abbreviation only works for arguments in helps"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAXH%2F%2F5HY%3D","line":70,"in_reply_to":"AAAAXH%2F%2F5qg%3D","updated":"2014-04-16 16:43:01.000000000","message":"Yes, sure, I will also add unit test, I upload this patch to get feedback because I was not sure about this change","commit_id":"82a3e2773b733ffd13173fef27d31c2fb667b52b"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cfbea093479c4b31dd1dda70b57f6a0d240a92d2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                      \u0027subp\u0027: progparts[2]})"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _get_option_tuples(self, option_string):"},{"line_number":70,"context_line":"        \"\"\"The idea of this method is to override the default behaviour to"},{"line_number":71,"context_line":"        avoid ambiguity in the abbreviation feature of argparse."},{"line_number":72,"context_line":"        In the case that the ambiguity is generated by 2 or more parameters"},{"line_number":73,"context_line":"        and only one is visible in the help and the others are with"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F4bE%3D","line":70,"updated":"2014-04-16 18:06:20.000000000","message":"Should have a single-line description before the longer one.","commit_id":"270cc9dd378b51d4c8d09e203adb73afb3dbecf8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cfbea093479c4b31dd1dda70b57f6a0d240a92d2","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        result \u003d super(CinderClientArgumentParser, self)._get_option_tuples("},{"line_number":81,"context_line":"            option_string)"},{"line_number":82,"context_line":"        #If the len \u003e 1, remove all parameter that are hidden, whit this"},{"line_number":83,"context_line":"        #abbreviation only works for arguments in helps"},{"line_number":84,"context_line":"        if len(result) \u003e 1:"},{"line_number":85,"context_line":"            aux \u003d [x for x in result if x[0].help !\u003d argparse.SUPPRESS]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F4b8%3D","line":82,"updated":"2014-04-16 18:06:20.000000000","message":"These comments just duplicate what the code is doing.  I\u0027d suggest removing them since the docstring will explain the \"why\" of what\u0027s going on here.","commit_id":"270cc9dd378b51d4c8d09e203adb73afb3dbecf8"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cfbea093479c4b31dd1dda70b57f6a0d240a92d2","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        #abbreviation only works for arguments in helps"},{"line_number":84,"context_line":"        if len(result) \u003e 1:"},{"line_number":85,"context_line":"            aux \u003d [x for x in result if x[0].help !\u003d argparse.SUPPRESS]"},{"line_number":86,"context_line":"            #After filtering, if there is only one, that argument is"},{"line_number":87,"context_line":"            #returned else the conflicting list is returned"},{"line_number":88,"context_line":"            if len(aux) \u003d\u003d 1:"},{"line_number":89,"context_line":"                result \u003d aux"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAXH%2F%2F4b4%3D","line":86,"updated":"2014-04-16 18:06:20.000000000","message":"Ditto","commit_id":"270cc9dd378b51d4c8d09e203adb73afb3dbecf8"}]}