)]}'
{"cloudkittyclient/v1/report/__init__.py":[{"author":{"_account_id":15917,"name":"Aaron-DH","email":"344677472@qq.com","username":"aaron"},"change_message_id":"8846e77f775ac2dd9601c30eb5d584083c61bf74","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def list_tenants(self):"},{"line_number":31,"context_line":"        return self.client.get(self.base_url + \"/tenants\").json()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_total(self, tenant_id\u003dNone, begin\u003dNone, end\u003dNone):"},{"line_number":34,"context_line":"        url \u003d self.base_url + \"/total\""},{"line_number":35,"context_line":"        if tenant_id or begin or end:"},{"line_number":36,"context_line":"            url +\u003d \"?\""}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_8f9b38c9","line":33,"updated":"2015-11-17 09:20:00.000000000","message":"the method who calls it should be changed when tenant_id came to an optional parameter?","commit_id":"7240ea72ee8f813640e936531179ebe7ef2d2308"},{"author":{"_account_id":15917,"name":"Aaron-DH","email":"344677472@qq.com","username":"aaron"},"change_message_id":"8846e77f775ac2dd9601c30eb5d584083c61bf74","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def get_total(self, tenant_id\u003dNone, begin\u003dNone, end\u003dNone):"},{"line_number":34,"context_line":"        url \u003d self.base_url + \"/total\""},{"line_number":35,"context_line":"        if tenant_id or begin or end:"},{"line_number":36,"context_line":"            url +\u003d \"?\""},{"line_number":37,"context_line":"        filtered_url \u003d [url]"},{"line_number":38,"context_line":"        if tenant_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_2fcc8c88","line":35,"updated":"2015-11-17 09:20:00.000000000","message":"judge condition will be more and more long when continue to add the query params.","commit_id":"7240ea72ee8f813640e936531179ebe7ef2d2308"},{"author":{"_account_id":7923,"name":"Gauvain Pocentek","email":"gauvainpocentek@gmail.com","username":"gpocentek"},"change_message_id":"c4a184db179f505c77034c927c5a33a0fba9ec41","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            # If we\u0027ve got parameters merge the first one"},{"line_number":44,"context_line":"            filtered_url[0] +\u003d \"?%s\" % filtered_url[1]"},{"line_number":45,"context_line":"            del filtered_url[1]"},{"line_number":46,"context_line":"        return self.client.get(\"\u0026\".join(filtered_url)).json()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_c1858ead","line":46,"updated":"2015-11-25 12:30:29.000000000","message":"I don\u0027t feel comfortable with this code, I was thinking of something like:\n\nfilters \u003d []\n\nif tenant_id: filters.append(\"tenant_id\u003d%s\" % tenant_id)\n\n...\n\nif (filters): url +\u003d \"?%s\" % (\"\u0026\".join(filters))\n\nreturn self.client.get(url).json()","commit_id":"4d5dd23a19245d1c49c920c0eb9a224a10cd42a7"}]}