)]}'
{"id":"openstack%2Fpython-cueclient~477870","triplet_id":"openstack%2Fpython-cueclient~master~Ia6b356dda4ce1b34694c2a19b4059bfb38a2e10a","project":"openstack/python-cueclient","branch":"master","topic":"six","hashtags":[],"change_id":"Ia6b356dda4ce1b34694c2a19b4059bfb38a2e10a","subject":"Replace six.iteritems() with .items()","status":"ABANDONED","created":"2017-06-27 10:07:30.000000000","updated":"2017-10-06 06:33:52.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"02291c41558fda4cf784e0c65ab2b3048a094c40","_number":477870,"virtual_id_number":477870,"owner":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":1,"date":"2017-06-27 10:22:05.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2017-10-04 09:54:57.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-27 10:22:05.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2017-10-04 09:54:57.000000000","updated_by":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"reviewer":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"state":"REVIEWER"}],"messages":[{"id":"4a23db97fc413247412f8ab09c2502d4f5f77d38","author":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"date":"2017-06-27 10:07:30.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"933cb18e5e4ce95362bb4120d9f49d9ce40a81db","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-27 10:12:01.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cueclient-docs-ubuntu-xenial http://docs-draft.openstack.org/70/477870/1/check/gate-python-cueclient-docs-ubuntu-xenial/b51cd70//doc/build/html/ : SUCCESS in 1m 55s\n- gate-python-cueclient-pep8-ubuntu-xenial http://logs.openstack.org/70/477870/1/check/gate-python-cueclient-pep8-ubuntu-xenial/ebff535/ : FAILURE in 2m 48s\n- gate-python-cueclient-python27-ubuntu-xenial http://logs.openstack.org/70/477870/1/check/gate-python-cueclient-python27-ubuntu-xenial/23c8753/ : SUCCESS in 2m 41s\n- gate-python-cueclient-python35-nv http://logs.openstack.org/70/477870/1/check/gate-python-cueclient-python35-nv/ad3ff8c/ : FAILURE in 3m 14s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"5cc0208cb7e9b87b296c42eed6cda792fe92d4af","author":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"date":"2017-06-27 10:16:18.000000000","message":"Patch Set 2: Published edit on patch set 1","accounts_in_message":[],"_revision_number":2},{"id":"8691017469ac7d02cec227e4bd42f2e8d3ae2478","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-27 10:22:05.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cueclient-docs-ubuntu-xenial http://docs-draft.openstack.org/70/477870/2/check/gate-python-cueclient-docs-ubuntu-xenial/0ca9667//doc/build/html/ : SUCCESS in 3m 32s\n- gate-python-cueclient-pep8-ubuntu-xenial http://logs.openstack.org/70/477870/2/check/gate-python-cueclient-pep8-ubuntu-xenial/79c51a1/ : SUCCESS in 2m 23s\n- gate-python-cueclient-python27-ubuntu-xenial http://logs.openstack.org/70/477870/2/check/gate-python-cueclient-python27-ubuntu-xenial/f52c659/ : SUCCESS in 2m 36s\n- gate-python-cueclient-python35-nv http://logs.openstack.org/70/477870/2/check/gate-python-cueclient-python35-nv/1e2371f/ : FAILURE in 3m 25s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"e9fcbf7f8920a332374fe786fd40f521aa3bf38d","author":{"_account_id":25903,"name":"Vu Cong Tuan","email":"tuanvc@vn.fujitsu.com","username":"tuanvu"},"date":"2017-10-04 09:54:57.000000000","message":"Patch Set 2: Code-Review-1\n\nDuplicated with https://review.openstack.org/#/c/408927/","accounts_in_message":[],"_revision_number":2},{"id":"bc0d3dc36045f349df1c0669c7edd0da56138532","author":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"date":"2017-10-06 06:33:52.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"2f8e993fb76c8cd43dc42c219709b5ed71c111b8","revisions":{"8626e629dae78fb70a61cf574bcd5105b8ac680a":{"kind":"REWORK","_number":1,"created":"2017-06-27 10:07:30.000000000","uploader":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"ref":"refs/changes/70/477870/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cueclient","ref":"refs/changes/70/477870/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cueclient refs/changes/70/477870/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cueclient refs/changes/70/477870/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cueclient refs/changes/70/477870/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cueclient refs/changes/70/477870/1"}}},"commit":{"parents":[{"commit":"bb1f4adca021247dcb5620f9e1c2667012dd5bc2","subject":"Switch to keystoneauth","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cueclient/commit/bb1f4adca021247dcb5620f9e1c2667012dd5bc2"}]}],"author":{"name":"Kiran_totad","email":"kiran.totad@nectechnologies.in","date":"2017-06-27 10:06:52.000000000","tz":330},"committer":{"name":"Kiran_totad","email":"kiran.totad@nectechnologies.in","date":"2017-06-27 10:08:50.000000000","tz":330},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1. As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators in\nPY3 as well. And dict.items/keys will more readable.\n2. In py2, the performance about list should be negligible, see the link [2].\n\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: Ia6b356dda4ce1b34694c2a19b4059bfb38a2e10a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cueclient/commit/8626e629dae78fb70a61cf574bcd5105b8ac680a"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cueclient/commit/8626e629dae78fb70a61cf574bcd5105b8ac680a"}]},"branch":"refs/heads/master"},"2f8e993fb76c8cd43dc42c219709b5ed71c111b8":{"kind":"REWORK","_number":2,"created":"2017-06-27 10:16:18.000000000","uploader":{"_account_id":24924,"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","username":"Kiran_totad"},"ref":"refs/changes/70/477870/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cueclient","ref":"refs/changes/70/477870/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cueclient refs/changes/70/477870/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cueclient refs/changes/70/477870/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cueclient refs/changes/70/477870/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cueclient refs/changes/70/477870/2"}}},"commit":{"parents":[{"commit":"bb1f4adca021247dcb5620f9e1c2667012dd5bc2","subject":"Switch to keystoneauth","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cueclient/commit/bb1f4adca021247dcb5620f9e1c2667012dd5bc2"}]}],"author":{"name":"Kiran_totad","email":"kiran.totad@nectechnologies.in","date":"2017-06-27 10:06:52.000000000","tz":330},"committer":{"name":"Kiran Totad","email":"kiran.totad@nectechnologies.in","date":"2017-06-27 10:16:14.000000000","tz":0},"subject":"Replace six.iteritems() with .items()","message":"Replace six.iteritems() with .items()\n\n1. As mentioned in [1], we should avoid using six.iteritems to achieve\niterators. We can use dict.items instead, as it will return iterators in\nPY3 as well. And dict.items/keys will more readable.\n2. In py2, the performance about list should be negligible, see the link [2].\n\n[1] https://wiki.openstack.org/wiki/Python3\n[2] http://lists.openstack.org/pipermail/openstack-dev/2015-June/066391.html\n\nChange-Id: Ia6b356dda4ce1b34694c2a19b4059bfb38a2e10a\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cueclient/commit/2f8e993fb76c8cd43dc42c219709b5ed71c111b8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cueclient/commit/2f8e993fb76c8cd43dc42c219709b5ed71c111b8"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}