)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"168239022c52152aa3ce2f49c4f3132ac468c7f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ea9c8749_8488cc2c","updated":"2021-11-26 09:26:34.000000000","message":"# openstack --os-accelerator-api-version 2.1 accelerator device profile show afexample_3\nNo DeviceProfile found for afexample_3: Client Error for url: http://172.23.97.140/accelerator/v2/device_profiles/afexample_3, Request not acceptable. The minimal required API version should be 2.2\n","commit_id":"6543b7a6c6a229714150711a958ec2aa6333b1fc"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"71a6b0923283a58daa9552b73c29a4a6b55446f5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eff02c99_8e942ded","updated":"2021-11-26 09:23:20.000000000","message":"# openstack --os-accelerator-api-version 2.2 accelerator device profile show afexample_3\n/usr/lib/python3/dist-packages/secretstorage/dhcrypto.py:15: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead\n  from cryptography.utils import int_from_bytes\n/usr/lib/python3/dist-packages/secretstorage/util.py:19: CryptographyDeprecationWarning: int_from_bytes is deprecated, use int.from_bytes instead\n  from cryptography.utils import int_from_bytes\n+-------------+------------------------------------------------------------------------------------------------------------------------------+\n| Field       | Value                                                                                                                        |\n+-------------+------------------------------------------------------------------------------------------------------------------------------+\n| created_at  | 2021-11-24 02:22:30+00:00                                                                                                    |\n| updated_at  | None                                                                                                                         |\n| uuid        | 0a6b98c6-e4ae-4abc-b5e7-662aadb1c90f                                                                                         |\n| name        | afexample_3                                                                                                                  |\n| groups      | [{\u0027resources:CUSTOM_ACCELERATOR_FPGA\u0027: \u00271\u0027, \u0027trait:CUSTOM_FPGA_1\u0027: \u0027required\u0027, \u0027trait:CUSTOM_FUNCTION_ID_3AFB\u0027: \u0027required\u0027}] |\n| description |                                                                                                                              |\n+-------------+------------------------------------------------------------------------------------------------------------------------------+","commit_id":"6543b7a6c6a229714150711a958ec2aa6333b1fc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"30bc69f0dd019a79b811c61fb22ee905f6843f4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"501e5554_9a292819","updated":"2021-11-30 02:29:17.000000000","message":"LGTM, thanks.","commit_id":"6543b7a6c6a229714150711a958ec2aa6333b1fc"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"07a570cc8775b0f2606ddc381d911cf52e87e84c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8cbbfa51_22562cb5","updated":"2021-12-01 00:33:06.000000000","message":"Latest output:\n# openstack --os-accelerator-api-version 2.2 accelerator device profile show afexample_3\n+-------------+------------------------------------------------------------------------------------------------------------------------------+\n| Field       | Value                                                                                                                        |\n+-------------+------------------------------------------------------------------------------------------------------------------------------+\n| created_at  | 2021-11-24 02:22:30+00:00                                                                                                    |\n| updated_at  | None                                                                                                                         |\n| uuid        | 0a6b98c6-e4ae-4abc-b5e7-662aadb1c90f                                                                                         |\n| name        | afexample_3                                                                                                                  |\n| groups      | [{\u0027resources:CUSTOM_ACCELERATOR_FPGA\u0027: \u00271\u0027, \u0027trait:CUSTOM_FPGA_1\u0027: \u0027required\u0027, \u0027trait:CUSTOM_FUNCTION_ID_3AFB\u0027: \u0027required\u0027}] |\n| description |                                                                                                                              |\n+-------------+------------------------------------------------------------------------------------------------------------------------------+\n(venvs) root@devstack01:/opt/stack/python-cyborgclient# openstack --os-accelerator-api-version 2.1 accelerator device profile show afexample_3\nRequest not acceptable. The minimal required API version should be 2.2 (HTTP 406)","commit_id":"92ebedc085afd9e0dc70262e73a53e3a1aa4f86e"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"6a2b3db231e444243b562bdada761c2bd8ea1e48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"075e1873_2cbe74bd","updated":"2021-12-01 07:40:35.000000000","message":"soft -1 for one nit./","commit_id":"92ebedc085afd9e0dc70262e73a53e3a1aa4f86e"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"ea7afddc59c1b82043af56c1a2b037ac3e5d38e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e5f7c17b_622670f0","updated":"2021-12-08 03:30:16.000000000","message":"LGTM thanks.","commit_id":"e1cf238c5da444581090b05997139397fccf8462"}],"cyborgclient/osc/v2/device_profile.py":[{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"dfca7b84c715afd4b5632aaa06041d1a9c1742e8","unresolved":true,"context_lines":[{"line_number":161,"context_line":"        parser \u003d super(ShowDeviceProfile, self).get_parser(prog_name)"},{"line_number":162,"context_line":"        parser.add_argument("},{"line_number":163,"context_line":"            \"device_profile\","},{"line_number":164,"context_line":"            metavar\u003d\"\u003cdevice_profile\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\"name or UUID of the device_profile.\")"},{"line_number":166,"context_line":"        )"},{"line_number":167,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"e7580900_ba0c3540","line":164,"updated":"2021-11-22 06:47:38.000000000","message":"IMO, there is need to be add the version limit for the new parameter device_profile_name_or_uuid, and the old parameter suuport before version \u003c\u003d2.1.\n\nWhile you completed that you can test by:\n\nroot@ubuntu:~# openstack --os-accelerator-api-version 2.2 accelerator device profile show \u003cdevice_profile_name\u003e","commit_id":"34e989ffd626b07809357061bfa51ad37b52f4ec"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"2e0105f435ffe2429f703efc12ac244ab27a884d","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        parser \u003d super(ShowDeviceProfile, self).get_parser(prog_name)"},{"line_number":162,"context_line":"        parser.add_argument("},{"line_number":163,"context_line":"            \"device_profile\","},{"line_number":164,"context_line":"            metavar\u003d\"\u003cdevice_profile\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\"name or UUID of the device_profile.\")"},{"line_number":166,"context_line":"        )"},{"line_number":167,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":2,"id":"07316a70_dd0b55a6","line":164,"in_reply_to":"e7580900_ba0c3540","updated":"2021-11-24 06:08:06.000000000","message":"Done","commit_id":"34e989ffd626b07809357061bfa51ad37b52f4ec"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"35569727eba54376ba3093881f0cfcc816e2d773","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        parser.add_argument("},{"line_number":163,"context_line":"            \"device_profile\","},{"line_number":164,"context_line":"            metavar\u003d\"\u003cdevice_profile\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\"name or UUID of the device_profile.\""},{"line_number":166,"context_line":"                   \" The name field reqires at least\""},{"line_number":167,"context_line":"                   \" ``--os-accelerator-api-version 2.2``.\")"},{"line_number":168,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"064f961d_18104622","line":165,"range":{"start_line":165,"start_character":20,"end_line":165,"end_character":25},"updated":"2021-11-30 09:13:49.000000000","message":"Name","commit_id":"6543b7a6c6a229714150711a958ec2aa6333b1fc"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"092465fa365023968846c235a0a2b5f53546e21e","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        parser.add_argument("},{"line_number":163,"context_line":"            \"device_profile\","},{"line_number":164,"context_line":"            metavar\u003d\"\u003cdevice_profile\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\"name or UUID of the device_profile.\""},{"line_number":166,"context_line":"                   \" The name field reqires at least\""},{"line_number":167,"context_line":"                   \" ``--os-accelerator-api-version 2.2``.\")"},{"line_number":168,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":3,"id":"c7b5f4f0_35025d89","line":165,"range":{"start_line":165,"start_character":20,"end_line":165,"end_character":25},"in_reply_to":"064f961d_18104622","updated":"2021-11-30 13:06:31.000000000","message":"Done","commit_id":"6543b7a6c6a229714150711a958ec2aa6333b1fc"},{"author":{"_account_id":26458,"name":"Brin Zhang","email":"zhangbailin@inspur.com","username":"zhangbailin"},"change_message_id":"30bc69f0dd019a79b811c61fb22ee905f6843f4a","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            \"device_profile\","},{"line_number":164,"context_line":"            metavar\u003d\"\u003cdevice_profile\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\"name or UUID of the device_profile.\""},{"line_number":166,"context_line":"                   \" The name field reqires at least\""},{"line_number":167,"context_line":"                   \" ``--os-accelerator-api-version 2.2``.\")"},{"line_number":168,"context_line":"        )"},{"line_number":169,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":3,"id":"2eb931d9_2b06eff3","line":166,"range":{"start_line":166,"start_character":19,"end_line":166,"end_character":21},"updated":"2021-11-30 02:29:17.000000000","message":"nit: it\u0027s better to add the blank space to the end sentence.","commit_id":"6543b7a6c6a229714150711a958ec2aa6333b1fc"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"f5a69554196df5a8a3befc06fabae1c00bbc2281","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            \"device_profile\","},{"line_number":164,"context_line":"            metavar\u003d\"\u003cdevice_profile\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\"name or UUID of the device_profile.\""},{"line_number":166,"context_line":"                   \" The name field reqires at least\""},{"line_number":167,"context_line":"                   \" ``--os-accelerator-api-version 2.2``.\")"},{"line_number":168,"context_line":"        )"},{"line_number":169,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":3,"id":"9e4f9948_ba29a2ec","line":166,"range":{"start_line":166,"start_character":36,"end_line":166,"end_character":44},"updated":"2021-11-30 09:05:30.000000000","message":"requires","commit_id":"6543b7a6c6a229714150711a958ec2aa6333b1fc"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"092465fa365023968846c235a0a2b5f53546e21e","unresolved":true,"context_lines":[{"line_number":163,"context_line":"            \"device_profile\","},{"line_number":164,"context_line":"            metavar\u003d\"\u003cdevice_profile\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\"name or UUID of the device_profile.\""},{"line_number":166,"context_line":"                   \" The name field reqires at least\""},{"line_number":167,"context_line":"                   \" ``--os-accelerator-api-version 2.2``.\")"},{"line_number":168,"context_line":"        )"},{"line_number":169,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":3,"id":"8e75ff37_94d6077d","line":166,"range":{"start_line":166,"start_character":19,"end_line":166,"end_character":21},"in_reply_to":"2eb931d9_2b06eff3","updated":"2021-11-30 13:06:31.000000000","message":"Added the blank space in line 167.","commit_id":"6543b7a6c6a229714150711a958ec2aa6333b1fc"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"092465fa365023968846c235a0a2b5f53546e21e","unresolved":false,"context_lines":[{"line_number":163,"context_line":"            \"device_profile\","},{"line_number":164,"context_line":"            metavar\u003d\"\u003cdevice_profile\u003e\","},{"line_number":165,"context_line":"            help\u003d_(\"name or UUID of the device_profile.\""},{"line_number":166,"context_line":"                   \" The name field reqires at least\""},{"line_number":167,"context_line":"                   \" ``--os-accelerator-api-version 2.2``.\")"},{"line_number":168,"context_line":"        )"},{"line_number":169,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":3,"id":"bcfb6d34_d8fd4a53","line":166,"range":{"start_line":166,"start_character":36,"end_line":166,"end_character":44},"in_reply_to":"9e4f9948_ba29a2ec","updated":"2021-11-30 13:06:31.000000000","message":"Done","commit_id":"6543b7a6c6a229714150711a958ec2aa6333b1fc"}],"cyborgclient/tests/unit/osc/v2/test_device_profile.py":[{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"f5a69554196df5a8a3befc06fabae1c00bbc2281","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    def setUp(self):"},{"line_number":101,"context_line":"        super(TestDeviceProfileShow, self).setUp()"},{"line_number":102,"context_line":"        self.cmd \u003d osc_device_profile.ShowDeviceProfile(self.app, None)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_device_profile_show_with_name(self):"},{"line_number":105,"context_line":"        arg_list \u003d [acc_fakes.device_profile_name]"},{"line_number":106,"context_line":"        verify_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"d12aaf15_691e6a4e","side":"PARENT","line":103,"updated":"2021-11-30 09:05:30.000000000","message":"here miss one test that name is not support before api-version 2.2.","commit_id":"0874496cdde1cd60260f1770b173c6dd730f4d80"},{"author":{"_account_id":23950,"name":"Eric Xie","email":"eric_xiett@163.com","username":"ericxie"},"change_message_id":"092465fa365023968846c235a0a2b5f53546e21e","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def setUp(self):"},{"line_number":101,"context_line":"        super(TestDeviceProfileShow, self).setUp()"},{"line_number":102,"context_line":"        self.cmd \u003d osc_device_profile.ShowDeviceProfile(self.app, None)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_device_profile_show_with_name(self):"},{"line_number":105,"context_line":"        arg_list \u003d [acc_fakes.device_profile_name]"},{"line_number":106,"context_line":"        verify_list \u003d []"}],"source_content_type":"text/x-python","patch_set":3,"id":"97639950_c06fe0ec","side":"PARENT","line":103,"in_reply_to":"d12aaf15_691e6a4e","updated":"2021-11-30 13:06:31.000000000","message":"Done","commit_id":"0874496cdde1cd60260f1770b173c6dd730f4d80"},{"author":{"_account_id":31412,"name":"Wenping Song","email":"songwenping@inspur.com","username":"songwenping"},"change_message_id":"6a2b3db231e444243b562bdada761c2bd8ea1e48","unresolved":true,"context_lines":[{"line_number":116,"context_line":"        result \u003d self.assertRaises(exc.NotAcceptable,"},{"line_number":117,"context_line":"                                   self.cmd.take_action,"},{"line_number":118,"context_line":"                                   parsed_args)"},{"line_number":119,"context_line":"        self.assertIn(\"The minimal required API version should be 2.2\","},{"line_number":120,"context_line":"                      str(result))"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def test_device_profile_show_with_name(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1c87e2d3_bf389074","line":119,"range":{"start_line":119,"start_character":22,"end_line":119,"end_character":70},"updated":"2021-12-01 07:40:35.000000000","message":"nit:exc_msg","commit_id":"92ebedc085afd9e0dc70262e73a53e3a1aa4f86e"}]}