)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"bb63fd086c0801962906571aee729e6efdcdc08a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"this is copied over from Cinderclient which already has the bits which was"},{"line_number":11,"context_line":"needed except the support for \"auth_plugins\"."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also this change introduces the use of \"oslo exceptions\" (the exceptions for"},{"line_number":14,"context_line":"clients which are carried in oslo-incubator)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"The code is also ready as a base for the V2 api."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"baada198_736b021e","line":13,"updated":"2014-07-05 22:24:29.000000000","message":"This is an API change, we should only use these for the v2 client when it\u0027s written.","commit_id":"f520a6dfac3449aed61ff4106d5af20226be0bb1"}],"designateclient/cli/__init__.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"bb63fd086c0801962906571aee729e6efdcdc08a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 Managed I.T."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Kiall Mac Innes \u003ckiall@managedit.ie\u003e"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7324e20c","line":1,"updated":"2014-07-05 22:24:29.000000000","message":"We probably shouldn\u0027t be adding new Managed IT headers... Also.. Empty files shouldn\u0027t have a notice at all..","commit_id":"f520a6dfac3449aed61ff4106d5af20226be0bb1"}],"designateclient/client.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"bb63fd086c0801962906571aee729e6efdcdc08a","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        return resp, body"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def _cs_request(self, url, method, **kwargs):"},{"line_number":95,"context_line":"        # this function is mostly redundant but makes compatibility easier"},{"line_number":96,"context_line":"        kwargs.setdefault(\u0027authenticated\u0027, True)"},{"line_number":97,"context_line":"        return self.request(url, method, **kwargs)"},{"line_number":98,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_931fb6b6","line":95,"updated":"2014-07-05 22:24:29.000000000","message":"I know these were copied from cinder, but we probably shouldn\u0027t copy dead code ;)\n\nSame applies to the method below.","commit_id":"f520a6dfac3449aed61ff4106d5af20226be0bb1"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"bb63fd086c0801962906571aee729e6efdcdc08a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"def get_client_class(version):"},{"line_number":174,"context_line":"    version_map \u003d {"},{"line_number":175,"context_line":"        \u00271\u0027: \u0027designateclient.v1.client.Client\u0027,"},{"line_number":176,"context_line":"        \u00272\u0027: \u0027designateclient.v2.client.Client\u0027,"},{"line_number":177,"context_line":"    }"},{"line_number":178,"context_line":"    try:"},{"line_number":179,"context_line":"        client_path \u003d version_map[str(version)]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b31afac3","line":176,"updated":"2014-07-05 22:24:29.000000000","message":"We don\u0027t have a v2 client yet..","commit_id":"f520a6dfac3449aed61ff4106d5af20226be0bb1"}],"designateclient/v1/__init__.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"bb63fd086c0801962906571aee729e6efdcdc08a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"baada198_3386eadb","updated":"2014-07-05 22:24:29.000000000","message":"Empty files shouldn\u0027t have a copyright header","commit_id":"f520a6dfac3449aed61ff4106d5af20226be0bb1"}],"designateclient/v1/client.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"572d7b69879a332fd2c5d24987baadd0b6247f54","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from designateclient import client"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class Client(object):"},{"line_number":22,"context_line":"    \"\"\" Client for the Designate v1 API \"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    def __init__(self, region_name\u003dNone, endpoint_type\u003d\u0027publicURL\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_73522268","line":21,"updated":"2014-07-05 22:38:41.000000000","message":"Moving this class, and changing the arguments is also an API change.\n\nRe the arguments - we\u0027ll need to put these back.. We\u0027ve also lost the ability to bypass keystone and simply supply an endpoint from what I can tell?\n\nThe python bindings are an API - just like the REST API. Making a breaking change should only be done if its absolutely necessary - I\u0027m not sure these changes provide any value other than aligning with cinderclient?","commit_id":"f520a6dfac3449aed61ff4106d5af20226be0bb1"}]}