)]}'
{"id":"openstack%2Fpython-designateclient~114397","triplet_id":"openstack%2Fpython-designateclient~master~I92ca95f167fec9fb36880024e6c84284186126df","project":"openstack/python-designateclient","branch":"master","hashtags":[],"change_id":"I92ca95f167fec9fb36880024e6c84284186126df","subject":"sync and touch Commands Extend the base.DeleteCommand","status":"MERGED","created":"2014-08-15 00:06:50.000000000","updated":"2014-08-30 13:21:53.000000000","submitted":"2014-08-30 13:21:52.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":4,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"62d6c74f6bc6638f4757bbb2929ad0a4d7ed5541","_number":114397,"virtual_id_number":114397,"owner":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":2,"date":"2014-08-30 13:21:52.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2014-08-15 00:39:10.000000000","_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},{"value":0,"date":"2014-08-19 14:55:39.000000000","_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},{"value":0,"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"_account_id":12428,"name":"Darshan Sanghani","email":"dsanghani@ebaysf.com","username":"darshan"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":2,"date":"2014-08-29 09:19:57.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},{"value":0,"_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},{"value":2,"date":"2014-08-30 12:46:04.000000000","_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":1,"date":"2014-08-15 00:32:56.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12428,"name":"Darshan Sanghani","email":"dsanghani@ebaysf.com","username":"darshan"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},{"value":0,"_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},{"value":1,"date":"2014-08-30 12:46:04.000000000","_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"_account_id":12428,"name":"Darshan Sanghani","email":"dsanghani@ebaysf.com","username":"darshan"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},{"value":0,"_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},{"value":0,"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"_account_id":12428,"name":"Darshan Sanghani","email":"dsanghani@ebaysf.com","username":"darshan"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},{"_account_id":12428,"name":"Darshan Sanghani","email":"dsanghani@ebaysf.com","username":"darshan"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-08-15 00:32:56.000000000","updated_by":{"_account_id":12428,"name":"Darshan Sanghani","email":"dsanghani@ebaysf.com","username":"darshan"},"reviewer":{"_account_id":12428,"name":"Darshan Sanghani","email":"dsanghani@ebaysf.com","username":"darshan"},"state":"REVIEWER"},{"updated":"2014-08-19 14:55:39.000000000","updated_by":{"_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},"reviewer":{"_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},"state":"REVIEWER"},{"updated":"2014-08-29 09:19:57.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"},{"updated":"2014-08-30 12:46:04.000000000","updated_by":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"reviewer":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"state":"REVIEWER"},{"updated":"2014-08-30 13:21:52.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"d5df6ddf7fe5191302b7ee41f44ac5a70d9ca079","author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"date":"2014-08-15 00:06:50.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"5f7ecf9a423eb8fd579b3f0a8a368bf0b61652bb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-15 00:06:56.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"581330f6fb6aa8548fcf8cca1109c0251d3a3183","author":{"_account_id":12428,"name":"Darshan Sanghani","email":"dsanghani@ebaysf.com","username":"darshan"},"date":"2014-08-15 00:32:56.000000000","message":"Patch Set 1: Code-Review+1\n\nLooks good. We should ideally also have a separate Command sub-class for such silent commands. But this should work.","accounts_in_message":[],"_revision_number":1},{"id":"8a12ceb2a0a341e6802fe3d0175772d0aee2dbe1","author":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"date":"2014-08-15 00:39:10.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"8b96fe8259a42cd197b435c0b47be68913bca5cb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-15 01:16:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-designateclient-pep8 http://logs.openstack.org/97/114397/1/check/gate-python-designateclient-pep8/99e981b : SUCCESS in 2m 19s\n- gate-python-designateclient-docs http://docs-draft.openstack.org/97/114397/1/check/gate-python-designateclient-docs/3924b4b/doc/build/html/ : SUCCESS in 1m 59s\n- gate-python-designateclient-python26 http://logs.openstack.org/97/114397/1/check/gate-python-designateclient-python26/bb47634 : SUCCESS in 2m 43s\n- gate-python-designateclient-python27 http://logs.openstack.org/97/114397/1/check/gate-python-designateclient-python27/26b5145 : SUCCESS in 2m 50s\n- gate-designate-devstack-dsvm http://logs.openstack.org/97/114397/1/check/gate-designate-devstack-dsvm/b04241f : SUCCESS in 12m 34s","accounts_in_message":[],"_revision_number":1},{"id":"6b94870bafc8fbd59d604815970c974ac3abbb78","author":{"_account_id":8101,"name":"Emmanuel Ankutse","email":"emmanuel.ankutse@rackspace.com","username":"emmanuel.ankutse"},"date":"2014-08-19 14:55:39.000000000","message":"Patch Set 1:\n\n(4 comments)\n\nFunctionality is probably good but it is a little confusing to see a a class named \u0027SyncAllCommand\u0027 extend a class named \u0027DeleteCommand\u0027. I know this is a little on the nit picky side but that was the first thing that hit me when I looked at the code.\n\nWould this just require a renaming of the \"DeleteCommand\" class to something more neutral?","accounts_in_message":[],"_revision_number":1},{"id":"3a800b1ea2c0ebf232e7c38509f70c9cef0f4092","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-19 14:55:40.000000000","message":"Patch Set 1: -Verified\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"208e3a039882b1d7dd5e548b490aa32e4e529bf1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-19 15:41:37.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded.\n\n- gate-python-designateclient-pep8 http://logs.openstack.org/97/114397/1/check/gate-python-designateclient-pep8/4555b7e : SUCCESS in 3m 14s\n- gate-python-designateclient-docs http://docs-draft.openstack.org/97/114397/1/check/gate-python-designateclient-docs/a8234d1/doc/build/html/ : SUCCESS in 2m 55s\n- gate-python-designateclient-python26 http://logs.openstack.org/97/114397/1/check/gate-python-designateclient-python26/8b79be8 : SUCCESS in 2m 49s\n- gate-python-designateclient-python27 http://logs.openstack.org/97/114397/1/check/gate-python-designateclient-python27/1bc2033 : SUCCESS in 2m 58s\n- gate-designate-devstack-dsvm http://logs.openstack.org/97/114397/1/check/gate-designate-devstack-dsvm/f5f001e : SUCCESS in 15m 34s","accounts_in_message":[],"_revision_number":1},{"id":"3840ef66ff1da401ce474f7c156574ceecc9573a","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2014-08-29 09:19:57.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"5485cf2cc0a67838f261d811960afc41902f9144","author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"date":"2014-08-30 12:46:04.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nI agree with Emmanuel that things look a little confusing with Sync extending Delete, and we should fix this.. But, I\u0027m happy to have a working CLI first.","accounts_in_message":[],"_revision_number":1},{"id":"ff756012a89effac79077118c44d2e45bee97828","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-30 12:46:05.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"9d7ea32c42fd0db6abe76eeb11b7c4d85b8f5350","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-30 13:21:52.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded.\n\n- gate-python-designateclient-docs http://docs-draft.openstack.org/97/114397/1/gate/gate-python-designateclient-docs/d93d748/doc/build/html/ : SUCCESS in 2m 34s\n- gate-python-designateclient-pep8 http://logs.openstack.org/97/114397/1/gate/gate-python-designateclient-pep8/8377082 : SUCCESS in 1m 25s\n- gate-python-designateclient-python26 http://logs.openstack.org/97/114397/1/gate/gate-python-designateclient-python26/50b894d : SUCCESS in 1m 34s\n- gate-python-designateclient-python27 http://logs.openstack.org/97/114397/1/gate/gate-python-designateclient-python27/a1e6193 : SUCCESS in 2m 23s\n- gate-designate-devstack-dsvm http://logs.openstack.org/97/114397/1/gate/gate-designate-devstack-dsvm/039197c : SUCCESS in 11m 55s","accounts_in_message":[],"_revision_number":1},{"id":"62d6c74f6bc6638f4757bbb2929ad0a4d7ed5541","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-08-30 13:21:53.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e23e51b5cd11f71ce3e0b41f6360b01856fd31eb","revisions":{"e23e51b5cd11f71ce3e0b41f6360b01856fd31eb":{"kind":"REWORK","_number":1,"created":"2014-08-15 00:06:50.000000000","uploader":{"_account_id":9605,"name":"Ron Rickard","email":"rrickard@paypalcorp.com","username":"rjrjr"},"ref":"refs/changes/97/114397/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/97/114397/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/97/114397/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/97/114397/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/97/114397/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/97/114397/1"}}},"commit":{"parents":[{"commit":"edbc00aed7adb9c7daf35398b9c66840f1bb3e7d","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/edbc00aed7adb9c7daf35398b9c66840f1bb3e7d"}]}],"author":{"name":"rjrjr","email":"rrickard@ebaysf.com","date":"2014-08-14 23:52:01.000000000","tz":-420},"committer":{"name":"rjrjr","email":"rrickard@ebaysf.com","date":"2014-08-15 00:06:17.000000000","tz":-420},"subject":"sync and touch Commands Extend the base.DeleteCommand","message":"sync and touch Commands Extend the base.DeleteCommand\n\nTo allow the sync-all, sync-domain, sync-record, and touch-domain commands\nto display errors correctly, the classes for these commands now extend the\nbase.DeleteCommand instead of the base.Command.\n\nThe base.Command has no formatter.\n\nThe base.DeleteCommand has the ShowOne formatter and does not show any\nmessages when the command is successful, but shows errors when there is\na failure.\n\nChange-Id: I92ca95f167fec9fb36880024e6c84284186126df\nCloses-Bug: #1357092\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/e23e51b5cd11f71ce3e0b41f6360b01856fd31eb"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/e23e51b5cd11f71ce3e0b41f6360b01856fd31eb"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}