)]}'
{"designateclient/client.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"4fb30b2cb279538c779150b4b4a6149d93171baa","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        resp, body \u003d self.client.session.post(url, **kwargs)"},{"line_number":54,"context_line":"        if response_key is not None:"},{"line_number":55,"context_line":"            return body[response_key]"},{"line_number":56,"context_line":"        return body"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _get(self, url, response_key\u003dNone):"},{"line_number":59,"context_line":"        resp, body \u003d self.client.session.get(url)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab921fb_ef3e7eb7","line":56,"updated":"2015-04-23 17:19:29.000000000","message":"This response key gets handled in every method here, yet it seems the caller should do it since it is passing in the response_key. For example, in v2/tlds.py, in the TLDController, the list method could return:\n\n  return {\u0027tlds\u0027: self._get(url)}\n\nThat reduces most functions to essentially call the respective client.session.$method, the only other adjustment being automatically serializing the `data` to a JSON string.","commit_id":"835706cfbb4cad1a0586291942185bea4451066f"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"3e09a777bdf2051a24f2f08499cdef730bf9f286","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        resp, body \u003d self.client.session.post(url, **kwargs)"},{"line_number":54,"context_line":"        if response_key is not None:"},{"line_number":55,"context_line":"            return body[response_key]"},{"line_number":56,"context_line":"        return body"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def _get(self, url, response_key\u003dNone):"},{"line_number":59,"context_line":"        resp, body \u003d self.client.session.get(url)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab921fb_2d27b0b7","line":56,"in_reply_to":"bab921fb_ef3e7eb7","updated":"2015-04-24 10:30:47.000000000","message":"That\u0027s not the thing, passing response_key\u003d\"\" makes it look for the response_key inside the response.. Since the API returns {\"collection key\": []} this will make it return the [] instead of {}.","commit_id":"835706cfbb4cad1a0586291942185bea4451066f"}],"designateclient/tests/v2/lib/test_blacklists.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"4fb30b2cb279538c779150b4b4a6149d93171baa","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        self.stub_entity(\"GET\", entity\u003dref, id\u003dref[\"id\"])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.client.blacklists.get(ref[\"id\"])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_list(self):"},{"line_number":59,"context_line":"        items \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"bab921fb_afe2c69d","line":56,"updated":"2015-04-23 17:19:29.000000000","message":"Do we need an assertion here?","commit_id":"835706cfbb4cad1a0586291942185bea4451066f"}],"designateclient/tests/v2/lib/test_recordsets.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"4fb30b2cb279538c779150b4b4a6149d93171baa","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        parts \u003d [\"zones\", ZONE[\"id\"], self.RESOURCE]"},{"line_number":182,"context_line":"        self.stub_entity(\"GET\", entity\u003dref, id\u003dref[\"id\"], parts\u003dparts)"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        self.client.recordsets.get(ZONE[\"id\"], ref[\"id\"])"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def test_list(self):"},{"line_number":187,"context_line":"        items \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"bab921fb_89ec9bc8","line":184,"updated":"2015-04-23 17:19:29.000000000","message":"Do we need an assertion?","commit_id":"835706cfbb4cad1a0586291942185bea4451066f"}],"designateclient/tests/v2/lib/test_tlds.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"4fb30b2cb279538c779150b4b4a6149d93171baa","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        self.stub_entity(\"GET\", entity\u003dref, id\u003dref[\"id\"])"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        self.client.tlds.get(ref[\"id\"])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def test_list(self):"},{"line_number":59,"context_line":"        items \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"bab921fb_294fcfbe","line":56,"updated":"2015-04-23 17:19:29.000000000","message":"No assertion.","commit_id":"835706cfbb4cad1a0586291942185bea4451066f"}],"designateclient/tests/v2/lib/test_zones.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"4fb30b2cb279538c779150b4b4a6149d93171baa","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        self.stub_entity(\"GET\", entity\u003dref, id\u003dref[\"id\"])"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        self.client.zones.get(ref[\"id\"])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_list(self):"},{"line_number":89,"context_line":"        items \u003d ["}],"source_content_type":"text/x-python","patch_set":12,"id":"bab921fb_29e6afb4","line":86,"updated":"2015-04-23 17:19:29.000000000","message":"No assertion.","commit_id":"835706cfbb4cad1a0586291942185bea4451066f"}],"designateclient/v2/blacklists.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"4fb30b2cb279538c779150b4b4a6149d93171baa","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def list(self, criterion\u003dNone, marker\u003dNone, limit\u003dNone):"},{"line_number":31,"context_line":"        url \u003d self.build_url(\u0027/blacklists\u0027, criterion, marker, limit)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"        return self._get(url, response_key\u003d\"blacklists\")"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def get(self, blacklist_id):"},{"line_number":36,"context_line":"        url \u003d \u0027/blacklists/%s\u0027 % blacklist_id"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab921fb_c9c173e6","line":33,"updated":"2015-04-23 17:19:29.000000000","message":"I mentioned this in the client.Controller:\n\n  return {\u0027blacklists\u0027: self._get(url)}","commit_id":"835706cfbb4cad1a0586291942185bea4451066f"}],"designateclient/v2/client.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"642bae00a81c7def8eeb2cd7d396b838d62a6614","unresolved":false,"context_lines":[{"line_number":38,"context_line":"            \u0027Content-Type\u0027, \u0027application/json\u0027)"},{"line_number":39,"context_line":"        response, body \u003d super(DesignateAdapter, self).request(*args, **kwargs)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Decode is response, if possible"},{"line_number":42,"context_line":"        try:"},{"line_number":43,"context_line":"            response_payload \u003d response.json()"},{"line_number":44,"context_line":"        except ValueError:"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_2a8146c4","line":41,"updated":"2015-02-24 22:09:00.000000000","message":"Just curious what this comment is trying to communicate. It sounds like it is making sure the reader understands that we try to decode the response (which also will consume a file handle). Does that sound right?","commit_id":"c4b866b3a3439fd628e5593c961dce7b2e12132b"},{"author":{"_account_id":13693,"name":"Erik Olof Gunnar Andersson","username":"eandersson","inactive":true},"change_message_id":"3b794fb5736670f0fa14d6f35d72e7e1919d5a2a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"class DesignateAdapter(adapter.LegacyJsonAdapter):"},{"line_number":31,"context_line":"    \"\"\""},{"line_number":32,"context_line":"    Adapter around LegacyJsonAdapter to support Designate\u0027s format of"},{"line_number":33,"context_line":"    expcetions down to \"oslo exceptions\"."},{"line_number":34,"context_line":"    \"\"\""},{"line_number":35,"context_line":"    def request(self, *args, **kwargs):"},{"line_number":36,"context_line":"        kwargs.setdefault(\u0027raise_exc\u0027, False)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7ad32947_8e04af15","line":33,"updated":"2015-04-28 10:38:22.000000000","message":"Minor typo in excetions \u003d\u003e exceptions","commit_id":"d608f64ad56458b7b67a6ab13dfb3a996f00848e"}],"designateclient/v2/limits.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"00513660ffac9c21473bd99cf0f8a65c751cbda4","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class LimitController(client.Controller):"},{"line_number":20,"context_line":"    def list(self):"},{"line_number":21,"context_line":"        limits \u003d []"},{"line_number":22,"context_line":"        json \u003d self.client.session._get(\u0027/limits\u0027).json()"},{"line_number":23,"context_line":"        for name, values in json[\u0027limits\u0027].items():"},{"line_number":24,"context_line":"            values[\u0027name\u0027] \u003d name"},{"line_number":25,"context_line":"            limits.append(values)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_a28cbf36","line":22,"updated":"2014-11-12 12:15:39.000000000","message":"I\u0027m not sure why you do this over self._get() ?","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"eb69d235129b83ccb4ad09e3bc156b5805b47b60","unresolved":false,"context_lines":[{"line_number":19,"context_line":"class LimitController(client.Controller):"},{"line_number":20,"context_line":"    def list(self):"},{"line_number":21,"context_line":"        limits \u003d []"},{"line_number":22,"context_line":"        json \u003d self.client.session._get(\u0027/limits\u0027).json()"},{"line_number":23,"context_line":"        for name, values in json[\u0027limits\u0027].items():"},{"line_number":24,"context_line":"            values[\u0027name\u0027] \u003d name"},{"line_number":25,"context_line":"            limits.append(values)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_b8587033","line":22,"in_reply_to":"5a890539_a28cbf36","updated":"2014-11-13 13:17:59.000000000","message":"Good catch.","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"}],"designateclient/v2/nameservers.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"00513660ffac9c21473bd99cf0f8a65c751cbda4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def list(self, zone):"},{"line_number":21,"context_line":"        url \u003d self.build_url(\u0027/zones/%s/nameservers\u0027 % zone)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        return self._list(url, response_key\u003d\u0027nameservers\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_2291af52","line":23,"updated":"2014-11-12 12:15:39.000000000","message":"self._list doesn\u0027t exist","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"eb69d235129b83ccb4ad09e3bc156b5805b47b60","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def list(self, zone):"},{"line_number":21,"context_line":"        url \u003d self.build_url(\u0027/zones/%s/nameservers\u0027 % zone)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"        return self._list(url, response_key\u003d\u0027nameservers\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_00000666","line":23,"in_reply_to":"5a890539_2291af52","updated":"2014-11-13 13:17:59.000000000","message":"Done","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"}],"designateclient/v2/recordsets.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"4fb30b2cb279538c779150b4b4a6149d93171baa","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            zone_id \u003d zone"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        url \u003d \u0027/zones/%s/recordsets\u0027 % zone_id"},{"line_number":66,"context_line":"        return self._post(url, data\u003ddata)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def list(self, zone, criterion\u003dNone, marker\u003dNone, limit\u003dNone):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab921fb_8c0ee932","line":65,"updated":"2015-04-23 17:19:29.000000000","message":"Should this use build_url for consistency sake?","commit_id":"835706cfbb4cad1a0586291942185bea4451066f"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"3e09a777bdf2051a24f2f08499cdef730bf9f286","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            zone_id \u003d zone"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        url \u003d \u0027/zones/%s/recordsets\u0027 % zone_id"},{"line_number":66,"context_line":"        return self._post(url, data\u003ddata)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def list(self, zone, criterion\u003dNone, marker\u003dNone, limit\u003dNone):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab921fb_4d2b0495","line":65,"in_reply_to":"bab921fb_8c0ee932","updated":"2015-04-24 10:30:47.000000000","message":"build_url() is mostly useful when you do stuff like query params etc..","commit_id":"835706cfbb4cad1a0586291942185bea4451066f"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"4fb30b2cb279538c779150b4b4a6149d93171baa","unresolved":false,"context_lines":[{"line_number":87,"context_line":"        zone \u003d v2_utils.resolve_by_name(self.client.zones.list, zone)"},{"line_number":88,"context_line":"        recordset \u003d v2_utils.resolve_by_name(self.list, recordset, zone)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        url \u003d \u0027/zones/%s/recordsets/%s\u0027 % (zone, recordset)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        return self._put(url, data\u003dvalues)"},{"line_number":93,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bab921fb_8cf829e7","line":90,"updated":"2015-04-23 17:19:29.000000000","message":"Use build_url?","commit_id":"835706cfbb4cad1a0586291942185bea4451066f"}],"designateclient/v2/reverse.py":[{"author":{"_account_id":13693,"name":"Erik Olof Gunnar Andersson","username":"eandersson","inactive":true},"change_message_id":"3b794fb5736670f0fa14d6f35d72e7e1919d5a2a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class FloatingIPController(client.Controller):"},{"line_number":20,"context_line":"    def set(self, region, floatingip_id, ptrdname, description\u003dNone, ttl\u003dNone):"},{"line_number":21,"context_line":"        data \u003d {"},{"line_number":22,"context_line":"            \u0027ptrdname\u0027: ptrdname"},{"line_number":23,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":14,"id":"7ad32947_4ef8d7e5","line":20,"updated":"2015-04-28 10:38:22.000000000","message":"ttl\u003dNone is never used","commit_id":"d608f64ad56458b7b67a6ab13dfb3a996f00848e"}],"designateclient/v2/tlds.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"00513660ffac9c21473bd99cf0f8a65c751cbda4","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from designateclient import client"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class TopLeveDomainController(client.Controller):"},{"line_number":20,"context_line":"    def create(self, name, description\u003dNone):"},{"line_number":21,"context_line":"        data \u003d {"},{"line_number":22,"context_line":"            \u0027tld\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_e22407b1","line":19,"updated":"2014-11-12 12:15:39.000000000","message":"Typo in the word Level, also, I think the bindings should line up with the APIs... e.g. \n\n    class TLDController(..):","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"eb69d235129b83ccb4ad09e3bc156b5805b47b60","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from designateclient import client"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class TopLeveDomainController(client.Controller):"},{"line_number":20,"context_line":"    def create(self, name, description\u003dNone):"},{"line_number":21,"context_line":"        data \u003d {"},{"line_number":22,"context_line":"            \u0027tld\u0027: {"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_000e468d","line":19,"in_reply_to":"5a890539_e22407b1","updated":"2014-11-13 13:17:59.000000000","message":"Done","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"00513660ffac9c21473bd99cf0f8a65c751cbda4","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def list(self, marker\u003dNone, limit\u003dNone):"},{"line_number":33,"context_line":"        url \u003d self.build_url(\u0027/tlds\u0027, marker, limit)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        return self._list(url, response_key\u003d\u0027tlds\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get(self, id_):"},{"line_number":38,"context_line":"        url \u003d self.build_url(\u0027/tlds/%s\u0027 % id_)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_a293df4d","line":35,"updated":"2014-11-12 12:15:39.000000000","message":"self._list doesn\u0027t exist?","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"eb69d235129b83ccb4ad09e3bc156b5805b47b60","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    def list(self, marker\u003dNone, limit\u003dNone):"},{"line_number":33,"context_line":"        url \u003d self.build_url(\u0027/tlds\u0027, marker, limit)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        return self._list(url, response_key\u003d\u0027tlds\u0027)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def get(self, id_):"},{"line_number":38,"context_line":"        url \u003d self.build_url(\u0027/tlds/%s\u0027 % id_)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_201182ac","line":35,"in_reply_to":"5a890539_a293df4d","updated":"2014-11-13 13:17:59.000000000","message":"Done","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"}],"designateclient/v2/zones.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"00513660ffac9c21473bd99cf0f8a65c751cbda4","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        if type_ \u003d\u003d \u0027PRIMARY\u0027:"},{"line_number":28,"context_line":"            data[\u0027email\u0027] \u003d email"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"            if ttl is not None:"},{"line_number":31,"context_line":"                data[\u0027ttl\u0027] \u003d ttl"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_6251f7d7","line":28,"updated":"2014-11-12 12:15:39.000000000","message":"Type should default to \u0027PRIMARY\u0027 when not supplied IMO, 99.9% of zones will be primary.","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"eb69d235129b83ccb4ad09e3bc156b5805b47b60","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        }"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"        if type_ \u003d\u003d \u0027PRIMARY\u0027:"},{"line_number":28,"context_line":"            data[\u0027email\u0027] \u003d email"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"            if ttl is not None:"},{"line_number":31,"context_line":"                data[\u0027ttl\u0027] \u003d ttl"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_00d3a6d6","line":28,"in_reply_to":"5a890539_6251f7d7","updated":"2014-11-13 13:17:59.000000000","message":"Done","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"4fb30b2cb279538c779150b4b4a6149d93171baa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"                data[\"ttl\"] \u003d ttl"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        elif type_ \u003d\u003d \"SECONDARY\":"},{"line_number":37,"context_line":"            data[\"masters\"] \u003d masters"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        if description is not None:"},{"line_number":40,"context_line":"            data[\"description\"] \u003d description"}],"source_content_type":"text/x-python","patch_set":12,"id":"bab921fb_2f1b4f1d","line":37,"updated":"2015-04-23 17:19:29.000000000","message":"If it is a secondary, is it OK to have masters as None? I\u0027m assuming the server would complain as well, so maybe it doesn\u0027t matter.","commit_id":"835706cfbb4cad1a0586291942185bea4451066f"},{"author":{"_account_id":13693,"name":"Erik Olof Gunnar Andersson","username":"eandersson","inactive":true},"change_message_id":"3b794fb5736670f0fa14d6f35d72e7e1919d5a2a","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        return self._post(\u0027/zones\u0027, data\u003ddata)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    def list(self, criterion\u003dNone, marker\u003dNone, limit\u003dNone, ):"},{"line_number":45,"context_line":"        url \u003d self.build_url(\u0027/zones\u0027, criterion, marker, limit)"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        return self._get(url, response_key\u003d\"zones\")"}],"source_content_type":"text/x-python","patch_set":14,"id":"7ad32947_cebbc70d","line":44,"updated":"2015-04-28 10:38:22.000000000","message":"Not a biggy, but you got an extra ,","commit_id":"d608f64ad56458b7b67a6ab13dfb3a996f00848e"}],"doc/examples/crud.py":[{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"00513660ffac9c21473bd99cf0f8a65c751cbda4","unresolved":false,"context_lines":[{"line_number":18,"context_line":"http \u003d HTTPClient(auth_plugin\u003dauth_plugin, debug\u003dTrue)"},{"line_number":19,"context_line":"http.authenticate()"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"client \u003d Client(http)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"try:"},{"line_number":24,"context_line":"    zone \u003d client.zones.create(name\u003d\u0027i.io.\u0027, email\u003d\u0027i@i.io\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_a29f5fb3","line":21,"updated":"2014-11-12 12:15:39.000000000","message":"Does this actually work? The first argument of the Client class constructor is region_name ??","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"eb69d235129b83ccb4ad09e3bc156b5805b47b60","unresolved":false,"context_lines":[{"line_number":18,"context_line":"http \u003d HTTPClient(auth_plugin\u003dauth_plugin, debug\u003dTrue)"},{"line_number":19,"context_line":"http.authenticate()"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"client \u003d Client(http)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"try:"},{"line_number":24,"context_line":"    zone \u003d client.zones.create(name\u003d\u0027i.io.\u0027, email\u003d\u0027i@i.io\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a890539_4003ee41","line":21,"in_reply_to":"5a890539_a29f5fb3","updated":"2014-11-13 13:17:59.000000000","message":"Ya, examples are kinda outdated -,,- Will fix up until next post.","commit_id":"2ca79d39373f2c4508f8e90f57c8793396612ec7"}],"doc/examples/recordset_create.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"642bae00a81c7def8eeb2cd7d396b838d62a6614","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"try:"},{"line_number":30,"context_line":"    zone \u003d client.zones.create(\u0027i.io.\u0027, email\u003d\u0027i@i.io\u0027)"},{"line_number":31,"context_line":"except exceptions.RemoteError:"},{"line_number":32,"context_line":"    zone \u003d dict([(z[\u0027name\u0027], z) for z in client.zones.list()])[\u0027i.io.\u0027]"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_e5b4bf36","line":30,"updated":"2015-02-24 22:09:00.000000000","message":"It might be slightly more obvious to a more common domain name here. If a user is scanning this example, it would be really easy to miss \"i.io\" as something else like an object reference or who knows. \n\nObviously, we\u0027d hope our users read these examples carefully! But, as someone who has lazily read docs, a domain like \"example.org.\" or \"foo.net.\" might be helpful understanding what is going on.","commit_id":"c4b866b3a3439fd628e5593c961dce7b2e12132b"}],"doc/examples/recordset_crud.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"642bae00a81c7def8eeb2cd7d396b838d62a6614","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"try:"},{"line_number":25,"context_line":"    zone \u003d dict([(z[\u0027name\u0027], z) for z in client.zones.list()])[\u0027i.io.\u0027]"},{"line_number":26,"context_line":"    client.zones.delete(zone[\u0027id\u0027])"},{"line_number":27,"context_line":"except exceptions.NotFound:"},{"line_number":28,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba7be1f8_c5d97b23","line":25,"updated":"2015-02-24 22:09:00.000000000","message":"What do you think about:\n\n  for z in client.zones.list():\n    if z[\u0027name\u0027] \u003d\u003d \u0027i.io\u0027:\n      client.zones.delete(zone[\u0027id\u0027])\n\nConstructing the dict to grab a single zone seems doesn\u0027t seem as obvious and also presents the opportunity for a KeyError if the name doesn\u0027t exists. \n\nJust a thought.","commit_id":"c4b866b3a3439fd628e5593c961dce7b2e12132b"},{"author":{"_account_id":13693,"name":"Erik Olof Gunnar Andersson","username":"eandersson","inactive":true},"change_message_id":"3b794fb5736670f0fa14d6f35d72e7e1919d5a2a","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    zone[\u0027id\u0027], zone[\u0027name\u0027], \u0027MX\u0027,"},{"line_number":70,"context_line":"    [\u00270 \u0027 + mail1[\u0027name\u0027], \u00275 \u0027 + mail2[\u0027name\u0027]])"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"print zone[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"7ad32947_ce0067ad","line":72,"updated":"2015-04-28 10:38:22.000000000","message":"You probably want to do print(zone[\u0027id\u0027) for future Python 3 compatibility.","commit_id":"d608f64ad56458b7b67a6ab13dfb3a996f00848e"}],"doc/examples/zone_list_paging.py":[{"author":{"_account_id":13693,"name":"Erik Olof Gunnar Andersson","username":"eandersson","inactive":true},"change_message_id":"3b794fb5736670f0fa14d6f35d72e7e1919d5a2a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    pages.append(page)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"for page in pages:"},{"line_number":36,"context_line":"    print page"}],"source_content_type":"text/x-python","patch_set":14,"id":"7ad32947_0ecc1f88","line":36,"updated":"2015-04-28 10:38:22.000000000","message":"For Python 3 compatibility you want to do print(page)","commit_id":"d608f64ad56458b7b67a6ab13dfb3a996f00848e"}]}