)]}'
{"designateclient/cli/records.py":[{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"af208d5defc089392d555c009d1bee5541126b23","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        domain_id \u003d self.find_resourceid_by_name_or_id("},{"line_number":80,"context_line":"            \u0027domains\u0027, parsed_args.domain_id)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        if parsed_args.relative is not None:"},{"line_number":83,"context_line":"            domain_name \u003d self.client.domains.get(domain_id)[\u0027name\u0027]"},{"line_number":84,"context_line":"            name \u003d \u0027%s.%s\u0027 % (parsed_args.relative, domain_name)"},{"line_number":85,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_9dce43b3","line":82,"updated":"2015-04-15 18:28:13.000000000","message":"instead of passing --relative in to the command, could we check if the provided domain ends in a \".\" ? that way we could just append the domain if there is no trailing .","commit_id":"45f8b7867bb010e89d079964bf2a07976919406e"},{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"bd4d671031a1744b5c81bee345727837703cde6f","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        domain_id \u003d self.find_resourceid_by_name_or_id("},{"line_number":80,"context_line":"            \u0027domains\u0027, parsed_args.domain_id)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        if parsed_args.relative is not None:"},{"line_number":83,"context_line":"            domain_name \u003d self.client.domains.get(domain_id)[\u0027name\u0027]"},{"line_number":84,"context_line":"            name \u003d \u0027%s.%s\u0027 % (parsed_args.relative, domain_name)"},{"line_number":85,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_e07d9ce8","line":82,"in_reply_to":"5aa745d1_9dce43b3","updated":"2015-04-15 19:06:04.000000000","message":"Definitely agree","commit_id":"45f8b7867bb010e89d079964bf2a07976919406e"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"73c20a31a5b08e4e0c22dd8e804dd22e71a546d6","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        domain_id \u003d self.find_resourceid_by_name_or_id("},{"line_number":80,"context_line":"            \u0027domains\u0027, parsed_args.domain_id)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        if parsed_args.relative is not None:"},{"line_number":83,"context_line":"            domain_name \u003d self.client.domains.get(domain_id)[\u0027name\u0027]"},{"line_number":84,"context_line":"            name \u003d \u0027%s.%s\u0027 % (parsed_args.relative, domain_name)"},{"line_number":85,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_e3080694","line":82,"in_reply_to":"5aa745d1_e07d9ce8","updated":"2015-04-15 19:37:24.000000000","message":"@graham, tim: I choose to define a specific option to avoid mistakes if a user creates a record with an absolute name but forgets the \".\" at the end of the name (so quite everyone):\n\n  designate record-create example.com. --name taz.example.com\n  # create taz.example.com.example.com. not taz.example.com.","commit_id":"45f8b7867bb010e89d079964bf2a07976919406e"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"6b126e39f3640cac6cef42d59029c4c7a50a49db","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        domain_id \u003d self.find_resourceid_by_name_or_id("},{"line_number":80,"context_line":"            \u0027domains\u0027, parsed_args.domain_id)"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"        if parsed_args.relative is not None:"},{"line_number":83,"context_line":"            domain_name \u003d self.client.domains.get(domain_id)[\u0027name\u0027]"},{"line_number":84,"context_line":"            name \u003d \u0027%s.%s\u0027 % (parsed_args.relative, domain_name)"},{"line_number":85,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5aa745d1_0363f21b","line":82,"in_reply_to":"5aa745d1_e3080694","updated":"2015-04-15 19:44:24.000000000","message":"This is a fantastic point.","commit_id":"45f8b7867bb010e89d079964bf2a07976919406e"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"83a3d131d99114d6eeb603e90faa39f72b777f99","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            absolute \u003d parsed_args.name + \u0027.\u0027"},{"line_number":85,"context_line":"            relative \u003d absolute + domain_name"},{"line_number":86,"context_line":"            if absolute.endswith(\u0027.\u0027 + domain_name):"},{"line_number":87,"context_line":"                # Relative name or absolute name missing final period?"},{"line_number":88,"context_line":"                msg \u003d (\u0027\"%s\" is a relative name but looks like an absolute \u0027"},{"line_number":89,"context_line":"                       \u0027name, use --name \"%s\" or \"%s\"\u0027"},{"line_number":90,"context_line":"                       % (parsed_args.name, absolute, relative))"}],"source_content_type":"text/x-python","patch_set":2,"id":"3acd31a7_c359075c","line":87,"updated":"2015-05-04 19:12:41.000000000","message":"We should:\n\n* raise an error (current case)\n* use absolute as name (and assume the user forgot the period)\n* use relative as name?","commit_id":"1349227339897d393aebf02567fe16c158b439d0"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"ac4aaafd00c7ee2e1cfbdbc01261e3012a2ab7a0","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            absolute \u003d parsed_args.name + \u0027.\u0027"},{"line_number":85,"context_line":"            relative \u003d absolute + domain_name"},{"line_number":86,"context_line":"            if absolute.endswith(\u0027.\u0027 + domain_name):"},{"line_number":87,"context_line":"                # Relative name or absolute name missing final period?"},{"line_number":88,"context_line":"                msg \u003d (\u0027\"%s\" is a relative name but looks like an absolute \u0027"},{"line_number":89,"context_line":"                       \u0027name, use --name \"%s\" or \"%s\"\u0027"},{"line_number":90,"context_line":"                       % (parsed_args.name, absolute, relative))"}],"source_content_type":"text/x-python","patch_set":2,"id":"5afe65bd_10e1bc9a","line":87,"in_reply_to":"3acd31a7_c359075c","updated":"2015-06-03 11:30:32.000000000","message":"I am thinking the error is the right solution.","commit_id":"1349227339897d393aebf02567fe16c158b439d0"}]}