)]}'
{"designateclient/tests/v2/test_client.py":[{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"8cf262e54889c983b4dc71c1eb123c5abafce9ab","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def test_init_with_session(self):"},{"line_number":29,"context_line":"        session \u003d keystone_session.Session()"},{"line_number":30,"context_line":"        adapted \u003d adapter.Adapter(session\u003dsession)"},{"line_number":31,"context_line":"        client \u003d Client(session\u003dadapted)"},{"line_number":32,"context_line":"        assert client.session"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_eca074f6","line":30,"updated":"2015-07-08 16:59:51.000000000","message":"You dont need to wrap the session in a adapter here, adapters are only need when wanting to override something towards the session but not modify the state of the thing in the session.","commit_id":"bb37839b040dca8ceb15830c35130350b23c1004"}],"designateclient/tests/v2/test_timeout.py":[{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"8cf262e54889c983b4dc71c1eb123c5abafce9ab","unresolved":false,"context_lines":[{"line_number":42,"context_line":"            session\u003dsession,"},{"line_number":43,"context_line":"            timeout\u003d2,"},{"line_number":44,"context_line":"        )"},{"line_number":45,"context_line":"        self.assertEqual(client.session.timeout, 2)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_8ce3e8d7","line":45,"updated":"2015-07-08 16:59:51.000000000","message":"Maybe you should also do a mock testing that when a request is done timeout\u003d2 is passed in ?","commit_id":"bb37839b040dca8ceb15830c35130350b23c1004"}],"designateclient/utils.py":[{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"8cf262e54889c983b4dc71c1eb123c5abafce9ab","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    \"\"\""},{"line_number":186,"context_line":"    def __init__(self, *args, **kw):"},{"line_number":187,"context_line":"        self.timeout \u003d kw.pop(\u0027timeout\u0027, None)"},{"line_number":188,"context_line":"        if self.timeout is None and args:"},{"line_number":189,"context_line":"            session \u003d args[0]"},{"line_number":190,"context_line":"            self.timeout \u003d getattr(session, \u0027timeout\u0027, None)"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_4c4080a5","line":188,"updated":"2015-07-08 16:59:51.000000000","message":"Again doing self.timeout \u003d kwargs.pop(\u0027timeout\u0027, None) should be fine?","commit_id":"bb37839b040dca8ceb15830c35130350b23c1004"}],"designateclient/v2/client.py":[{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"8cf262e54889c983b4dc71c1eb123c5abafce9ab","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    The user can pass a timeout keyword that will apply only to"},{"line_number":34,"context_line":"    the Designate Client, in order:"},{"line_number":35,"context_line":"        - timeout keyword passed to request()"},{"line_number":36,"context_line":"        - timeout keyword passed to AdapterWithTimeout()"},{"line_number":37,"context_line":"        - timeout attribute on keystone session"},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_8c3d2890","line":36,"updated":"2015-07-08 16:59:51.000000000","message":"AdapterWithTimeout wont be used here.","commit_id":"bb37839b040dca8ceb15830c35130350b23c1004"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"8cf262e54889c983b4dc71c1eb123c5abafce9ab","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        - timeout attribute on keystone session"},{"line_number":38,"context_line":"    \"\"\""},{"line_number":39,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":40,"context_line":"        if not args or args[0] is None:"},{"line_number":41,"context_line":"            raise ValueError(\"A session instance is required\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        self.timeout \u003d kwargs.pop(\u0027timeout\u0027, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_ec8dd431","line":40,"updated":"2015-07-08 16:59:51.000000000","message":"Uhm, The adapter shouldn\u0027t be used by anything else then the Client in here I think so not checking the args stuff is fine?","commit_id":"bb37839b040dca8ceb15830c35130350b23c1004"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"8cf262e54889c983b4dc71c1eb123c5abafce9ab","unresolved":false,"context_lines":[{"line_number":41,"context_line":"            raise ValueError(\"A session instance is required\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        self.timeout \u003d kwargs.pop(\u0027timeout\u0027, None)"},{"line_number":44,"context_line":"        if self.timeout is None:"},{"line_number":45,"context_line":"            session \u003d args[0]"},{"line_number":46,"context_line":"            self.timeout \u003d getattr(session, \u0027timeout\u0027, None)"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_cca1f0aa","line":44,"updated":"2015-07-08 16:59:51.000000000","message":"We shouldn\u0027t get the timeout off of the session as it will be used from the session if not kwargs[\"timeout\"] is passed in to request().\n\nSo doing self.timeout \u003d kwargs.pop(\"timeout\", None) is totally fine vs adding all that code ?","commit_id":"bb37839b040dca8ceb15830c35130350b23c1004"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"8cf262e54889c983b4dc71c1eb123c5abafce9ab","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                 extensions\u003dNone, service_type\u003d\u0027dns\u0027, service_name\u003dNone,"},{"line_number":83,"context_line":"                 http_log_debug\u003dFalse, session\u003dNone, auth\u003dNone, timeout\u003dNone,"},{"line_number":84,"context_line":"                 endpoint_override\u003dNone):"},{"line_number":85,"context_line":"        if session is None:"},{"line_number":86,"context_line":"            raise ValueError(\"A session instance is required\")"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.session \u003d DesignateAdapter("}],"source_content_type":"text/x-python","patch_set":4,"id":"ba3cc151_4c7de01a","line":85,"updated":"2015-07-08 16:59:51.000000000","message":"Nice one!","commit_id":"bb37839b040dca8ceb15830c35130350b23c1004"}]}