)]}'
{"designateclient/utils.py":[{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66554fe886374d5054297e6a3a0b63ff1d2ba40a","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def action_and_notify(action, resource, success_msg, error_msg):"},{"line_number":56,"context_line":"    \"\"\""},{"line_number":57,"context_line":"    Performs specific action and displays appropriate success or"},{"line_number":58,"context_line":"    failure message accordingly."},{"line_number":59,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_03d5721a","line":56,"updated":"2015-08-06 05:31:56.000000000","message":"Please add some unit tests for this util function.","commit_id":"6bc2568266e42113b586635bfd7ce956896594f3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66554fe886374d5054297e6a3a0b63ff1d2ba40a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        print(e)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    if error_flag:"},{"line_number":69,"context_line":"        print(error_msg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"def get_item_properties(item, fields, mixed_case_fields\u003d[], formatters\u003d{}):"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_8322e250","line":69,"updated":"2015-08-06 05:31:56.000000000","message":"How about raising command error here like - raise exceptions.CommandError(error_msg)","commit_id":"6bc2568266e42113b586635bfd7ce956896594f3"}],"designateclient/v1/domains.py":[{"author":{"_account_id":8174,"name":"Tim Simmons","email":"tim.r.simmons@gmail.com","username":"TimSimmons"},"change_message_id":"87d6b7217feb1f60eb8410bb9eb46660e336ecb4","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            param \u003d domain.id"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            param \u003d domain"},{"line_number":82,"context_line":"        utils.action_and_notify(self.client.delete, \u0027/domains/%s\u0027 % param,"},{"line_number":83,"context_line":"                                \"Deletion of domain %s completed successfully\","},{"line_number":84,"context_line":"                                \"Unable to delete the specified domain.\")"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_ccb6503d","line":82,"updated":"2015-07-20 16:02:44.000000000","message":"Seems like the client should raise an exception if the delete was unsuccessful, and we could catch it and give a better error message to me. Probably by reraising the exception? I would hope that would bubble up.","commit_id":"6bc2568266e42113b586635bfd7ce956896594f3"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"66554fe886374d5054297e6a3a0b63ff1d2ba40a","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            param \u003d domain.id"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            param \u003d domain"},{"line_number":82,"context_line":"        utils.action_and_notify(self.client.delete, \u0027/domains/%s\u0027 % param,"},{"line_number":83,"context_line":"                                \"Deletion of domain %s completed successfully\","},{"line_number":84,"context_line":"                                \"Unable to delete the specified domain.\")"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1a4dcd0f_631556e3","line":82,"in_reply_to":"3a50d1a3_59e51607","updated":"2015-08-06 05:31:56.000000000","message":"I also agree.","commit_id":"6bc2568266e42113b586635bfd7ce956896594f3"},{"author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"change_message_id":"d521209b62920976041582a7070621791e236fb9","unresolved":false,"context_lines":[{"line_number":79,"context_line":"            param \u003d domain.id"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            param \u003d domain"},{"line_number":82,"context_line":"        utils.action_and_notify(self.client.delete, \u0027/domains/%s\u0027 % param,"},{"line_number":83,"context_line":"                                \"Deletion of domain %s completed successfully\","},{"line_number":84,"context_line":"                                \"Unable to delete the specified domain.\")"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3a50d1a3_59e51607","line":82,"in_reply_to":"3a50d1a3_ccb6503d","updated":"2015-07-20 18:50:56.000000000","message":"Yea, the python bindings should not print - they should raise an exception for the calling application to catch, as it is here, Horizon won\u0027t be able to handle this etc.\n\nThe calling app - the CLI - just happens to be in the same repo!","commit_id":"6bc2568266e42113b586635bfd7ce956896594f3"},{"author":{"_account_id":395,"name":"Endre Karlson","email":"endre.karlson@gmail.com","username":"endre-karlson"},"change_message_id":"78cae10a95e804fd372093c679830e92ee4f8743","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        :param domain: A :class:`Domain`, or Domain Identifier to delete"},{"line_number":77,"context_line":"        \"\"\""},{"line_number":78,"context_line":"        if isinstance(domain, Domain):"},{"line_number":79,"context_line":"            param \u003d domain.id"},{"line_number":80,"context_line":"        else:"},{"line_number":81,"context_line":"            param \u003d domain"}],"source_content_type":"text/x-python","patch_set":3,"id":"da20952f_c56442ba","line":78,"updated":"2015-08-31 13:56:02.000000000","message":"I think you\u0027re going about this wrong. You (sh|c)ould instead use a LOG.info() to tell that the domain was succesfully deleted but using the notify code you put in with a print is wrong.\n\nPut the log call at the bottom of the delete()","commit_id":"a0dbf556208a52ecc77b6846241bda1c3a015657"}]}