)]}'
{"designateclient/functionaltests/models.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"280af061387dcb0ec39a4376908474177eb99879","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        table \u003d output_parser.table(out)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # NOTE: support multi-line values in tables"},{"line_number":50,"context_line":"        value_lines \u003d []"},{"line_number":51,"context_line":"        prev_field \u003d None"},{"line_number":52,"context_line":"        for field, value in table[\u0027values\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_89745368","line":49,"updated":"2016-03-23 21:24:36.000000000","message":"Would you mind expanding on what this comment means?","commit_id":"ce97060f1e0e1e16634d2dc53677a3831fa81a7a"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"f543976dda8cf3a403c6aa96e20ab1774eed0bc9","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \"\"\""},{"line_number":47,"context_line":"        table \u003d output_parser.table(out)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"        # NOTE: support multi-line values in tables"},{"line_number":50,"context_line":"        value_lines \u003d []"},{"line_number":51,"context_line":"        prev_field \u003d None"},{"line_number":52,"context_line":"        for field, value in table[\u0027values\u0027]:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_3e10dc58","line":49,"in_reply_to":"fa0719c6_89745368","updated":"2016-03-23 22:00:19.000000000","message":"Sure!  For a taste of an answer before I add more clarification in another patch:\n\nThe output_parser.table() call parses the output of a CLI table (the one with +\u0027s and -\u0027s).  However it behaves poorly with a value entry that is multiple lines (e.g. zonefile output).  The additional lines are available in the parsed output, but they\u0027re associated with a field name of \u0027\u0027.\n\nThis change ensures that a multi-line value entry in a CLI table is aggregated appropriately.","commit_id":"ce97060f1e0e1e16634d2dc53677a3831fa81a7a"}],"designateclient/functionaltests/v2/test_zone_export.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"592e29865fad049ace3f7eb32ee6cdd94ec21cb2","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        zone_exports \u003d self.clients.zone_export_list()"},{"line_number":39,"context_line":"        self.assertGreater(len(zone_exports), 0)"},{"line_number":40,"context_line":"        self.assertEqual(True,"},{"line_number":41,"context_line":"                         self._is_export_in_list(zone_export, zone_exports))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_create_and_show_zone_export(self):"},{"line_number":44,"context_line":"        zone_export \u003d self.useFixture(ExportFixture("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_4ce9bfe5","line":41,"updated":"2016-03-23 16:45:45.000000000","message":"You can use self.assertTrue for this.","commit_id":"cd43ad3f796f044b1b487bd57c19c76b373a41d6"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"5fbaf70137bae79189c38627b0dec1b84c38c343","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        zone_exports \u003d self.clients.zone_export_list()"},{"line_number":39,"context_line":"        self.assertGreater(len(zone_exports), 0)"},{"line_number":40,"context_line":"        self.assertEqual(True,"},{"line_number":41,"context_line":"                         self._is_export_in_list(zone_export, zone_exports))"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def test_create_and_show_zone_export(self):"},{"line_number":44,"context_line":"        zone_export \u003d self.useFixture(ExportFixture("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_90d6454d","line":41,"in_reply_to":"fa0719c6_4ce9bfe5","updated":"2016-03-23 18:28:06.000000000","message":"Oops, maybe I had a typo when executing the test using assertTrue (thought it was unavailable due to the choice of tempestlib unittest framework or something).  \n\nThanks for catching these!","commit_id":"cd43ad3f796f044b1b487bd57c19c76b373a41d6"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"592e29865fad049ace3f7eb32ee6cdd94ec21cb2","unresolved":false,"context_lines":[{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        zone_exports \u003d self.clients.zone_export_list()"},{"line_number":62,"context_line":"        self.assertEqual(True,"},{"line_number":63,"context_line":"                         self._is_export_in_list(zone_export, zone_exports))"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"        self.clients.zone_export_delete(zone_export.id)"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_0cb22706","line":63,"updated":"2016-03-23 16:45:45.000000000","message":"Same as above - assertTrue","commit_id":"cd43ad3f796f044b1b487bd57c19c76b373a41d6"},{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"592e29865fad049ace3f7eb32ee6cdd94ec21cb2","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        zone_exports \u003d self.clients.zone_export_list()"},{"line_number":68,"context_line":"        self.assertEqual(False,"},{"line_number":69,"context_line":"                         self._is_export_in_list(zone_export, zone_exports))"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def test_show_export_file(self):"},{"line_number":72,"context_line":"        zone_export \u003d self.useFixture(ExportFixture("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_ac321ba5","line":69,"updated":"2016-03-23 16:45:45.000000000","message":"Same, self.assertFalse.","commit_id":"cd43ad3f796f044b1b487bd57c19c76b373a41d6"},{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"280af061387dcb0ec39a4376908474177eb99879","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\"\"\""},{"line_number":2,"context_line":"Copyright 2016 Rackspace"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":5,"context_line":"you may not use this file except in compliance with the License."},{"line_number":6,"context_line":"You may obtain a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_4924fb5e","line":3,"updated":"2016-03-23 21:24:36.000000000","message":"How \u0027bout an author line!","commit_id":"ce97060f1e0e1e16634d2dc53677a3831fa81a7a"}],"designateclient/tests/v2/test_zones.py":[{"author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"change_message_id":"280af061387dcb0ec39a4376908474177eb99879","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"import time"},{"line_number":17,"context_line":"import uuid"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from designateclient.tests import v2"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_fb2cb603","line":16,"updated":"2016-03-23 21:24:36.000000000","message":"Is this used?","commit_id":"ce97060f1e0e1e16634d2dc53677a3831fa81a7a"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"f543976dda8cf3a403c6aa96e20ab1774eed0bc9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":"import time"},{"line_number":17,"context_line":"import uuid"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from designateclient.tests import v2"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa0719c6_71744567","line":16,"in_reply_to":"fa0719c6_fb2cb603","updated":"2016-03-23 22:00:19.000000000","message":"Yes, on line 257-258 I\u0027m using the current time in creating a new mock entity.","commit_id":"ce97060f1e0e1e16634d2dc53677a3831fa81a7a"}],"designateclient/v2/cli/zones.py":[{"author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"change_message_id":"592e29865fad049ace3f7eb32ee6cdd94ec21cb2","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"class ShowZoneExportFileCommand(show.ShowOne):"},{"line_number":485,"context_line":"    \"\"\"Show the contents of a Zone Export\"\"\""},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def get_parser(self, prog_name):"},{"line_number":488,"context_line":"        parser \u003d super(ShowZoneExportFileCommand, self).get_parser("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_fa9b2564","line":485,"updated":"2016-03-23 16:45:45.000000000","message":"We could mention that this fetches the zone file to distinguish better from the `zone export show` command. Some like \"Show the zone file for the Zone Export\" maybe.","commit_id":"cd43ad3f796f044b1b487bd57c19c76b373a41d6"},{"author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"change_message_id":"5fbaf70137bae79189c38627b0dec1b84c38c343","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":""},{"line_number":484,"context_line":"class ShowZoneExportFileCommand(show.ShowOne):"},{"line_number":485,"context_line":"    \"\"\"Show the contents of a Zone Export\"\"\""},{"line_number":486,"context_line":""},{"line_number":487,"context_line":"    def get_parser(self, prog_name):"},{"line_number":488,"context_line":"        parser \u003d super(ShowZoneExportFileCommand, self).get_parser("}],"source_content_type":"text/x-python","patch_set":1,"id":"fa0719c6_9253e516","line":485,"in_reply_to":"fa0719c6_fa9b2564","updated":"2016-03-23 18:28:06.000000000","message":"Sounds legit.","commit_id":"cd43ad3f796f044b1b487bd57c19c76b373a41d6"}]}