)]}'
{"id":"openstack%2Fpython-designateclient~298730","triplet_id":"openstack%2Fpython-designateclient~master~I23b4ecc52b71cafc4085ab6586164bd03ac6afea","project":"openstack/python-designateclient","branch":"master","topic":"fix-v2-controllers","hashtags":[],"change_id":"I23b4ecc52b71cafc4085ab6586164bd03ac6afea","subject":"Move all V2 Controllers to inherit from the v2","status":"MERGED","created":"2016-03-29 12:50:55.000000000","updated":"2016-03-29 17:06:17.000000000","submitted":"2016-03-29 17:06:17.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"ec3ca777f60290a264877adf19916a2dbe82088b","_number":298730,"virtual_id_number":298730,"owner":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-03-29 17:06:17.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},{"value":0,"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":2,"date":"2016-03-29 15:38:58.000000000","_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},{"value":2,"date":"2016-03-29 16:31:40.000000000","_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":1,"date":"2016-03-29 13:50:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},{"value":1,"date":"2016-03-29 16:31:40.000000000","_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},{"value":0,"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-29 13:50:46.000000000","updated_by":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"reviewer":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"state":"REVIEWER"},{"updated":"2016-03-29 15:38:58.000000000","updated_by":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"reviewer":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"state":"REVIEWER"},{"updated":"2016-03-29 16:31:40.000000000","updated_by":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"reviewer":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"state":"REVIEWER"},{"updated":"2016-03-29 17:06:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"05429e787bc2379c9e7e91aa6e9f1a50aa6b4274","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2016-03-29 12:50:55.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"1cf186bb9911ae4e83d0f2e27c068ee79dad2959","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-29 13:17:55.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-designateclient-docs http://docs-draft.openstack.org/30/298730/1/check/gate-python-designateclient-docs/04387c7//doc/build/html/ : SUCCESS in 2m 04s\n- gate-python-designateclient-pep8 http://logs.openstack.org/30/298730/1/check/gate-python-designateclient-pep8/e9b3883/ : SUCCESS in 1m 35s\n- gate-python-designateclient-python27 http://logs.openstack.org/30/298730/1/check/gate-python-designateclient-python27/dc440ed/ : SUCCESS in 1m 36s\n- check-osc-plugins http://logs.openstack.org/30/298730/1/check/check-osc-plugins/3db5793/ : SUCCESS in 4m 47s (non-voting)\n- gate-designate-dsvm-powerdns http://logs.openstack.org/30/298730/1/check/gate-designate-dsvm-powerdns/579813c/ : SUCCESS in 22m 24s\n- gate-python-designateclient-python34 http://logs.openstack.org/30/298730/1/check/gate-python-designateclient-python34/b2b1eb2/ : SUCCESS in 2m 05s","accounts_in_message":[],"_revision_number":1},{"id":"f21d7b337e83ace1c2c79432cacd88f424b26299","author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"date":"2016-03-29 13:40:09.000000000","message":"Patch Set 1: Code-Review-1\n\nWas there a reason other controllers aren\u0027t included in this change?\n\nBlacklistController, FloatingIPController, TLDController?","accounts_in_message":[],"_revision_number":1},{"id":"1961e28f2c900dec72ef21ae5eaf744a3c5fd3c2","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2016-03-29 13:45:53.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"db17f3704f93c54d1cbf914d696df701875ca97a","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2016-03-29 13:46:44.000000000","message":"Patch Set 1:\n\nTLD was done in the dependant patchset, FloatingIP was done, and i didnt git add blacklists. -_-\n\nUpdated","accounts_in_message":[],"_revision_number":1},{"id":"bd0f2307e8ac7e5b7fcd59a2c898c1a301c5f5d0","author":{"_account_id":15452,"name":"Rahman Syed","email":"rahman.syed@gmail.com","username":"rahmansyed"},"date":"2016-03-29 13:50:46.000000000","message":"Patch Set 2: Code-Review+1\n\nThanks!  My mistake on FloatingIP, and saw the other patchset just after I posted.","accounts_in_message":[],"_revision_number":2},{"id":"0b15f123389f2a6fae79e5dbf90b4b5365d87ea1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-29 14:20:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-designateclient-docs http://docs-draft.openstack.org/30/298730/2/check/gate-python-designateclient-docs/7ebe4d8//doc/build/html/ : SUCCESS in 3m 23s\n- gate-python-designateclient-pep8 http://logs.openstack.org/30/298730/2/check/gate-python-designateclient-pep8/5b64ae3/ : SUCCESS in 3m 16s\n- gate-python-designateclient-python27 http://logs.openstack.org/30/298730/2/check/gate-python-designateclient-python27/385e449/ : SUCCESS in 3m 52s\n- check-osc-plugins http://logs.openstack.org/30/298730/2/check/check-osc-plugins/fc9b186/ : SUCCESS in 6m 05s (non-voting)\n- gate-designate-dsvm-powerdns http://logs.openstack.org/30/298730/2/check/gate-designate-dsvm-powerdns/ce2ad6b/ : SUCCESS in 22m 10s\n- gate-python-designateclient-python34 http://logs.openstack.org/30/298730/2/check/gate-python-designateclient-python34/1d28700/ : SUCCESS in 4m 36s","accounts_in_message":[],"_revision_number":2},{"id":"68fcc3af0e760ade3f2619673d248bf75046f68a","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2016-03-29 14:59:50.000000000","message":"Patch Set 2: Cherry Picked\n\nThis patchset was cherry picked to branch stable/mitaka as commit 9150dfb7f15aa35c280f728cf4acbfa7bec6f75a","accounts_in_message":[],"_revision_number":2},{"id":"b02b877f38e6db0975fcad4eeeb04b868905f643","author":{"_account_id":15171,"name":"Eric Larson","email":"eric.larson@rackspace.com","username":"elarson"},"date":"2016-03-29 15:38:58.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"df07a8ea12be52fc872fecb8ecece3d844d5fb3d","author":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"date":"2016-03-29 16:31:40.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"4be3c792364d20a04b064c9d70a17ddb500bb8e7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-29 16:31:50.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"c361862cf5c7e678f4051073871d8afcfa209495","date":"2016-03-29 17:06:17.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"a2bab0ebfe0d722d6a8379bebb410a8ba8a20cb1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-29 17:06:17.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-designateclient-docs http://docs-draft.openstack.org/30/298730/2/gate/gate-python-designateclient-docs/e21215f//doc/build/html/ : SUCCESS in 2m 12s\n- gate-python-designateclient-pep8 http://logs.openstack.org/30/298730/2/gate/gate-python-designateclient-pep8/7752581/ : SUCCESS in 2m 00s\n- gate-python-designateclient-python27 http://logs.openstack.org/30/298730/2/gate/gate-python-designateclient-python27/d61bb9c/ : SUCCESS in 2m 10s\n- gate-designate-dsvm-powerdns http://logs.openstack.org/30/298730/2/gate/gate-designate-dsvm-powerdns/0602bd7/ : SUCCESS in 33m 39s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"255523c63d4d843be632b73eeab98e2b6f408470","revisions":{"2c26147082c9ad735ee52b60aad5498a1dd17aa5":{"kind":"REWORK","_number":1,"created":"2016-03-29 12:50:55.000000000","uploader":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"ref":"refs/changes/30/298730/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/30/298730/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/30/298730/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/30/298730/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/30/298730/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/30/298730/1"}}},"commit":{"parents":[{"commit":"9011aac4ccf5219453efbab38623b63a57282de0","subject":"Fixes \u0027openstack tld list\u0027 command\u0027s exception","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/9011aac4ccf5219453efbab38623b63a57282de0"}]}],"author":{"name":"Graham Hayes","email":"graham.hayes@hpe.com","date":"2016-03-29 12:49:02.000000000","tz":60},"committer":{"name":"Graham Hayes","email":"graham.hayes@hpe.com","date":"2016-03-29 12:50:02.000000000","tz":60},"subject":"Move all V2 Controllers to inherit from the v2","message":"Move all V2 Controllers to inherit from the v2\n\nPreviously some v2 controllers inherited from the base\nclient.Controller.\n\nFixes have been added to the V2Controller that allow it\nto work with lists + next links.\n\nChange-Id: I23b4ecc52b71cafc4085ab6586164bd03ac6afea\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/2c26147082c9ad735ee52b60aad5498a1dd17aa5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/2c26147082c9ad735ee52b60aad5498a1dd17aa5"}]},"branch":"refs/heads/master"},"255523c63d4d843be632b73eeab98e2b6f408470":{"kind":"REWORK","_number":2,"created":"2016-03-29 13:45:53.000000000","uploader":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"ref":"refs/changes/30/298730/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/30/298730/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/30/298730/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/30/298730/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/30/298730/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/30/298730/2"}}},"commit":{"parents":[{"commit":"9011aac4ccf5219453efbab38623b63a57282de0","subject":"Fixes \u0027openstack tld list\u0027 command\u0027s exception","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/9011aac4ccf5219453efbab38623b63a57282de0"}]}],"author":{"name":"Graham Hayes","email":"graham.hayes@hpe.com","date":"2016-03-29 12:49:02.000000000","tz":60},"committer":{"name":"Graham Hayes","email":"graham.hayes@hpe.com","date":"2016-03-29 13:45:36.000000000","tz":60},"subject":"Move all V2 Controllers to inherit from the v2","message":"Move all V2 Controllers to inherit from the v2\n\nPreviously some v2 controllers inherited from the base\nclient.Controller.\n\nFixes have been added to the V2Controller that allow it\nto work with lists + next links.\n\nChange-Id: I23b4ecc52b71cafc4085ab6586164bd03ac6afea\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/255523c63d4d843be632b73eeab98e2b6f408470"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/255523c63d4d843be632b73eeab98e2b6f408470"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}