)]}'
{"id":"openstack%2Fpython-designateclient~308011","triplet_id":"openstack%2Fpython-designateclient~master~I32f74aee0035a953e6ec1c9f4a461179c251d68e","project":"openstack/python-designateclient","branch":"master","topic":"update_noauth","hashtags":[],"change_id":"I32f74aee0035a953e6ec1c9f4a461179c251d68e","subject":"noauth-related doc and test updates","status":"ABANDONED","created":"2016-04-19 19:36:25.000000000","updated":"2016-05-12 09:12:16.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"9ca3c433ed4179258bbfb46a426100aa60cc1f02","_number":308011,"virtual_id_number":308011,"owner":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2016-05-06 17:41:38.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-04-19 21:04:10.000000000","_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},{"value":-1,"date":"2016-04-19 20:39:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"rejected":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2016-04-19 21:22:21.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-04-19 20:39:08.000000000","updated_by":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"reviewer":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"state":"REVIEWER"},{"updated":"2016-05-06 17:41:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"41f57633018be39fdb6c0d511a6db9428d7aef3e","author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"date":"2016-04-19 19:36:25.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ac57fdfc2b469e6370f64db7ab2a5b2daf21f504","author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"date":"2016-04-19 20:39:08.000000000","message":"Patch Set 1: Code-Review-1\n\nWhat version of openstack client do you have? I see the --os-url argument, after installing the latest version of python-openstackclient with pip:\n\n    $ openstack --version\n    openstack 2.3.0\n    $ openstack --help | grep os-url\n                     [--os-endpoint \u003cauth-endpoint\u003e] [--os-url \u003cauth-url\u003e]\n      --os-url \u003cauth-url\u003e   With token_endpoint: Specific service endpoint to use\n\nI could be mis-remembering but these functional tests will never completely pass against a Designate running in noauth mode. The python-designateclient does not pass in the X-Auth-Project-ID header, which means all zones are created on the same account when the override url is specified. This means all tests involving two tenants (zone transfers) will always fail.\n\nWhile I\u0027m not sure about --os-url vs --os-endpoint, I find no mention of --os-endpoint in the python-openstackclient repository, and for example, the docs only mention --os-url: http://docs.openstack.org/developer/python-openstackclient/authentication.html","accounts_in_message":[],"_revision_number":1},{"id":"835d5f491ea942d015b49e5b66fd9b0ebd3cf167","author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"date":"2016-04-19 21:04:10.000000000","message":"Patch Set 1:\n\nHi Paul, I am actually using the designate client, not openstack client.  Are you saying the designate client internally uses the openstack client?","accounts_in_message":[],"_revision_number":1},{"id":"e15dd8354fb05ac553cc746bd0d44cf261b809ca","author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"date":"2016-04-19 21:16:07.000000000","message":"Patch Set 1:\n\nOh, I didn\u0027t notice that the shell examples were using the `designate` client. The `designate` client works with Designate\u0027s v1 api, which is deprecated. \n\npython-designateclient also has a plugin for the openstack client, which works with Designate\u0027s v2 api (which is current). There is some pretty pitiful documentation for the new cli here: http://docs.openstack.org/developer/python-designateclient/shell-v2.html\n\nThe tests at designateclient/functionaltests exercise the `openstack` cli. They do not use the older `designate` cli.","accounts_in_message":[],"_revision_number":1},{"id":"d0bd5213cd2e0ff29c7adef00a256b64ca52c8f6","author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"date":"2016-04-19 21:22:21.000000000","message":"Patch Set 1: Workflow-1\n\nThanks Paul, that helps a ton!  I\u0027m going to WIP this review and see if I can make it clear to use openstack client instead.","accounts_in_message":[],"_revision_number":1},{"id":"3889a17ce0412a4ca6bf02942068db64efd0504f","author":{"_account_id":11662,"name":"Paul Glass","email":"paul.glass@rackspace.com","username":"pglass"},"date":"2016-04-19 21:25:52.000000000","message":"Patch Set 1:\n\nSure. If you have questions about anything you can find Designate people in `#openstack-dns` on freenode, too.","accounts_in_message":[],"_revision_number":1},{"id":"b03479d73021d4026ceda949fe9e1e46577562b0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-04-20 02:28:04.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-designateclient-docs http://docs-draft.openstack.org/11/308011/1/check/gate-python-designateclient-docs/e2acb24//doc/build/html/ : SUCCESS in 1m 56s\n- gate-python-designateclient-pep8 http://logs.openstack.org/11/308011/1/check/gate-python-designateclient-pep8/d5b9a29/ : SUCCESS in 1m 45s\n- gate-python-designateclient-python27 http://logs.openstack.org/11/308011/1/check/gate-python-designateclient-python27/acd65a8/ : SUCCESS in 1m 57s\n- check-osc-plugins http://logs.openstack.org/11/308011/1/check/check-osc-plugins/4435938/ : SUCCESS in 3m 38s (non-voting)\n- gate-designate-dsvm-powerdns http://logs.openstack.org/11/308011/1/check/gate-designate-dsvm-powerdns/7ab5586/ : SUCCESS in 31m 41s\n- gate-designate-dsvm-bind9 http://logs.openstack.org/11/308011/1/check/gate-designate-dsvm-bind9/b6b482a/ : SUCCESS in 30m 38s\n- gate-tempest-dsvm-designate-powerdns http://logs.openstack.org/11/308011/1/check/gate-tempest-dsvm-designate-powerdns/1872412/ : SUCCESS in 21m 03s\n- gate-tempest-dsvm-designate-bind9 http://logs.openstack.org/11/308011/1/check/gate-tempest-dsvm-designate-bind9/7868a5d/ : SUCCESS in 20m 35s\n- gate-rally-dsvm-designate-designate http://logs.openstack.org/11/308011/1/check/gate-rally-dsvm-designate-designate/f491211/ : FAILURE in 25m 13s (non-voting)\n- gate-python-designateclient-python34 http://logs.openstack.org/11/308011/1/check/gate-python-designateclient-python34/18bf4fd/ : SUCCESS in 2m 33s","accounts_in_message":[],"_revision_number":1},{"id":"306d6544ffe3b4b1515604d24f9d716ec7ca4ea0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-05-06 17:41:38.000000000","message":"Patch Set 1: Verified-1\n\nMerge Failed.\n\nThis change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"8bc66eb35c3555d9072c345f0e3a5d909b58a966","author":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"date":"2016-05-12 09:12:16.000000000","message":"Abandoned\n\nAbandoning for now.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"900428154c2526cf909c8cdb30d16ccd56a2f12b","revisions":{"900428154c2526cf909c8cdb30d16ccd56a2f12b":{"kind":"REWORK","_number":1,"created":"2016-04-19 19:36:25.000000000","uploader":{"_account_id":7307,"name":"Matt Thompson","email":"mattt@defunct.ca","username":"mattt416"},"ref":"refs/changes/11/308011/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/11/308011/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/11/308011/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/11/308011/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/11/308011/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/11/308011/1"}}},"commit":{"parents":[{"commit":"df20e404051d2fdcbafa94563ec003f85a58680d","subject":"Merge \"Run the functional tests in a more verbose mode\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/df20e404051d2fdcbafa94563ec003f85a58680d"}]}],"author":{"name":"Matt Thompson","email":"mattt@defunct.ca","date":"2016-04-19 19:25:48.000000000","tz":60},"committer":{"name":"Matt Thompson","email":"mattt@defunct.ca","date":"2016-04-19 19:36:22.000000000","tz":60},"subject":"noauth-related doc and test updates","message":"noauth-related doc and test updates\n\nThis commit does the following to doc/source/shell-examples.rst:\n\n- updates designate examples to pass in --os-token, which according to\n  my tests is necessary when Designate is configured with \u0027noauth\u0027\n- updates some spelling and grammatical errors\n\nAdditionally, this commit updates\ndesignateclient/functionaltests/client.py to use ``--os-endpoint``\ninstead of ``--os-url``, which according to what I can see is not a\nvalid option.\n\nChange-Id: I32f74aee0035a953e6ec1c9f4a461179c251d68e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/900428154c2526cf909c8cdb30d16ccd56a2f12b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/900428154c2526cf909c8cdb30d16ccd56a2f12b"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}