)]}'
{"id":"openstack%2Fpython-designateclient~340102","triplet_id":"openstack%2Fpython-designateclient~master~Iefbe60e4650ab221f1ceebb8e2964f5a43118e01","project":"openstack/python-designateclient","branch":"master","topic":"instead_of_None","hashtags":[],"change_id":"Iefbe60e4650ab221f1ceebb8e2964f5a43118e01","subject":"Prints  \u0027-\u0027 instead of \u0027None\u0027 when data is None","status":"ABANDONED","created":"2016-07-10 05:47:31.000000000","updated":"2016-07-12 11:51:48.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b80f96c537e8c434f88cd9c30b9b6785e51678a4","_number":340102,"virtual_id_number":340102,"owner":{"_account_id":17795,"name":"PanFengyun","email":"pan_feng_yun@163.com","username":"panfy"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":1,"date":"2016-07-10 11:58:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"rejected":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":-2,"date":"2016-07-12 08:23:11.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-10 11:58:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-07-12 08:23:11.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"}],"messages":[{"id":"5dbd9e5f38d4e1f5dca0d6b9aedd060def44ce96","author":{"_account_id":17795,"name":"PanFengyun","email":"pan_feng_yun@163.com","username":"panfy"},"date":"2016-07-10 05:47:31.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"e154e7347275d99c491b3ee0af6abdbbcccddb1b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-10 06:26:06.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-designateclient-docs http://docs-draft.openstack.org/02/340102/1/check/gate-python-designateclient-docs/0c14aeb//doc/build/html/ : SUCCESS in 2m 33s\n- gate-python-designateclient-pep8 http://logs.openstack.org/02/340102/1/check/gate-python-designateclient-pep8/daa816a/ : SUCCESS in 3m 47s\n- gate-python-designateclient-python27 http://logs.openstack.org/02/340102/1/check/gate-python-designateclient-python27/6570c67/ : SUCCESS in 4m 09s\n- check-osc-plugins http://logs.openstack.org/02/340102/1/check/check-osc-plugins/13d064e/ : SUCCESS in 4m 13s\n- gate-designate-dsvm-powerdns http://logs.openstack.org/02/340102/1/check/gate-designate-dsvm-powerdns/3941608/ : SUCCESS in 37m 55s\n- gate-designate-dsvm-bind9 http://logs.openstack.org/02/340102/1/check/gate-designate-dsvm-bind9/91b0b4d/ : SUCCESS in 21m 11s\n- gate-tempest-dsvm-designate-powerdns http://logs.openstack.org/02/340102/1/check/gate-tempest-dsvm-designate-powerdns/5361212/ : SUCCESS in 30m 12s\n- gate-tempest-dsvm-designate-bind9 http://logs.openstack.org/02/340102/1/check/gate-tempest-dsvm-designate-bind9/41bbc75/ : SUCCESS in 15m 21s\n- gate-rally-dsvm-designate-designate http://logs.openstack.org/02/340102/1/check/gate-rally-dsvm-designate-designate/a5ccbc4/ : FAILURE in 15m 19s (non-voting)\n- gate-python-designateclient-python34 http://logs.openstack.org/02/340102/1/check/gate-python-designateclient-python34/9c49ee0/ : SUCCESS in 3m 11s\n- gate-python-designateclient-python35-nv http://logs.openstack.org/02/340102/1/check/gate-python-designateclient-python35-nv/170152c/ : SUCCESS in 4m 11s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"4f31a2ceb82b8e2c4080bf62c89a3f60f854a4e5","author":{"_account_id":17795,"name":"PanFengyun","email":"pan_feng_yun@163.com","username":"panfy"},"date":"2016-07-10 11:19:37.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"501d676a98157dbb326950e7f2b757c198766595","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-10 11:58:09.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-designateclient-docs http://docs-draft.openstack.org/02/340102/2/check/gate-python-designateclient-docs/ccc3ce9//doc/build/html/ : SUCCESS in 4m 21s\n- gate-python-designateclient-pep8 http://logs.openstack.org/02/340102/2/check/gate-python-designateclient-pep8/a79eff5/ : SUCCESS in 2m 52s\n- gate-python-designateclient-python27 http://logs.openstack.org/02/340102/2/check/gate-python-designateclient-python27/d5c9796/ : SUCCESS in 2m 42s\n- check-osc-plugins http://logs.openstack.org/02/340102/2/check/check-osc-plugins/3e93057/ : SUCCESS in 3m 52s\n- gate-designate-dsvm-powerdns http://logs.openstack.org/02/340102/2/check/gate-designate-dsvm-powerdns/8a5a84b/ : SUCCESS in 34m 13s\n- gate-designate-dsvm-bind9 http://logs.openstack.org/02/340102/2/check/gate-designate-dsvm-bind9/050507d/ : SUCCESS in 36m 22s\n- gate-tempest-dsvm-designate-powerdns http://logs.openstack.org/02/340102/2/check/gate-tempest-dsvm-designate-powerdns/e87ef79/ : SUCCESS in 28m 24s\n- gate-tempest-dsvm-designate-bind9 http://logs.openstack.org/02/340102/2/check/gate-tempest-dsvm-designate-bind9/b8a7fc4/ : SUCCESS in 26m 03s\n- gate-rally-dsvm-designate-designate http://logs.openstack.org/02/340102/2/check/gate-rally-dsvm-designate-designate/0ccd8b2/ : FAILURE in 27m 30s (non-voting)\n- gate-python-designateclient-python34 http://logs.openstack.org/02/340102/2/check/gate-python-designateclient-python34/0686acf/ : SUCCESS in 2m 54s\n- gate-python-designateclient-python35-nv http://logs.openstack.org/02/340102/2/check/gate-python-designateclient-python35-nv/8cf75be/ : SUCCESS in 4m 26s (non-voting)","accounts_in_message":[],"_revision_number":2},{"id":"c1c7b282ebc4434d1b529615330f8fd0acd6f413","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2016-07-12 08:23:11.000000000","message":"Patch Set 2: Code-Review-2\n\nWe print \u0027\u0027 (empty string). Changing this is a breaking change, that I see no point for.\n\nWhy is \u0027-\u0027 better than \u0027\u0027 ?\n\nIf this is going to be done across openstack, this should be a cross project spec.\n\nAlso tests are completely irrelevant to the change - if this was to be merged, they would have to be removed.","accounts_in_message":[],"_revision_number":2},{"id":"00aa8fd4c6a1956f458d1380093225b98ed7752e","author":{"_account_id":17795,"name":"PanFengyun","email":"pan_feng_yun@163.com","username":"panfy"},"date":"2016-07-12 11:51:48.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f4355bf21ebf6126aec0508adb5054e8826f80a1","revisions":{"90f0ffb0fdd1a925b2aaeee4c02fb80cbee2884e":{"kind":"REWORK","_number":1,"created":"2016-07-10 05:47:31.000000000","uploader":{"_account_id":17795,"name":"PanFengyun","email":"pan_feng_yun@163.com","username":"panfy"},"ref":"refs/changes/02/340102/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/02/340102/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/02/340102/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/02/340102/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/02/340102/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/02/340102/1"}}},"commit":{"parents":[{"commit":"0a2959ec8ab6cf1791c2b5396b70f4c89b734d6f","subject":"Merge \"Use osc_lib instead of cliff\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/0a2959ec8ab6cf1791c2b5396b70f4c89b734d6f"}]}],"author":{"name":"PanFengyun","email":"fengyun.pan@easystack.cn","date":"2016-07-10 05:46:36.000000000","tz":480},"committer":{"name":"PanFengyun","email":"fengyun.pan@easystack.cn","date":"2016-07-10 05:46:58.000000000","tz":480},"subject":"Prints  \u0027-\u0027 instead of \u0027None\u0027 when data is None","message":"Prints  \u0027-\u0027 instead of \u0027None\u0027 when data is None\n\nClient prints \u0027None\u0027 when data is None , and client also prints\n\u0027None\u0027 when data is a string \u0027None\u0027. But string \u0027None\u0027 is  different\nto None. To clear the confusion, Client should print \u0027-\u0027 instead of\n\u0027None\u0027 when data is None. Nova Client and Cinder Client has cleared\nthe confusion.\n\nChange-Id: Iefbe60e4650ab221f1ceebb8e2964f5a43118e01\nRelated-Bug: #1266414\nRelated-Bug: #1422244\nRelated-Bug: #1600553\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/90f0ffb0fdd1a925b2aaeee4c02fb80cbee2884e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/90f0ffb0fdd1a925b2aaeee4c02fb80cbee2884e"}]},"branch":"refs/heads/master"},"f4355bf21ebf6126aec0508adb5054e8826f80a1":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2016-07-10 11:19:37.000000000","uploader":{"_account_id":17795,"name":"PanFengyun","email":"pan_feng_yun@163.com","username":"panfy"},"ref":"refs/changes/02/340102/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/02/340102/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/02/340102/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/02/340102/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/02/340102/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/02/340102/2"}}},"commit":{"parents":[{"commit":"0a2959ec8ab6cf1791c2b5396b70f4c89b734d6f","subject":"Merge \"Use osc_lib instead of cliff\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/0a2959ec8ab6cf1791c2b5396b70f4c89b734d6f"}]}],"author":{"name":"PanFengyun","email":"fengyun.pan@easystack.cn","date":"2016-07-10 11:18:40.000000000","tz":480},"committer":{"name":"PanFengyun","email":"fengyun.pan@easystack.cn","date":"2016-07-10 11:18:40.000000000","tz":480},"subject":"Prints  \u0027-\u0027 instead of \u0027None\u0027 when data is None","message":"Prints  \u0027-\u0027 instead of \u0027None\u0027 when data is None\n\nClient prints \u0027None\u0027 when data is None , and client also prints\n\u0027None\u0027 when data is a string \u0027None\u0027. But string \u0027None\u0027 is  different\nto None. To clear the confusion, Client should print \u0027-\u0027 instead of\n\u0027None\u0027 when data is None. Nova Client and Cinder Client has cleared\nthe confusion.\n\nChange-Id: Iefbe60e4650ab221f1ceebb8e2964f5a43118e01\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/f4355bf21ebf6126aec0508adb5054e8826f80a1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/f4355bf21ebf6126aec0508adb5054e8826f80a1"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}