)]}'
{"id":"openstack%2Fpython-designateclient~366253","triplet_id":"openstack%2Fpython-designateclient~master~I5f2b45d14d32a631cefbb4ba94e9ac257340574d","project":"openstack/python-designateclient","branch":"master","topic":"bug/1620729","hashtags":[],"change_id":"I5f2b45d14d32a631cefbb4ba94e9ac257340574d","subject":"ptr record list fails with error","status":"ABANDONED","created":"2016-09-06 17:04:08.000000000","updated":"2016-09-07 14:49:26.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2982c9d6c710f4b88a1d6aeac350a912ffb2b0f3","_number":366253,"virtual_id_number":366253,"owner":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":-1,"date":"2016-09-06 17:40:46.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"date":"2016-09-07 02:04:02.000000000","_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"all":[{"value":-1,"date":"2016-09-06 22:27:36.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"date":"2016-09-06 17:19:02.000000000","_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-06 17:19:02.000000000","updated_by":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"reviewer":{"_account_id":741,"name":"Kiall Mac Innes","email":"kiall@macinnes.ie","username":"kiall"},"state":"REVIEWER"},{"updated":"2016-09-06 17:40:46.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2016-09-06 22:27:36.000000000","updated_by":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"reviewer":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"state":"REVIEWER"}],"messages":[{"id":"eef200d5caf61d49c076c449dfaf0c4413b6af00","author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"date":"2016-09-06 17:04:08.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"bc0cef80f2c3a73121e3de6bc5b80cc991166851","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-06 17:40:46.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-designateclient-docs-ubuntu-xenial http://docs-draft.openstack.org/53/366253/1/check/gate-python-designateclient-docs-ubuntu-xenial/f9425fb//doc/build/html/ : SUCCESS in 2m 09s\n- gate-python-designateclient-pep8-ubuntu-xenial http://logs.openstack.org/53/366253/1/check/gate-python-designateclient-pep8-ubuntu-xenial/8ac5d01/ : SUCCESS in 2m 07s\n- gate-python-designateclient-python27-ubuntu-xenial http://logs.openstack.org/53/366253/1/check/gate-python-designateclient-python27-ubuntu-xenial/c997d55/ : SUCCESS in 2m 15s\n- check-osc-plugins http://logs.openstack.org/53/366253/1/check/check-osc-plugins/ad9f362/ : SUCCESS in 3m 25s (non-voting)\n- gate-designate-dsvm-powerdns http://logs.openstack.org/53/366253/1/check/gate-designate-dsvm-powerdns/c243685/ : SUCCESS in 36m 24s\n- gate-designate-dsvm-bind9 http://logs.openstack.org/53/366253/1/check/gate-designate-dsvm-bind9/1090c2c/ : SUCCESS in 26m 42s\n- gate-tempest-dsvm-designate-powerdns http://logs.openstack.org/53/366253/1/check/gate-tempest-dsvm-designate-powerdns/8aa492c/ : SUCCESS in 19m 29s\n- gate-tempest-dsvm-designate-bind9 http://logs.openstack.org/53/366253/1/check/gate-tempest-dsvm-designate-bind9/a5725fd/ : SUCCESS in 18m 45s\n- gate-tempest-dsvm-designate-powerdns-postgres-nv http://logs.openstack.org/53/366253/1/check/gate-tempest-dsvm-designate-powerdns-postgres-nv/182f3d6/ : FAILURE in 20m 48s (non-voting)\n- gate-rally-dsvm-designate-designate http://logs.openstack.org/53/366253/1/check/gate-rally-dsvm-designate-designate/e3d3836/ : FAILURE in 22m 13s (non-voting)\n- gate-grenade-dsvm-designate-powerdns http://logs.openstack.org/53/366253/1/check/gate-grenade-dsvm-designate-powerdns/7c470bb/ : FAILURE in 16m 34s\n- gate-tempest-dsvm-designate-powerdns-identity-v3-only-nv http://logs.openstack.org/53/366253/1/check/gate-tempest-dsvm-designate-powerdns-identity-v3-only-nv/f74e3b5/ : FAILURE in 22m 35s (non-voting)\n- gate-python-designateclient-python35-nv http://logs.openstack.org/53/366253/1/check/gate-python-designateclient-python35-nv/a6a39ab/ : SUCCESS in 2m 58s (non-voting)\n- gate-python-designateclient-python34 http://logs.openstack.org/53/366253/1/check/gate-python-designateclient-python34/160433d/ : SUCCESS in 2m 15s","accounts_in_message":[],"_revision_number":1},{"id":"9f739f91998c6a4b223ff99746e9354e1e505aac","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2016-09-06 22:27:36.000000000","message":"Patch Set 1: Code-Review-1\n\nthis is needed for other calls to the API - we cannot just remove it.","accounts_in_message":[],"_revision_number":1},{"id":"80f184dab53220218967e971691ed7d8b3e739cb","author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"date":"2016-09-07 02:04:02.000000000","message":"Patch Set 1:\n\nHi Graham,\nCan you please let me know what other APIs that are getting impacted? I will test ...","accounts_in_message":[],"_revision_number":1},{"id":"62154fe17035491f1b7d709b1be1c1cf9ab22326","author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"date":"2016-09-07 11:13:02.000000000","message":"Patch Set 1:\n\nHi Graham,\nhttps://github.com/openstack/python-designateclient/blob/fd118972b0128dbd65d349a385f4cab7b528217e/designateclient/v2/utils.py#L69 passes keyword arguments criterion\u003dcriterion .\n\nBut the function name is calling for https://github.com/openstack/python-designateclient/blob/stable/mitaka/designateclient/v2/reverse.py#L34\nSince the list function does not accept the extra keyword argument thats why the error reported","accounts_in_message":[],"_revision_number":1},{"id":"b6efa4edd9cf358d21f611b85c889ccaf43db139","author":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"date":"2016-09-07 14:49:26.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"98e97136a496269403f5d3e499a157bedf63adff","revisions":{"98e97136a496269403f5d3e499a157bedf63adff":{"kind":"REWORK","_number":1,"created":"2016-09-06 17:04:08.000000000","uploader":{"_account_id":10781,"name":"selvakumar","email":"selvakumar.s2@hpe.com","username":"selvakumar"},"ref":"refs/changes/53/366253/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/53/366253/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/53/366253/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/53/366253/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/53/366253/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/53/366253/1"}}},"commit":{"parents":[{"commit":"0971bd5483faa5d316ec6de4c5084ce555e4dce7","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/0971bd5483faa5d316ec6de4c5084ce555e4dce7"}]}],"author":{"name":"Selvakumar S","email":"selvakumar.s2@hp.com","date":"2016-09-06 16:55:26.000000000","tz":-420},"committer":{"name":"Selvakumar S","email":"selvakumar.s2@hp.com","date":"2016-09-06 16:58:27.000000000","tz":-420},"subject":"ptr record list fails with error","message":"ptr record list fails with error\n\nopenstack ptr record list fails with \u0027unexpected keyword\nargument \u0027criterion\u0027\u0027 as extra argument is being passed in\nutils.py for the FloatingIPController.list function.\n\nChange-Id: I5f2b45d14d32a631cefbb4ba94e9ac257340574d\nCloses-Bug: 1620729\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/98e97136a496269403f5d3e499a157bedf63adff"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/98e97136a496269403f5d3e499a157bedf63adff"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}