)]}'
{"id":"openstack%2Fpython-designateclient~543457","triplet_id":"openstack%2Fpython-designateclient~master~Ib943ed0eea436ad1a7ad0c3717f0fb6bd6b5b3f0","project":"openstack/python-designateclient","branch":"master","topic":"update-recordsets-update-UI","hashtags":[],"change_id":"Ib943ed0eea436ad1a7ad0c3717f0fb6bd6b5b3f0","subject":"Improve the RecordSet Update UI","status":"MERGED","created":"2018-02-12 13:42:35.000000000","updated":"2018-02-12 20:45:02.000000000","submitted":"2018-02-12 20:45:02.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"543457-1518468302634-ae768c8a","meta_rev_id":"1f5e9a12c7f5ab920a6374214c2be8123cb649f3","_number":543457,"virtual_id_number":543457,"owner":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":2,"date":"2018-02-12 20:45:02.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":2,"date":"2018-02-12 14:41:47.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-02-12 18:48:39.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2018-02-12 18:48:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-02-12 14:41:47.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2018-02-12 18:48:39.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2018-02-12 20:45:02.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"5d16ce5af8fea80fd0796d325b7aa40954f38686","author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"date":"2018-02-12 13:42:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"be6a1e23d34f7e68caff773f832bcadb0fbf7409","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-12 14:38:21.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/57/543457/1/check/openstack-tox-pep8/7a30b01/ : SUCCESS in 3m 31s\n- openstack-tox-py27 http://logs.openstack.org/57/543457/1/check/openstack-tox-py27/97874f9/ : SUCCESS in 3m 53s\n- build-openstack-sphinx-docs http://logs.openstack.org/57/543457/1/check/build-openstack-sphinx-docs/a2d78e0/html/ : SUCCESS in 3m 58s\n- openstackclient-check-plugins http://logs.openstack.org/57/543457/1/check/openstackclient-check-plugins/5a353c1/ : SUCCESS in 6m 18s (non-voting)\n- openstack-tox-py35 http://logs.openstack.org/57/543457/1/check/openstack-tox-py35/8c8ee41/ : SUCCESS in 4m 39s\n- designate-devstack-bind9 http://logs.openstack.org/57/543457/1/check/designate-devstack-bind9/742b6b4/ : SUCCESS in 27m 47s\n- designate-devstack-pdns4 http://logs.openstack.org/57/543457/1/check/designate-devstack-pdns4/2f5f706/ : SUCCESS in 26m 01s\n- designate-devstack-pdns4-postgres http://logs.openstack.org/57/543457/1/check/designate-devstack-pdns4-postgres/037dc55/ : SUCCESS in 23m 06s\n- designate-devstack-pdns4-manager-model http://logs.openstack.org/57/543457/1/check/designate-devstack-pdns4-manager-model/7841245/ : SUCCESS in 26m 42s\n- designate-devstack-pdns4-py35 http://logs.openstack.org/57/543457/1/check/designate-devstack-pdns4-py35/eef4645/ : SUCCESS in 26m 02s\n- designate-grenade-pdns4 http://logs.openstack.org/57/543457/1/check/designate-grenade-pdns4/df07692/ : SUCCESS in 49m 58s","accounts_in_message":[],"_revision_number":1},{"id":"15301a4424286437bc7d92d108331f64008ed03c","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2018-02-12 14:41:47.000000000","message":"Patch Set 1: Code-Review+2\n\nGood catch","accounts_in_message":[],"_revision_number":1},{"id":"8e91013dd5aa469f1c867624205d34054d3b79df","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2018-02-12 18:48:39.000000000","message":"Patch Set 1: Workflow+1 Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"2ae6efa5ca40bb07f0f6b1284babfe77b5e648ac","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-12 19:06:24.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"00e1ca35b9f73944df165431a007ea00cdf5f296","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-12 20:45:02.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":1},{"id":"07bc0f3711afb4c4e6a3f8e4b6aaf0b0e1b0f8e0","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-02-12 20:45:02.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/57/543457/1/gate/openstack-tox-pep8/6e0edc0/ : SUCCESS in 4m 14s\n- openstack-tox-py27 http://logs.openstack.org/57/543457/1/gate/openstack-tox-py27/a622b34/ : SUCCESS in 3m 23s\n- build-openstack-sphinx-docs http://logs.openstack.org/57/543457/1/gate/build-openstack-sphinx-docs/f171e65/html/ : SUCCESS in 4m 03s\n- openstack-tox-py35 http://logs.openstack.org/57/543457/1/gate/openstack-tox-py35/f1513d1/ : SUCCESS in 4m 48s\n- designate-devstack-bind9 http://logs.openstack.org/57/543457/1/gate/designate-devstack-bind9/5cecf9a/ : SUCCESS in 27m 05s\n- designate-devstack-pdns4 http://logs.openstack.org/57/543457/1/gate/designate-devstack-pdns4/b977ce2/ : SUCCESS in 24m 24s\n- designate-devstack-pdns4-postgres http://logs.openstack.org/57/543457/1/gate/designate-devstack-pdns4-postgres/5fe6d6d/ : SUCCESS in 26m 35s\n- designate-devstack-pdns4-manager-model http://logs.openstack.org/57/543457/1/gate/designate-devstack-pdns4-manager-model/5d70196/ : SUCCESS in 28m 33s\n- designate-grenade-pdns4 http://logs.openstack.org/57/543457/1/gate/designate-grenade-pdns4/4c9d5a1/ : SUCCESS in 1h 15m 00s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"653643b448f10bec6d6c6d899831318f6bdbcf82","revisions":{"653643b448f10bec6d6c6d899831318f6bdbcf82":{"kind":"REWORK","_number":1,"created":"2018-02-12 13:42:35.000000000","uploader":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"ref":"refs/changes/57/543457/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/57/543457/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/57/543457/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/57/543457/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/57/543457/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/57/543457/1"}}},"commit":{"parents":[{"commit":"1a3632cf5748db837b6d85b1f8d40eeae0a270c6","subject":"Merge \"Updated from global requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/1a3632cf5748db837b6d85b1f8d40eeae0a270c6"}]}],"author":{"name":"Graham Hayes","email":"gr@ham.ie","date":"2018-02-12 13:41:10.000000000","tz":0},"committer":{"name":"Graham Hayes","email":"gr@ham.ie","date":"2018-02-12 13:41:10.000000000","tz":0},"subject":"Improve the RecordSet Update UI","message":"Improve the RecordSet Update UI\n\nThis adds the logic introduced in\nI8fefd9d0f104170d50c5d5dc3cbcc53facda9baf to the \"recordset set\"\ncommand as well.\n\nThis helps with the consistancy, and fixes some of the same issues\nin the set command.\n\nChange-Id: Ib943ed0eea436ad1a7ad0c3717f0fb6bd6b5b3f0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/653643b448f10bec6d6c6d899831318f6bdbcf82"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/653643b448f10bec6d6c6d899831318f6bdbcf82"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}