)]}'
{"designateclient/v2/cli/common.py":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"a2d52af0d4174502ce5535d82941dd018bd87d77","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"# under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def add_all_projects_option(parser):"},{"line_number":19,"context_line":"    parser.add_argument("},{"line_number":20,"context_line":"        \u0027--all-projects\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_c3aaca83","side":"PARENT","line":17,"updated":"2018-04-10 16:01:32.000000000","message":"Need another blank line here.","commit_id":"6eeef0dd24e0787f6c2c58f63ae27872ad22ac47"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"ef764f6009f1f3998240808dddfb9e747065eb25","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        set_edit_managed(client, parsed_args.edit_managed)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if parsed_args.sudo_project_id is not None and \\"},{"line_number":73,"context_line":"            isinstance(parsed_args.sudo_project_id, six.string_types):"},{"line_number":74,"context_line":"        set_sudo_project_id(client, parsed_args.sudo_project_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf659307_f578e1f8","line":73,"updated":"2018-04-10 16:43:23.000000000","message":"I assume this is needed because we\u0027re getting a unicode type from argparse in Python 2?","commit_id":"a1e3c006be5b6b58952725abc7c84dce6a0f6e9b"},{"author":{"_account_id":8099,"name":"Graham Hayes","email":"gr@ham.ie","username":"graham"},"change_message_id":"3eb0f57f145c7e6fffa2663647e68a9b5994ce11","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        set_edit_managed(client, parsed_args.edit_managed)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    if parsed_args.sudo_project_id is not None and \\"},{"line_number":73,"context_line":"            isinstance(parsed_args.sudo_project_id, six.string_types):"},{"line_number":74,"context_line":"        set_sudo_project_id(client, parsed_args.sudo_project_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_18240fc6","line":73,"in_reply_to":"bf659307_f578e1f8","updated":"2018-04-16 14:56:36.000000000","message":"yup - I can\u0027t seem to find when that changed :/","commit_id":"a1e3c006be5b6b58952725abc7c84dce6a0f6e9b"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"16d5662ac65f5f27e688a1aa2605bd3cffcfc752","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def set_all_projects(client, value):"},{"line_number":52,"context_line":"    client.session.all_projects \u003d value"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"def set_sudo_project_id(client, value):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_3e41883a","line":52,"updated":"2018-04-18 08:29:54.000000000","message":"Actually we might clean this up, too, I think. Having four lines of code instead of simply the single set statement doesn\u0027t seem useful to me.","commit_id":"c0543004d06825c5b3d5f6f91b0ba2ad470fbf9c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"19d980afa1f375298926799e214c1c6f4034f697","unresolved":false,"context_lines":[{"line_number":63,"context_line":"def set_all_common_headers(client, parsed_args):"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    if parsed_args.all_projects is not None and \\"},{"line_number":66,"context_line":"            isinstance(parsed_args.all_projects, bool):"},{"line_number":67,"context_line":"        set_all_projects(client, parsed_args.all_projects)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    if parsed_args.edit_managed is not None and \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_6b20a4b1","line":66,"updated":"2018-04-18 08:28:10.000000000","message":"If we do clean this up, this statement seem always to be satisfies by the way the option is defined above.","commit_id":"c0543004d06825c5b3d5f6f91b0ba2ad470fbf9c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"19d980afa1f375298926799e214c1c6f4034f697","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        set_all_projects(client, parsed_args.all_projects)"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    if parsed_args.edit_managed is not None and \\"},{"line_number":70,"context_line":"            isinstance(parsed_args.edit_managed, bool):"},{"line_number":71,"context_line":"        set_edit_managed(client, parsed_args.edit_managed)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    if parsed_args.sudo_project_id is not None and \\"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_2b2aac8f","line":70,"updated":"2018-04-18 08:28:10.000000000","message":"Dito","commit_id":"c0543004d06825c5b3d5f6f91b0ba2ad470fbf9c"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"19d980afa1f375298926799e214c1c6f4034f697","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        set_edit_managed(client, parsed_args.edit_managed)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    if parsed_args.sudo_project_id is not None and \\"},{"line_number":74,"context_line":"            isinstance(parsed_args.sudo_project_id, six.string_types):"},{"line_number":75,"context_line":"        set_sudo_project_id(client, parsed_args.sudo_project_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_cb31b00d","line":74,"updated":"2018-04-18 08:28:10.000000000","message":"Actually I think it is a very bad behaviour to simply ignore arguments that do not match a certain pattern. As a user, I would expect an error to be thrown in that situation instead of my argument being silently ignored. Might be good for a followup, though.","commit_id":"c0543004d06825c5b3d5f6f91b0ba2ad470fbf9c"}]}