)]}'
{"id":"openstack%2Fpython-designateclient~682868","triplet_id":"openstack%2Fpython-designateclient~master~I9716014d65a3f649c23eb78faca2cb6dbf5eb5db","project":"openstack/python-designateclient","branch":"master","topic":"bug/1844028","hashtags":[],"change_id":"I9716014d65a3f649c23eb78faca2cb6dbf5eb5db","subject":"Fix \"recordset list --all-projects\" in interactive OSC","status":"MERGED","created":"2019-09-18 11:46:49.000000000","updated":"2019-09-20 03:23:24.000000000","submitted":"2019-09-20 03:21:46.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"682868-1568949706508-f2a16230","meta_rev_id":"67a3243e89d1e480e2679053a7b08ac43822b33b","_number":682868,"virtual_id_number":682868,"owner":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":2,"date":"2019-09-20 03:21:46.000000000","post_submit":true,"permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2019-09-19 16:37:42.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2019-09-20 02:03:45.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2019-09-20 02:03:45.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2019-09-20 03:21:46.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"444c03d1201f63c3a31f29e8271951d384a179fc","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-09-18 11:46:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"66ac5151e9dab079e49b6b5a1dccf18965780081","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-09-18 11:47:30.000000000","message":"Uploaded patch set 2: Commit message was updated.","accounts_in_message":[],"_revision_number":2},{"id":"bfaf57249596f119fe1b8c0ab6274f7bba09cef5","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-09-18 11:53:08.000000000","message":"Abandoned\n\nDuplicate of https://review.opendev.org/682782","accounts_in_message":[],"_revision_number":2},{"id":"d393301cc0243a1aa0d58c44dfe8167c3b55ef76","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-09-18 15:40:38.000000000","message":"Patch Set 2:\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"c8c7b35bd156d182d394cf770500d63f0dc5c9f0","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-09-18 16:21:51.000000000","message":"Patch Set 2:\n\nLet’s go with this one instead","accounts_in_message":[],"_revision_number":2},{"id":"14773f7f64fe1027718f9f59df2fbc4c1879a81a","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2019-09-19 08:17:07.000000000","message":"Restored","accounts_in_message":[],"_revision_number":2},{"id":"ba3343e16d710e4d6659b59f1e82e307936fffb3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-19 09:49:00.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/922f22f1e45c4c5da1bd206474297438 : SUCCESS in 41m 52s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/0c126c37e2cb479d86f38e50b761d12e : SUCCESS in 54m 58s\n- designate-bind9-manager-model https://zuul.opendev.org/t/openstack/build/d90f53a8fcd5408cad469af529125caa : SUCCESS in 48m 45s\n- designate-bind9-py27 https://zuul.opendev.org/t/openstack/build/53f6a1c6fb2e4598b151c4a7dac2dca7 : SUCCESS in 47m 59s\n- designate-pdns4-py27 https://zuul.opendev.org/t/openstack/build/2e30d78a4eff43a7999697b7ceb408a6 : SUCCESS in 44m 33s\n- designate-pdns4-postgres https://zuul.opendev.org/t/openstack/build/0fc39fa0728b424aa6d0d38d16d2c544 : FAILURE in 37m 14s (non-voting)\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/41310fc3207f46bdb21bdeaa0ecf10bd : SUCCESS in 1h 01m 14s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/072338a6020d4f169129e39fd5829615 : SUCCESS in 46m 39s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/ddb19b4227974a47933e6f40fcb69141 : SUCCESS in 38m 59s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/b97dc254cba6455687e2d5489d24ca05 : SUCCESS in 2m 51s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4c104ed963b04e86a832acd310699390 : SUCCESS in 4m 23s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d5c7e788e03845ebb8fad1fe819360c2 : SUCCESS in 3m 27s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/56cd14337f314d359c357702fbd74f98 : SUCCESS in 3m 46s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/d938f5bfe1f34b2e9a5e4e76909feb68 : SUCCESS in 3m 20s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/fab24cc4ec4a41dd86ba22a26896f6c2 : SUCCESS in 3m 37s\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/d5fdb24421914075b80806081d0f789c : SUCCESS in 5m 44s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/fe149d9d5a194a6f9fd2f3d250523991 : SUCCESS in 4m 24s","accounts_in_message":[],"_revision_number":2},{"id":"17468ac4b3ccaacaf377158ef1c863a75242406e","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-09-19 16:36:41.000000000","message":"Patch Set 2:\n\nLooks good, but still a nit on the title. The issue is really with all, and not --all-projects. \n\nIf you look at the all-projects impl it checks if project_id is already added\n\u003e if client.session.all_projects and _has_project_id(data):\n\nThe issue is really with\n\u003e if parsed_args.zone_id \u003d\u003d \u0027all\u0027:\n\nWhich adds zone_name\n\u003e cols.insert(2, \u0027zone_name\u0027)","accounts_in_message":[],"_revision_number":2},{"id":"2b5e10aa1e7ca16aa5b529370f944b6cf65f1c0f","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-09-19 16:37:37.000000000","message":"Patch Set 2:\n\n\u003e Looks good, but still a nit on the title. The issue is really with\n \u003e all, and not --all-projects.\n \u003e \n \u003e If you look at the all-projects impl it checks if project_id is\n \u003e already added\n \u003e \u003e if client.session.all_projects and _has_project_id(data):\n \u003e \n \u003e The issue is really with\n \u003e \u003e if parsed_args.zone_id \u003d\u003d \u0027all\u0027:\n \u003e \n \u003e Which adds zone_name\n \u003e \u003e cols.insert(2, \u0027zone_name\u0027)\n\nnvm I am stupid - it has an issue with both.","accounts_in_message":[],"_revision_number":2},{"id":"aff5940f3c7e969445fbf5668bd8f9fb5c2fca2a","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-09-19 16:37:42.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"90954567309071e6d954bb95898fdef4de08f6da","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2019-09-20 02:03:45.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"1c9b8abc9c8add05f3e8ff9fb635e42be81b5850","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 02:05:14.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"e48608e3cbd3b50868e2e87ce346c789bf931828","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 03:21:46.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"289ff533be000bd3c7544977a222ae40a71425f3","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 03:21:46.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/d6543b0ed9e0407592ac8b16e8724a47 : SUCCESS in 43m 20s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/a5902ec543134951833078377a8647d7 : SUCCESS in 43m 46s\n- designate-bind9-manager-model https://zuul.opendev.org/t/openstack/build/44b41188c904472bb670b4b169c728df : SUCCESS in 38m 56s\n- designate-bind9-py27 https://zuul.opendev.org/t/openstack/build/0759a92cc0274bacb2440e5a0a4d3e58 : SUCCESS in 40m 34s\n- designate-pdns4-py27 https://zuul.opendev.org/t/openstack/build/1349402647f642dda9ee5dcef1966530 : SUCCESS in 40m 33s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/00b12e3bd8574e7f83d7aa06b13d9848 : SUCCESS in 1h 06m 35s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/8f50b13f4cf245e5b8251854f387ebd5 : SUCCESS in 43m 29s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/830752e49f75411289cd7c4ffb081de9 : SUCCESS in 39m 31s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/f2a5a2770ae8495c85be4e2f8164988f : SUCCESS in 4m 18s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d11ae48a6fdc409993311c073c9b83cc : SUCCESS in 3m 22s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/a96669ceb8f1411fbc0b416c50b2aa2c : SUCCESS in 3m 11s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0d16111aa6d444ac8e1a07865060aa96 : SUCCESS in 3m 34s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/61612c54e4c84b0ca3ba5f21f97995c2 : SUCCESS in 3m 39s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/a475cbe51f8248f7b994244bfd3107d1 : SUCCESS in 3m 11s","accounts_in_message":[],"_revision_number":2},{"id":"0921c068c631a89625d95bb20080e6d03111339e","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2019-09-20 03:23:24.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1053cddb542a430dba8eae1bcbc2119e : SUCCESS in 48s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"6be5c7b49e32864ebc60b255774d8f9b2a6ef9fc","revisions":{"a0e436b82ea7fcce2807b8a08a26c3ebec7929e3":{"kind":"REWORK","_number":1,"created":"2019-09-18 11:46:49.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/68/682868/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/68/682868/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/68/682868/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/68/682868/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/68/682868/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/68/682868/1"}}},"commit":{"parents":[{"commit":"7cc5f8bb2a31524f612e484e0bd4ea4e024e7d2c","subject":"Fix \"zone list --all-projects\" in interactive OSC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/7cc5f8bb2a31524f612e484e0bd4ea4e024e7d2c"}]}],"author":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-09-18 11:44:57.000000000","tz":0},"committer":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-09-18 11:44:57.000000000","tz":0},"subject":"Fix \"zone list --all-projects\" in interactive OSC","message":"Fix \"zone list --all-projects\" in interactive OSC\n\nClass variables get re-used when multiple commands are executed in a row\nwithin a single OSC interactive session. So we need to take a copy\nbefore modifying in order to avoid unwanted side-effects.\n\nChange-Id: I9716014d65a3f649c23eb78faca2cb6dbf5eb5db\nRelated-Bug: 1844028\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/a0e436b82ea7fcce2807b8a08a26c3ebec7929e3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/a0e436b82ea7fcce2807b8a08a26c3ebec7929e3"}]},"branch":"refs/heads/master"},"6be5c7b49e32864ebc60b255774d8f9b2a6ef9fc":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2019-09-18 11:47:30.000000000","uploader":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"ref":"refs/changes/68/682868/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/68/682868/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/68/682868/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/68/682868/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/68/682868/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/68/682868/2"}}},"commit":{"parents":[{"commit":"7cc5f8bb2a31524f612e484e0bd4ea4e024e7d2c","subject":"Fix \"zone list --all-projects\" in interactive OSC","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/7cc5f8bb2a31524f612e484e0bd4ea4e024e7d2c"}]}],"author":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-09-18 11:44:57.000000000","tz":0},"committer":{"name":"Jens Harbott","email":"j.harbott@x-ion.de","date":"2019-09-18 11:47:09.000000000","tz":0},"subject":"Fix \"recordset list --all-projects\" in interactive OSC","message":"Fix \"recordset list --all-projects\" in interactive OSC\n\nClass variables get re-used when multiple commands are executed in a row\nwithin a single OSC interactive session. So we need to take a copy\nbefore modifying in order to avoid unwanted side-effects.\n\nChange-Id: I9716014d65a3f649c23eb78faca2cb6dbf5eb5db\nRelated-Bug: 1844028\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/6be5c7b49e32864ebc60b255774d8f9b2a6ef9fc"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/6be5c7b49e32864ebc60b255774d8f9b2a6ef9fc"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}