)]}'
{"id":"openstack%2Fpython-designateclient~713021","triplet_id":"openstack%2Fpython-designateclient~master~I9582d623727e5853637812083033a348b71551ce","project":"openstack/python-designateclient","branch":"master","topic":"unittest.mock","hashtags":[],"change_id":"I9582d623727e5853637812083033a348b71551ce","subject":"Use unittest.mock instead of third party mock","status":"MERGED","created":"2020-03-13 16:41:21.000000000","updated":"2020-03-23 08:33:51.000000000","submitted":"2020-03-23 08:32:23.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"713021-1584952343937-81340386","meta_rev_id":"b67a440aaf013743e0da4dff343671d0da9f21b8","_number":713021,"virtual_id_number":713021,"owner":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"tag":"autogenerated:zuul:gate","value":2,"date":"2020-03-23 08:32:23.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":2,"date":"2020-03-16 06:58:51.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2020-03-16 08:33:50.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"all":[{"value":0,"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":1,"date":"2020-03-16 08:33:50.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"recommended":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"all":[{"value":1,"date":"2020-03-16 06:58:51.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","value":1,"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-03-16 06:58:51.000000000","updated_by":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"reviewer":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"state":"REVIEWER"},{"updated":"2020-03-16 08:33:50.000000000","updated_by":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"reviewer":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"state":"REVIEWER"},{"updated":"2020-03-23 08:32:23.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"4743b401cdaa69a85c005ea07ee73fa8e1e63528","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-03-13 16:41:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3834b70f411acffeb88bdb69145777f352d85199","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-13 17:57:02.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/e7e98eb4e17b4f599dc66ee8013dcd48 : SUCCESS in 3m 44s\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/715494117e4e4280b0ccc39f6735d6fb : SUCCESS in 40m 14s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/e3cc5ae785e445febd5f5c22f696aaf6 : SUCCESS in 40m 24s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/c6b4605b078448d58e71092c950e4b70 : SUCCESS in 1h 09m 18s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/ef3efc93655643ecbb0e9e921e476c00 : SUCCESS in 46m 00s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/ee9927ba2aa54bb4b8e645c04126bab6 : SUCCESS in 38m 52s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/a2cfa562e10945d39187c1a5527292d0 : SUCCESS in 5m 45s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/90fe18d984fd4752aea80ccc119b0638 : SUCCESS in 5m 36s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/f8f85f54c395499ab87f26cf9809b42b : SUCCESS in 3m 53s\n- openstack-tox-py27 https://zuul.opendev.org/t/openstack/build/62a2addf96d6486091df77796fea9eb1 : FAILURE in 6m 04s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/4361130d9e134f7c9fbb5f83d064df6b : SUCCESS in 4m 04s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/1ba720d18d2d4c36b77586dcd9d500c2 : SUCCESS in 3m 55s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/1e5e93f9e3194b84affd520c6747ca4c : SUCCESS in 6m 03s (non-voting)\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/07eac3b489c64d46a6534c6178273b98 : SUCCESS in 6m 27s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/901d96f5061d49c0b00117cdca4710eb : SUCCESS in 4m 14s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/7e8979db61304935a6f6e99a8920f9a0 : SUCCESS in 4m 36s","accounts_in_message":[],"_revision_number":1},{"id":"e1fd94770d6086cd013dee08c3567ff6a9101c92","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-03-13 18:30:14.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"9ee0055f073321cff7f4cd96a63cd5f1f448a823","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-13 19:38:06.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/75d209974c464cb3a64edb9d0de2095a : SUCCESS in 2m 38s\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/ce589cc8b3ef438f926e22828e5e0415 : SUCCESS in 39m 14s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/965106ebd8aa49bba1ad1b9d294f2c92 : SUCCESS in 36m 08s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/a37a7016418c4c8f838c99254e4c3f5a : SUCCESS in 1h 02m 09s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/7b7ecef9c0ec43258f03e7eee25d26fd : SUCCESS in 41m 34s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/38d9035a2cb6418e82b28c5bbd834fa1 : SUCCESS in 41m 34s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/4d746458c1be416da3eec25aff0fa6fa : SUCCESS in 3m 06s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/4d77176956a0459984d4301c2b262a58 : SUCCESS in 3m 41s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/6b7fda733f8e42c89e0c5786fed5493e : SUCCESS in 3m 41s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/7c09ac27cfd141ffb2855da7400b1ff6 : SUCCESS in 3m 42s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/5ffca7b0053d4986a8d3a9f55aded72b : SUCCESS in 4m 15s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/39c51864e3f448f8af7afb4b2c72692d : SUCCESS in 5m 14s (non-voting)\n- openstackclient-check-plugins https://zuul.opendev.org/t/openstack/build/bcd7d6293f2b40509eaf1c7a3c3bbe8e : SUCCESS in 6m 01s (non-voting)\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/1e97c8db9e7c4dabac288a597c620297 : SUCCESS in 3m 06s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/3eac25fce1864491b1706a0fa4770f7e : SUCCESS in 3m 21s","accounts_in_message":[],"_revision_number":2},{"id":"dc4c0b97293046be04b8f5acf1ce18342d8ea908","author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"date":"2020-03-16 06:58:51.000000000","message":"Patch Set 2: Code-Review+2 Review-Priority+1","accounts_in_message":[],"_revision_number":2},{"id":"e7a7dc51fd22b4b61fb1fdcf608230420396aa7b","author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"date":"2020-03-16 08:33:50.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"0d7e1a0d83ea9eba820a889e297abb6bfdae9f93","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 07:19:57.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"774fd06cd0d06a4715a9fe580ce17ee8c0abb8db","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 08:32:23.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/953f0651c3b0416bad7b79ec3f2a4790 : SUCCESS in 2m 10s\n- designate-bind9 https://zuul.opendev.org/t/openstack/build/07169a85f752400f8c65b63dcf6b2d9b : SUCCESS in 41m 28s\n- designate-pdns4 https://zuul.opendev.org/t/openstack/build/039eed72a05c46b4b6a748e8d419ecf7 : SUCCESS in 49m 02s\n- designate-grenade-pdns4 https://zuul.opendev.org/t/openstack/build/4aef7a9a7db14ff3af10e27a7aa63ab3 : SUCCESS in 1h 10m 49s\n- designate-ipv6-only-pdns4 https://zuul.opendev.org/t/openstack/build/7b3745022e334ec8b066b9a72268fb1b : SUCCESS in 50m 59s\n- designate-ipv6-only-bind9 https://zuul.opendev.org/t/openstack/build/cc16270a9590440e8157a3cf5dfa122f : SUCCESS in 51m 08s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/6460a782552943bb886c6e77c04e307c : SUCCESS in 5m 00s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/1f1386df4e78432ca694784099e81b0d : SUCCESS in 4m 22s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/0cfb60b6052a45a28808b7337163bf64 : SUCCESS in 4m 26s\n- openstack-tox-py37 https://zuul.opendev.org/t/openstack/build/97247b31d2574822b836a41ef782c581 : SUCCESS in 3m 58s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/7915c59838cc4c6da6151fcee79ab826 : SUCCESS in 4m 39s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/2e1b44f6e1464c6a97699aeb0c3d223a : SUCCESS in 3m 54s","accounts_in_message":[],"_revision_number":2},{"id":"83d228f72bfd12663c99322b21aafe47ac471c17","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 08:32:23.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2},{"id":"caa5690e321d311e872a579ee3d5b716cf333a1e","tag":"autogenerated:zuul:promote","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-03-23 08:33:51.000000000","message":"Patch Set 2:\n\nBuild succeeded (promote pipeline).\n\n- promote-openstack-tox-docs https://zuul.opendev.org/t/openstack/build/d56ddc0288f148f892d5ec291f52374b : SUCCESS in 1m 07s\n- promote-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/1139da8fc4214339bba289faa742d0dc : SUCCESS in 1m 11s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b9bcae014013834bc72dc5a490eeae4876eda764","revisions":{"a68cb7c37b7923982ab89b7074a0e8d424ee6614":{"kind":"REWORK","_number":1,"created":"2020-03-13 16:41:21.000000000","uploader":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"ref":"refs/changes/21/713021/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/21/713021/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/21/713021/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/21/713021/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/21/713021/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/21/713021/1"}}},"commit":{"parents":[{"commit":"b0d3e37732786708c7d775eeb3f7e919e3d95c42","subject":"Switch to Ussuri jobs","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/b0d3e37732786708c7d775eeb3f7e919e3d95c42"}]}],"author":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2020-03-13 16:40:44.000000000","tz":-300},"committer":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2020-03-13 16:40:44.000000000","tz":-300},"subject":"Use unittest.mock instead of third party mock","message":"Use unittest.mock instead of third party mock\n\nNow that we are py36 or later, we can use the standard library\nunittest.mock module instead of the third party mock lib.\n\nChange-Id: I9582d623727e5853637812083033a348b71551ce\nSigned-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/a68cb7c37b7923982ab89b7074a0e8d424ee6614"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/a68cb7c37b7923982ab89b7074a0e8d424ee6614"}]},"branch":"refs/heads/master"},"b9bcae014013834bc72dc5a490eeae4876eda764":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2020-03-13 18:30:14.000000000","uploader":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"ref":"refs/changes/21/713021/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-designateclient","ref":"refs/changes/21/713021/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/21/713021/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/21/713021/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-designateclient refs/changes/21/713021/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-designateclient refs/changes/21/713021/2"}}},"commit":{"parents":[{"commit":"1c8e5e801365055a2a7c37b57dbfd1e0ea7c8716","subject":"Drop py27 support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/1c8e5e801365055a2a7c37b57dbfd1e0ea7c8716"}]}],"author":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2020-03-13 16:40:44.000000000","tz":-300},"committer":{"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","date":"2020-03-13 18:30:14.000000000","tz":0},"subject":"Use unittest.mock instead of third party mock","message":"Use unittest.mock instead of third party mock\n\nNow that we are py36 or later, we can use the standard library\nunittest.mock module instead of the third party mock lib.\n\nChange-Id: I9582d623727e5853637812083033a348b71551ce\nSigned-off-by: Sean McGinnis \u003csean.mcginnis@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/b9bcae014013834bc72dc5a490eeae4876eda764"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-designateclient/commit/b9bcae014013834bc72dc5a490eeae4876eda764"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}