)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"6a38e44a5a986dda396bd4de0e3edfa7005b052b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"03ca41cf_2c0a6d36","updated":"2021-12-06 02:58:31.000000000","message":"recheck DesignatePtrRecord","commit_id":"11423c21284368d11fffb8ce4fff67b76f8b1dee"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"cb313e40257953b2fee674efd4b6ad9279b2e256","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8096de64_1b93b28f","updated":"2021-12-06 01:31:48.000000000","message":"recheck DesignatePtrRecord","commit_id":"11423c21284368d11fffb8ce4fff67b76f8b1dee"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7b34dcd0f7c2d8e04e448e4ba189745933841389","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2239a41e_24237dfd","updated":"2021-12-09 23:12:26.000000000","message":"I have a couple of thoughts on this.","commit_id":"87e9b3333bb7d1b2648474df6bbb6a06693964fd"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"4eee94e2b890a1505166a5e23d1d0b3446784908","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"3aa7e376_a08c5033","updated":"2021-12-07 09:59:47.000000000","message":"thx","commit_id":"87e9b3333bb7d1b2648474df6bbb6a06693964fd"}],"designateclient/tests/osc/resources/__init__.py":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"80265e36b0ef740404797214e93becb375ff4145","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def load(action):"},{"line_number":20,"context_line":"    with open(f\u0027{path}/{action}.json\u0027) as fp:"},{"line_number":21,"context_line":"        return json.load(fp)"}],"source_content_type":"text/x-python","patch_set":3,"id":"a6fad782_336f99da","line":20,"updated":"2021-12-07 07:41:04.000000000","message":"Better use os.path.join()","commit_id":"11423c21284368d11fffb8ce4fff67b76f8b1dee"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"768601d7e2c12ee4f805d5d4347f037444aba200","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"def load(action):"},{"line_number":20,"context_line":"    with open(f\u0027{path}/{action}.json\u0027) as fp:"},{"line_number":21,"context_line":"        return json.load(fp)"}],"source_content_type":"text/x-python","patch_set":3,"id":"e7d7f9f5_2b5067df","line":20,"in_reply_to":"a6fad782_336f99da","updated":"2021-12-07 08:10:49.000000000","message":"Done","commit_id":"11423c21284368d11fffb8ce4fff67b76f8b1dee"}],"designateclient/tests/osc/resources/recordset_create.json":[{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"80265e36b0ef740404797214e93becb375ff4145","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  \"zone_id\": \"6f106adb-0896-4114-b34f-4ac8dfee9465\","},{"line_number":4,"context_line":"  \"project_id\": \"15a6ae43e4dd498383e127e5f2521301\","},{"line_number":5,"context_line":"  \"name\": \"example.example.devstack.org.\","},{"line_number":6,"context_line":"  \"zone_name\": \"example.devstack.org.\","},{"line_number":7,"context_line":"  \"type\": \"A\","},{"line_number":8,"context_line":"  \"records\": ["},{"line_number":9,"context_line":"    \"127.0.0.1\","}],"source_content_type":"application/json","patch_set":3,"id":"095c124b_02c290ac","line":6,"updated":"2021-12-07 07:41:04.000000000","message":"devstack.org is in real use, better use only \"example.org\"","commit_id":"11423c21284368d11fffb8ce4fff67b76f8b1dee"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"768601d7e2c12ee4f805d5d4347f037444aba200","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  \"zone_id\": \"6f106adb-0896-4114-b34f-4ac8dfee9465\","},{"line_number":4,"context_line":"  \"project_id\": \"15a6ae43e4dd498383e127e5f2521301\","},{"line_number":5,"context_line":"  \"name\": \"example.example.devstack.org.\","},{"line_number":6,"context_line":"  \"zone_name\": \"example.devstack.org.\","},{"line_number":7,"context_line":"  \"type\": \"A\","},{"line_number":8,"context_line":"  \"records\": ["},{"line_number":9,"context_line":"    \"127.0.0.1\","}],"source_content_type":"application/json","patch_set":3,"id":"d2a48921_b35315b9","line":6,"in_reply_to":"095c124b_02c290ac","updated":"2021-12-07 08:10:49.000000000","message":"Done","commit_id":"11423c21284368d11fffb8ce4fff67b76f8b1dee"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"80265e36b0ef740404797214e93becb375ff4145","unresolved":true,"context_lines":[{"line_number":19,"context_line":"  \"links\": {"},{"line_number":20,"context_line":"    \"self\": \"http://10.0.1.203/dns/v2/zones/6f106adb-0896-4114-b34f-4ac8dfee9465/recordsets/a00ac483-d74d-4555-b30f-2e0a176287e2\""},{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"7ff26f00_da25084c","line":22,"updated":"2021-12-07 07:41:04.000000000","message":"Can we have a newline at the end of these files please?","commit_id":"11423c21284368d11fffb8ce4fff67b76f8b1dee"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"768601d7e2c12ee4f805d5d4347f037444aba200","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  \"links\": {"},{"line_number":20,"context_line":"    \"self\": \"http://10.0.1.203/dns/v2/zones/6f106adb-0896-4114-b34f-4ac8dfee9465/recordsets/a00ac483-d74d-4555-b30f-2e0a176287e2\""},{"line_number":21,"context_line":"  }"},{"line_number":22,"context_line":"}"}],"source_content_type":"application/json","patch_set":3,"id":"a59c20ac_c78f3f29","line":22,"in_reply_to":"7ff26f00_da25084c","updated":"2021-12-07 08:10:49.000000000","message":"Done","commit_id":"11423c21284368d11fffb8ce4fff67b76f8b1dee"}],"designateclient/tests/osc/v2/test_recordsets.py":[{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7b34dcd0f7c2d8e04e448e4ba189745933841389","unresolved":true,"context_lines":[{"line_number":24,"context_line":"        super(TestDesignateCreateRecordSets, self).setUp()"},{"line_number":25,"context_line":"        self.app.client_manager.dns \u003d mock.MagicMock()"},{"line_number":26,"context_line":"        self.cmd \u003d recordsets.CreateRecordSetCommand(self.app, None)"},{"line_number":27,"context_line":"        self.dns_client \u003d self.app.client_manager.dns"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_create_recordset(self):"},{"line_number":30,"context_line":"        arg_list \u003d ["}],"source_content_type":"text/x-python","patch_set":6,"id":"c223c655_a21ac3d2","line":27,"updated":"2021-12-09 23:12:26.000000000","message":"Can\u0027t we pull some of this out to a parent class so we don\u0027t have to duplicate it for every test class?\nYou can use resest_mock() to reset/clear it.","commit_id":"87e9b3333bb7d1b2648474df6bbb6a06693964fd"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"7b34dcd0f7c2d8e04e448e4ba189745933841389","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        results \u003d list(data)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.assertEqual(14, len(results))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class TestDesignateListRecordSets(utils.TestCommand):"}],"source_content_type":"text/x-python","patch_set":6,"id":"97fb0195_54f0faf6","line":52,"updated":"2021-12-09 23:12:26.000000000","message":"I prefer to validate the data and the right API method was called.\n\nThis is obviously better than what we have and this could be incrementally improved, but I think our end goal should be checking the data in and the data out is as expected.\n\ni.e. https://github.com/openstack/python-octaviaclient/blob/master/octaviaclient/tests/unit/osc/v2/test_load_balancer.py#L59","commit_id":"87e9b3333bb7d1b2648474df6bbb6a06693964fd"},{"author":{"_account_id":22623,"name":"Erik Olof Gunnar Andersson","email":"eandersson@blizzard.com","username":"eoandersson"},"change_message_id":"ec76b61950f5ad9454589687f1f3ba9e8576d37e","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        results \u003d list(data)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        self.assertEqual(14, len(results))"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class TestDesignateListRecordSets(utils.TestCommand):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da2de9d7_e47f632b","line":52,"in_reply_to":"97fb0195_54f0faf6","updated":"2021-12-13 05:22:15.000000000","message":"I rather just have some basic coverage for now, so I am gonna merge this, but I\u0027ll start PoCing something based on your feedback.","commit_id":"87e9b3333bb7d1b2648474df6bbb6a06693964fd"}]}