)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9c40bd758d52751e8ce4a6a642854615527bc47d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d8d2ea00_ba108fdd","updated":"2022-10-06 15:03:49.000000000","message":"recheck","commit_id":"fdaf3d99343648e6f6d25b6af012aaa82ec4542e"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"206084150c28abdda1585b6fbed146039425e1eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"879d0092_460499a5","updated":"2022-10-19 19:47:53.000000000","message":"After discussions with the core team, we think \"hard delete\" is more descriptive of this option. I have updated that.\nThis patch still needs test coverage and a release note, thus why I am marking it -1 now.","commit_id":"175f5ecec9d37cd9cfb5741e5666689bae7f69d9"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"ae466ccce2e6f09d86dae2334e2f9d3815adea02","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b57db292_ecc3b007","in_reply_to":"5291d4ee_d4eee556","updated":"2022-10-19 19:56:52.000000000","message":"I am updating the Designate patch now. Give me 30 minutes.\nIt would be great if you could work on the test coverage and release notes here.","commit_id":"175f5ecec9d37cd9cfb5741e5666689bae7f69d9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"250a3e93a3437ef8b910841c821996aed19a15b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5291d4ee_d4eee556","in_reply_to":"879d0092_460499a5","updated":"2022-10-19 19:53:19.000000000","message":"Does hard-delete need to change in designate as well ?\nI will add test coverage and releasenote","commit_id":"175f5ecec9d37cd9cfb5741e5666689bae7f69d9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"a637ecdcb82430efb6b79ae284b18d23061705a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e6d67e34_b1399ca0","in_reply_to":"b57db292_ecc3b007","updated":"2022-10-19 20:22:50.000000000","message":"Added release note. I do not see tests for existing header options.","commit_id":"175f5ecec9d37cd9cfb5741e5666689bae7f69d9"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"23eca5a8c0db1d42576b4c1897ee8f5439f4507f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ed66831c_8879cce1","updated":"2023-01-10 18:15:01.000000000","message":"Hi Michael,\ncan you merge this PR ?","commit_id":"8bfdfbaa2470792d95c336371d5576d9b140949f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"d8cb20fe25cd25f46b71b3b2dd1247cdd3653d86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"6243289b_c9c4457f","updated":"2022-11-23 07:51:53.000000000","message":"Hi core-reviewers,\nsince dependent PR of designate is merged, please merge this as well.","commit_id":"8bfdfbaa2470792d95c336371d5576d9b140949f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"70219a3538d741964cab7111c6f35f19f0dd59bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"5da99d27_5c61713f","updated":"2023-01-29 22:51:11.000000000","message":"It looks like we have some testing work to do on the client. I am ok merging this now and covering when we do a full pass on the client test coverage.","commit_id":"8bfdfbaa2470792d95c336371d5576d9b140949f"},{"author":{"_account_id":5572,"name":"Don Kehn","display_name":"DEKehn","email":"dekehn@gmail.com","username":"dekehn"},"change_message_id":"aac82aa566f4bdc875d49cdd618acc0b8cce0451","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"70cd8ee4_6a584184","updated":"2022-10-24 15:57:31.000000000","message":"lgtm - \nLGTM - \nbefore:root@ospr1-069:/opt/stack/tempest# ll /var/cache/bind\ntotal 1348\ndrwxrwxr-x  2 bind bind 1212416 Oct 24 15:37 ./\ndrwxr-xr-x 19 root root    4096 Oct 24 14:17 ../\n-rw-rw----  1 bind bind  106496 Oct 24 15:37 _default.nzd\n-rw-------  1 bind bind    8192 Oct 24 15:37 _default.nzd-lock\n-rw-r--r--  1 bind bind     821 Oct 24 15:21 managed-keys.bind\n-rw-rw-r--  1 bind bind    3852 Oct 24 15:20 managed-keys.bind.jnl\n-rw-rw-r--  1 bind bind   31635 Oct  6 15:48 named_dump.db\n-rw-r--r--  1 bind bind     176 Oct 24 15:37 slave.example1.com.61b80159-f7cf-47cc-ac5b-07a1bd497865\n\nafter the --hard-delete:\nroot@ospr1-069:/opt/stack/tempest# ll /var/cache/bind\ntotal 1344\ndrwxrwxr-x  2 bind bind 1212416 Oct 24 15:55 ./\ndrwxr-xr-x 19 root root    4096 Oct 24 14:17 ../\n-rw-rw----  1 bind bind  106496 Oct 24 15:55 _default.nzd\n-rw-------  1 bind bind    8192 Oct 24 15:55 _default.nzd-lock\n-rw-r--r--  1 bind bind     821 Oct 24 15:21 managed-keys.bind\n-rw-rw-r--  1 bind bind    3852 Oct 24 15:20 managed-keys.bind.jnl\n-rw-rw-r--  1 bind bind   31635 Oct  6 15:48 named_dump.db","commit_id":"8bfdfbaa2470792d95c336371d5576d9b140949f"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"9b4769a199827227334c54c3c6347fe4d2974ca5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a63b7f29_17782b08","in_reply_to":"ed66831c_8879cce1","updated":"2023-01-20 10:27:17.000000000","message":"Ping to merge.","commit_id":"8bfdfbaa2470792d95c336371d5576d9b140949f"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"1798b1710dfeb539e97e1f8e84c233cc64a38ebf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"fb587443_d3be9c33","updated":"2023-01-30 01:29:31.000000000","message":"LGTM, rebased on tox4 fix","commit_id":"a9c368da29af82979c8c393be104daafcb9fb972"},{"author":{"_account_id":11628,"name":"Michael Johnson","email":"johnsomor@gmail.com","username":"johnsom"},"change_message_id":"6bfd9843023d6d51b7406a07a30edca29aa2201e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8e8c25b2_c2a787f0","updated":"2023-01-30 03:44:55.000000000","message":"Still LGTM","commit_id":"483e0d16c6b357a610634ad5f7db9ab61b41d353"}],"designateclient/v2/cli/zones.py":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"38c5c9217774d2666d39039c4ce2f9ce060c0209","unresolved":true,"context_lines":[{"line_number":256,"context_line":"        client \u003d self.app.client_manager.dns"},{"line_number":257,"context_line":"        common.set_all_common_headers(client, parsed_args)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        if parsed_args.clean_zonefile is not None and \\"},{"line_number":260,"context_line":"           isinstance(parsed_args.clean_zonefile, bool):"},{"line_number":261,"context_line":"            clean_zonefile \u003d parsed_args.clean_zonefile"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff50898b_a02219d9","line":259,"updated":"2022-04-30 13:41:55.000000000","message":"if parsed_args.clean_zonefile and","commit_id":"9996b69fc6a0c976508300156f76c8985ae4b492"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"105b6935c5887131cd51e6c8cc31e2c636c5a99d","unresolved":false,"context_lines":[{"line_number":256,"context_line":"        client \u003d self.app.client_manager.dns"},{"line_number":257,"context_line":"        common.set_all_common_headers(client, parsed_args)"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"        if parsed_args.clean_zonefile is not None and \\"},{"line_number":260,"context_line":"           isinstance(parsed_args.clean_zonefile, bool):"},{"line_number":261,"context_line":"            clean_zonefile \u003d parsed_args.clean_zonefile"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"c13e2e30_4d9b5ba0","line":259,"in_reply_to":"ff50898b_a02219d9","updated":"2022-10-03 08:43:16.000000000","message":"Done","commit_id":"9996b69fc6a0c976508300156f76c8985ae4b492"}],"designateclient/v2/zones.py":[{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"38c5c9217774d2666d39039c4ce2f9ce060c0209","unresolved":true,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        url \u003d self.build_url(\u0027/zones/%s\u0027 % zone)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        data \u003d {"},{"line_number":71,"context_line":"            \"clean_zonefile\": clean_zonefile"},{"line_number":72,"context_line":"        }"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"abf1adb2_7f4db828","line":70,"updated":"2022-04-30 13:41:55.000000000","message":"if clean_zonefile:\n   data[\u0027clean_zonefile\u0027] \u003d clean_zonefile","commit_id":"9996b69fc6a0c976508300156f76c8985ae4b492"},{"author":{"_account_id":32919,"name":"kiran pawar","display_name":"Kiran Pawar","email":"kinpaa@gmail.com","username":"kpdev"},"change_message_id":"105b6935c5887131cd51e6c8cc31e2c636c5a99d","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        url \u003d self.build_url(\u0027/zones/%s\u0027 % zone)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"        data \u003d {"},{"line_number":71,"context_line":"            \"clean_zonefile\": clean_zonefile"},{"line_number":72,"context_line":"        }"},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"705f2172_f425319c","line":70,"in_reply_to":"abf1adb2_7f4db828","updated":"2022-10-03 08:43:16.000000000","message":"Done","commit_id":"9996b69fc6a0c976508300156f76c8985ae4b492"}]}