)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37213,"name":"ahnhyun","display_name":"ahnhyun","email":"ahnsunny926@naver.com","username":"ahnhyun"},"change_message_id":"b95f05cec1bf43c265d1da8db1f397c4741fb2bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"066e23f8_b3f2fccc","updated":"2025-06-02 02:19:52.000000000","message":"recheck","commit_id":"36c584793633f19be369b38b1d4c8f24e846825f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f797e069e9e9bd50ae706d4179fca9865d4d8483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"204d32b3_5a43e9e1","updated":"2026-03-13 16:55:50.000000000","message":"recheck Thanks for working on this. I left a few comments","commit_id":"36c584793633f19be369b38b1d4c8f24e846825f"},{"author":{"_account_id":37213,"name":"ahnhyun","display_name":"ahnhyun","email":"ahnsunny926@naver.com","username":"ahnhyun"},"change_message_id":"d22accb6cdeaef632c67ed267d039d58d07b5739","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1728bc1d_487fa1f9","updated":"2026-06-15 05:54:21.000000000","message":"Thanks for taking this over the line, Omer, addressing the comments and rebasing onto master to get CI passing. Really appreciate it. Let me know if there\u0027s anything else I should do on my side to help it land.\n\nAlso, since CI is green now, is there an active core around who could give it a review? Would be great to get it merged.","commit_id":"1e11933da633598eb6fccfee9f2cd7d3edab63cc"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f033903dd4962b5ea439ded0b72bd0078fb93289","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"da9c4927_80f48e30","in_reply_to":"1728bc1d_487fa1f9","updated":"2026-06-15 09:55:03.000000000","message":"Hi ahnhyun, I\u0027ve added release notes to this patch. As no other core reviewers usually review patches outside of designate repository, I think we could merge it as is. Thanks for suggesting it.","commit_id":"1e11933da633598eb6fccfee9f2cd7d3edab63cc"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"206da072cf537f6fe62a06a4357e2f5409f47bc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"04dec9cd_90d77c0d","updated":"2026-06-15 09:55:28.000000000","message":"I also tested it on my devstack env, it LGTM, let\u0027s merge it","commit_id":"c7dd3bf9859ce645295732b88a378716a00ed37f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"c4a1658a690744fedbe2f3b99cb3837123441cdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0aa100d0_c59d0b69","updated":"2026-06-15 15:20:05.000000000","message":"recheck non related post_failures","commit_id":"c7dd3bf9859ce645295732b88a378716a00ed37f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"2240171aa5a54f4874cbe0824160539c95323b69","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"41c8721f_bbb2869c","updated":"2026-06-15 11:49:49.000000000","message":"recheck non related post_failures","commit_id":"c7dd3bf9859ce645295732b88a378716a00ed37f"}],"designateclient/v2/cli/limits.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f797e069e9e9bd50ae706d4179fca9865d4d8483","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Endre Karlson \u003cendre.karlson@hp.com\u003e"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"566115e5_c0cdffce","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":46},"updated":"2026-03-13 16:55:50.000000000","message":"We should probably remove these lines","commit_id":"36c584793633f19be369b38b1d4c8f24e846825f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d28527973cdc99bb792fe007499eec654fe154c1","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2014 Hewlett-Packard Development Company, L.P."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Author: Endre Karlson \u003cendre.karlson@hp.com\u003e"},{"line_number":4,"context_line":"#"},{"line_number":5,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":6,"context_line":"# not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"d6a964ef_aa423fd1","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":46},"in_reply_to":"566115e5_c0cdffce","updated":"2026-06-12 12:00:50.000000000","message":"Done","commit_id":"36c584793633f19be369b38b1d4c8f24e846825f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f797e069e9e9bd50ae706d4179fca9865d4d8483","unresolved":true,"context_lines":[{"line_number":34,"context_line":"        common.set_all_common_headers(client, parsed_args)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        data \u003d client.limits.get()"},{"line_number":37,"context_line":"        limits \u003d data.get(\u0027limits\u0027, data)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        limits_list \u003d [(key, str(value)) for key, value in limits.items()]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        return self.columns, limits_list"}],"source_content_type":"text/x-python","patch_set":4,"id":"cd6734b2_5b570d21","line":41,"range":{"start_line":37,"start_character":8,"end_line":41,"end_character":40},"updated":"2026-03-13 16:55:50.000000000","message":"The API returns a flat dict, there\u0027s no limits wrapper key, so this always falls back to data. We can just use data directly.\nSay,\n```\nreturn self.columns, sorted(data.items())\n```","commit_id":"36c584793633f19be369b38b1d4c8f24e846825f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d28527973cdc99bb792fe007499eec654fe154c1","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        common.set_all_common_headers(client, parsed_args)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        data \u003d client.limits.get()"},{"line_number":37,"context_line":"        limits \u003d data.get(\u0027limits\u0027, data)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        limits_list \u003d [(key, str(value)) for key, value in limits.items()]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        return self.columns, limits_list"}],"source_content_type":"text/x-python","patch_set":4,"id":"bd396fd2_af7930b2","line":41,"range":{"start_line":37,"start_character":8,"end_line":41,"end_character":40},"in_reply_to":"cd6734b2_5b570d21","updated":"2026-06-12 12:00:50.000000000","message":"Done","commit_id":"36c584793633f19be369b38b1d4c8f24e846825f"}],"designateclient/v2/limits.py":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f797e069e9e9bd50ae706d4179fca9865d4d8483","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"268098ed_78a019b0","line":27,"range":{"start_line":23,"start_character":4,"end_line":27,"end_character":0},"updated":"2026-03-13 16:55:50.000000000","message":"The list() method isn\u0027t used anywhere — the CLI calls get(). The limits API endpoint (GET /limits) returns a flat dict, not a paginated collection, so criterion/marker/limit params don\u0027t apply here. We should remove these lines.","commit_id":"36c584793633f19be369b38b1d4c8f24e846825f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d28527973cdc99bb792fe007499eec654fe154c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c2d04441_b2c44f03","line":27,"range":{"start_line":23,"start_character":4,"end_line":27,"end_character":0},"in_reply_to":"268098ed_78a019b0","updated":"2026-06-12 12:00:50.000000000","message":"Done","commit_id":"36c584793633f19be369b38b1d4c8f24e846825f"}],"setup.cfg":[{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"f797e069e9e9bd50ae706d4179fca9865d4d8483","unresolved":true,"context_lines":[{"line_number":106,"context_line":"    tsigkey_set \u003d designateclient.v2.cli.tsigkeys:SetTSIGKeyCommand"},{"line_number":107,"context_line":"    tsigkey_delete \u003d designateclient.v2.cli.tsigkeys:DeleteTSIGKeyCommand"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    dns_limit_list \u003d designateclient.v2.cli.limits:ListLimitsCommand"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"90d44939_8cd0b160","line":109,"updated":"2026-03-13 16:55:50.000000000","message":"As the line at the bottom suggests - this patch is removing the newline at the end of this file","commit_id":"36c584793633f19be369b38b1d4c8f24e846825f"},{"author":{"_account_id":31664,"name":"Omer Schwartz","email":"oschwart@redhat.com","username":"oschwart"},"change_message_id":"d28527973cdc99bb792fe007499eec654fe154c1","unresolved":false,"context_lines":[{"line_number":106,"context_line":"    tsigkey_set \u003d designateclient.v2.cli.tsigkeys:SetTSIGKeyCommand"},{"line_number":107,"context_line":"    tsigkey_delete \u003d designateclient.v2.cli.tsigkeys:DeleteTSIGKeyCommand"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    dns_limit_list \u003d designateclient.v2.cli.limits:ListLimitsCommand"}],"source_content_type":"text/x-ttcn-cfg","patch_set":4,"id":"1893fa8e_f0c2cc0e","line":109,"in_reply_to":"90d44939_8cd0b160","updated":"2026-06-12 12:00:50.000000000","message":"Done","commit_id":"36c584793633f19be369b38b1d4c8f24e846825f"}]}
