)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for H755 RAID controller from converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of H755 RAID controller, exisiting virtual disks get deleted"},{"line_number":10,"context_line":"and moves physical disks into \u0027ready\u0027 state. Moreover, it creates"},{"line_number":11,"context_line":"another job to convert each physical disk to \u0027RAID-0\u0027."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"434046b1_78f3b406","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":68},"updated":"2021-09-06 10:34:13.000000000","message":"this is what different method does, existing virtual disks have nothing to do with this patch and updated method.\n\nThe scope for this change rather is (just my suggestion)- \n\n\"When converting H755 RAID controller physical disks to non-RAID mode, RAID-0 virtual disks get created for each physical disk and disks moved to \u0027Online\u0027 mode.\n\nThis is different from other controllers supporting non-RAID conversion and takes up physical disks that cannot be used for user intended RAID configuration later. This change excludes H755 RAID controller\u0027s physical disks from converting to non-RAID mode and leaves disks in \u0027Ready\u0027 state.\"","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d01161082fdda65515d272c2afcbf2f0b6967745","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for H755 RAID controller from converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of H755 RAID controller, exisiting virtual disks get deleted"},{"line_number":10,"context_line":"and moves physical disks into \u0027ready\u0027 state. Moreover, it creates"},{"line_number":11,"context_line":"another job to convert each physical disk to \u0027RAID-0\u0027."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bec0ebbc_9714c9e9","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":68},"in_reply_to":"434046b1_78f3b406","updated":"2021-09-09 08:43:32.000000000","message":"Done","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix for H755 RAID controller from converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of H755 RAID controller, exisiting virtual disks get deleted"},{"line_number":10,"context_line":"and moves physical disks into \u0027ready\u0027 state. Moreover, it creates"},{"line_number":11,"context_line":"another job to convert each physical disk to \u0027RAID-0\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change excludes H755 RAID controller from conversion of"},{"line_number":14,"context_line":"physical disks to \u0027RAID-0\u0027 when mode is \u0027JBOD\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"2df29a75_826eb31a","line":11,"range":{"start_line":10,"start_character":58,"end_line":11,"end_character":11},"updated":"2021-09-06 10:34:13.000000000","message":"from my observations it was only 1 job, that had 2 operations in it, so this is not precise.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d01161082fdda65515d272c2afcbf2f0b6967745","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix for H755 RAID controller from converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In case of H755 RAID controller, exisiting virtual disks get deleted"},{"line_number":10,"context_line":"and moves physical disks into \u0027ready\u0027 state. Moreover, it creates"},{"line_number":11,"context_line":"another job to convert each physical disk to \u0027RAID-0\u0027."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This change excludes H755 RAID controller from conversion of"},{"line_number":14,"context_line":"physical disks to \u0027RAID-0\u0027 when mode is \u0027JBOD\u0027."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"30558482_d69edea4","line":11,"range":{"start_line":10,"start_character":58,"end_line":11,"end_character":11},"in_reply_to":"2df29a75_826eb31a","updated":"2021-09-09 08:43:32.000000000","message":"Done","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8fc312dc49d97cf426473e2cdf40bad7a6304283","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Monica Pardhi \u003cmpardhi1991@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-09-15 12:55:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for H755 RAID controller from converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When converting H755 RAID controller physical disks to"},{"line_number":10,"context_line":"non-RAID mode, RAID-0 virtual disks get created for each"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"79e73f18_20812f6f","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":33},"updated":"2021-09-16 12:59:44.000000000","message":"nit: s/from/when/","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"4cbc9ac37ecf84be5b70ef2a6a94d23e07f14b7b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Monica Pardhi \u003cmpardhi1991@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-09-15 12:55:13 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for H755 RAID controller from converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When converting H755 RAID controller physical disks to"},{"line_number":10,"context_line":"non-RAID mode, RAID-0 virtual disks get created for each"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"25a8bfdf_3fe4979f","line":7,"range":{"start_line":7,"start_character":29,"end_line":7,"end_character":33},"in_reply_to":"79e73f18_20812f6f","updated":"2021-09-17 07:51:50.000000000","message":"Done","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8fc312dc49d97cf426473e2cdf40bad7a6304283","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for H755 RAID controller from converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When converting H755 RAID controller physical disks to"},{"line_number":10,"context_line":"non-RAID mode, RAID-0 virtual disks get created for each"},{"line_number":11,"context_line":"physical disk and disks moved to \u0027Online\u0027 state."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4e9da7f1_d97f4e08","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":20},"updated":"2021-09-16 12:59:44.000000000","message":"Let us identify the product the first time as follows:\n\n    Dell EMC PERC H755\n\nSubsequent references can simply be H755.","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"4cbc9ac37ecf84be5b70ef2a6a94d23e07f14b7b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for H755 RAID controller from converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When converting H755 RAID controller physical disks to"},{"line_number":10,"context_line":"non-RAID mode, RAID-0 virtual disks get created for each"},{"line_number":11,"context_line":"physical disk and disks moved to \u0027Online\u0027 state."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ac5c4ff0_febf4c87","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":20},"in_reply_to":"4e9da7f1_d97f4e08","updated":"2021-09-17 07:51:50.000000000","message":"Done","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8fc312dc49d97cf426473e2cdf40bad7a6304283","unresolved":true,"context_lines":[{"line_number":11,"context_line":"physical disk and disks moved to \u0027Online\u0027 state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is different from other controllers supporting non-RAID"},{"line_number":14,"context_line":"conversion and takes up physical disks that cannot be used"},{"line_number":15,"context_line":"for user intended RAID configuration later. This change"},{"line_number":16,"context_line":"excludes H755 RAID controller\u0027s physical disks from converting"},{"line_number":17,"context_line":"to non-RAID mode and leaves disks in \u0027Ready\u0027 state."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1195af47_c435215b","line":14,"range":{"start_line":14,"start_character":54,"end_line":14,"end_character":58},"updated":"2021-09-16 12:59:44.000000000","message":"nit: s/used/later used/","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"4cbc9ac37ecf84be5b70ef2a6a94d23e07f14b7b","unresolved":false,"context_lines":[{"line_number":11,"context_line":"physical disk and disks moved to \u0027Online\u0027 state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is different from other controllers supporting non-RAID"},{"line_number":14,"context_line":"conversion and takes up physical disks that cannot be used"},{"line_number":15,"context_line":"for user intended RAID configuration later. This change"},{"line_number":16,"context_line":"excludes H755 RAID controller\u0027s physical disks from converting"},{"line_number":17,"context_line":"to non-RAID mode and leaves disks in \u0027Ready\u0027 state."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3202595d_845463d2","line":14,"range":{"start_line":14,"start_character":54,"end_line":14,"end_character":58},"in_reply_to":"1195af47_c435215b","updated":"2021-09-17 07:51:50.000000000","message":"Done","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8fc312dc49d97cf426473e2cdf40bad7a6304283","unresolved":true,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is different from other controllers supporting non-RAID"},{"line_number":14,"context_line":"conversion and takes up physical disks that cannot be used"},{"line_number":15,"context_line":"for user intended RAID configuration later. This change"},{"line_number":16,"context_line":"excludes H755 RAID controller\u0027s physical disks from converting"},{"line_number":17,"context_line":"to non-RAID mode and leaves disks in \u0027Ready\u0027 state."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ef83e8f9_fd7c3c62","line":15,"range":{"start_line":15,"start_character":36,"end_line":15,"end_character":42},"updated":"2021-09-16 12:59:44.000000000","message":"nit: s/ later//","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"4cbc9ac37ecf84be5b70ef2a6a94d23e07f14b7b","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is different from other controllers supporting non-RAID"},{"line_number":14,"context_line":"conversion and takes up physical disks that cannot be used"},{"line_number":15,"context_line":"for user intended RAID configuration later. This change"},{"line_number":16,"context_line":"excludes H755 RAID controller\u0027s physical disks from converting"},{"line_number":17,"context_line":"to non-RAID mode and leaves disks in \u0027Ready\u0027 state."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"37cb05fc_4b2fc4e7","line":15,"range":{"start_line":15,"start_character":36,"end_line":15,"end_character":42},"in_reply_to":"ef83e8f9_fd7c3c62","updated":"2021-09-17 07:51:50.000000000","message":"Done","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8fc312dc49d97cf426473e2cdf40bad7a6304283","unresolved":true,"context_lines":[{"line_number":13,"context_line":"This is different from other controllers supporting non-RAID"},{"line_number":14,"context_line":"conversion and takes up physical disks that cannot be used"},{"line_number":15,"context_line":"for user intended RAID configuration later. This change"},{"line_number":16,"context_line":"excludes H755 RAID controller\u0027s physical disks from converting"},{"line_number":17,"context_line":"to non-RAID mode and leaves disks in \u0027Ready\u0027 state."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id6de320c8e8a9ca21fac277718c405c657f58a3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"95cf1438_d2bb21ff","line":16,"range":{"start_line":16,"start_character":47,"end_line":16,"end_character":51},"updated":"2021-09-16 12:59:44.000000000","message":"nit: s/from/when/","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"4cbc9ac37ecf84be5b70ef2a6a94d23e07f14b7b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This is different from other controllers supporting non-RAID"},{"line_number":14,"context_line":"conversion and takes up physical disks that cannot be used"},{"line_number":15,"context_line":"for user intended RAID configuration later. This change"},{"line_number":16,"context_line":"excludes H755 RAID controller\u0027s physical disks from converting"},{"line_number":17,"context_line":"to non-RAID mode and leaves disks in \u0027Ready\u0027 state."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id6de320c8e8a9ca21fac277718c405c657f58a3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"b20f84f2_93dbbeed","line":16,"range":{"start_line":16,"start_character":47,"end_line":16,"end_character":51},"in_reply_to":"95cf1438_d2bb21ff","updated":"2021-09-17 07:51:50.000000000","message":"Done","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"828b05d072d453ed2d66a43513d59cf477d335f2","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Monica Pardhi \u003cmpardhi1991@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-09-17 10:34:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for H755 RAID controller when converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When converting Dell EMC PERC H755 RAID controller physical"},{"line_number":10,"context_line":"disks to non-RAID mode, RAID-0 virtual disks get created"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5dd7dcd9_b6621737","line":7,"updated":"2021-09-17 12:50:57.000000000","message":"This line is exceeds 50 characters. Please see https://wiki.openstack.org/wiki/GitCommitMessages for guidance. I suggest it be changed to the following:\n\n    Fix for H755 RAID controller when convert to JBOD","commit_id":"e6f1dbdcc7a2852fd4cf442f234b159743c1be91"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"f998c18173b0f0599e6b397d385cdecc56bf2bdc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Monica Pardhi \u003cmpardhi1991@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-09-17 10:34:39 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for H755 RAID controller when converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When converting Dell EMC PERC H755 RAID controller physical"},{"line_number":10,"context_line":"disks to non-RAID mode, RAID-0 virtual disks get created"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"78f97a02_bf7d1a97","line":7,"in_reply_to":"5dd7dcd9_b6621737","updated":"2021-09-20 07:40:14.000000000","message":"Done","commit_id":"e6f1dbdcc7a2852fd4cf442f234b159743c1be91"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"828b05d072d453ed2d66a43513d59cf477d335f2","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for H755 RAID controller when converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When converting Dell EMC PERC H755 RAID controller physical"},{"line_number":10,"context_line":"disks to non-RAID mode, RAID-0 virtual disks get created"},{"line_number":11,"context_line":"for each physical disk and disks moved to \u0027Online\u0027 state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is different from other controllers supporting non-RAID"},{"line_number":14,"context_line":"conversion and takes up physical disks that cannot be"},{"line_number":15,"context_line":"later used for user intended RAID configuration. This change"},{"line_number":16,"context_line":"excludes H755 RAID controller\u0027s physical disks when converting"},{"line_number":17,"context_line":"to non-RAID mode and leaves disks in \u0027Ready\u0027 state."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id6de320c8e8a9ca21fac277718c405c657f58a3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"e371cb0a_2522075d","line":17,"range":{"start_line":9,"start_character":0,"end_line":17,"end_character":51},"updated":"2021-09-17 12:50:57.000000000","message":"Per the linked best practices above, these line should wrap at 72 characters.","commit_id":"e6f1dbdcc7a2852fd4cf442f234b159743c1be91"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"f998c18173b0f0599e6b397d385cdecc56bf2bdc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix for H755 RAID controller when converting to JBOD mode"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When converting Dell EMC PERC H755 RAID controller physical"},{"line_number":10,"context_line":"disks to non-RAID mode, RAID-0 virtual disks get created"},{"line_number":11,"context_line":"for each physical disk and disks moved to \u0027Online\u0027 state."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This is different from other controllers supporting non-RAID"},{"line_number":14,"context_line":"conversion and takes up physical disks that cannot be"},{"line_number":15,"context_line":"later used for user intended RAID configuration. This change"},{"line_number":16,"context_line":"excludes H755 RAID controller\u0027s physical disks when converting"},{"line_number":17,"context_line":"to non-RAID mode and leaves disks in \u0027Ready\u0027 state."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Id6de320c8e8a9ca21fac277718c405c657f58a3a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"ba21edcb_869336c7","line":17,"range":{"start_line":9,"start_character":0,"end_line":17,"end_character":51},"in_reply_to":"e371cb0a_2522075d","updated":"2021-09-20 07:40:14.000000000","message":"I have checked , all lines are wrapped under 72 characters.","commit_id":"e6f1dbdcc7a2852fd4cf442f234b159743c1be91"}],"dracclient/resources/raid.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":911,"context_line":"        RAID to JBOD or vice versa.  It does this by only converting the"},{"line_number":912,"context_line":"        disks that are not already in the correct state."},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        In case of H755 RAID controller, exisiting virtual disks get deleted"},{"line_number":915,"context_line":"        and moves physical disks into \u0027ready\u0027 state. Moreover, it creates"},{"line_number":916,"context_line":"        another job to convert each physical disk to \u0027RAID-0\u0027."},{"line_number":917,"context_line":"        Modified change excludes H755 RAID controller from conversion of"},{"line_number":918,"context_line":"        physical disks to \u0027RAID-0\u0027 when mode is \u0027JBOD\u0027."},{"line_number":919,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"537835f4_11fc3f1a","line":916,"range":{"start_line":914,"start_character":8,"end_line":916,"end_character":61},"updated":"2021-09-06 10:34:13.000000000","message":"same comment as in the commit message, this paragraph is imprecise.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"74a225b2827586cec10e484680c7bf425b0cfbb0","unresolved":false,"context_lines":[{"line_number":911,"context_line":"        RAID to JBOD or vice versa.  It does this by only converting the"},{"line_number":912,"context_line":"        disks that are not already in the correct state."},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        In case of H755 RAID controller, exisiting virtual disks get deleted"},{"line_number":915,"context_line":"        and moves physical disks into \u0027ready\u0027 state. Moreover, it creates"},{"line_number":916,"context_line":"        another job to convert each physical disk to \u0027RAID-0\u0027."},{"line_number":917,"context_line":"        Modified change excludes H755 RAID controller from conversion of"},{"line_number":918,"context_line":"        physical disks to \u0027RAID-0\u0027 when mode is \u0027JBOD\u0027."},{"line_number":919,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"4766b345_f7f56e9d","line":916,"range":{"start_line":914,"start_character":8,"end_line":916,"end_character":61},"in_reply_to":"537835f4_11fc3f1a","updated":"2021-09-08 18:01:53.000000000","message":"Done","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":915,"context_line":"        and moves physical disks into \u0027ready\u0027 state. Moreover, it creates"},{"line_number":916,"context_line":"        another job to convert each physical disk to \u0027RAID-0\u0027."},{"line_number":917,"context_line":"        Modified change excludes H755 RAID controller from conversion of"},{"line_number":918,"context_line":"        physical disks to \u0027RAID-0\u0027 when mode is \u0027JBOD\u0027."},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"        :param mode: constants.RaidStatus enumeration that indicates the mode"},{"line_number":921,"context_line":"                     to change the disks to."}],"source_content_type":"text/x-python","patch_set":4,"id":"448091d8_7df18b10","line":918,"range":{"start_line":918,"start_character":23,"end_line":918,"end_character":34},"updated":"2021-09-06 10:34:13.000000000","message":"imprecise - this change excludes from converting to non-RAID mode.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"74a225b2827586cec10e484680c7bf425b0cfbb0","unresolved":true,"context_lines":[{"line_number":915,"context_line":"        and moves physical disks into \u0027ready\u0027 state. Moreover, it creates"},{"line_number":916,"context_line":"        another job to convert each physical disk to \u0027RAID-0\u0027."},{"line_number":917,"context_line":"        Modified change excludes H755 RAID controller from conversion of"},{"line_number":918,"context_line":"        physical disks to \u0027RAID-0\u0027 when mode is \u0027JBOD\u0027."},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"        :param mode: constants.RaidStatus enumeration that indicates the mode"},{"line_number":921,"context_line":"                     to change the disks to."}],"source_content_type":"text/x-python","patch_set":4,"id":"b3bf040e_119da703","line":918,"range":{"start_line":918,"start_character":23,"end_line":918,"end_character":34},"in_reply_to":"448091d8_7df18b10","updated":"2021-09-08 18:01:53.000000000","message":"Ack","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d01161082fdda65515d272c2afcbf2f0b6967745","unresolved":false,"context_lines":[{"line_number":915,"context_line":"        and moves physical disks into \u0027ready\u0027 state. Moreover, it creates"},{"line_number":916,"context_line":"        another job to convert each physical disk to \u0027RAID-0\u0027."},{"line_number":917,"context_line":"        Modified change excludes H755 RAID controller from conversion of"},{"line_number":918,"context_line":"        physical disks to \u0027RAID-0\u0027 when mode is \u0027JBOD\u0027."},{"line_number":919,"context_line":""},{"line_number":920,"context_line":"        :param mode: constants.RaidStatus enumeration that indicates the mode"},{"line_number":921,"context_line":"                     to change the disks to."}],"source_content_type":"text/x-python","patch_set":4,"id":"43663248_e0f58b94","line":918,"range":{"start_line":918,"start_character":23,"end_line":918,"end_character":34},"in_reply_to":"b3bf040e_119da703","updated":"2021-09-09 08:43:32.000000000","message":"Done","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":953,"context_line":""},{"line_number":954,"context_line":"                    physical_disk_ids.append(physical_d.id)"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"        \u0027\u0027\u0027In case of H755 RAID controller, exisiting virtual disks get deleted"},{"line_number":957,"context_line":"        and moves physical disks into \u0027ready\u0027 state. Moreover, it creates"},{"line_number":958,"context_line":"        another job to convert each physical disk to RAID-0."},{"line_number":959,"context_line":"        With below change, it excludes the H755 RAID controller from conversion"},{"line_number":960,"context_line":"        of physical disks when mode is \u0027JBOD\u0027"},{"line_number":961,"context_line":"        \u0027\u0027\u0027"},{"line_number":962,"context_line":"        if mode \u003d\u003d jbod:"},{"line_number":963,"context_line":"            for cntlr in all_controllers:"}],"source_content_type":"text/x-python","patch_set":4,"id":"6651f133_33e8211c","line":960,"range":{"start_line":956,"start_character":11,"end_line":960,"end_character":45},"updated":"2021-09-06 10:34:13.000000000","message":"again, imprecise as indicated before.\nHowever, here I wouldn\u0027t repeat exactly the same text as elsewhere.\nI would be shorter here, just saying\n\n  # filter out PERC H755 controller as it creates RAID0 VDs when in non-RAID mode","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"74a225b2827586cec10e484680c7bf425b0cfbb0","unresolved":false,"context_lines":[{"line_number":953,"context_line":""},{"line_number":954,"context_line":"                    physical_disk_ids.append(physical_d.id)"},{"line_number":955,"context_line":""},{"line_number":956,"context_line":"        \u0027\u0027\u0027In case of H755 RAID controller, exisiting virtual disks get deleted"},{"line_number":957,"context_line":"        and moves physical disks into \u0027ready\u0027 state. Moreover, it creates"},{"line_number":958,"context_line":"        another job to convert each physical disk to RAID-0."},{"line_number":959,"context_line":"        With below change, it excludes the H755 RAID controller from conversion"},{"line_number":960,"context_line":"        of physical disks when mode is \u0027JBOD\u0027"},{"line_number":961,"context_line":"        \u0027\u0027\u0027"},{"line_number":962,"context_line":"        if mode \u003d\u003d jbod:"},{"line_number":963,"context_line":"            for cntlr in all_controllers:"}],"source_content_type":"text/x-python","patch_set":4,"id":"95845661_9c9deab0","line":960,"range":{"start_line":956,"start_character":11,"end_line":960,"end_character":45},"in_reply_to":"6651f133_33e8211c","updated":"2021-09-08 18:01:53.000000000","message":"Done","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":965,"context_line":"                 cntlr.id in controllers_to_physical_disk_ids:"},{"line_number":966,"context_line":"                    LOG.debug(\"Excluding {} from converting to \""},{"line_number":967,"context_line":"                              \"non-RAID mode\".format(cntlr.model))"},{"line_number":968,"context_line":"                    del controllers_to_physical_disk_ids[cntlr.id]"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        \u0027\u0027\u0027Modify controllers_to_physical_disk_ids dict by inspecting desired"},{"line_number":971,"context_line":"        status vs current status of each controller\u0027s disks."}],"source_content_type":"text/x-python","patch_set":4,"id":"49c9fd00_f09e52cd","line":968,"updated":"2021-09-06 10:34:13.000000000","message":"looking around, this method is returning `conversion_results`. Add entry for H755 controller here. Consult the docstring at line 924 and existing examples at line 99, 1005 to see what should be there.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d01161082fdda65515d272c2afcbf2f0b6967745","unresolved":false,"context_lines":[{"line_number":965,"context_line":"                 cntlr.id in controllers_to_physical_disk_ids:"},{"line_number":966,"context_line":"                    LOG.debug(\"Excluding {} from converting to \""},{"line_number":967,"context_line":"                              \"non-RAID mode\".format(cntlr.model))"},{"line_number":968,"context_line":"                    del controllers_to_physical_disk_ids[cntlr.id]"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        \u0027\u0027\u0027Modify controllers_to_physical_disk_ids dict by inspecting desired"},{"line_number":971,"context_line":"        status vs current status of each controller\u0027s disks."}],"source_content_type":"text/x-python","patch_set":4,"id":"9b5cd94e_448ff023","line":968,"in_reply_to":"2bd31557_9587be6d","updated":"2021-09-09 08:43:32.000000000","message":"Done","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"74a225b2827586cec10e484680c7bf425b0cfbb0","unresolved":true,"context_lines":[{"line_number":965,"context_line":"                 cntlr.id in controllers_to_physical_disk_ids:"},{"line_number":966,"context_line":"                    LOG.debug(\"Excluding {} from converting to \""},{"line_number":967,"context_line":"                              \"non-RAID mode\".format(cntlr.model))"},{"line_number":968,"context_line":"                    del controllers_to_physical_disk_ids[cntlr.id]"},{"line_number":969,"context_line":""},{"line_number":970,"context_line":"        \u0027\u0027\u0027Modify controllers_to_physical_disk_ids dict by inspecting desired"},{"line_number":971,"context_line":"        status vs current status of each controller\u0027s disks."}],"source_content_type":"text/x-python","patch_set":4,"id":"2bd31557_9587be6d","line":968,"in_reply_to":"49c9fd00_f09e52cd","updated":"2021-09-08 18:01:53.000000000","message":"Added conversion_result here.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d01161082fdda65515d272c2afcbf2f0b6967745","unresolved":true,"context_lines":[{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        This is different from other controllers supporting non-RAID conversion"},{"line_number":919,"context_line":"        and takes up physical disks that cannot be used for user intended RAID"},{"line_number":920,"context_line":"        configuration later. This change excludes H755 RAID controller\u0027s"},{"line_number":921,"context_line":"        physical disks from converting to non-RAID mode and leaves disks"},{"line_number":922,"context_line":"        in \u0027Ready\u0027 state."},{"line_number":923,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5fd353ac_6a3778d3","line":920,"range":{"start_line":920,"start_character":29,"end_line":920,"end_character":40},"updated":"2021-09-09 08:43:32.000000000","message":"this is a documentation string, in the context of documentation there is no \"This change\". Please rephrase to say smth like \"H755 RAID controllers are excluded from converting to to non-RAID mode leaving disks in \u0027Ready\u0027 state\".","commit_id":"6976e9935f2f1747c96281ecfb922b64927b0209"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8fc312dc49d97cf426473e2cdf40bad7a6304283","unresolved":true,"context_lines":[{"line_number":911,"context_line":"        RAID to JBOD or vice versa.  It does this by only converting the"},{"line_number":912,"context_line":"        disks that are not already in the correct state."},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        When converting H755 RAID controller physical disks to non-RAID mode,"},{"line_number":915,"context_line":"        RAID-0 virtual disks get created for each physical disk and disks moved"},{"line_number":916,"context_line":"        to \u0027Online\u0027 state."},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        This is different from other controllers supporting non-RAID conversion"},{"line_number":919,"context_line":"        and takes up physical disks that cannot be used for user intended RAID"},{"line_number":920,"context_line":"        configuration later. H755 RAID controllers are excluded from converting"},{"line_number":921,"context_line":"        to non-RAID mode leaving disks in \u0027Ready\u0027 state."},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"        :param mode: constants.RaidStatus enumeration that indicates the mode"},{"line_number":924,"context_line":"                     to change the disks to."},{"line_number":925,"context_line":"        :param controllers_to_physical_disk_ids: Dictionary of controllers and"}],"source_content_type":"text/x-python","patch_set":6,"id":"698a8113_e540c3a9","line":922,"range":{"start_line":914,"start_character":0,"end_line":922,"end_character":0},"updated":"2021-09-16 12:59:44.000000000","message":"Please consider applying suggested commit message improvements here.","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"4cbc9ac37ecf84be5b70ef2a6a94d23e07f14b7b","unresolved":false,"context_lines":[{"line_number":911,"context_line":"        RAID to JBOD or vice versa.  It does this by only converting the"},{"line_number":912,"context_line":"        disks that are not already in the correct state."},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        When converting H755 RAID controller physical disks to non-RAID mode,"},{"line_number":915,"context_line":"        RAID-0 virtual disks get created for each physical disk and disks moved"},{"line_number":916,"context_line":"        to \u0027Online\u0027 state."},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"        This is different from other controllers supporting non-RAID conversion"},{"line_number":919,"context_line":"        and takes up physical disks that cannot be used for user intended RAID"},{"line_number":920,"context_line":"        configuration later. H755 RAID controllers are excluded from converting"},{"line_number":921,"context_line":"        to non-RAID mode leaving disks in \u0027Ready\u0027 state."},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"        :param mode: constants.RaidStatus enumeration that indicates the mode"},{"line_number":924,"context_line":"                     to change the disks to."},{"line_number":925,"context_line":"        :param controllers_to_physical_disk_ids: Dictionary of controllers and"}],"source_content_type":"text/x-python","patch_set":6,"id":"824db9cf_31fe3d87","line":922,"range":{"start_line":914,"start_character":0,"end_line":922,"end_character":0},"in_reply_to":"698a8113_e540c3a9","updated":"2021-09-17 07:51:50.000000000","message":"Done","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8fc312dc49d97cf426473e2cdf40bad7a6304283","unresolved":true,"context_lines":[{"line_number":956,"context_line":""},{"line_number":957,"context_line":"                    physical_disk_ids.append(physical_d.id)"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"        # Filter out PERC H755 controller as it creates RAID0 virtual disks"},{"line_number":960,"context_line":"        # when in non-RAID mode"},{"line_number":961,"context_line":"        controllers_to_results \u003d {}"},{"line_number":962,"context_line":"        if mode \u003d\u003d jbod:"}],"source_content_type":"text/x-python","patch_set":6,"id":"51a7919f_a1c08bd6","line":959,"range":{"start_line":959,"start_character":56,"end_line":959,"end_character":61},"updated":"2021-09-16 12:59:44.000000000","message":"nit: RAID-0","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"4cbc9ac37ecf84be5b70ef2a6a94d23e07f14b7b","unresolved":false,"context_lines":[{"line_number":956,"context_line":""},{"line_number":957,"context_line":"                    physical_disk_ids.append(physical_d.id)"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"        # Filter out PERC H755 controller as it creates RAID0 virtual disks"},{"line_number":960,"context_line":"        # when in non-RAID mode"},{"line_number":961,"context_line":"        controllers_to_results \u003d {}"},{"line_number":962,"context_line":"        if mode \u003d\u003d jbod:"}],"source_content_type":"text/x-python","patch_set":6,"id":"e9094ee1_23bd0b97","line":959,"range":{"start_line":959,"start_character":56,"end_line":959,"end_character":61},"in_reply_to":"51a7919f_a1c08bd6","updated":"2021-09-17 07:51:50.000000000","message":"Done","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"8fc312dc49d97cf426473e2cdf40bad7a6304283","unresolved":true,"context_lines":[{"line_number":958,"context_line":""},{"line_number":959,"context_line":"        # Filter out PERC H755 controller as it creates RAID0 virtual disks"},{"line_number":960,"context_line":"        # when in non-RAID mode"},{"line_number":961,"context_line":"        controllers_to_results \u003d {}"},{"line_number":962,"context_line":"        if mode \u003d\u003d jbod:"},{"line_number":963,"context_line":"            for cntlr in all_controllers:"},{"line_number":964,"context_line":"                if cntlr.model.startswith(\"PERC H755\") and \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"5ddfd961_b836d0d1","line":961,"updated":"2021-09-16 12:59:44.000000000","message":"Please highlight this as the method\u0027s return value by moving it above the comment about the filter on line 959. A brief comment that it is the return value would help.","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"4cbc9ac37ecf84be5b70ef2a6a94d23e07f14b7b","unresolved":false,"context_lines":[{"line_number":958,"context_line":""},{"line_number":959,"context_line":"        # Filter out PERC H755 controller as it creates RAID0 virtual disks"},{"line_number":960,"context_line":"        # when in non-RAID mode"},{"line_number":961,"context_line":"        controllers_to_results \u003d {}"},{"line_number":962,"context_line":"        if mode \u003d\u003d jbod:"},{"line_number":963,"context_line":"            for cntlr in all_controllers:"},{"line_number":964,"context_line":"                if cntlr.model.startswith(\"PERC H755\") and \\"}],"source_content_type":"text/x-python","patch_set":6,"id":"d84954a7_cb15196e","line":961,"in_reply_to":"5ddfd961_b836d0d1","updated":"2021-09-17 07:51:50.000000000","message":"Done","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"f3a51358e3c57f3d2cf77c4c5a0ae350185ba3d3","unresolved":true,"context_lines":[{"line_number":956,"context_line":""},{"line_number":957,"context_line":"                    physical_disk_ids.append(physical_d.id)"},{"line_number":958,"context_line":""},{"line_number":959,"context_line":"        controllers_to_results \u003d {}"},{"line_number":960,"context_line":"        # Filter out PERC H755 controller as it creates RAID-0 virtual disks"},{"line_number":961,"context_line":"        # when in non-RAID mode. Returns conversion result dictionary"},{"line_number":962,"context_line":"        # containing is_commit_required and is_reboot_required key with"}],"source_content_type":"text/x-python","patch_set":8,"id":"6c14eaf1_3acfd9eb","line":959,"updated":"2021-09-17 18:34:19.000000000","message":"nit: Please add a blank line after this one and before the comment block that follows.","commit_id":"e6f1dbdcc7a2852fd4cf442f234b159743c1be91"}],"dracclient/tests/test_raid.py":[{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.disk_5 \u003d raid.PhysicalDisk("},{"line_number":126,"context_line":"            id\u003d\u0027Disk.Bay.0:Enclosure.Internal.0-1:RAID.SL.8-1\u0027,"},{"line_number":127,"context_line":"            description\u003d\u0027Disk 0 in Backplane 1 of Int RAID Controller 1\u0027,"},{"line_number":128,"context_line":"            controller\u003d\u0027RAID.SL.8-1\u0027,"},{"line_number":129,"context_line":"            manufacturer\u003d\u0027ATA\u0027,"},{"line_number":130,"context_line":"            model\u003d\u0027ST91000640NS\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"c83208d5_a3ccede0","line":127,"range":{"start_line":127,"start_character":25,"end_line":127,"end_character":71},"updated":"2021-09-06 10:34:13.000000000","message":"let\u0027s have realistic, or at least different description here. See that existing test data has different description for different controllers (e.g., line 109 and line 91).","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"74a225b2827586cec10e484680c7bf425b0cfbb0","unresolved":false,"context_lines":[{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        self.disk_5 \u003d raid.PhysicalDisk("},{"line_number":126,"context_line":"            id\u003d\u0027Disk.Bay.0:Enclosure.Internal.0-1:RAID.SL.8-1\u0027,"},{"line_number":127,"context_line":"            description\u003d\u0027Disk 0 in Backplane 1 of Int RAID Controller 1\u0027,"},{"line_number":128,"context_line":"            controller\u003d\u0027RAID.SL.8-1\u0027,"},{"line_number":129,"context_line":"            manufacturer\u003d\u0027ATA\u0027,"},{"line_number":130,"context_line":"            model\u003d\u0027ST91000640NS\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"eb27f3f8_3bdac334","line":127,"range":{"start_line":127,"start_character":25,"end_line":127,"end_character":71},"in_reply_to":"c83208d5_a3ccede0","updated":"2021-09-08 18:01:53.000000000","message":"Done","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":1375,"context_line":"                     [\u0027Disk.Bay.0:Enclosure.Internal.0-1:AHCI.Integrated.1-1\u0027,"},{"line_number":1376,"context_line":"                      \u0027Disk.Bay.1:Enclosure.Internal.0-1:AHCI.Integrated.1-1\u0027]}"},{"line_number":1377,"context_line":"        results \u003d self.drac_client.change_physical_disk_state("},{"line_number":1378,"context_line":"            mode, cntl_dict)"},{"line_number":1379,"context_line":"        self.assertEqual(results[\u0027conversion_results\u0027],"},{"line_number":1380,"context_line":"                         expected_return_value)"},{"line_number":1381,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"edee5940_39acad1f","line":1378,"range":{"start_line":1378,"start_character":18,"end_line":1378,"end_character":27},"updated":"2021-09-06 10:34:13.000000000","message":"why this change? This is input parameter, that should pass all existing controllers and their drives, including H755. This patch is for accommodating H755, but having this change here this test excludes H755 from testing. Which is opposite of what should be done.\nRevisit this change. If tests are failing, then there is smth else missing, e.g., mocking.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d01161082fdda65515d272c2afcbf2f0b6967745","unresolved":false,"context_lines":[{"line_number":1375,"context_line":"                     [\u0027Disk.Bay.0:Enclosure.Internal.0-1:AHCI.Integrated.1-1\u0027,"},{"line_number":1376,"context_line":"                      \u0027Disk.Bay.1:Enclosure.Internal.0-1:AHCI.Integrated.1-1\u0027]}"},{"line_number":1377,"context_line":"        results \u003d self.drac_client.change_physical_disk_state("},{"line_number":1378,"context_line":"            mode, cntl_dict)"},{"line_number":1379,"context_line":"        self.assertEqual(results[\u0027conversion_results\u0027],"},{"line_number":1380,"context_line":"                         expected_return_value)"},{"line_number":1381,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3b090165_32429345","line":1378,"range":{"start_line":1378,"start_character":18,"end_line":1378,"end_character":27},"in_reply_to":"220789e2_c371368b","updated":"2021-09-09 08:43:32.000000000","message":"Done","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"74a225b2827586cec10e484680c7bf425b0cfbb0","unresolved":true,"context_lines":[{"line_number":1375,"context_line":"                     [\u0027Disk.Bay.0:Enclosure.Internal.0-1:AHCI.Integrated.1-1\u0027,"},{"line_number":1376,"context_line":"                      \u0027Disk.Bay.1:Enclosure.Internal.0-1:AHCI.Integrated.1-1\u0027]}"},{"line_number":1377,"context_line":"        results \u003d self.drac_client.change_physical_disk_state("},{"line_number":1378,"context_line":"            mode, cntl_dict)"},{"line_number":1379,"context_line":"        self.assertEqual(results[\u0027conversion_results\u0027],"},{"line_number":1380,"context_line":"                         expected_return_value)"},{"line_number":1381,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"220789e2_c371368b","line":1378,"range":{"start_line":1378,"start_character":18,"end_line":1378,"end_character":27},"in_reply_to":"edee5940_39acad1f","updated":"2021-09-08 18:01:53.000000000","message":"As I have added new test case for H755 ,thats why used new cntl_dict which is not having H755 controller disk.\nNow updated this test case which is covering H755 controller.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":1385,"context_line":"    @mock.patch.object(dracclient.resources.raid.RAIDManagement,"},{"line_number":1386,"context_line":"                       \u0027convert_physical_disks\u0027, spec_set\u003dTrue,"},{"line_number":1387,"context_line":"                       autospec\u003dTrue)"},{"line_number":1388,"context_line":"    def test_change_physical_disk_state_jbod_h755("},{"line_number":1389,"context_line":"            self, mock_requests,"},{"line_number":1390,"context_line":"            mock_convert_physical_disks,"},{"line_number":1391,"context_line":"            wait_until_idrac_is_ready):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bd983be1_e13f4672","line":1388,"range":{"start_line":1388,"start_character":8,"end_line":1388,"end_character":49},"updated":"2021-09-06 10:34:13.000000000","message":"it shouldn\u0027t be necessary to create separate test just for H755, it should be covered by `test_change_physical_disk_state_jbod` (see comment above).","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d01161082fdda65515d272c2afcbf2f0b6967745","unresolved":false,"context_lines":[{"line_number":1385,"context_line":"    @mock.patch.object(dracclient.resources.raid.RAIDManagement,"},{"line_number":1386,"context_line":"                       \u0027convert_physical_disks\u0027, spec_set\u003dTrue,"},{"line_number":1387,"context_line":"                       autospec\u003dTrue)"},{"line_number":1388,"context_line":"    def test_change_physical_disk_state_jbod_h755("},{"line_number":1389,"context_line":"            self, mock_requests,"},{"line_number":1390,"context_line":"            mock_convert_physical_disks,"},{"line_number":1391,"context_line":"            wait_until_idrac_is_ready):"}],"source_content_type":"text/x-python","patch_set":4,"id":"937af66c_1a216c6f","line":1388,"range":{"start_line":1388,"start_character":8,"end_line":1388,"end_character":49},"in_reply_to":"30c38fe7_10ea9c49","updated":"2021-09-09 08:43:32.000000000","message":"Done","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"74a225b2827586cec10e484680c7bf425b0cfbb0","unresolved":true,"context_lines":[{"line_number":1385,"context_line":"    @mock.patch.object(dracclient.resources.raid.RAIDManagement,"},{"line_number":1386,"context_line":"                       \u0027convert_physical_disks\u0027, spec_set\u003dTrue,"},{"line_number":1387,"context_line":"                       autospec\u003dTrue)"},{"line_number":1388,"context_line":"    def test_change_physical_disk_state_jbod_h755("},{"line_number":1389,"context_line":"            self, mock_requests,"},{"line_number":1390,"context_line":"            mock_convert_physical_disks,"},{"line_number":1391,"context_line":"            wait_until_idrac_is_ready):"}],"source_content_type":"text/x-python","patch_set":4,"id":"30c38fe7_10ea9c49","line":1388,"range":{"start_line":1388,"start_character":8,"end_line":1388,"end_character":49},"in_reply_to":"bd983be1_e13f4672","updated":"2021-09-08 18:01:53.000000000","message":"I have added this because of code coverage. But now I have updated the test_change_physical_disk_state_jbod test case in new patchset which is covering H755 controller. So deleted this test case.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":1416,"context_line":"        mode \u003d constants.RaidStatus.raid"},{"line_number":1417,"context_line":"        disk_1_non_raid \u003d self.disk_1._replace(raid_status\u003d\u0027non-RAID\u0027)"},{"line_number":1418,"context_line":"        disk_2_non_raid \u003d self.disk_2._replace(raid_status\u003d\u0027non-RAID\u0027)"},{"line_number":1419,"context_line":"        disk_5_non_raid \u003d self.disk_5._replace(raid_status\u003d\u0027non-RAID\u0027)"},{"line_number":1420,"context_line":"        physical_disks \u003d [disk_1_non_raid, disk_2_non_raid,"},{"line_number":1421,"context_line":"                          self.disk_3, self.disk_4, disk_5_non_raid]"},{"line_number":1422,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"}],"source_content_type":"text/x-python","patch_set":4,"id":"9f4b4878_471db24f","line":1419,"range":{"start_line":1419,"start_character":8,"end_line":1419,"end_character":70},"updated":"2021-09-06 10:34:13.000000000","message":"is this realistic state for H755 physical disk? From my observations there is no \u0027non-RAID\u0027 state for H755 disks. It\u0027s either \u0027Ready\u0027 (when no VD created) or \u0027Online\u0027 (when VD created). Some clarification is necessary from firmware team to understand what it means to have non-RAID disk for H755.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d01161082fdda65515d272c2afcbf2f0b6967745","unresolved":false,"context_lines":[{"line_number":1416,"context_line":"        mode \u003d constants.RaidStatus.raid"},{"line_number":1417,"context_line":"        disk_1_non_raid \u003d self.disk_1._replace(raid_status\u003d\u0027non-RAID\u0027)"},{"line_number":1418,"context_line":"        disk_2_non_raid \u003d self.disk_2._replace(raid_status\u003d\u0027non-RAID\u0027)"},{"line_number":1419,"context_line":"        disk_5_non_raid \u003d self.disk_5._replace(raid_status\u003d\u0027non-RAID\u0027)"},{"line_number":1420,"context_line":"        physical_disks \u003d [disk_1_non_raid, disk_2_non_raid,"},{"line_number":1421,"context_line":"                          self.disk_3, self.disk_4, disk_5_non_raid]"},{"line_number":1422,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"}],"source_content_type":"text/x-python","patch_set":4,"id":"e5366530_2c32e506","line":1419,"range":{"start_line":1419,"start_character":8,"end_line":1419,"end_character":70},"in_reply_to":"37e89464_13ae572a","updated":"2021-09-09 08:43:32.000000000","message":"Done","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"74a225b2827586cec10e484680c7bf425b0cfbb0","unresolved":true,"context_lines":[{"line_number":1416,"context_line":"        mode \u003d constants.RaidStatus.raid"},{"line_number":1417,"context_line":"        disk_1_non_raid \u003d self.disk_1._replace(raid_status\u003d\u0027non-RAID\u0027)"},{"line_number":1418,"context_line":"        disk_2_non_raid \u003d self.disk_2._replace(raid_status\u003d\u0027non-RAID\u0027)"},{"line_number":1419,"context_line":"        disk_5_non_raid \u003d self.disk_5._replace(raid_status\u003d\u0027non-RAID\u0027)"},{"line_number":1420,"context_line":"        physical_disks \u003d [disk_1_non_raid, disk_2_non_raid,"},{"line_number":1421,"context_line":"                          self.disk_3, self.disk_4, disk_5_non_raid]"},{"line_number":1422,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"}],"source_content_type":"text/x-python","patch_set":4,"id":"37e89464_13ae572a","line":1419,"range":{"start_line":1419,"start_character":8,"end_line":1419,"end_character":70},"in_reply_to":"9f4b4878_471db24f","updated":"2021-09-08 18:01:53.000000000","message":"No, there is not Non-RAID state for H755 physical disk. We are having only \u0027ready\u0027 and \u0027online\u0027 state.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":1426,"context_line":"        raid_return_value \u003d {\u0027is_commit_required\u0027: True,"},{"line_number":1427,"context_line":"                             \u0027is_reboot_required\u0027:"},{"line_number":1428,"context_line":"                             constants.RebootRequired.true}"},{"line_number":1429,"context_line":"        h755_return_value \u003d {\u0027is_commit_required\u0027: True,"},{"line_number":1430,"context_line":"                             \u0027is_reboot_required\u0027:"},{"line_number":1431,"context_line":"                             constants.RebootRequired.true}"},{"line_number":1432,"context_line":"        mock_convert_physical_disks.return_value \u003d raid_return_value"},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"        results \u003d self.drac_client.change_physical_disk_state("}],"source_content_type":"text/x-python","patch_set":4,"id":"e321e262_8b033e7e","line":1431,"range":{"start_line":1429,"start_character":7,"end_line":1431,"end_character":59},"updated":"2021-09-06 10:34:13.000000000","message":"Is this realistic scenario? Are there any scripts checked where conversion to RAID mode is done for H755 physical disks? Because in iDRAC UI there is no option \"Convert to RAID mode\". I haven\u0027t checked what happens when trying to call it using Redfish or WS-Man API, but that should be checked to have realistic test setup here.\n\nMy guess is that the PDs will be in \u0027Ready\u0027 state or \u0027Online\u0027, never in \u0027non-RAID\u0027 state. Implicitly, H755 will never have response were commit or reboot is required. Please do some testing on real hardware to see what\u0027s really happening and mimic it here.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d01161082fdda65515d272c2afcbf2f0b6967745","unresolved":false,"context_lines":[{"line_number":1426,"context_line":"        raid_return_value \u003d {\u0027is_commit_required\u0027: True,"},{"line_number":1427,"context_line":"                             \u0027is_reboot_required\u0027:"},{"line_number":1428,"context_line":"                             constants.RebootRequired.true}"},{"line_number":1429,"context_line":"        h755_return_value \u003d {\u0027is_commit_required\u0027: True,"},{"line_number":1430,"context_line":"                             \u0027is_reboot_required\u0027:"},{"line_number":1431,"context_line":"                             constants.RebootRequired.true}"},{"line_number":1432,"context_line":"        mock_convert_physical_disks.return_value \u003d raid_return_value"},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"        results \u003d self.drac_client.change_physical_disk_state("}],"source_content_type":"text/x-python","patch_set":4,"id":"ab85466d_26f118bf","line":1431,"range":{"start_line":1429,"start_character":7,"end_line":1431,"end_character":59},"in_reply_to":"dd8cc369_f0961225","updated":"2021-09-09 08:43:32.000000000","message":"Done","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"74a225b2827586cec10e484680c7bf425b0cfbb0","unresolved":true,"context_lines":[{"line_number":1426,"context_line":"        raid_return_value \u003d {\u0027is_commit_required\u0027: True,"},{"line_number":1427,"context_line":"                             \u0027is_reboot_required\u0027:"},{"line_number":1428,"context_line":"                             constants.RebootRequired.true}"},{"line_number":1429,"context_line":"        h755_return_value \u003d {\u0027is_commit_required\u0027: True,"},{"line_number":1430,"context_line":"                             \u0027is_reboot_required\u0027:"},{"line_number":1431,"context_line":"                             constants.RebootRequired.true}"},{"line_number":1432,"context_line":"        mock_convert_physical_disks.return_value \u003d raid_return_value"},{"line_number":1433,"context_line":""},{"line_number":1434,"context_line":"        results \u003d self.drac_client.change_physical_disk_state("}],"source_content_type":"text/x-python","patch_set":4,"id":"dd8cc369_f0961225","line":1431,"range":{"start_line":1429,"start_character":7,"end_line":1431,"end_character":59},"in_reply_to":"e321e262_8b033e7e","updated":"2021-09-08 18:01:53.000000000","message":"I have checked in iDRAC UI there is no option \u0027Convert to RAID mode\u0027. Also executed WS-Man cli to test it on real hardware, getting below message :\n\n\u003cn1:ConvertToRAID_OUTPUT\u003e\n    \u003cn1:Message\u003eThe operation cannot be completed either because the operation is not supported on the target device, or the RAIDType of \"MD Software RAID\" does not allow the operation.\u003c/n1:Message\u003e\n\u003cn1:MessageID\u003eSTOR058\u003c/n1:MessageID\u003e","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"eadbda1001521b40d61913eae860b632afacce69","unresolved":true,"context_lines":[{"line_number":1450,"context_line":"    def test_change_physical_disk_state_none("},{"line_number":1451,"context_line":"            self, mock_requests,"},{"line_number":1452,"context_line":"            mock_list_physical_disks,"},{"line_number":1453,"context_line":"            mock_list_raid_controllers):"},{"line_number":1454,"context_line":"        mode \u003d constants.RaidStatus.raid"},{"line_number":1455,"context_line":"        physical_disks \u003d [self.disk_1, self.disk_2, self.disk_3, self.disk_4,"},{"line_number":1456,"context_line":"                          self.disk_5]"}],"source_content_type":"text/x-python","patch_set":4,"id":"39a82e96_06cf013b","line":1453,"range":{"start_line":1453,"start_character":12,"end_line":1453,"end_character":38},"updated":"2021-09-06 10:34:13.000000000","message":"here and below, is there any `return_value` mocked somewhere for this? Or is it using just default `Mock`?","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"74a225b2827586cec10e484680c7bf425b0cfbb0","unresolved":true,"context_lines":[{"line_number":1450,"context_line":"    def test_change_physical_disk_state_none("},{"line_number":1451,"context_line":"            self, mock_requests,"},{"line_number":1452,"context_line":"            mock_list_physical_disks,"},{"line_number":1453,"context_line":"            mock_list_raid_controllers):"},{"line_number":1454,"context_line":"        mode \u003d constants.RaidStatus.raid"},{"line_number":1455,"context_line":"        physical_disks \u003d [self.disk_1, self.disk_2, self.disk_3, self.disk_4,"},{"line_number":1456,"context_line":"                          self.disk_5]"}],"source_content_type":"text/x-python","patch_set":4,"id":"627e043f_fc6a38aa","line":1453,"range":{"start_line":1453,"start_character":12,"end_line":1453,"end_character":38},"in_reply_to":"39a82e96_06cf013b","updated":"2021-09-08 18:01:53.000000000","message":"It is mocked here , because of below change.\nall_controllers \u003d self.list_raid_controllers() in change_physical_disk_state\nIf list_raid_controller is not mocked, it will raise NoMockAdrress exception.","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"d01161082fdda65515d272c2afcbf2f0b6967745","unresolved":true,"context_lines":[{"line_number":1450,"context_line":"    def test_change_physical_disk_state_none("},{"line_number":1451,"context_line":"            self, mock_requests,"},{"line_number":1452,"context_line":"            mock_list_physical_disks,"},{"line_number":1453,"context_line":"            mock_list_raid_controllers):"},{"line_number":1454,"context_line":"        mode \u003d constants.RaidStatus.raid"},{"line_number":1455,"context_line":"        physical_disks \u003d [self.disk_1, self.disk_2, self.disk_3, self.disk_4,"},{"line_number":1456,"context_line":"                          self.disk_5]"}],"source_content_type":"text/x-python","patch_set":4,"id":"68831729_cd279e53","line":1453,"range":{"start_line":1453,"start_character":12,"end_line":1453,"end_character":38},"in_reply_to":"627e043f_fc6a38aa","updated":"2021-09-09 08:43:32.000000000","message":"yup, but if there is no return_value specified then it will return MagickMock() and the only reason because these tests are still passing is because they don\u0027t need to use the returned value (lines 954 and 956 are not tested in these tests). It\u0027s OK as long as code works as expected, otherwise it could render confusing error messages when entering lines 954, 956.\n\nHowever, I suggest to keep the same approach as it is in other tests to mock list_raid_controllers. Looking around at other tests, `mock_requests.post` is used to mock returned controllers that populates entries from provided XMLs. See for example [1]. Please update to use this same approach for consistency.\n\n[1] https://opendev.org/openstack/python-dracclient/src/branch/master/dracclient/tests/test_raid.py#L1334-L1336","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"34bce4837eae12026c1d2e48de469b9bb98164dd","unresolved":true,"context_lines":[{"line_number":1450,"context_line":"    def test_change_physical_disk_state_none("},{"line_number":1451,"context_line":"            self, mock_requests,"},{"line_number":1452,"context_line":"            mock_list_physical_disks,"},{"line_number":1453,"context_line":"            mock_list_raid_controllers):"},{"line_number":1454,"context_line":"        mode \u003d constants.RaidStatus.raid"},{"line_number":1455,"context_line":"        physical_disks \u003d [self.disk_1, self.disk_2, self.disk_3, self.disk_4,"},{"line_number":1456,"context_line":"                          self.disk_5]"}],"source_content_type":"text/x-python","patch_set":4,"id":"954fca9f_57f6ca79","line":1453,"range":{"start_line":1453,"start_character":12,"end_line":1453,"end_character":38},"in_reply_to":"68831729_cd279e53","updated":"2021-09-09 08:45:23.000000000","message":"meant lines 954, 964","commit_id":"ee4dca3a7eb12d87e361889449e46f4d0e122c97"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"b59239674cabdb2bdf049db6ff655bca17a00021","unresolved":true,"context_lines":[{"line_number":1345,"context_line":"                          physical_disks,"},{"line_number":1346,"context_line":"                          self.controllers_to_physical_disk_ids)"},{"line_number":1347,"context_line":""},{"line_number":1348,"context_line":"    @mock.patch.object(dracclient.resources.raid.RAIDManagement,"},{"line_number":1349,"context_line":"                       \u0027list_physical_disks\u0027, spec_set\u003dTrue,"},{"line_number":1350,"context_line":"                       autospec\u003dTrue)"},{"line_number":1351,"context_line":"    @mock.patch.object(dracclient.client.WSManClient,"},{"line_number":1352,"context_line":"                       \u0027wait_until_idrac_is_ready\u0027, spec_set\u003dTrue,"},{"line_number":1353,"context_line":"                       autospec\u003dTrue)"},{"line_number":1354,"context_line":"    @mock.patch.object(dracclient.resources.raid.RAIDManagement,"},{"line_number":1355,"context_line":"                       \u0027convert_physical_disks\u0027, spec_set\u003dTrue,"},{"line_number":1356,"context_line":"                       autospec\u003dTrue)"},{"line_number":1357,"context_line":"    def test_change_physical_disk_state_jbod("},{"line_number":1358,"context_line":"            self, mock_requests,"},{"line_number":1359,"context_line":"            mock_convert_physical_disks,"},{"line_number":1360,"context_line":"            wait_until_idrac_is_ready,"},{"line_number":1361,"context_line":"            mock_list_physical_disks):"},{"line_number":1362,"context_line":"        mode \u003d constants.RaidStatus.jbod"},{"line_number":1363,"context_line":"        physical_disks \u003d [self.disk_1, self.disk_2, self.disk_3, self.disk_4,"},{"line_number":1364,"context_line":"                          self.disk_5]"},{"line_number":1365,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"},{"line_number":1366,"context_line":"        mock_requests.post("},{"line_number":1367,"context_line":"            \u0027https://1.2.3.4:443/wsman\u0027,"},{"line_number":1368,"context_line":"            text\u003dtest_utils.RAIDEnumerations[uris.DCIM_ControllerView][\u0027ok\u0027])"},{"line_number":1369,"context_line":"        cvt_phys_disks_return_value \u003d {\u0027is_commit_required\u0027: True,"},{"line_number":1370,"context_line":"                                       \u0027is_reboot_required\u0027: constants."},{"line_number":1371,"context_line":"                                       RebootRequired.true}"}],"source_content_type":"text/x-python","patch_set":6,"id":"d708c173_56437831","line":1368,"range":{"start_line":1348,"start_character":4,"end_line":1368,"end_character":77},"updated":"2021-09-15 14:04:19.000000000","message":"no need to mix mocking style with adding patch for list_physical_disks. It\u0027s possible to keep the previous style, and add mocked response for list_raid_controllers - \n\n1) remove @mock.patch.object for list_physical_disks and corresponding input variable\n2) remove all mocking for mock_list_physical_disks\n3) update mock_requests.post to mock responses for both physical disks and raid controllers in order they are called in the tested method - \n\n  mock_requests.post(\n      \u0027https://1.2.3.4:443/wsman\u0027,\n      [{\u0027text\u0027: test_utils.RAIDEnumerations[\n        uris.DCIM_PhysicalDiskView][\u0027ok\u0027]},\n      {\u0027text\u0027: test_utils.RAIDEnumerations[\n        uris.DCIM_ControllerView][\u0027ok\u0027]}])","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"2ff718fa59c25c61eda216a9e338e1df6e13c5ba","unresolved":true,"context_lines":[{"line_number":1398,"context_line":"            self, mock_requests,"},{"line_number":1399,"context_line":"            mock_convert_physical_disks,"},{"line_number":1400,"context_line":"            mock_list_physical_disks,"},{"line_number":1401,"context_line":"            mock_list_raid_controllers):"},{"line_number":1402,"context_line":"        mode \u003d constants.RaidStatus.raid"},{"line_number":1403,"context_line":"        disk_1_non_raid \u003d self.disk_1._replace(raid_status\u003d\u0027non-RAID\u0027)"},{"line_number":1404,"context_line":"        disk_2_non_raid \u003d self.disk_2._replace(raid_status\u003d\u0027non-RAID\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"570cec39_c55b98e7","line":1401,"range":{"start_line":1401,"start_character":12,"end_line":1401,"end_character":38},"updated":"2021-09-16 12:59:27.000000000","message":"clean it up to remove `mock.patch.object` and use `mock_requests.post` as elsewhere in the code, e.g., testcase `test_change_physical_disk_state_none`","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"33aa93672126f9435936d2293d1188eb3bbb4184","unresolved":false,"context_lines":[{"line_number":1398,"context_line":"            self, mock_requests,"},{"line_number":1399,"context_line":"            mock_convert_physical_disks,"},{"line_number":1400,"context_line":"            mock_list_physical_disks,"},{"line_number":1401,"context_line":"            mock_list_raid_controllers):"},{"line_number":1402,"context_line":"        mode \u003d constants.RaidStatus.raid"},{"line_number":1403,"context_line":"        disk_1_non_raid \u003d self.disk_1._replace(raid_status\u003d\u0027non-RAID\u0027)"},{"line_number":1404,"context_line":"        disk_2_non_raid \u003d self.disk_2._replace(raid_status\u003d\u0027non-RAID\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"c3786f5c_79434c18","line":1401,"range":{"start_line":1401,"start_character":12,"end_line":1401,"end_character":38},"in_reply_to":"570cec39_c55b98e7","updated":"2021-09-17 10:35:33.000000000","message":"Done","commit_id":"bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"abc6ed8a82564caea8a4495a9389d4f65de36e71","unresolved":true,"context_lines":[{"line_number":1387,"context_line":"            self, mock_requests,"},{"line_number":1388,"context_line":"            mock_list_physical_disks):"},{"line_number":1389,"context_line":"        mode \u003d constants.RaidStatus.raid"},{"line_number":1390,"context_line":"        physical_disks \u003d [self.disk_1, self.disk_2, self.disk_3, self.disk_4]"},{"line_number":1391,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"},{"line_number":1392,"context_line":"        expected_return_value \u003d {\u0027is_commit_required\u0027: False,"},{"line_number":1393,"context_line":"                                 \u0027is_reboot_required\u0027:"},{"line_number":1394,"context_line":"                                 constants.RebootRequired.false}"}],"source_content_type":"text/x-python","patch_set":7,"id":"52e027bd_449fe1b2","side":"PARENT","line":1391,"range":{"start_line":1390,"start_character":8,"end_line":1391,"end_character":62},"updated":"2021-09-17 08:33:30.000000000","message":"I know there is mix with styles, but I wouldn\u0027t change already existing code. Would keep these lines, and just add mock_request.post for controller + wait until idrac ready patch object.","commit_id":"90daeb3c0a9b952c30c2e529bb6b55121a4d11bd"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"33aa93672126f9435936d2293d1188eb3bbb4184","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"            self, mock_requests,"},{"line_number":1388,"context_line":"            mock_list_physical_disks):"},{"line_number":1389,"context_line":"        mode \u003d constants.RaidStatus.raid"},{"line_number":1390,"context_line":"        physical_disks \u003d [self.disk_1, self.disk_2, self.disk_3, self.disk_4]"},{"line_number":1391,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"},{"line_number":1392,"context_line":"        expected_return_value \u003d {\u0027is_commit_required\u0027: False,"},{"line_number":1393,"context_line":"                                 \u0027is_reboot_required\u0027:"},{"line_number":1394,"context_line":"                                 constants.RebootRequired.false}"}],"source_content_type":"text/x-python","patch_set":7,"id":"bb6f9018_3330dabb","side":"PARENT","line":1391,"range":{"start_line":1390,"start_character":8,"end_line":1391,"end_character":62},"in_reply_to":"52e027bd_449fe1b2","updated":"2021-09-17 10:35:33.000000000","message":"Done","commit_id":"90daeb3c0a9b952c30c2e529bb6b55121a4d11bd"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"6cc5080005560325aa8b115c8c57e9d80e40e9fe","unresolved":true,"context_lines":[{"line_number":1494,"context_line":"            \u0027https://1.2.3.4:443/wsman\u0027,"},{"line_number":1495,"context_line":"            text\u003dtest_utils.RAIDEnumerations[uris.DCIM_ControllerView][\u0027ok\u0027])"},{"line_number":1496,"context_line":"        mode \u003d constants.RaidStatus.jbod"},{"line_number":1497,"context_line":"        physical_disks \u003d [self.disk_1, self.disk_2, self.disk_3, self.disk_4]"},{"line_number":1498,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"},{"line_number":1499,"context_line":"        cvt_phys_disks_return_value \u003d {\u0027is_commit_required\u0027: True,"},{"line_number":1500,"context_line":"                                       \u0027is_reboot_required\u0027: constants."},{"line_number":1501,"context_line":"                                       RebootRequired.true}"}],"source_content_type":"text/x-python","patch_set":8,"id":"c1c7dc47_446a4d0f","side":"PARENT","line":1498,"range":{"start_line":1497,"start_character":7,"end_line":1498,"end_character":62},"updated":"2021-09-17 12:50:43.000000000","message":"let\u0027s revert this change and keep mocking physical disks the way it was - the same I commented earlier.\nWhen reverting this change this test should only have changes to expected result - `h755_return_value` and `expected_return_value`.","commit_id":"90daeb3c0a9b952c30c2e529bb6b55121a4d11bd"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"f998c18173b0f0599e6b397d385cdecc56bf2bdc","unresolved":false,"context_lines":[{"line_number":1494,"context_line":"            \u0027https://1.2.3.4:443/wsman\u0027,"},{"line_number":1495,"context_line":"            text\u003dtest_utils.RAIDEnumerations[uris.DCIM_ControllerView][\u0027ok\u0027])"},{"line_number":1496,"context_line":"        mode \u003d constants.RaidStatus.jbod"},{"line_number":1497,"context_line":"        physical_disks \u003d [self.disk_1, self.disk_2, self.disk_3, self.disk_4]"},{"line_number":1498,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"},{"line_number":1499,"context_line":"        cvt_phys_disks_return_value \u003d {\u0027is_commit_required\u0027: True,"},{"line_number":1500,"context_line":"                                       \u0027is_reboot_required\u0027: constants."},{"line_number":1501,"context_line":"                                       RebootRequired.true}"}],"source_content_type":"text/x-python","patch_set":8,"id":"4ea953c3_4d42b968","side":"PARENT","line":1498,"range":{"start_line":1497,"start_character":7,"end_line":1498,"end_character":62},"in_reply_to":"c1c7dc47_446a4d0f","updated":"2021-09-20 07:40:14.000000000","message":"Done","commit_id":"90daeb3c0a9b952c30c2e529bb6b55121a4d11bd"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"828b05d072d453ed2d66a43513d59cf477d335f2","unresolved":true,"context_lines":[{"line_number":1449,"context_line":"        self.assertEqual(results[\u0027conversion_results\u0027][\u0027RAID.Integrated.1-1\u0027],"},{"line_number":1450,"context_line":"                         expected_return_value)"},{"line_number":1451,"context_line":"        self.assertEqual(results[\u0027conversion_results\u0027][\u0027AHCI.Integrated.1-1\u0027],"},{"line_number":1452,"context_line":"                         expected_return_value)"},{"line_number":1453,"context_line":""},{"line_number":1454,"context_line":"    @mock.patch.object(dracclient.client.WSManClient,"},{"line_number":1455,"context_line":"                       \u0027wait_until_idrac_is_ready\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"b998eb1c_114a840b","line":1452,"updated":"2021-09-17 12:50:57.000000000","message":"We should assert the result for the H755, just like lines 1424-1425 above.","commit_id":"e6f1dbdcc7a2852fd4cf442f234b159743c1be91"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"f998c18173b0f0599e6b397d385cdecc56bf2bdc","unresolved":false,"context_lines":[{"line_number":1449,"context_line":"        self.assertEqual(results[\u0027conversion_results\u0027][\u0027RAID.Integrated.1-1\u0027],"},{"line_number":1450,"context_line":"                         expected_return_value)"},{"line_number":1451,"context_line":"        self.assertEqual(results[\u0027conversion_results\u0027][\u0027AHCI.Integrated.1-1\u0027],"},{"line_number":1452,"context_line":"                         expected_return_value)"},{"line_number":1453,"context_line":""},{"line_number":1454,"context_line":"    @mock.patch.object(dracclient.client.WSManClient,"},{"line_number":1455,"context_line":"                       \u0027wait_until_idrac_is_ready\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7dc72753_d3ab0a4f","line":1452,"in_reply_to":"b998eb1c_114a840b","updated":"2021-09-20 07:40:14.000000000","message":"Done","commit_id":"e6f1dbdcc7a2852fd4cf442f234b159743c1be91"},{"author":{"_account_id":23847,"name":"Richard G. Pioso","email":"richard.pioso@gmail.com","username":"richard.pioso"},"change_message_id":"828b05d072d453ed2d66a43513d59cf477d335f2","unresolved":true,"context_lines":[{"line_number":1484,"context_line":"        self.assertEqual(results[\u0027conversion_results\u0027][\u0027RAID.Integrated.1-1\u0027],"},{"line_number":1485,"context_line":"                         expected_return_value)"},{"line_number":1486,"context_line":"        self.assertEqual(results[\u0027conversion_results\u0027][\u0027AHCI.Integrated.1-1\u0027],"},{"line_number":1487,"context_line":"                         expected_return_value)"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":"    @mock.patch.object(dracclient.client.WSManClient,"},{"line_number":1490,"context_line":"                       \u0027wait_until_idrac_is_ready\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"e1f301a9_7d0adb89","line":1487,"updated":"2021-09-17 12:50:57.000000000","message":"Ditto.","commit_id":"e6f1dbdcc7a2852fd4cf442f234b159743c1be91"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"f998c18173b0f0599e6b397d385cdecc56bf2bdc","unresolved":false,"context_lines":[{"line_number":1484,"context_line":"        self.assertEqual(results[\u0027conversion_results\u0027][\u0027RAID.Integrated.1-1\u0027],"},{"line_number":1485,"context_line":"                         expected_return_value)"},{"line_number":1486,"context_line":"        self.assertEqual(results[\u0027conversion_results\u0027][\u0027AHCI.Integrated.1-1\u0027],"},{"line_number":1487,"context_line":"                         expected_return_value)"},{"line_number":1488,"context_line":""},{"line_number":1489,"context_line":"    @mock.patch.object(dracclient.client.WSManClient,"},{"line_number":1490,"context_line":"                       \u0027wait_until_idrac_is_ready\u0027, spec_set\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"a1443831_71345990","line":1487,"in_reply_to":"e1f301a9_7d0adb89","updated":"2021-09-20 07:40:14.000000000","message":"Done","commit_id":"e6f1dbdcc7a2852fd4cf442f234b159743c1be91"},{"author":{"_account_id":27909,"name":"Aija Jauntēva","email":"code@clusums.eu","username":"ajya"},"change_message_id":"33edafa47cb20c852596087254ca15f9a56c4fdd","unresolved":true,"context_lines":[{"line_number":1567,"context_line":"            mock_convert_physical_disks,"},{"line_number":1568,"context_line":"            mock_list_physical_disks,"},{"line_number":1569,"context_line":"            mock_wait_until_idrac_is_ready):"},{"line_number":1570,"context_line":"        mode \u003d constants.RaidStatus.jbod"},{"line_number":1571,"context_line":"        physical_disks \u003d [self.disk_1, self.disk_2, self.disk_3, self.disk_4,"},{"line_number":1572,"context_line":"                          self.disk_5]"},{"line_number":1573,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"},{"line_number":1574,"context_line":"        mock_requests.post("},{"line_number":1575,"context_line":"            \u0027https://1.2.3.4:443/wsman\u0027,"},{"line_number":1576,"context_line":"            text\u003dtest_utils.RAIDEnumerations[uris.DCIM_ControllerView][\u0027ok\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"355a1068_b710e738","line":1573,"range":{"start_line":1570,"start_character":7,"end_line":1573,"end_character":62},"updated":"2021-09-20 08:03:54.000000000","message":"nit: move this back to where it was before - (on line 1496-1498 in base patchset). Now it shows up as change, although it is only moved from one place to another and disk_5 is added.","commit_id":"379a75e55af04f2d04510f13bd1c1fb54dc6d44b"},{"author":{"_account_id":29863,"name":"Monica Pardhi","email":"mpardhi1991@gmail.com","username":"mpardhi"},"change_message_id":"4fae2b23136ce0fff6613c585532cc465706a83e","unresolved":false,"context_lines":[{"line_number":1567,"context_line":"            mock_convert_physical_disks,"},{"line_number":1568,"context_line":"            mock_list_physical_disks,"},{"line_number":1569,"context_line":"            mock_wait_until_idrac_is_ready):"},{"line_number":1570,"context_line":"        mode \u003d constants.RaidStatus.jbod"},{"line_number":1571,"context_line":"        physical_disks \u003d [self.disk_1, self.disk_2, self.disk_3, self.disk_4,"},{"line_number":1572,"context_line":"                          self.disk_5]"},{"line_number":1573,"context_line":"        mock_list_physical_disks.return_value \u003d physical_disks"},{"line_number":1574,"context_line":"        mock_requests.post("},{"line_number":1575,"context_line":"            \u0027https://1.2.3.4:443/wsman\u0027,"},{"line_number":1576,"context_line":"            text\u003dtest_utils.RAIDEnumerations[uris.DCIM_ControllerView][\u0027ok\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"d903c196_99d47eea","line":1573,"range":{"start_line":1570,"start_character":7,"end_line":1573,"end_character":62},"in_reply_to":"355a1068_b710e738","updated":"2021-09-20 11:47:40.000000000","message":"Done","commit_id":"379a75e55af04f2d04510f13bd1c1fb54dc6d44b"}]}