)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14084,"name":"Einst Crazy","email":"yu.changcai@99cloud.net","username":"Einst"},"change_message_id":"cc65a3de849604a1c47d33f885c82109b80eeb5f","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Filter jobs by client or custom filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Resolves bug: 1562015"},{"line_number":10,"context_line":"Change-Id: Ib887226c53d747ae36bef0dea7ade6a7a5e37531"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_291e7963","line":9,"updated":"2016-03-29 09:59:16.000000000","message":"Closes-Bug is better, as https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"3d261d1354eb542601d10223c1843f3d723c7bcc"},{"author":{"_account_id":14340,"name":"Memo Garcia","email":"guillermo.ramirez-garcia@hp.com","username":"memogarcia"},"change_message_id":"603834f1d2fdb22b1f721923be771dc996587c35","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Filter jobs by client or custom filters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Resolves bug: 1562015"},{"line_number":10,"context_line":"Change-Id: Ib887226c53d747ae36bef0dea7ade6a7a5e37531"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ba0121b8_297839f2","line":9,"in_reply_to":"ba0121b8_291e7963","updated":"2016-03-29 10:06:01.000000000","message":"Done","commit_id":"3d261d1354eb542601d10223c1843f3d723c7bcc"}],"freezerclient/v1/backups.py":[{"author":{"_account_id":14028,"name":"Jonas Pfannschmidt","email":"jonas.pfannschmidt@hp.com","username":"jonaspf"},"change_message_id":"a36f2ee268f6550b52a504d652e0c7216b0ba082","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                ((b.get(\u0027backup_uuid\u0027),"},{"line_number":102,"context_line":"                  b.get(\u0027backup_metadata\u0027, {}).get(\u0027hostname\u0027),"},{"line_number":103,"context_line":"                  b.get(\u0027backup_metadata\u0027, {}).get(\u0027path_to_backup\u0027),"},{"line_number":104,"context_line":"                  datetime.datetime.fromtimestamp("},{"line_number":105,"context_line":"                      int(b.get(\u0027backup_metadata\u0027,{}).get(\u0027time_stamp\u0027))),"},{"line_number":106,"context_line":"                  b.get(\u0027backup_metadata\u0027, {}).get(\u0027curr_backup_level\u0027)"},{"line_number":107,"context_line":"                  ) for b in backups))"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_7477d0d4","line":105,"range":{"start_line":104,"start_character":18,"end_line":105,"end_character":71},"updated":"2016-05-06 10:30:25.000000000","message":"I think defaulting to an empty dict here is unnecessary. \u0027backup_metadata\u0027 should always be present. If not this will fail anyway when it tries to cast None to int.\n\nI would use b[\u0027backup_metadata\u0027] instead of b.get(\u0027backup_metadata\u0027, {}). Fail fast!","commit_id":"e68069dac312e3f95195194f188154b8e96e6612"},{"author":{"_account_id":14028,"name":"Jonas Pfannschmidt","email":"jonas.pfannschmidt@hp.com","username":"jonaspf"},"change_message_id":"a36f2ee268f6550b52a504d652e0c7216b0ba082","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                  datetime.datetime.fromtimestamp("},{"line_number":105,"context_line":"                      int(b.get(\u0027backup_metadata\u0027,{}).get(\u0027time_stamp\u0027))),"},{"line_number":106,"context_line":"                  b.get(\u0027backup_metadata\u0027, {}).get(\u0027curr_backup_level\u0027)"},{"line_number":107,"context_line":"                  ) for b in backups))"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dab17558_f430e009","line":107,"range":{"start_line":107,"start_character":18,"end_line":107,"end_character":38},"updated":"2016-05-06 10:30:25.000000000","message":"Maybe it\u0027s just the indentation but I find it hard to read this 6 line list comprehension.","commit_id":"e68069dac312e3f95195194f188154b8e96e6612"}]}