)]}'
{"id":"openstack%2Fpython-freezerclient~396721","triplet_id":"openstack%2Fpython-freezerclient~master~I076afbcda21b1f1ca7a85d733f7fc7204487b25e","project":"openstack/python-freezerclient","branch":"master","topic":"bug/1641184","hashtags":[],"change_id":"I076afbcda21b1f1ca7a85d733f7fc7204487b25e","subject":"Fix freezer client-* output","status":"MERGED","created":"2016-11-11 18:07:52.000000000","updated":"2016-11-14 12:27:16.000000000","submitted":"2016-11-14 12:27:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"14ab40af86cd0a88dca6ff101151e59b719d2bcb","_number":396721,"virtual_id_number":396721,"owner":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-11-14 12:27:16.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},{"value":0,"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},{"value":0,"_account_id":22405,"name":"Vitaliy Nogin","email":"shadoff1982@gmail.com","username":"vnogin"},{"value":0,"_account_id":14509,"name":"Pierre Mathieu","email":"pierre-arthur.mathieu@hpe.com","username":"slashme"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":14509,"name":"Pierre Mathieu","email":"pierre-arthur.mathieu@hpe.com","username":"slashme"},"recommended":{"_account_id":22405,"name":"Vitaliy Nogin","email":"shadoff1982@gmail.com","username":"vnogin"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},{"value":0,"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},{"value":1,"date":"2016-11-13 10:13:29.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":22405,"name":"Vitaliy Nogin","email":"shadoff1982@gmail.com","username":"vnogin"},{"value":2,"date":"2016-11-14 10:47:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":14509,"name":"Pierre Mathieu","email":"pierre-arthur.mathieu@hpe.com","username":"slashme"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-11-14 12:23:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},{"value":0,"date":"2016-11-11 18:13:15.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},{"value":0,"_account_id":22405,"name":"Vitaliy Nogin","email":"shadoff1982@gmail.com","username":"vnogin"},{"value":0,"_account_id":14509,"name":"Pierre Mathieu","email":"pierre-arthur.mathieu@hpe.com","username":"slashme"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},{"_account_id":14509,"name":"Pierre Mathieu","email":"pierre-arthur.mathieu@hpe.com","username":"slashme"},{"_account_id":22405,"name":"Vitaliy Nogin","email":"shadoff1982@gmail.com","username":"vnogin"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-11 18:13:15.000000000","updated_by":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"reviewer":{"_account_id":14101,"name":"yapeng Yang","email":"a394954369@gmail.com","username":"yapeng"},"state":"REVIEWER"},{"updated":"2016-11-13 10:13:29.000000000","updated_by":{"_account_id":22405,"name":"Vitaliy Nogin","email":"shadoff1982@gmail.com","username":"vnogin"},"reviewer":{"_account_id":22405,"name":"Vitaliy Nogin","email":"shadoff1982@gmail.com","username":"vnogin"},"state":"REVIEWER"},{"updated":"2016-11-14 10:47:55.000000000","updated_by":{"_account_id":14509,"name":"Pierre Mathieu","email":"pierre-arthur.mathieu@hpe.com","username":"slashme"},"reviewer":{"_account_id":14509,"name":"Pierre Mathieu","email":"pierre-arthur.mathieu@hpe.com","username":"slashme"},"state":"REVIEWER"},{"updated":"2016-11-14 12:23:10.000000000","updated_by":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"reviewer":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"state":"REVIEWER"},{"updated":"2016-11-14 12:27:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"582f006e9ca7bd214829b6eb70ba25bed5befe6f","author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"date":"2016-11-11 18:07:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"ce30bcd93ff7cbc064a769003dc2cfa1205014da","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-11 18:12:39.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-freezerclient-docs-ubuntu-xenial http://docs-draft.openstack.org/21/396721/1/check/gate-python-freezerclient-docs-ubuntu-xenial/5ce2037//doc/build/html/ : SUCCESS in 1m 42s\n- gate-python-freezerclient-pep8-ubuntu-xenial http://logs.openstack.org/21/396721/1/check/gate-python-freezerclient-pep8-ubuntu-xenial/bd05d16/ : SUCCESS in 3m 43s\n- gate-python-freezerclient-python27-ubuntu-xenial http://logs.openstack.org/21/396721/1/check/gate-python-freezerclient-python27-ubuntu-xenial/3b5369e/ : SUCCESS in 1m 50s\n- gate-python-freezerclient-python34 http://logs.openstack.org/21/396721/1/check/gate-python-freezerclient-python34/ff5be87/ : SUCCESS in 1m 51s\n- gate-python-freezerclient-python35 http://logs.openstack.org/21/396721/1/check/gate-python-freezerclient-python35/7ed4897/ : SUCCESS in 2m 32s\n- gate-python-freezerclient-pylint http://logs.openstack.org/21/396721/1/check/gate-python-freezerclient-pylint/3efea36/ : SUCCESS in 1m 48s","accounts_in_message":[],"_revision_number":1},{"id":"d43e3c3a63645c4606165d29622bc3460d1912fa","author":{"_account_id":22405,"name":"Vitaliy Nogin","email":"shadoff1982@gmail.com","username":"vnogin"},"date":"2016-11-13 10:13:29.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"12f7721c68ddd4a4760fdb38f532ec26c12846f6","author":{"_account_id":14509,"name":"Pierre Mathieu","email":"pierre-arthur.mathieu@hpe.com","username":"slashme"},"date":"2016-11-14 10:47:55.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"1c4536e32555bb43165a1aaebf4c8f9b97a99a34","author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"date":"2016-11-14 11:57:51.000000000","message":"Patch Set 1:\n\nRuslan Aliev, In spite of the issue can be fixed with this solution, \nI think it\u0027s better to return error 404 in the\n\"DELETE /v1/clients/{freezerc_id}\" API implementation of the\nfreezer-api. Then the exception can be raised in the\npython-freezer.freezerclient.v1.managers.clients.delete when\nstatus_code !\u003d 204.\n\nI have checked the other openstack project(nova、glance and so on).\nThe similar solution is being used.","accounts_in_message":[],"_revision_number":1},{"id":"1e1163a2a3302fdfecc7a6a6c07da221d4a45b68","author":{"_account_id":13940,"name":"Saad Zaher","email":"eng.szaher@gmail.com","username":"szaher"},"date":"2016-11-14 12:23:10.000000000","message":"Patch Set 1: Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"b10ea13b9961ce39034b05910e29ed65401f21dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-14 12:23:20.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"c2c850591d166856cd2b8f81ac5f5edcba22c67e","date":"2016-11-14 12:27:16.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"b10630bd8ee4d8dca6919cf526078c1f1e030159","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-14 12:27:16.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-freezerclient-docs-ubuntu-xenial http://docs-draft.openstack.org/21/396721/1/gate/gate-python-freezerclient-docs-ubuntu-xenial/b189397//doc/build/html/ : SUCCESS in 2m 13s\n- gate-python-freezerclient-pep8-ubuntu-xenial http://logs.openstack.org/21/396721/1/gate/gate-python-freezerclient-pep8-ubuntu-xenial/402db53/ : SUCCESS in 2m 52s\n- gate-python-freezerclient-python27-ubuntu-xenial http://logs.openstack.org/21/396721/1/gate/gate-python-freezerclient-python27-ubuntu-xenial/0f576bd/ : SUCCESS in 2m 44s\n- gate-python-freezerclient-python34 http://logs.openstack.org/21/396721/1/gate/gate-python-freezerclient-python34/a2e5887/ : SUCCESS in 2m 26s\n- gate-python-freezerclient-python35 http://logs.openstack.org/21/396721/1/gate/gate-python-freezerclient-python35/650000a/ : SUCCESS in 2m 23s\n- gate-python-freezerclient-pylint http://logs.openstack.org/21/396721/1/gate/gate-python-freezerclient-pylint/b958396/ : SUCCESS in 1m 45s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"e6a88639563b4d90bdbdf48b6c7560c371ce6071","revisions":{"e6a88639563b4d90bdbdf48b6c7560c371ce6071":{"kind":"REWORK","_number":1,"created":"2016-11-11 18:07:52.000000000","uploader":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"ref":"refs/changes/21/396721/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-freezerclient","ref":"refs/changes/21/396721/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/21/396721/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/21/396721/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/21/396721/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-freezerclient refs/changes/21/396721/1"}}},"commit":{"parents":[{"commit":"c96526ff5de5893ee924636448772e0ff2324619","subject":"Fix freezer CLI output","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/c96526ff5de5893ee924636448772e0ff2324619"}]}],"author":{"name":"Ruslan Aliev","email":"raliev@mirantis.com","date":"2016-11-11 18:02:10.000000000","tz":180},"committer":{"name":"Ruslan Aliev","email":"raliev@mirantis.com","date":"2016-11-11 18:02:10.000000000","tz":180},"subject":"Fix freezer client-* output","message":"Fix freezer client-* output\n\nWhat\u0027s new:\n* Print empty table if no clients found\n* Check that client exists before delete,\n  print message if no clients with ID was found\n* Import objects replaced by modules\n* Some code refactored\n\nChange-Id: I076afbcda21b1f1ca7a85d733f7fc7204487b25e\nCloses-Bug: #1641184\nSigned-off-by: Ruslan Aliev \u003craliev@mirantis.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/e6a88639563b4d90bdbdf48b6c7560c371ce6071"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/e6a88639563b4d90bdbdf48b6c7560c371ce6071"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}