)]}'
{"id":"openstack%2Fpython-freezerclient~398151","triplet_id":"openstack%2Fpython-freezerclient~master~I080fc4a5baac46b08d4cf10e5c08af7fb69b81db","project":"openstack/python-freezerclient","branch":"master","topic":"bug/1642151","hashtags":[],"change_id":"I080fc4a5baac46b08d4cf10e5c08af7fb69b81db","subject":"Add backup-delete command","status":"ABANDONED","created":"2016-11-16 07:24:57.000000000","updated":"2016-12-02 01:17:30.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"166675e30149876a1b566657fb4542f905c2a76b","_number":398151,"virtual_id_number":398151,"owner":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},{"value":1,"date":"2016-12-01 15:11:28.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-11-28 12:36:43.000000000","updated_by":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"reviewer":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"state":"REVIEWER"},{"updated":"2016-12-01 15:11:28.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"239e8c78cbdd4ca1e7f039708a6555eb6f6e0b31","author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"date":"2016-11-16 07:24:57.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"fa179655bd2df61355dcbeb35d34501d9f82f76a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-16 07:28:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-freezerclient-docs-ubuntu-xenial http://docs-draft.openstack.org/51/398151/1/check/gate-python-freezerclient-docs-ubuntu-xenial/cd98611//doc/build/html/ : SUCCESS in 1m 46s\n- gate-python-freezerclient-pep8-ubuntu-xenial http://logs.openstack.org/51/398151/1/check/gate-python-freezerclient-pep8-ubuntu-xenial/a095ff5/ : SUCCESS in 1m 46s\n- gate-python-freezerclient-python27-ubuntu-xenial http://logs.openstack.org/51/398151/1/check/gate-python-freezerclient-python27-ubuntu-xenial/c8bf2ae/ : SUCCESS in 2m 50s\n- gate-python-freezerclient-python34 http://logs.openstack.org/51/398151/1/check/gate-python-freezerclient-python34/eb1abd1/ : SUCCESS in 1m 47s\n- gate-python-freezerclient-python35 http://logs.openstack.org/51/398151/1/check/gate-python-freezerclient-python35/19fd3d5/ : SUCCESS in 2m 51s\n- gate-python-freezerclient-pylint http://logs.openstack.org/51/398151/1/check/gate-python-freezerclient-pylint/0811f21/ : SUCCESS in 1m 40s","accounts_in_message":[],"_revision_number":1},{"id":"42f23ba6c08f765fe72485d5b326a187612b317f","author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"date":"2016-11-17 17:39:25.000000000","message":"Patch Set 1: Code-Review-1\n\nAre you sure that backup-create and backup-delete CLI actions is needed? I\u0027m not sure. May be backup-delete is needed, but I don\u0027t have the same opinion about backup-create. So,\n1. freezer-scheduler doesn\u0027t provide this CLI actions.\n2. This actions are only update the DB. So if you create backup using backup-create - you create fake backup, there is no guarantee that you can restore this backup. What I want to say - backup objects created automatically when backup job is started [1][2]. I think that there is no need to provide this CLI action. Regarding backup-delete, well, may be it useful, but API will delete only DB entry, backup files will remain.\n3. freezer backup-delete is not works correctly, it always prints \u0027Backup not found\u0027. Here is the log [3]. It seems that you should use the same approach like in Backup-Show [4] for finding backup object.\n\n\n[1] https://github.com/openstack/freezer/blob/master/freezer/scheduler/freezer_scheduler.py#L115\n[2] https://github.com/openstack/freezer/blob/master/freezer/scheduler/scheduler_job.py#L366\n[3] http://paste.openstack.org/show/589627/\n[4] https://github.com/openstack/python-freezerclient/blob/master/freezerclient/v1/backups.py#L45-46","accounts_in_message":[],"_revision_number":1},{"id":"5360dd0384e73fd549f51faddf02c7b44e9e6535","author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"date":"2016-11-18 02:58:28.000000000","message":"Patch Set 1:\n\nRuslan Aliev, thank you for this review. I\u0027ll check your opinion later.","accounts_in_message":[],"_revision_number":1},{"id":"6b9694c3f46ff553de74ac635e775c207db9d8d0","author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"date":"2016-11-22 10:24:31.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"f2d9f15729bdba6d7d97d3476458f017256edbdb","author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"date":"2016-11-22 10:31:35.000000000","message":"Patch Set 2:\n\nRuslan Aliev, Yes, the backup-create should not be added.\nThe delete implementation has been updated.\nBut the backup record hasn\u0027t been deleted from DB when I try to test it. Maybe there is some issue on the freezer-API.","accounts_in_message":[],"_revision_number":2},{"id":"6afacdb4263c32cc9bd5268dca62fb510f88e322","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-11-22 10:35:43.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-freezerclient-docs-ubuntu-xenial http://docs-draft.openstack.org/51/398151/2/check/gate-python-freezerclient-docs-ubuntu-xenial/fe51a99//doc/build/html/ : SUCCESS in 2m 38s\n- gate-python-freezerclient-pep8-ubuntu-xenial http://logs.openstack.org/51/398151/2/check/gate-python-freezerclient-pep8-ubuntu-xenial/f84d2d4/ : SUCCESS in 1m 54s\n- gate-python-freezerclient-python27-ubuntu-xenial http://logs.openstack.org/51/398151/2/check/gate-python-freezerclient-python27-ubuntu-xenial/e15decf/ : SUCCESS in 1m 56s\n- gate-python-freezerclient-python34 http://logs.openstack.org/51/398151/2/check/gate-python-freezerclient-python34/5fe505e/ : SUCCESS in 1m 55s\n- gate-python-freezerclient-python35 http://logs.openstack.org/51/398151/2/check/gate-python-freezerclient-python35/ff55216/ : SUCCESS in 1m 58s\n- gate-python-freezerclient-pylint http://logs.openstack.org/51/398151/2/check/gate-python-freezerclient-pylint/fc8d220/ : SUCCESS in 1m 50s","accounts_in_message":[],"_revision_number":2},{"id":"19fdb9f294ad61be94d62e66e5370ac54f7707a2","author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"date":"2016-11-22 10:41:14.000000000","message":"Patch Set 2: Workflow-1","accounts_in_message":[],"_revision_number":2},{"id":"b14d092f0fa563f66c738985a56cec2fb51a0bf6","author":{"_account_id":16768,"name":"Ruslan Aliev","email":"raliev@mirantis.com","username":"raliev"},"date":"2016-11-28 12:36:43.000000000","message":"Patch Set 2:\n\n\u003e Ruslan Aliev, Yes, the backup-create should not be added.\n \u003e The delete implementation has been updated.\n \u003e But the backup record hasn\u0027t been deleted from DB when I try to\n \u003e test it. Maybe there is some issue on the freezer-API.\n\nShangzhong Zhu, I\u0027ve investigated this problem. There is not your fault, the root cause of this problem - backup_id may contain unsupported HTTP characters, for example if we send request \n\u0027DELETE /v1/backups//opt/stack/backup/_blabla_123456_0\u0027 it will not processed. We need to switch to UUID as backup_id and this problem will be solved.\n\nLinks on this problem:\nhttps://github.com/openstack/python-freezerclient/blob/master/freezerclient/v1/backups.py#L38-L43\nhttps://bugs.launchpad.net/freezer/+bug/1618030\n\nI\u0027ve proposed appropriate patchset here - https://review.openstack.org/#/c/403442/, if it\u0027ll be merged then your patch will work well.","accounts_in_message":[],"_revision_number":2},{"id":"c2459bf3b0c1a6a1fc7c2a6671ea857e4ddc3ed5","author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"date":"2016-11-29 01:35:39.000000000","message":"Patch Set 2:\n\nRuslan Aliev, thanks for your help. I\u0027m reviewing your patch.","accounts_in_message":[],"_revision_number":2},{"id":"9613374286ad7012b517c3f94cf748fca6a7aa0d","author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"date":"2016-12-01 15:06:35.000000000","message":"Patch Set 2: -Workflow","accounts_in_message":[],"_revision_number":2},{"id":"dd8ebb358969772884c3a8ba684f3bddbf0cd059","author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"date":"2016-12-01 15:06:46.000000000","message":"Patch Set 3: Patch Set 2 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"feff94e3311b154fe2d37f5cfc67fc3698ba325f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-12-01 15:11:28.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-freezerclient-docs-ubuntu-xenial http://docs-draft.openstack.org/51/398151/3/check/gate-python-freezerclient-docs-ubuntu-xenial/46bd376//doc/build/html/ : SUCCESS in 2m 48s\n- gate-python-freezerclient-pep8-ubuntu-xenial http://logs.openstack.org/51/398151/3/check/gate-python-freezerclient-pep8-ubuntu-xenial/fd37be6/ : SUCCESS in 4m 20s\n- gate-python-freezerclient-python27-ubuntu-xenial http://logs.openstack.org/51/398151/3/check/gate-python-freezerclient-python27-ubuntu-xenial/e4e8193/ : SUCCESS in 2m 15s\n- gate-python-freezerclient-python34 http://logs.openstack.org/51/398151/3/check/gate-python-freezerclient-python34/f408982/ : SUCCESS in 2m 40s\n- gate-python-freezerclient-python35 http://logs.openstack.org/51/398151/3/check/gate-python-freezerclient-python35/39577c5/ : SUCCESS in 3m 08s\n- gate-python-freezerclient-pylint http://logs.openstack.org/51/398151/3/check/gate-python-freezerclient-pylint/b584508/ : SUCCESS in 3m 02s","accounts_in_message":[],"_revision_number":3},{"id":"401532bdb7903d884a2643030b2f91c8f587b271","author":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"date":"2016-12-02 01:17:30.000000000","message":"Abandoned\n\nUse Ruslan Aliev\u0027s patch:\nhttps://review.openstack.org/#/c/405579/","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"e4b0c800431875911bfef68a52dc1956ec88c6f0","revisions":{"5e66911ea12d376eb116ea13a3e5b144ca36a58e":{"kind":"REWORK","_number":1,"created":"2016-11-16 07:24:57.000000000","uploader":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"ref":"refs/changes/51/398151/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-freezerclient","ref":"refs/changes/51/398151/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/1"}}},"commit":{"parents":[{"commit":"d71101139b3a2f76b127eae917d2e8c7b958c5ad","subject":"Import objects replaced by modules","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/d71101139b3a2f76b127eae917d2e8c7b958c5ad"}]}],"author":{"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","date":"2016-11-16 07:15:36.000000000","tz":480},"committer":{"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","date":"2016-11-16 07:15:36.000000000","tz":480},"subject":"Add backup-create and backup-delete command","message":"Add backup-create and backup-delete command\n\nChange-Id: I080fc4a5baac46b08d4cf10e5c08af7fb69b81db\nCloses-Bug: #1642151\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/5e66911ea12d376eb116ea13a3e5b144ca36a58e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/5e66911ea12d376eb116ea13a3e5b144ca36a58e"}]},"branch":"refs/heads/master"},"483ac4be2e325735406656b1b528db476d559a64":{"kind":"REWORK","_number":2,"created":"2016-11-22 10:24:31.000000000","uploader":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"ref":"refs/changes/51/398151/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-freezerclient","ref":"refs/changes/51/398151/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/2"}}},"commit":{"parents":[{"commit":"d71101139b3a2f76b127eae917d2e8c7b958c5ad","subject":"Import objects replaced by modules","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/d71101139b3a2f76b127eae917d2e8c7b958c5ad"}]}],"author":{"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","date":"2016-11-16 07:15:36.000000000","tz":480},"committer":{"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","date":"2016-11-22 10:21:10.000000000","tz":480},"subject":"Add backup-delete command","message":"Add backup-delete command\n\nChange-Id: I080fc4a5baac46b08d4cf10e5c08af7fb69b81db\nCloses-Bug: #1642151\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/483ac4be2e325735406656b1b528db476d559a64"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/483ac4be2e325735406656b1b528db476d559a64"}]},"branch":"refs/heads/master"},"e4b0c800431875911bfef68a52dc1956ec88c6f0":{"kind":"TRIVIAL_REBASE","_number":3,"created":"2016-12-01 15:06:46.000000000","uploader":{"_account_id":21644,"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","username":"shangzhong.zhu"},"ref":"refs/changes/51/398151/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-freezerclient","ref":"refs/changes/51/398151/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-freezerclient refs/changes/51/398151/3"}}},"commit":{"parents":[{"commit":"2500e1e57240ca87c8b2c93e4c5454b67f83d6e5","subject":"Merge \"Fixed \"End Date\" and \"Interval\" error\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/2500e1e57240ca87c8b2c93e4c5454b67f83d6e5"}]}],"author":{"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","date":"2016-11-16 07:15:36.000000000","tz":480},"committer":{"name":"Shangzhong Zhu","email":"zhu.shangzhong@zte.com.cn","date":"2016-12-01 15:06:46.000000000","tz":0},"subject":"Add backup-delete command","message":"Add backup-delete command\n\nChange-Id: I080fc4a5baac46b08d4cf10e5c08af7fb69b81db\nCloses-Bug: #1642151\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/e4b0c800431875911bfef68a52dc1956ec88c6f0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/e4b0c800431875911bfef68a52dc1956ec88c6f0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}