)]}'
{"id":"openstack%2Fpython-freezerclient~604284","triplet_id":"openstack%2Fpython-freezerclient~master~Ic43d7c194387a4063b38a11e1a1c850aaaf713c0","project":"openstack/python-freezerclient","branch":"master","topic":"bug/gengchc","hashtags":[],"change_id":"Ic43d7c194387a4063b38a11e1a1c850aaaf713c0","subject":"Use keystoneauth1.loading instead of specifying V2 or V3 of keystone","status":"MERGED","created":"2018-09-21 07:26:48.000000000","updated":"2018-09-29 01:43:55.000000000","submitted":"2018-09-29 01:43:55.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"604284-1538185435716-c1dafa6e","meta_rev_id":"a245fd495c7f6e69aebae6fb1470375506425ccd","_number":604284,"virtual_id_number":604284,"owner":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"value":0,"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"value":2,"date":"2018-09-29 01:43:55.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"recommended":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"all":[{"value":0,"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"value":1,"date":"2018-09-28 03:22:36.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":2,"date":"2018-09-29 00:38:22.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"all":[{"value":1,"date":"2018-09-29 01:32:53.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"value":0,"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"value":0,"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-09-28 03:22:36.000000000","updated_by":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"reviewer":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"state":"REVIEWER"},{"updated":"2018-09-29 00:38:22.000000000","updated_by":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"reviewer":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"state":"REVIEWER"},{"updated":"2018-09-29 01:43:55.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"74e37ab9ce8f46aa25ba64cbeda21c7e9276cfc7","author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"date":"2018-09-21 07:26:48.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"540dda6adc9a766f70dc956ff4f734a41404b9d1","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-21 07:46:01.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/84/604284/1/check/openstack-tox-pep8/fb9ae91/ : SUCCESS in 3m 35s\n- openstack-tox-py27 http://logs.openstack.org/84/604284/1/check/openstack-tox-py27/432e938/ : SUCCESS in 4m 01s\n- openstack-tox-py35 http://logs.openstack.org/84/604284/1/check/openstack-tox-py35/95166bf/ : SUCCESS in 4m 01s\n- build-openstack-sphinx-docs http://logs.openstack.org/84/604284/1/check/build-openstack-sphinx-docs/24cbe45/html/ : SUCCESS in 3m 19s\n- openstack-tox-pylint http://logs.openstack.org/84/604284/1/check/openstack-tox-pylint/1c6c744/ : SUCCESS in 3m 29s\n- openstack-tox-py36 http://logs.openstack.org/84/604284/1/check/openstack-tox-py36/f99b13b/ : SUCCESS in 3m 43s\n- openstack-tox-docs http://logs.openstack.org/84/604284/1/check/openstack-tox-docs/1f8739c/html/ : SUCCESS in 2m 48s\n- openstack-tox-lower-constraints http://logs.openstack.org/84/604284/1/check/openstack-tox-lower-constraints/73769da/ : SUCCESS in 4m 25s","accounts_in_message":[],"_revision_number":1},{"id":"79a5412d6fae1074c0f511656bed5c8ef60a80cc","author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"date":"2018-09-21 08:30:07.000000000","message":"Patch Set 1: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":1},{"id":"7efffac5d3f8dda233ff2da4d43fc6f38a41ab8d","author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"date":"2018-09-21 08:33:10.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)\n\nHi Geng. Thanks for the patch. Shouldn\u0027t we update client v1 [1] [2] also? Also, it\u0027s better to have a unit test for client v2. Currently, we don\u0027t have tests for client v2.\n\n[1] https://github.com/openstack/python-freezerclient/blob/master/freezerclient/v1/client.py\n\n[2] https://github.com/openstack/python-freezerclient/blob/master/freezerclient/tests/unit/v1/test_client.py#L58","accounts_in_message":[],"_revision_number":1},{"id":"8b250a9bc62e555b265c2c1b000f4fa480c452c4","author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"date":"2018-09-21 08:54:43.000000000","message":"Patch Set 1:\n\n\u003e (1 comment)\n \u003e \n \u003e Hi Geng. Thanks for the patch. Shouldn\u0027t we update client v1 [1]\n \u003e [2] also? Also, it\u0027s better to have a unit test for client v2.\n \u003e Currently, we don\u0027t have tests for client v2.\n \u003e \n \u003e [1] https://github.com/openstack/python-freezerclient/blob/master/freezerclient/v1/client.py\n \u003e \n \u003e [2] https://github.com/openstack/python-freezerclient/blob/master/freezerclient/tests/unit/v1/test_client.py#L58\n\nHi Trinh Nguyen, current interface is V2, V1 is too old, I think that we don\u0027t need to modify v1.\nThe function \u0027get_auth_plugin\u0027 is used in the class Client, I think that it shouldn\u0027t be used as external interface.","accounts_in_message":[],"_revision_number":1},{"id":"a9286fc8e654248ac528eff6140b5180ad749679","author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"date":"2018-09-21 10:43:53.000000000","message":"Patch Set 1:\n\nOk. So please add a test case to make sure your change work as expected.","accounts_in_message":[],"_revision_number":1},{"id":"2c96b32f44c76b99135b88d134a39d963dba2a18","author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"date":"2018-09-28 03:14:32.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"d66b7d20b7859b5a2a71cfd5c65fa734d95d9774","author":{"_account_id":21387,"name":"gecong","email":"ge.cong@zte.com.cn","username":"gecong"},"date":"2018-09-28 03:22:36.000000000","message":"Patch Set 2: Code-Review+1\n\nLGTM","accounts_in_message":[],"_revision_number":2},{"id":"734a050a28fbd8eed47d9a81f9c500e5a7b2fbca","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-28 05:33:20.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/84/604284/2/check/openstack-tox-pep8/de55499/ : SUCCESS in 3m 31s\n- openstack-tox-py27 http://logs.openstack.org/84/604284/2/check/openstack-tox-py27/c47a7fe/ : SUCCESS in 3m 18s\n- openstack-tox-py35 http://logs.openstack.org/84/604284/2/check/openstack-tox-py35/3b7c289/ : SUCCESS in 3m 29s\n- build-openstack-sphinx-docs http://logs.openstack.org/84/604284/2/check/build-openstack-sphinx-docs/f1380a1/html/ : SUCCESS in 3m 15s\n- openstack-tox-pylint http://logs.openstack.org/84/604284/2/check/openstack-tox-pylint/69aba9e/ : SUCCESS in 3m 22s\n- openstack-tox-py36 http://logs.openstack.org/84/604284/2/check/openstack-tox-py36/661f288/ : SUCCESS in 4m 10s\n- openstack-tox-docs http://logs.openstack.org/84/604284/2/check/openstack-tox-docs/18552ab/html/ : SUCCESS in 2m 30s\n- openstack-tox-lower-constraints http://logs.openstack.org/84/604284/2/check/openstack-tox-lower-constraints/fc4fc99/ : SUCCESS in 3m 56s","accounts_in_message":[],"_revision_number":2},{"id":"22196eac04ad630b4aa64c509fda728528da8df3","author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"date":"2018-09-29 00:38:22.000000000","message":"Patch Set 2: Code-Review+2\n\nLGTM.","accounts_in_message":[],"_revision_number":2},{"id":"af0efe289390343f025657f0fdaaa0d7f99b4f4c","author":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"date":"2018-09-29 01:32:53.000000000","message":"Patch Set 2: Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"2f35e0fcc8b32a929bfc6b9679ca45f2bd81ae67","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-29 01:33:04.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"009223926bfc11be81358bcceafec6f26a6cecdf","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-29 01:43:55.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/84/604284/2/gate/openstack-tox-pep8/cc6d6b0/ : SUCCESS in 3m 12s\n- openstack-tox-py27 http://logs.openstack.org/84/604284/2/gate/openstack-tox-py27/f8b7270/ : SUCCESS in 3m 12s\n- openstack-tox-py35 http://logs.openstack.org/84/604284/2/gate/openstack-tox-py35/a09d7b5/ : SUCCESS in 3m 29s\n- build-openstack-sphinx-docs http://logs.openstack.org/84/604284/2/gate/build-openstack-sphinx-docs/6143b96/html/ : SUCCESS in 2m 40s\n- openstack-tox-pylint http://logs.openstack.org/84/604284/2/gate/openstack-tox-pylint/4a0801a/ : SUCCESS in 3m 13s\n- openstack-tox-py36 http://logs.openstack.org/84/604284/2/gate/openstack-tox-py36/0d555fe/ : SUCCESS in 2m 50s\n- openstack-tox-docs http://logs.openstack.org/84/604284/2/gate/openstack-tox-docs/03510d3/html/ : SUCCESS in 2m 52s\n- openstack-tox-lower-constraints http://logs.openstack.org/84/604284/2/gate/openstack-tox-lower-constraints/5eab58e/ : SUCCESS in 4m 05s","accounts_in_message":[],"_revision_number":2},{"id":"00b5318be1285954dfd7ab644872659475ce6cbe","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-09-29 01:43:55.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"60aa9ec5dd4d2dfa1f4176bf1a48cdafc05a8b36","revisions":{"7e7597b608b1f3a96d88063971c0de795700f5b5":{"kind":"REWORK","_number":1,"created":"2018-09-21 07:26:48.000000000","uploader":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"ref":"refs/changes/84/604284/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-freezerclient","ref":"refs/changes/84/604284/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/84/604284/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/84/604284/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/84/604284/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-freezerclient refs/changes/84/604284/1"}}},"commit":{"parents":[{"commit":"77e63223f0090a9edcfd553174358f25dd883fae","subject":"Merge \"add python 3.6 unit test job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/77e63223f0090a9edcfd553174358f25dd883fae"}]}],"author":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2018-09-21 07:17:44.000000000","tz":-420},"committer":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2018-09-21 07:26:41.000000000","tz":-420},"subject":"Use keystoneauth1.loading instead of specifying V2 or V3 of keystone","message":"Use keystoneauth1.loading instead of specifying V2 or V3 of keystone\n\nIn devstack, there is an error:\nNot Found (HTTP 404) (Request-ID: req-c5b74593-ecd6-4c06-9db1-b1fa9c124fc1).\nThis is a keystone authentication failure.\nUse keystoneauth1.load.get_plugin_loader to load and discovery dynamically\nwithout explicitly specifying V2 or V3 of keystone.\n\nChange-Id: Ic43d7c194387a4063b38a11e1a1c850aaaf713c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/7e7597b608b1f3a96d88063971c0de795700f5b5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/7e7597b608b1f3a96d88063971c0de795700f5b5"}]},"branch":"refs/heads/master"},"60aa9ec5dd4d2dfa1f4176bf1a48cdafc05a8b36":{"kind":"REWORK","_number":2,"created":"2018-09-28 03:14:32.000000000","uploader":{"_account_id":22484,"name":"gengchc2","email":"geng.changcai2@zte.com.cn","username":"gengchc2"},"ref":"refs/changes/84/604284/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-freezerclient","ref":"refs/changes/84/604284/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/84/604284/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/84/604284/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-freezerclient refs/changes/84/604284/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-freezerclient refs/changes/84/604284/2"}}},"commit":{"parents":[{"commit":"77e63223f0090a9edcfd553174358f25dd883fae","subject":"Merge \"add python 3.6 unit test job\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/77e63223f0090a9edcfd553174358f25dd883fae"}]}],"author":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2018-09-21 07:17:44.000000000","tz":-420},"committer":{"name":"gengchc2","email":"geng.changcai2@zte.com.cn","date":"2018-09-28 03:13:23.000000000","tz":-420},"subject":"Use keystoneauth1.loading instead of specifying V2 or V3 of keystone","message":"Use keystoneauth1.loading instead of specifying V2 or V3 of keystone\n\nIn devstack, there is an error:\nNot Found (HTTP 404) (Request-ID: req-c5b74593-ecd6-4c06-9db1-b1fa9c124fc1).\nThis is a keystone authentication failure.\nUse keystoneauth1.load.get_plugin_loader to load and discovery dynamically\nwithout explicitly specifying V2 or V3 of keystone.\n\nChange-Id: Ic43d7c194387a4063b38a11e1a1c850aaaf713c0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/60aa9ec5dd4d2dfa1f4176bf1a48cdafc05a8b36"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-freezerclient/commit/60aa9ec5dd4d2dfa1f4176bf1a48cdafc05a8b36"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
