)]}'
{"id":"openstack%2Fpython-glanceclient~1015466","triplet_id":"openstack%2Fpython-glanceclient~master~I5ad5efa870b3f973208f1ce42a2f76edc7ba89b8","project":"openstack/python-glanceclient","branch":"master","hashtags":[],"change_id":"I5ad5efa870b3f973208f1ce42a2f76edc7ba89b8","subject":"Verify the server certificate with cacert\u003dNone","status":"NEW","created":"2026-11-12 21:17:49.000000000","updated":"2026-11-12 23:10:14.000000000","submit_type":"MERGE_IF_NECESSARY","mergeable":true,"submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"215727625afa4dc1dfd0c16dc852b5e971007368","_number":1015466,"virtual_id_number":1015466,"owner":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"tag":"autogenerated:zuul:check","value":1,"date":"2026-11-12 23:10:14.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2026-11-12 23:10:14.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"96ca8dadad5d14f3d5b3cbdf47c7998a16a962df","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"date":"2026-11-12 21:17:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"215727625afa4dc1dfd0c16dc852b5e971007368","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2026-11-12 23:10:14.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\nhttps://zuul.opendev.org/t/openstack/buildset/2cb5f5cb421a48f2b7c742ab711bdfc5\n\n- tempest-full-py3 https://zuul.opendev.org/t/openstack/build/7bfece8ec0b44dd98172a50bfdb14468 : SUCCESS in 1h 45m 51s\n- openstack-tox-cover https://zuul.opendev.org/t/openstack/build/3dc7e2da12ef4e7ca9127bc1a01e6a7c : SUCCESS in 2m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/13f638c92c494882b03d27c87ed0f1cf : SUCCESS in 3m 06s\n- openstack-tox-py311 https://zuul.opendev.org/t/openstack/build/b4f95f4f357c492f80db0b41567a6401 : SUCCESS in 2m 04s\n- openstack-tox-py314 https://zuul.opendev.org/t/openstack/build/ee9f05a84a5642d1b90e1fbca1f20b4e : SUCCESS in 6m 49s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/bed316e501ed4175877558cd269b9bcd : SUCCESS in 4m 34s\n- build-openstack-releasenotes https://zuul.opendev.org/t/openstack/build/81357a16f0e7440fb081360300eca3ee : SUCCESS in 4m 55s\n- glanceclient-dsvm-functional https://zuul.opendev.org/t/openstack/build/795b5ba0e51f493fac9a88de6328ca30 : SUCCESS in 36m 59s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"34c9e7ab78925a794b10745a1d40d4d550f66a31","revisions":{"34c9e7ab78925a794b10745a1d40d4d550f66a31":{"kind":"REWORK","_number":1,"created":"2026-11-12 21:17:49.000000000","uploader":{"_account_id":9373,"name":"Vlad Gusev","email":"vlad.esten@gmail.com","username":"s10"},"ref":"refs/changes/66/1015466/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/66/1015466/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/66/1015466/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/66/1015466/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/66/1015466/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/66/1015466/1"}}},"commit":{"parents":[{"commit":"cb5fd7f377dc6729a4e4feac31f39fd91604ac58","subject":"Add import info detail API support","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/cb5fd7f377dc6729a4e4feac31f39fd91604ac58"}]}],"author":{"name":"Vladislav Gusev","email":"vlad.esten@gmail.com","date":"2026-11-12 16:15:48.000000000","tz":120},"committer":{"name":"Vladislav Gusev","email":"vlad.esten@gmail.com","date":"2026-11-12 21:17:47.000000000","tz":120},"subject":"Verify the server certificate with cacert\u003dNone","message":"Verify the server certificate with cacert\u003dNone\n\nHTTPClient set session.verify to kwargs.get(\u0027cacert\u0027, True). That\ndefault applies only when the key is missing, so a caller that passes\ncacert\u003dNone got session.verify \u003d None. requests verifies only when\nthat value is true, so the client talked to an https endpoint without\na certificate check although insecure was not set.\n\nRequests to a local TLS server that presents a certificate the client\ndoes not trust, before this change:\n\n  no cacert argument    certificate verify failed\n  cacert\u003d\u0027\u0027             certificate verify failed\n  cacert\u003dNone           HTTP 200, InsecureRequestWarning\n  insecure\u003dTrue         HTTP 200, InsecureRequestWarning\n\nWith REQUESTS_CA_BUNDLE or CURL_CA_BUNDLE in the environment requests\nuses that file for a session value of None, so the check was skipped\nonly without these variables.\n\nTwo callers pass None when no CA file is configured:\n\n* Horizon passes cacert\u003dsettings.OPENSTACK_SSL_CACERT, which is None\n  by default. Its documentation says that None means verification\n  against the default CA certificate of the system. A Horizon with\n  default settings sends the token of the user to glance over a\n  connection that is not verified.\n* The glance command with --os-auth-token and --os-image-url passes\n  the value of --os-cacert, which keystoneauth sets to None when\n  neither the option nor OS_CACERT is given.\n\nWithout insecure, always assign session.verify: True when cacert is\nNone or an empty string, which both mean that no CA file is given,\nand the given value otherwise. The new test in test_ssl.py fails\nwithout this change, also with REQUESTS_CA_BUNDLE set.\n\nA caller that relied on the missing check now gets \"certificate\nverify failed\" for a certificate that the CA bundle of requests does\nnot cover. The release note names the options.\n\nThe two lines changed here come from the fix for bug 1357430, which\nhandled a missing cacert and an empty string but not None.\n\nA change with the same goal was proposed in 2019 and abandoned:\nhttps://review.opendev.org/c/openstack/python-glanceclient/+/631526\nIts review read the old code as: the client verifies when the\nassignment runs and does not verify when it is skipped. The results\nabove show the reverse in both cases. An empty string skipped the\nassignment and was verified through the default of requests, and\nNone ran the assignment and stored None.\n\nRelated-Bug: #1357430\nAssisted-By: Claude Fable 5.2\nChange-Id: I5ad5efa870b3f973208f1ce42a2f76edc7ba89b8\nSigned-off-by: Vladislav Gusev \u003cvlad.esten@gmail.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/34c9e7ab78925a794b10745a1d40d4d550f66a31"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/34c9e7ab78925a794b10745a1d40d4d550f66a31"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"OK","labels":[{"label":"Verified","status":"MAY","applied_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}},{"label":"Code-Review","status":"MAY"},{"label":"Workflow","status":"MAY"},{"label":"Review-Priority","status":"MAY"}]}],"submit_requirements":[{"name":"Verified","description":"Verified in gate by CI","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Verified\u003dMAX AND -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","label:Verified\u003dMIN"],"atom_explanations":{"label:Verified\u003dMAX":"","label:Verified\u003dMIN":""}}},{"name":"Code-Review","description":"Code reviewed by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX AND -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","label:Code-Review\u003dMIN"],"atom_explanations":{"label:Code-Review\u003dMAX":"","label:Code-Review\u003dMIN":""}}},{"name":"Review-Priority","description":"Review priority","status":"SATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"-label:Review-Priority\u003dMIN","fulfilled":true,"status":"PASS","passing_atoms":[],"failing_atoms":["label:Review-Priority\u003dMIN"],"atom_explanations":{"label:Review-Priority\u003dMIN":""}}},{"name":"Workflow","description":"Approved for gate by core reviewer","status":"UNSATISFIED","is_legacy":false,"submittability_expression_result":{"expression":"label:Workflow\u003dMAX AND -label:Workflow\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Workflow\u003dMAX","label:Workflow\u003dMIN"],"atom_explanations":{"label:Workflow\u003dMAX":"","label:Workflow\u003dMIN":""}}}]}
