)]}'
{"id":"openstack%2Fpython-glanceclient~121894","triplet_id":"openstack%2Fpython-glanceclient~master~I24e2cb2664d1d86610e0afd3c2ebc79af8eef507","project":"openstack/python-glanceclient","branch":"master","topic":"no_log_error","hashtags":[],"change_id":"I24e2cb2664d1d86610e0afd3c2ebc79af8eef507","subject":"glanceclient should not ever LOG.error","status":"ABANDONED","created":"2014-09-16 15:03:59.000000000","updated":"2014-09-16 15:35:16.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"2ca5d87300ab0a104b88f374c5d02000d47567f1","_number":121894,"virtual_id_number":121894,"owner":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"all":[{"value":-1,"date":"2014-09-16 15:34:29.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"value":2,"date":"2014-09-16 15:34:35.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Top Priority / Holds Gate"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-09-16 15:34:29.000000000","updated_by":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"reviewer":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"state":"REVIEWER"},{"updated":"2014-09-16 15:34:35.000000000","updated_by":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"reviewer":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"state":"REVIEWER"}],"messages":[{"id":"cc2360c722dfe1f568350d9fcdb4255dde047ba6","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2014-09-16 15:03:59.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"dc9fb6eb24417c343b09fd9643f17de572e9f272","author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"date":"2014-09-16 15:34:29.000000000","message":"Patch Set 1: Code-Review-1\n\nThis patch duplicated with change Iec13bff439073a79cb24e9b22fd43603ae4e61b7 .","accounts_in_message":[],"_revision_number":1},{"id":"deea82b597efe9603178d9baee37c64cdb147208","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2014-09-16 15:34:35.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1\n\nninja approve. The change is trivial","accounts_in_message":[],"_revision_number":1},{"id":"c7fa3028536bae20dccf20a672ed020a80123dde","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2014-09-16 15:34:45.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"095b350c79b78372d435de26cf7f2aed064b83ad","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2014-09-16 15:35:16.000000000","message":"Abandoned\n\nSuperseded Change-Id: Iec13bff439073a79cb24e9b22fd43603ae4e61b7","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"22acda5686620d05afcb5b213e01dc0350594406","revisions":{"22acda5686620d05afcb5b213e01dc0350594406":{"kind":"REWORK","_number":1,"created":"2014-09-16 15:03:59.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/94/121894/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-glanceclient","ref":"refs/changes/94/121894/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/94/121894/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/94/121894/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-glanceclient refs/changes/94/121894/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-glanceclient refs/changes/94/121894/1"}}},"commit":{"parents":[{"commit":"49feed7cba45d8dad75b69cb153196dbad962f2b","subject":"Merge \"Update how tokens are redacted\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/49feed7cba45d8dad75b69cb153196dbad962f2b"}]}],"author":{"name":"Sean Dague","email":"sean@dague.net","date":"2014-09-16 15:02:48.000000000","tz":-240},"committer":{"name":"Sean Dague","email":"sean@dague.net","date":"2014-09-16 15:02:48.000000000","tz":-240},"subject":"glanceclient should not ever LOG.error","message":"glanceclient should not ever LOG.error\n\nThe information should be returned to the caller to handle the error\nconditions, it shouldn\u0027t log it\u0027s own error because it doesn\u0027t have\nenough context to know if that\u0027s really a problem under the\ncircumstances.\n\nChange-Id: I24e2cb2664d1d86610e0afd3c2ebc79af8eef507\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/22acda5686620d05afcb5b213e01dc0350594406"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-glanceclient/commit/22acda5686620d05afcb5b213e01dc0350594406"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
